Skip to contentSkip to conversation

softmmu/physmem: Improve guest memory allocation failure error message

PATCH In review Philippe Mathieu-Daudé 7 participants 20 messages Aug 20, 2021 – Aug 24, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 softmmu/physmem: Improve guest memory allocation failure error message

When Linux refuses to overcommit a seriously wild allocation we get:

  $ qemu-system-i386 -m 40000000
  qemu-system-i386: cannot set up guest memory 'pc.ram': Cannot allocate memory

Slighly improve the error message, displaying the memory size requested (in case the user didn't expect unspecified memory size unit is in MiB):

  $ qemu-system-i386 -m 40000000
  qemu-system-i386: Cannot set up 38.1 TiB of guest memory 'pc.ram': Cannot allocate memory
---
 softmmu/physmem.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
softmmu/physmem.c +3 -1
index 2e18947598e..2f300a9e79b 100644
@@ -1982,8 +1982,10 @@ static void ram_block_add(RAMBlock *new_block, Error **errp)
                                                   &new_block->mr->align,
                                                   shared, noreserve);
             if (!new_block->host) {
+                g_autofree char *size_s = size_to_str(new_block->max_length);
                 error_setg_errno(errp, errno,
-                                 "cannot set up guest memory '%s'",
+                                 "Cannot set up %s of guest memory '%s'",
+                                 size_s,
                                  memory_region_name(new_block->mr));
                 qemu_mutex_unlock_ramlist();
                 return;
Signature · 1 line
2.31.1
#1 lore raw
Quoted 25 lines · Philippe Mathieu-Daudé

When Linux refuses to overcommit a seriously wild allocation we get:

   $ qemu-system-i386 -m 40000000
   qemu-system-i386: cannot set up guest memory 'pc.ram': Cannot allocate memory

Slighly improve the error message, displaying the memory size requested (in case the user didn't expect unspecified memory size unit is in MiB):

   $ qemu-system-i386 -m 40000000
   qemu-system-i386: Cannot set up 38.1 TiB of guest memory 'pc.ram': Cannot allocate memory
---
  softmmu/physmem.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)
softmmu/physmem.c +0 -0
index 2e18947598e..2f300a9e79b 100644
@@ -1982,8 +1982,10 @@ static void ram_block_add(RAMBlock *new_block, Error **errp)
                                                    &new_block->mr->align,

softmmu/physmem.c static void ram_block_add(RAMBlock *new_block, Error **errp) · line 1991

Quoted 10 lines
softmmu/physmem.c +3 -1
                                                    shared, noreserve);
              if (!new_block->host) {
+                g_autofree char *size_s = size_to_str(new_block->max_length);
                  error_setg_errno(errp, errno,
-                                 "cannot set up guest memory '%s'",
+                                 "Cannot set up %s of guest memory '%s'",
+                                 size_s,
                                   memory_region_name(new_block->mr));
                  qemu_mutex_unlock_ramlist();
                  return;

IIRC, ram blocks might not necessarily be used for guest memory ... or is my memory wrong?

Signature · 3 lines
Thanks,

David / dhildenb
#2 lore raw
Quoted 37 lines · David Hildenbrand
Quoted 36 lines · Philippe Mathieu-Daudé

When Linux refuses to overcommit a seriously wild allocation we get:

   $ qemu-system-i386 -m 40000000
   qemu-system-i386: cannot set up guest memory 'pc.ram': Cannot
allocate memory

Slighly improve the error message, displaying the memory size requested (in case the user didn't expect unspecified memory size unit is in MiB):

   $ qemu-system-i386 -m 40000000
   qemu-system-i386: Cannot set up 38.1 TiB of guest memory 'pc.ram':
Cannot allocate memory

---
  softmmu/physmem.c | 4 +++-

  1 file changed, 3 insertions(+), 1 deletion(-)
softmmu/physmem.c +0 -0
index 2e18947598e..2f300a9e79b 100644
@@ -1982,8 +1982,10 @@ static void ram_block_add(RAMBlock *new_block,
 Error **errp)


&new_block->mr->align,
                                                    shared, noreserve); if (!new_block->host) {
+                g_autofree char *size_s = size_to_str(new_block->max_length);
                  error_setg_errno(errp, errno,
-                                 "cannot set up guest memory '%s'", +                                 "Cannot set up %s of guest memory '%s'",

Quoted 8 lines
Quoted 5 lines

+                                 size_s, memory_region_name(new_block->mr)); qemu_mutex_unlock_ramlist();
                  return;

IIRC, ram blocks might not necessarily be used for guest memory ... or is my memory wrong?

No clue, this error message was already here.

No problem to change s/guest/block/ although.

#3 lore raw
Quoted 47 lines · On Fri, 20 Aug 2021 18:00:26 +0200 Philippe Mathieu-Daudé <[email protected]>…
Quoted 37 lines · David Hildenbrand
Quoted 36 lines · Philippe Mathieu-Daudé

When Linux refuses to overcommit a seriously wild allocation we get:

   $ qemu-system-i386 -m 40000000
   qemu-system-i386: cannot set up guest memory 'pc.ram': Cannot
allocate memory

Slighly improve the error message, displaying the memory size requested (in case the user didn't expect unspecified memory size unit is in MiB):

   $ qemu-system-i386 -m 40000000
   qemu-system-i386: Cannot set up 38.1 TiB of guest memory 'pc.ram':
Cannot allocate memory

---
  softmmu/physmem.c | 4 +++-

  1 file changed, 3 insertions(+), 1 deletion(-)
softmmu/physmem.c +0 -0
index 2e18947598e..2f300a9e79b 100644
@@ -1982,8 +1982,10 @@ static void ram_block_add(RAMBlock *new_block,
 Error **errp)


&new_block->mr->align,
                                                    shared, noreserve); if (!new_block->host) {
+                g_autofree char *size_s = size_to_str(new_block->max_length);
                  error_setg_errno(errp, errno,
-                                 "cannot set up guest memory '%s'", +                                 "Cannot set up %s of guest memory '%s'",

Quoted 8 lines
Quoted 5 lines

+                                 size_s, memory_region_name(new_block->mr)); qemu_mutex_unlock_ramlist();
                  return;

IIRC, ram blocks might not necessarily be used for guest memory ... or is my memory wrong?

Quoted 1 line

No clue, this error message was already here.

it's not only guest RAM, adding size here is marginal improvement,
(it won't help much since it's not exact match to CLI which may use suffixes for sizes)

Quoted 3 lines

No problem to change s/guest/block/ although.

#4 lore raw
Quoted 50 lines · Igor Mammedov
Quoted 47 lines · On Fri, 20 Aug 2021 18:00:26 +0200 Philippe Mathieu-Daudé <[email protected]>…
Quoted 45 lines · David Hildenbrand
Quoted 32 lines · Philippe Mathieu-Daudé

When Linux refuses to overcommit a seriously wild allocation we get:

   $ qemu-system-i386 -m 40000000
   qemu-system-i386: cannot set up guest memory 'pc.ram': Cannot
allocate memory

Slighly improve the error message, displaying the memory size requested (in case the user didn't expect unspecified memory size unit is in MiB):

   $ qemu-system-i386 -m 40000000
   qemu-system-i386: Cannot set up 38.1 TiB of guest memory 'pc.ram':
Cannot allocate memory

---
  softmmu/physmem.c | 4 +++-

  1 file changed, 3 insertions(+), 1 deletion(-)
softmmu/physmem.c +0 -0
index 2e18947598e..2f300a9e79b 100644
@@ -1982,8 +1982,10 @@ static void ram_block_add(RAMBlock *new_block,
 Error **errp)


&new_block->mr->align,
                                                    shared, noreserve); if (!new_block->host) {
+                g_autofree char *size_s = size_to_str(new_block->max_length);

Quoted 9 lines

                  error_setg_errno(errp, errno,
-                                 "cannot set up guest memory '%s'", +                                 "Cannot set up %s of guest memory '%s'",
+                                 size_s, memory_region_name(new_block->mr)); qemu_mutex_unlock_ramlist();
                  return;

IIRC, ram blocks might not necessarily be used for guest memory ... or is my memory wrong?

Quoted 4 lines
Quoted 1 line

No clue, this error message was already here.

it's not only guest RAM, adding size here is marginal improvement,
(it won't help much since it's not exact match to CLI which may use suffixes for sizes)

The suffixed size is already converted at this point:

qemu-system-i386 -m 2T
qemu-system-i386: Cannot set up 2 TiB of guest memory 'pc.ram': Cannot
allocate memory

I agree however the size displayed might be less than the size passed to the '-m' argument.

Anyhow I still see the size displayed in the error message as an useful hint:

$ qemu-system-i386 -m 64000
qemu-system-i386: cannot set up guest memory 'pc.ram': Cannot allocate
memory

VS:

$ qemu-system-i386 -m 64000
qemu-system-i386: Cannot set up 62.5 GiB of guest memory 'pc.ram':
Cannot allocate memory
Quoted 5 lines
Quoted 4 lines

No problem to change s/guest/block/ although.

#5 lore raw
Quoted 7 lines · Philippe Mathieu-Daudé

Anyhow I still see the size displayed in the error message as an useful hint:

$ qemu-system-i386 -m 64000
qemu-system-i386: cannot set up guest memory 'pc.ram': Cannot allocate
memory
Quoted 5 lines

VS:

$ qemu-system-i386 -m 64000
qemu-system-i386: Cannot set up 62.5 GiB of guest memory 'pc.ram':
Cannot allocate memory

I hadn't spotted that we were doing the size-to-str -- I think that's definitely helpful because it will catch cases like the one here where the user didn't realize they were asking for 30 terabytes of RAM...

-- PMM

#6 lore raw
In reply to Philippe Mathieu-Daudé
Quoted 47 lines · Philippe Mathieu-Daudé
Quoted 37 lines · David Hildenbrand
Quoted 36 lines · Philippe Mathieu-Daudé

When Linux refuses to overcommit a seriously wild allocation we get:

    $ qemu-system-i386 -m 40000000
    qemu-system-i386: cannot set up guest memory 'pc.ram': Cannot
allocate memory

Slighly improve the error message, displaying the memory size requested (in case the user didn't expect unspecified memory size unit is in MiB):

    $ qemu-system-i386 -m 40000000
    qemu-system-i386: Cannot set up 38.1 TiB of guest memory 'pc.ram':
Cannot allocate memory
---
   softmmu/physmem.c | 4 +++-
   1 file changed, 3 insertions(+), 1 deletion(-)
softmmu/physmem.c +2 -1
index 2e18947598e..2f300a9e79b 100644
@@ -1982,8 +1982,10 @@ static void ram_block_add(RAMBlock *new_block,
 Error **errp)
 
 &new_block->mr->align,
                                                     shared, noreserve);
               if (!new_block->host) {
+                g_autofree char *size_s =
 size_to_str(new_block->max_length);
                   error_setg_errno(errp, errno,
-                                 "cannot set up guest memory '%s'",
+                                 "Cannot set up %s of guest memory

'%s'",

Quoted 8 lines
Quoted 5 lines

+                                 size_s,
                                   memory_region_name(new_block->mr)); qemu_mutex_unlock_ramlist();
                  return;

IIRC, ram blocks might not necessarily be used for guest memory ... or is my memory wrong?

Quoted 3 lines

No clue, this error message was already here.

No problem to change s/guest/block/ although.

We should probably just adjust that as well (separate patch) ... but your patch subject also mentions "guest memory".

Not opposed to printing the size, although I doubt that it will really stop similar questions/problems getting raised.

Signature · 3 lines
Thanks,

David / dhildenb
#7 lore raw
Quoted 2 lines · David Hildenbrand

Not opposed to printing the size, although I doubt that it will really stop similar questions/problems getting raised.

The case that triggered this was somebody thinking -m took a byte count, so very likely that an error message saying "you tried to allocate 38TB" would have made their mistake clear in a way that just "allocation failed" did not. It also means that if a future user asks us for help then we can look at the error message and immediately tell them the problem, rather than going "hmm, what are all the possible ways that allocation might have failed" and going off down rabbitholes like VM overcommit settings...

-- PMM

#8 lore raw
Quoted 4 lines · Peter Maydell
Quoted 2 lines · David Hildenbrand

Not opposed to printing the size, although I doubt that it will really stop similar questions/problems getting raised.

Quoted 9 lines

The case that triggered this was somebody thinking -m took a byte count, so very likely that an error message saying "you tried to allocate 38TB" would have made their mistake clear in a way that just "allocation failed" did not. It also means that if a future user asks us for help then we can look at the error message and immediately tell them the problem, rather than going "hmm, what are all the possible ways that allocation might have failed" and going off down rabbitholes like VM overcommit settings...

We've had similar issues recently where Linux memory overcommit handling rejected the allocation -- and the user was well aware about the actual size. You won't be able to catch such reports, because people don't understand how Linux memory overcommit handling works or was configured.

"I have 3 GiB of free memory, why can't I create a 3 GiB VM". "I have 3 GiB of RAM, why can't I create a 3 GiB VM even if it won't make use of all 3 GiB of memory".

Thus my comment, it will only stop very basic usage issues. And I agree that looking at the error *might* help. It didn't help for the cases I just described, because we need much more system information to make a guess what the user error actually is.

Signature · 3 lines
Thanks,

David / dhildenb
#9 lore raw
Quoted 20 lines · David Hildenbrand
Quoted 4 lines · Peter Maydell
Quoted 2 lines · David Hildenbrand

Not opposed to printing the size, although I doubt that it will really stop similar questions/problems getting raised.

Quoted 9 lines

The case that triggered this was somebody thinking -m took a byte count, so very likely that an error message saying "you tried to allocate 38TB" would have made their mistake clear in a way that just "allocation failed" did not. It also means that if a future user asks us for help then we can look at the error message and immediately tell them the problem, rather than going "hmm, what are all the possible ways that allocation might have failed" and going off down rabbitholes like VM overcommit settings...

We've had similar issues recently where Linux memory overcommit handling rejected the allocation -- and the user was well aware about the actual size. You won't be able to catch such reports, because people don't understand how Linux memory overcommit handling works or was configured.

Quoted 8 lines

"I have 3 GiB of free memory, why can't I create a 3 GiB VM". "I have 3 GiB of RAM, why can't I create a 3 GiB VM even if it won't make use of all 3 GiB of memory".

Thus my comment, it will only stop very basic usage issues. And I agree that looking at the error *might* help. It didn't help for the cases I just described, because we need much more system information to make a guess what the user error actually is.

Is it possible to get the maximal overcommitable amount on Linux?

#10 lore raw
Quoted 25 lines · Philippe Mathieu-Daudé
Quoted 24 lines · David Hildenbrand
Quoted 4 lines · Peter Maydell
Quoted 2 lines · David Hildenbrand

Not opposed to printing the size, although I doubt that it will really stop similar questions/problems getting raised.

Quoted 9 lines

The case that triggered this was somebody thinking -m took a byte count, so very likely that an error message saying "you tried to allocate 38TB" would have made their mistake clear in a way that just "allocation failed" did not. It also means that if a future user asks us for help then we can look at the error message and immediately tell them the problem, rather than going "hmm, what are all the possible ways that allocation might have failed" and going off down rabbitholes like VM overcommit settings...

We've had similar issues recently where Linux memory overcommit handling rejected the allocation -- and the user was well aware about the actual size. You won't be able to catch such reports, because people don't understand how Linux memory overcommit handling works or was configured.

"I have 3 GiB of free memory, why can't I create a 3 GiB VM". "I have 3 GiB of RAM, why can't I create a 3 GiB VM even if it won't make use of all 3 GiB of memory".

Quoted 6 lines
Quoted 4 lines

Thus my comment, it will only stop very basic usage issues. And I agree that looking at the error *might* help. It didn't help for the cases I just described, because we need much more system information to make a guess what the user error actually is.

Is it possible to get the maximal overcommitable amount on Linux?

Not reliably I think.

In the "always" mode, there is none.

In the "guess"/"estimate" mode, the kernel takes a guess (currently implemented as checking if the mmap size <= total RAM + total SWAP).
Committable = MemTotal + SwapTotal

In the "never" mode:
Committable = CommitLimit - Committed_AS
However, the value gets further reduced for !root applications by /proc/sys/vm/admin_reserve_kbytes.

Replicating these calculations in user space would be suboptimal IMHO.

Signature · 3 lines
Thanks,

David / dhildenb
#11 lore raw
Quoted 42 lines · David Hildenbrand
Quoted 26 lines · Philippe Mathieu-Daudé
Quoted 25 lines · David Hildenbrand
Quoted 5 lines · Peter Maydell
Quoted 2 lines · David Hildenbrand

Not opposed to printing the size, although I doubt that it will really stop similar questions/problems getting raised.

Quoted 9 lines

The case that triggered this was somebody thinking -m took a byte count, so very likely that an error message saying "you tried to allocate 38TB" would have made their mistake clear in a way that just "allocation failed" did not. It also means that if a future user asks us for help then we can look at the error message and immediately tell them the problem, rather than going "hmm, what are all the possible ways that allocation might have failed" and going off down rabbitholes like VM overcommit settings...

We've had similar issues recently where Linux memory overcommit handling rejected the allocation -- and the user was well aware about the actual size. You won't be able to catch such reports, because people don't understand how Linux memory overcommit handling works or was configured.

"I have 3 GiB of free memory, why can't I create a 3 GiB VM". "I have 3 GiB of RAM, why can't I create a 3 GiB VM even if it won't make use of all 3 GiB of memory".

Quoted 6 lines
Quoted 4 lines

Thus my comment, it will only stop very basic usage issues. And I agree that looking at the error *might* help. It didn't help for the cases I just described, because we need much more system information to make a guess what the user error actually is.

Is it possible to get the maximal overcommitable amount on Linux?

Not reliably I think.

In the "always" mode, there is none.

In the "guess"/"estimate" mode, the kernel takes a guess (currently implemented as checking if the mmap size <= total RAM + total SWAP). Committable = MemTotal + SwapTotal

Quoted 6 lines

In the "never" mode:
    Committable = CommitLimit - Committed_AS
However, the value gets further reduced for !root applications by /proc/sys/vm/admin_reserve_kbytes.

Replicating these calculations in user space would be suboptimal IMHO.

What about simply giving a hint about memory overcommit and display a link to documentation with longer description about how to check and figure out this issue?

#12 lore raw
Quoted 48 lines · Philippe Mathieu-Daudé
Quoted 47 lines · David Hildenbrand
Quoted 26 lines · Philippe Mathieu-Daudé
Quoted 25 lines · David Hildenbrand
Quoted 5 lines · Peter Maydell
Quoted 2 lines · David Hildenbrand

Not opposed to printing the size, although I doubt that it will really stop similar questions/problems getting raised.

Quoted 9 lines

The case that triggered this was somebody thinking -m took a byte count, so very likely that an error message saying "you tried to allocate 38TB" would have made their mistake clear in a way that just "allocation failed" did not. It also means that if a future user asks us for help then we can look at the error message and immediately tell them the problem, rather than going "hmm, what are all the possible ways that allocation might have failed" and going off down rabbitholes like VM overcommit settings...

We've had similar issues recently where Linux memory overcommit handling rejected the allocation -- and the user was well aware about the actual size. You won't be able to catch such reports, because people don't understand how Linux memory overcommit handling works or was configured.

"I have 3 GiB of free memory, why can't I create a 3 GiB VM". "I have 3 GiB of RAM, why can't I create a 3 GiB VM even if it won't make use of all 3 GiB of memory".

Quoted 6 lines
Quoted 4 lines

Thus my comment, it will only stop very basic usage issues. And I agree that looking at the error *might* help. It didn't help for the cases I just described, because we need much more system information to make a guess what the user error actually is.

Is it possible to get the maximal overcommitable amount on Linux?

Not reliably I think.

In the "always" mode, there is none.

In the "guess"/"estimate" mode, the kernel takes a guess (currently implemented as checking if the mmap size <= total RAM + total SWAP).
    Committable = MemTotal + SwapTotal

In the "never" mode:
    Committable = CommitLimit - Committed_AS
However, the value gets further reduced for !root applications by /proc/sys/vm/admin_reserve_kbytes.

Quoted 5 lines
Quoted 1 line

Replicating these calculations in user space would be suboptimal IMHO.

What about simply giving a hint about memory overcommit and display a link to documentation with longer description about how to check and figure out this issue?

That would be highly OS-specific -- for example, there is no memory overcommit under Windows. Sure, we could add a Linux specific hint, indication documentation. But I'm not sure if most end users stumbling into such an error+hint would be able to make sense of memory overcommit details (not to mention that they know what it even is) :)

You can run into memory allocation issues with many applications. Let me give you a simple example

t480s: ~ $ dd if=/dev/zero of=/dev/null ibs=100G
dd: memory exhausted by input buffer of size 107374182400 bytes (100 GiB)

So indicating the size of the failing allocation might be just good enough. For the other parts it's usually just "the way the OS was configured, it does not think it can allow this allocation".

Signature · 3 lines
Thanks,

David / dhildenb
#13 lore raw
Quoted 64 lines · * David Hildenbrand ([email protected]) wrote:
Quoted 48 lines · Philippe Mathieu-Daudé
Quoted 47 lines · David Hildenbrand
Quoted 26 lines · Philippe Mathieu-Daudé
Quoted 25 lines · David Hildenbrand
Quoted 5 lines · Peter Maydell
Quoted 2 lines · David Hildenbrand

Not opposed to printing the size, although I doubt that it will really stop similar questions/problems getting raised.

Quoted 9 lines

The case that triggered this was somebody thinking -m took a byte count, so very likely that an error message saying "you tried to allocate 38TB" would have made their mistake clear in a way that just "allocation failed" did not. It also means that if a future user asks us for help then we can look at the error message and immediately tell them the problem, rather than going "hmm, what are all the possible ways that allocation might have failed" and going off down rabbitholes like VM overcommit settings...

We've had similar issues recently where Linux memory overcommit handling rejected the allocation -- and the user was well aware about the actual size. You won't be able to catch such reports, because people don't understand how Linux memory overcommit handling works or was configured.

"I have 3 GiB of free memory, why can't I create a 3 GiB VM". "I have 3 GiB of RAM, why can't I create a 3 GiB VM even if it won't make use of all 3 GiB of memory".

Quoted 6 lines
Quoted 4 lines

Thus my comment, it will only stop very basic usage issues. And I agree that looking at the error *might* help. It didn't help for the cases I just described, because we need much more system information to make a guess what the user error actually is.

Is it possible to get the maximal overcommitable amount on Linux?

Not reliably I think.

In the "always" mode, there is none.

In the "guess"/"estimate" mode, the kernel takes a guess (currently implemented as checking if the mmap size <= total RAM + total SWAP).
    Committable = MemTotal + SwapTotal

In the "never" mode:
    Committable = CommitLimit - Committed_AS
However, the value gets further reduced for !root applications by /proc/sys/vm/admin_reserve_kbytes.

Quoted 5 lines
Quoted 1 line

Replicating these calculations in user space would be suboptimal IMHO.

What about simply giving a hint about memory overcommit and display a link to documentation with longer description about how to check and figure out this issue?

That would be highly OS-specific -- for example, there is no memory overcommit under Windows. Sure, we could add a Linux specific hint, indication documentation. But I'm not sure if most end users stumbling into such an error+hint would be able to make sense of memory overcommit details (not to mention that they know what it even is) :)

You can run into memory allocation issues with many applications. Let me give you a simple example

Quoted 6 lines

t480s: ~ $ dd if=/dev/zero of=/dev/null ibs=100G
dd: memory exhausted by input buffer of size 107374182400 bytes (100 GiB)

So indicating the size of the failing allocation might be just good enough. For the other parts it's usually just "the way the OS was configured, it does not think it can allow this allocation".

Does it also get complicated by the use of CGroup?

Dave

Quoted 5 lines
Signature · 3 lines
Thanks,

David / dhildenb
Signature · 1 line
Dr. David Alan Gilbert / [email protected] / Manchester, UK
#14 lore raw
Quoted 65 lines · Dr. David Alan Gilbert
Quoted 64 lines · * David Hildenbrand ([email protected]) wrote:
Quoted 48 lines · Philippe Mathieu-Daudé
Quoted 47 lines · David Hildenbrand
Quoted 26 lines · Philippe Mathieu-Daudé
Quoted 25 lines · David Hildenbrand
Quoted 5 lines · Peter Maydell
Quoted 2 lines · David Hildenbrand

Not opposed to printing the size, although I doubt that it will really stop similar questions/problems getting raised.

Quoted 9 lines

The case that triggered this was somebody thinking -m took a byte count, so very likely that an error message saying "you tried to allocate 38TB" would have made their mistake clear in a way that just "allocation failed" did not. It also means that if a future user asks us for help then we can look at the error message and immediately tell them the problem, rather than going "hmm, what are all the possible ways that allocation might have failed" and going off down rabbitholes like VM overcommit settings...

We've had similar issues recently where Linux memory overcommit handling rejected the allocation -- and the user was well aware about the actual size. You won't be able to catch such reports, because people don't understand how Linux memory overcommit handling works or was configured.

"I have 3 GiB of free memory, why can't I create a 3 GiB VM". "I have 3 GiB of RAM, why can't I create a 3 GiB VM even if it won't make use of all 3 GiB of memory".

Quoted 6 lines
Quoted 4 lines

Thus my comment, it will only stop very basic usage issues. And I agree that looking at the error *might* help. It didn't help for the cases I just described, because we need much more system information to make a guess what the user error actually is.

Is it possible to get the maximal overcommitable amount on Linux?

Not reliably I think.

In the "always" mode, there is none.

In the "guess"/"estimate" mode, the kernel takes a guess (currently implemented as checking if the mmap size <= total RAM + total SWAP).
    Committable = MemTotal + SwapTotal

In the "never" mode:
    Committable = CommitLimit - Committed_AS
However, the value gets further reduced for !root applications by /proc/sys/vm/admin_reserve_kbytes.

Quoted 5 lines
Quoted 1 line

Replicating these calculations in user space would be suboptimal IMHO.

What about simply giving a hint about memory overcommit and display a link to documentation with longer description about how to check and figure out this issue?

That would be highly OS-specific -- for example, there is no memory overcommit under Windows. Sure, we could add a Linux specific hint, indication documentation. But I'm not sure if most end users stumbling into such an error+hint would be able to make sense of memory overcommit details (not to mention that they know what it even is) :)

You can run into memory allocation issues with many applications. Let me give you a simple example

Quoted 8 lines
Quoted 6 lines

t480s: ~ $ dd if=/dev/zero of=/dev/null ibs=100G
dd: memory exhausted by input buffer of size 107374182400 bytes (100 GiB)

So indicating the size of the failing allocation might be just good enough. For the other parts it's usually just "the way the OS was configured, it does not think it can allow this allocation".

Does it also get complicated by the use of CGroup?

Not in terms of memory overcommit AFAIU. cgroups only control actually memory consumption, not mmap() creation.

Quoted 2 lines

Dave

Signature · 3 lines
Thanks,

David / dhildenb
#15 lore raw
In reply to Dr. David Alan Gilbert
Quoted 65 lines · On Tue, 24 Aug 2021 09:37:54 +0100 "Dr. David Alan Gilbert"…
Quoted 64 lines · * David Hildenbrand ([email protected]) wrote:
Quoted 48 lines · Philippe Mathieu-Daudé
Quoted 47 lines · David Hildenbrand
Quoted 26 lines · Philippe Mathieu-Daudé
Quoted 25 lines · David Hildenbrand
Quoted 5 lines · Peter Maydell
Quoted 2 lines · David Hildenbrand

Not opposed to printing the size, although I doubt that it will really stop similar questions/problems getting raised.

Quoted 9 lines

The case that triggered this was somebody thinking -m took a byte count, so very likely that an error message saying "you tried to allocate 38TB" would have made their mistake clear in a way that just "allocation failed" did not. It also means that if a future user asks us for help then we can look at the error message and immediately tell them the problem, rather than going "hmm, what are all the possible ways that allocation might have failed" and going off down rabbitholes like VM overcommit settings...

We've had similar issues recently where Linux memory overcommit handling rejected the allocation -- and the user was well aware about the actual size. You won't be able to catch such reports, because people don't understand how Linux memory overcommit handling works or was configured.

"I have 3 GiB of free memory, why can't I create a 3 GiB VM". "I have 3 GiB of RAM, why can't I create a 3 GiB VM even if it won't make use of all 3 GiB of memory".

Quoted 6 lines
Quoted 4 lines

Thus my comment, it will only stop very basic usage issues. And I agree that looking at the error *might* help. It didn't help for the cases I just described, because we need much more system information to make a guess what the user error actually is.

Is it possible to get the maximal overcommitable amount on Linux?

Not reliably I think.

In the "always" mode, there is none.

In the "guess"/"estimate" mode, the kernel takes a guess (currently implemented as checking if the mmap size <= total RAM + total SWAP).
    Committable = MemTotal + SwapTotal

In the "never" mode:
    Committable = CommitLimit - Committed_AS
However, the value gets further reduced for !root applications by /proc/sys/vm/admin_reserve_kbytes.

Quoted 5 lines
Quoted 1 line

Replicating these calculations in user space would be suboptimal IMHO.

What about simply giving a hint about memory overcommit and display a link to documentation with longer description about how to check and figure out this issue?

That would be highly OS-specific -- for example, there is no memory overcommit under Windows. Sure, we could add a Linux specific hint, indication documentation. But I'm not sure if most end users stumbling into such an error+hint would be able to make sense of memory overcommit details (not to mention that they know what it even is) :)

You can run into memory allocation issues with many applications. Let me give you a simple example

Quoted 8 lines
Quoted 6 lines

t480s: ~ $ dd if=/dev/zero of=/dev/null ibs=100G
dd: memory exhausted by input buffer of size 107374182400 bytes (100 GiB)

So indicating the size of the failing allocation might be just good enough. For the other parts it's usually just "the way the OS was configured, it does not think it can allow this allocation".

Does it also get complicated by the use of CGroup?

And if it's not complex enough, add to that NUMA node binding, which introduces additional limitations on RAM size that can be allocated.

Quoted 7 lines

Dave

Quoted 5 lines
Signature · 3 lines
Thanks,

David / dhildenb
Reviewed-by on v1 1/1
#16 lore raw
In reply to Philippe Mathieu-Daudé
Quoted 9 lines · Philippe Mathieu-Daudé

When Linux refuses to overcommit a seriously wild allocation we get:

  $ qemu-system-i386 -m 40000000
  qemu-system-i386: cannot set up guest memory 'pc.ram': Cannot allocate memory

Slighly improve the error message, displaying the memory size requested (in case the user didn't expect unspecified memory size unit is in MiB):

Quoted 5 lines
  $ qemu-system-i386 -m 40000000
  qemu-system-i386: Cannot set up 38.1 TiB of guest memory 'pc.ram': Cannot allocate memory
Signature · 1 line
Peter Xu
Tested-by on v1 1/1
#17 lore raw
In reply to Philippe Mathieu-Daudé
Quoted 7 lines · Philippe Mathieu-Daudé

When Linux refuses to overcommit a seriously wild allocation we get:

  $ qemu-system-i386 -m 40000000
  qemu-system-i386: cannot set up guest memory 'pc.ram': Cannot allocate memory

Slighly improve the error message, displaying the memory size

typo: Slightly

Quoted 17 lines

requested (in case the user didn't expect unspecified memory size unit is in MiB):

  $ qemu-system-i386 -m 40000000
  qemu-system-i386: Cannot set up 38.1 TiB of guest memory 'pc.ram': Cannot allocate memory
---
 softmmu/physmem.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
softmmu/physmem.c +0 -0
index 2e18947598e..2f300a9e79b 100644

softmmu/physmem.c static void ram_block_add(RAMBlock *new_block, Error **errp) · line 1985

Quoted 4 lines
softmmu/physmem.c +1 -0
@@ -1982,8 +1982,10 @@ static void ram_block_add(RAMBlock *new_block, Error **errp)
                                                   &new_block->mr->align,
                                                   shared, noreserve);
             if (!new_block->host) {
+                g_autofree char *size_s = size_to_str(new_block->max_length);

Does g_autofree work with every compiler we support?

Looks it only applies to GCC and clang?
https://www.gitmemory.com/issue/linuxwacom/libwacom/142/518787578

softmmu/physmem.c static void ram_block_add(RAMBlock *new_block, Error **errp) · line 1988

Quoted 4 lines
softmmu/physmem.c +2 -1
                 error_setg_errno(errp, errno,
-                                 "cannot set up guest memory '%s'",
+                                 "Cannot set up %s of guest memory '%s'",
+                                 size_s,

Nice improvement!

softmmu/physmem.c static void ram_block_add(RAMBlock *new_block, Error **errp) · line 1991

Quoted 3 lines
softmmu/physmem.c +0 -0
                                  memory_region_name(new_block->mr));
                 qemu_mutex_unlock_ramlist();
                 return;
#19 lore raw
In reply to Bin Meng
Quoted 11 lines · Bin Meng
Quoted 7 lines · Philippe Mathieu-Daudé

When Linux refuses to overcommit a seriously wild allocation we get:

  $ qemu-system-i386 -m 40000000
  qemu-system-i386: cannot set up guest memory 'pc.ram': Cannot allocate memory

Slighly improve the error message, displaying the memory size

typo: Slightly

Oops.

Quoted 7 lines
Quoted 2 lines
             if (!new_block->host) {

+ g_autofree char *size_s = size_to_str(new_block->max_length);

Does g_autofree work with every compiler we support?

Looks it only applies to GCC and clang?
https://www.gitmemory.com/issue/linuxwacom/libwacom/142/518787578

Which are the only two supported by the project AFAIK.

g_autofree depends on glib, minimum available since commit 00f2cfbbec6 ("glib: bump min required glib library version to 2.48").

Merged here:

commit 3590b27c7a2be7a24b4b265
Merge: d013d220c71 57b9f113fce
Date: Thu Aug 22 17:57:09 2019 +0100

Merge remote-tracking branch 'remotes/berrange/tags/autofree-pull-request' into staging

require newer glib2 to enable autofree'ing of stack variables exiting scope

Quoted 1 line

Thanks!