Skip to contentSkip to conversation

drm/i915: Add psr_safest_params

PATCH In review José Roberto de Souza 3 participants 6 messages May 20, 2020 – Jun 5, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: Add psr_safest_params

This parameter is meant to be used when PSR issues are found as some issues in the past was due wrong values set in VBT so this would be a quick and easy way to ask users or for us to check if the issue is due VBT values.

---
 drivers/gpu/drm/i915/display/intel_psr.c | 37 ++++++++++++++++++------
 drivers/gpu/drm/i915/i915_params.c       |  5 ++++
 drivers/gpu/drm/i915/i915_params.h       |  1 +
 3 files changed, 34 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/display/intel_psr.c +28 -9
index b7a2c102648a..859780853f42 100644
@@ -426,6 +426,12 @@ static u32 intel_psr1_get_tp_time(struct intel_dp *intel_dp)
 	if (INTEL_GEN(dev_priv) >= 11)
 		val |= EDP_PSR_TP4_TIME_0US;
 
+	if (i915_modparams.psr_safest_params) {
+		val |= EDP_PSR_TP1_TIME_2500us;
+		val |= EDP_PSR_TP2_TP3_TIME_2500us;
+		goto check_tp3_sel;
+	}
+
 	if (dev_priv->vbt.psr.tp1_wakeup_time_us == 0)
 		val |= EDP_PSR_TP1_TIME_0us;
 	else if (dev_priv->vbt.psr.tp1_wakeup_time_us <= 100)
@@ -444,6 +450,7 @@ static u32 intel_psr1_get_tp_time(struct intel_dp *intel_dp)
 	else
 		val |= EDP_PSR_TP2_TP3_TIME_2500us;
 
+check_tp3_sel:
 	if (intel_dp_source_supports_hbr2(intel_dp) &&
 	    drm_dp_tps3_supported(intel_dp->dpcd))
 		val |= EDP_PSR_TP1_TP3_SEL;
@@ -495,18 +502,13 @@ static void hsw_activate_psr1(struct intel_dp *intel_dp)
 	intel_de_write(dev_priv, EDP_PSR_CTL(dev_priv->psr.transcoder), val);
 }
 
-static void hsw_activate_psr2(struct intel_dp *intel_dp)
+static u32 intel_psr2_get_tp_time(struct intel_dp *intel_dp)
 {
 	struct drm_i915_private *dev_priv = dp_to_i915(intel_dp);
-	u32 val;
-
-	val = psr_compute_idle_frames(intel_dp) << EDP_PSR2_IDLE_FRAME_SHIFT;
-
-	val |= EDP_PSR2_ENABLE | EDP_SU_TRACK_ENABLE;
-	if (INTEL_GEN(dev_priv) >= 10 || IS_GEMINILAKE(dev_priv))
-		val |= EDP_Y_COORDINATE_ENABLE;
+	u32 val = 0;
 
-	val |= EDP_PSR2_FRAME_BEFORE_SU(dev_priv->psr.sink_sync_latency + 1);
+	if (i915_modparams.psr_safest_params)
+		return EDP_PSR2_TP2_TIME_2500us;
 
 	if (dev_priv->vbt.psr.psr2_tp2_tp3_wakeup_time_us >= 0 &&
 	    dev_priv->vbt.psr.psr2_tp2_tp3_wakeup_time_us <= 50)
@@ -518,6 +520,23 @@ static void hsw_activate_psr2(struct intel_dp *intel_dp)
 	else
 		val |= EDP_PSR2_TP2_TIME_2500us;
 
+	return val;
+}
+
+static void hsw_activate_psr2(struct intel_dp *intel_dp)
+{
+	struct drm_i915_private *dev_priv = dp_to_i915(intel_dp);
+	u32 val;
+
+	val = psr_compute_idle_frames(intel_dp) << EDP_PSR2_IDLE_FRAME_SHIFT;
+
+	val |= EDP_PSR2_ENABLE | EDP_SU_TRACK_ENABLE;
+	if (INTEL_GEN(dev_priv) >= 10 || IS_GEMINILAKE(dev_priv))
+		val |= EDP_Y_COORDINATE_ENABLE;
+
+	val |= EDP_PSR2_FRAME_BEFORE_SU(dev_priv->psr.sink_sync_latency + 1);
+	val |= intel_psr2_get_tp_time(intel_dp);
+
 	/*
 	 * PSR2 HW is incorrectly using EDP_PSR_TP1_TP3_SEL and BSpec is
 	 * recommending keep this bit unset while PSR2 is enabled.
drivers/gpu/drm/i915/i915_params.c +5 -0
index add00ec1f787..307e4667fc62 100644
@@ -88,6 +88,11 @@ i915_param_named_unsafe(enable_psr, int, 0600,
 	"(0=disabled, 1=enabled) "
 	"Default: -1 (use per-chip default)");
 
+i915_param_named(psr_safest_params, bool, 0400,
+	"Replace PSR VBT parameters by the safest and not optimal ones. This "
+	"is helpfull to detect if PSR issues are related to bad values set in "
+	" VBT. (0=use VBT paramters, 1=use safest parameters)");
+
 i915_param_named_unsafe(force_probe, charp, 0400,
 	"Force probe the driver for specified devices. "
 	"See CONFIG_DRM_I915_FORCE_PROBE for details.");
drivers/gpu/drm/i915/i915_params.h +1 -0
index 45323732f099..2a99c908c7c8 100644
@@ -53,6 +53,7 @@ struct drm_printer;
 	param(int, enable_dc, -1, 0400) \
 	param(int, enable_fbc, -1, 0600) \
 	param(int, enable_psr, -1, 0600) \
+	param(bool, psr_safest_params, false, 0600) \
 	param(int, disable_power_well, -1, 0400) \
 	param(int, enable_ips, 1, 0600) \
 	param(int, invert_brightness, 0, 0600) \
Signature · 6 lines
2.26.2

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add psr_safest_params

== Series Details ==

== Series Details ==

Series: drm/i915: Add psr_safest_params
URL : https://patchwork.freedesktop.org/series/77491/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
7f3095d8f257 drm/i915: Add psr_safest_params
-:98: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#98: FILE: drivers/gpu/drm/i915/i915_params.c:92:
+i915_param_named(psr_safest_params, bool, 0400,
+	"Replace PSR VBT parameters by the safest and not optimal ones. This "

-:99: WARNING:TYPO_SPELLING: 'helpfull' may be misspelled - perhaps 'helpful'? #99: FILE: drivers/gpu/drm/i915/i915_params.c:93:
+ "is helpfull to detect if PSR issues are related to bad values set in "

-:100: WARNING:TYPO_SPELLING: 'paramters' may be misspelled - perhaps 'parameters'? #100: FILE: drivers/gpu/drm/i915/i915_params.c:94:
+ " VBT. (0=use VBT paramters, 1=use safest parameters)");

total: 0 errors, 2 warnings, 1 checks, 82 lines checked

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add psr_safest_params

In reply to José Roberto de Souza
== Series Details ==

== Series Details ==

Series: drm/i915: Add psr_safest_params
URL : https://patchwork.freedesktop.org/series/77491/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_8515 -> Patchwork_17738
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/index.html

Known issues
------------

Here are the changes found in Patchwork_17738 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_pm_rpm@module-reload:
- fi-bsw-kefka: [PASS][1] -> [INCOMPLETE][2] ([i915#151] / [i915#1844] / [i915#392])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/fi-bsw-kefka/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/fi-bsw-kefka/igt@[email protected]
- fi-kbl-guc: [PASS][3] -> [FAIL][4] ([i915#579])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/fi-kbl-guc/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/fi-kbl-guc/igt@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@execlists:
- {fi-tgl-dsi}: [INCOMPLETE][5] ([i915#1803]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/fi-tgl-dsi/igt@i915_selftest@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/fi-tgl-dsi/igt@i915_selftest@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[i915#151]: https://gitlab.freedesktop.org/drm/intel/issues/151
[i915#1803]: https://gitlab.freedesktop.org/drm/intel/issues/1803
[i915#1844]: https://gitlab.freedesktop.org/drm/intel/issues/1844
[i915#392]: https://gitlab.freedesktop.org/drm/intel/issues/392
[i915#579]: https://gitlab.freedesktop.org/drm/intel/issues/579

Participating hosts (49 -> 42)
------------------------------

Missing (7): fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-hsw-4770 fi-kbl-7560u fi-byt-clapper fi-bdw-samus

Build changes
-------------

* Linux: CI_DRM_8515 -> Patchwork_17738

CI-20190529: 20190529
CI_DRM_8515: 41f9bb782f3bb2f30be09683184bbeecb1fd31bb @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5665: c5e5b0ce26fc321591a6d0235c639a1e8ec3cdfa @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17738: 7f3095d8f257cc9646071b19df534a8a5df7ed60 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

7f3095d8f257 drm/i915: Add psr_safest_params

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Add psr_safest_params

In reply to José Roberto de Souza
== Series Details ==

== Series Details ==

Series: drm/i915: Add psr_safest_params
URL : https://patchwork.freedesktop.org/series/77491/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_8515_full -> Patchwork_17738_full
====================================================

Summary
-------

**WARNING**

Minor unknown changes coming with Patchwork_17738_full need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_17738_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_17738_full:

### IGT changes ###

#### Warnings ####

* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][1] ([i915#588]) -> [SKIP][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-iclb2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-iclb3/igt@[email protected]

New tests
---------

New tests have been introduced between CI_DRM_8515_full and Patchwork_17738_full:

### New IGT tests (74) ###

* igt@kms_big_fb@linear-16bpp-rotate-0:
- Statuses : 7 pass(s)
- Exec time: [1.51, 7.43] s

* igt@kms_big_fb@linear-16bpp-rotate-180:
- Statuses : 7 pass(s)
- Exec time: [1.61, 7.23] s

* igt@kms_big_fb@linear-16bpp-rotate-270:
- Statuses : 7 skip(s)
- Exec time: [0.01, 0.19] s

* igt@kms_big_fb@linear-16bpp-rotate-90:
- Statuses : 7 skip(s)
- Exec time: [0.02, 0.19] s

* igt@kms_big_fb@linear-32bpp-rotate-0:
- Statuses : 7 pass(s)
- Exec time: [1.65, 11.03] s

* igt@kms_big_fb@linear-32bpp-rotate-180:
- Statuses : 7 pass(s)
- Exec time: [1.63, 10.83] s

* igt@kms_big_fb@linear-32bpp-rotate-270:
- Statuses : 7 skip(s)
- Exec time: [0.01, 0.20] s

* igt@kms_big_fb@linear-32bpp-rotate-90:
- Statuses : 7 skip(s)
- Exec time: [0.01, 0.19] s

* igt@kms_big_fb@linear-64bpp-rotate-0:
- Statuses : 6 pass(s)
- Exec time: [1.91, 10.99] s

* igt@kms_big_fb@linear-64bpp-rotate-180:
- Statuses : 7 pass(s)
- Exec time: [1.92, 10.95] s

* igt@kms_big_fb@linear-64bpp-rotate-270:
- Statuses : 7 skip(s)
- Exec time: [0.04, 0.78] s

* igt@kms_big_fb@linear-64bpp-rotate-90:
- Statuses : 7 skip(s)
- Exec time: [0.06, 0.85] s

* igt@kms_big_fb@linear-8bpp-rotate-0:
- Statuses : 7 pass(s)
- Exec time: [1.46, 6.00] s

* igt@kms_big_fb@linear-8bpp-rotate-180:
- Statuses : 7 pass(s)
- Exec time: [1.48, 5.51] s

* igt@kms_big_fb@linear-8bpp-rotate-270:
- Statuses : 6 skip(s)
- Exec time: [0.02, 0.21] s

* igt@kms_big_fb@linear-8bpp-rotate-90:
- Statuses : 7 skip(s)
- Exec time: [0.02, 0.30] s

* igt@kms_big_fb@linear-addfb:
- Statuses : 7 pass(s)
- Exec time: [0.0, 0.00] s

* igt@kms_big_fb@x-tiled-16bpp-rotate-0:
- Statuses : 7 pass(s)
- Exec time: [1.46, 7.09] s

* igt@kms_big_fb@x-tiled-16bpp-rotate-180:
- Statuses : 7 pass(s)
- Exec time: [1.58, 7.07] s

* igt@kms_big_fb@x-tiled-16bpp-rotate-270:
- Statuses : 7 skip(s)
- Exec time: [0.01, 0.19] s

* igt@kms_big_fb@x-tiled-16bpp-rotate-90:
- Statuses : 6 skip(s)
- Exec time: [0.01, 0.20] s

* igt@kms_big_fb@x-tiled-32bpp-rotate-0:
- Statuses : 7 pass(s)
- Exec time: [1.56, 10.64] s

* igt@kms_big_fb@x-tiled-32bpp-rotate-180:
- Statuses : 7 pass(s)
- Exec time: [1.59, 10.58] s

* igt@kms_big_fb@x-tiled-32bpp-rotate-270:
- Statuses : 7 skip(s)
- Exec time: [0.01, 0.21] s

* igt@kms_big_fb@x-tiled-32bpp-rotate-90:
- Statuses : 7 skip(s)
- Exec time: [0.02, 0.21] s

* igt@kms_big_fb@x-tiled-64bpp-rotate-0:
- Statuses : 7 pass(s)
- Exec time: [1.87, 11.61] s

* igt@kms_big_fb@x-tiled-64bpp-rotate-180:
- Statuses : 7 pass(s)
- Exec time: [1.97, 10.64] s

* igt@kms_big_fb@x-tiled-64bpp-rotate-270:
- Statuses : 7 skip(s)
- Exec time: [0.04, 0.87] s

* igt@kms_big_fb@x-tiled-64bpp-rotate-90:
- Statuses : 6 skip(s)
- Exec time: [0.05, 0.76] s

* igt@kms_big_fb@x-tiled-8bpp-rotate-0:
- Statuses : 7 pass(s)
- Exec time: [1.28, 5.08] s

* igt@kms_big_fb@x-tiled-8bpp-rotate-180:
- Statuses : 7 pass(s)
- Exec time: [1.40, 5.49] s

* igt@kms_big_fb@x-tiled-8bpp-rotate-270:
- Statuses : 7 skip(s)
- Exec time: [0.02, 0.29] s

* igt@kms_big_fb@x-tiled-8bpp-rotate-90:
- Statuses : 7 skip(s)
- Exec time: [0.03, 0.42] s

* igt@kms_big_fb@x-tiled-addfb:
- Statuses : 7 pass(s)
- Exec time: [0.0, 0.00] s

* igt@kms_big_fb@x-tiled-addfb-size-offset-overflow:
- Statuses : 4 pass(s) 3 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@x-tiled-addfb-size-overflow:
- Statuses : 6 pass(s) 1 skip(s)
- Exec time: [0.0, 0.00] s

* igt@kms_big_fb@y-tiled-16bpp-rotate-0:
- Statuses : 5 pass(s) 1 skip(s)
- Exec time: [0.0, 7.18] s

* igt@kms_big_fb@y-tiled-16bpp-rotate-180:
- Statuses : 6 pass(s) 1 skip(s)
- Exec time: [0.0, 7.01] s

* igt@kms_big_fb@y-tiled-16bpp-rotate-270:
- Statuses : 2 pass(s) 5 skip(s)
- Exec time: [0.0, 1.64] s

* igt@kms_big_fb@y-tiled-16bpp-rotate-90:
- Statuses : 2 pass(s) 5 skip(s)
- Exec time: [0.0, 1.90] s

* igt@kms_big_fb@y-tiled-32bpp-rotate-0:
- Statuses : 6 pass(s) 1 skip(s)
- Exec time: [0.0, 10.76] s

* igt@kms_big_fb@y-tiled-32bpp-rotate-180:
- Statuses : 6 pass(s) 1 skip(s)
- Exec time: [0.0, 11.56] s

* igt@kms_big_fb@y-tiled-32bpp-rotate-270:
- Statuses : 6 pass(s) 1 skip(s)
- Exec time: [0.0, 11.24] s

* igt@kms_big_fb@y-tiled-32bpp-rotate-90:
- Statuses : 6 pass(s) 1 skip(s)
- Exec time: [0.0, 10.58] s

* igt@kms_big_fb@y-tiled-64bpp-rotate-0:
- Statuses : 5 pass(s) 2 skip(s)
- Exec time: [0.0, 7.04] s

* igt@kms_big_fb@y-tiled-64bpp-rotate-180:
- Statuses : 5 pass(s) 2 skip(s)
- Exec time: [0.0, 7.79] s

* igt@kms_big_fb@y-tiled-64bpp-rotate-270:
- Statuses : 7 skip(s)
- Exec time: [0.0, 0.99] s

* igt@kms_big_fb@y-tiled-64bpp-rotate-90:
- Statuses : 7 skip(s)
- Exec time: [0.0, 0.96] s

* igt@kms_big_fb@y-tiled-8bpp-rotate-0:
- Statuses : 5 pass(s) 1 skip(s)
- Exec time: [0.0, 2.45] s

* igt@kms_big_fb@y-tiled-8bpp-rotate-180:
- Statuses : 6 pass(s) 1 skip(s)
- Exec time: [0.0, 5.08] s

* igt@kms_big_fb@y-tiled-8bpp-rotate-270:
- Statuses : 7 skip(s)
- Exec time: [0.0, 0.34] s

* igt@kms_big_fb@y-tiled-8bpp-rotate-90:
- Statuses : 7 skip(s)
- Exec time: [0.0, 0.42] s

* igt@kms_big_fb@y-tiled-addfb:
- Statuses : 6 pass(s) 1 skip(s)
- Exec time: [0.0, 0.00] s

* igt@kms_big_fb@y-tiled-addfb-size-offset-overflow:
- Statuses : 4 pass(s) 3 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@y-tiled-addfb-size-overflow:
- Statuses : 6 pass(s) 1 skip(s)
- Exec time: [0.0, 0.00] s

* igt@kms_big_fb@yf-tiled-16bpp-rotate-0:
- Statuses : 5 pass(s) 2 skip(s)
- Exec time: [0.0, 7.47] s

* igt@kms_big_fb@yf-tiled-16bpp-rotate-180:
- Statuses : 5 pass(s) 2 skip(s)
- Exec time: [0.0, 7.14] s

* igt@kms_big_fb@yf-tiled-16bpp-rotate-270:
- Statuses : 1 pass(s) 5 skip(s)
- Exec time: [0.0, 1.85] s

* igt@kms_big_fb@yf-tiled-16bpp-rotate-90:
- Statuses : 1 pass(s) 5 skip(s)
- Exec time: [0.0, 1.68] s

* igt@kms_big_fb@yf-tiled-32bpp-rotate-0:
- Statuses : 5 pass(s) 2 skip(s)
- Exec time: [0.0, 11.56] s

* igt@kms_big_fb@yf-tiled-32bpp-rotate-180:
- Statuses : 5 pass(s) 2 skip(s)
- Exec time: [0.0, 11.05] s

* igt@kms_big_fb@yf-tiled-32bpp-rotate-270:
- Statuses : 5 pass(s) 2 skip(s)
- Exec time: [0.0, 13.39] s

* igt@kms_big_fb@yf-tiled-32bpp-rotate-90:
- Statuses : 5 pass(s) 2 skip(s)
- Exec time: [0.0, 11.89] s

* igt@kms_big_fb@yf-tiled-64bpp-rotate-0:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@yf-tiled-64bpp-rotate-180:
- Statuses : 7 skip(s)
- Exec time: [0.0, 0.05] s

* igt@kms_big_fb@yf-tiled-64bpp-rotate-270:
- Statuses : 7 skip(s)
- Exec time: [0.0, 0.05] s

* igt@kms_big_fb@yf-tiled-64bpp-rotate-90:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@yf-tiled-8bpp-rotate-0:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@yf-tiled-8bpp-rotate-180:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@yf-tiled-8bpp-rotate-270:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@yf-tiled-8bpp-rotate-90:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@yf-tiled-addfb:
- Statuses : 5 pass(s) 2 skip(s)
- Exec time: [0.0, 0.00] s

* igt@kms_big_fb@yf-tiled-addfb-size-offset-overflow:
- Statuses : 3 pass(s) 4 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@yf-tiled-addfb-size-overflow:
- Statuses : 5 pass(s) 2 skip(s)
- Exec time: [0.0, 0.00] s

Known issues
------------

Here are the changes found in Patchwork_17738_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gen9_exec_parse@allowed-all:
- shard-apl: [PASS][3] -> [DMESG-WARN][4] ([i915#1436] / [i915#716])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-apl3/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-apl6/igt@[email protected]

* igt@i915_selftest@live@execlists:
- shard-skl: [PASS][5] -> [INCOMPLETE][6] ([i915#1795] / [i915#1874])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-skl2/igt@i915_selftest@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-skl1/igt@i915_selftest@[email protected]

* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][7] -> [FAIL][8] ([i915#1188]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-skl7/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-skl8/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: [PASS][9] -> [DMESG-WARN][10] ([i915#180])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-apl1/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-apl8/igt@[email protected]
- shard-kbl: [PASS][11] -> [DMESG-WARN][12] ([i915#180]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-kbl4/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-kbl3/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [PASS][13] -> [FAIL][14] ([fdo#108145] / [i915#265])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-skl1/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-skl2/igt@[email protected]

* igt@kms_plane_cursor@pipe-a-overlay-size-256:
- shard-kbl: [PASS][15] -> [FAIL][16] ([i915#1559] / [i915#93] / [i915#95])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-kbl7/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-kbl1/igt@[email protected]
- shard-apl: [PASS][17] -> [FAIL][18] ([i915#1559] / [i915#95])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-apl8/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-apl3/igt@[email protected]

* igt@kms_psr@psr2_basic:
- shard-iclb: [PASS][19] -> [SKIP][20] ([fdo#109441])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-iclb2/igt@kms_psr@psr2_basic.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-iclb3/igt@kms_psr@psr2_basic.html

* igt@kms_psr@suspend:
- shard-skl: [PASS][21] -> [INCOMPLETE][22] ([i915#198])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-skl6/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-skl10/igt@[email protected]

* igt@kms_vblank@pipe-b-accuracy-idle:
- shard-glk: [PASS][23] -> [FAIL][24] ([i915#43])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-glk6/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-glk1/igt@[email protected]

#### Possible fixes ####

* igt@gem_ctx_persistence@legacy-engines-mixed-process@render:
- shard-apl: [FAIL][25] ([i915#1528]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-apl8/igt@gem_ctx_persistence@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-apl7/igt@gem_ctx_persistence@[email protected]

* {igt@kms_flip@flip-vs-suspend-interruptible@a-dp1}:
- shard-kbl: [DMESG-WARN][27] ([i915#180]) -> [PASS][28] +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-kbl3/igt@kms_flip@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-kbl4/igt@kms_flip@[email protected]
- shard-apl: [DMESG-WARN][29] ([i915#180]) -> [PASS][30] +6 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-apl3/igt@kms_flip@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-apl6/igt@kms_flip@[email protected]

* {igt@kms_flip@flip-vs-suspend-interruptible@b-edp1}:
- shard-skl: [INCOMPLETE][31] ([i915#198]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-skl6/igt@kms_flip@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-skl3/igt@kms_flip@[email protected]

* igt@kms_flip_tiling@flip-changes-tiling-yf:
- shard-kbl: [FAIL][33] ([i915#699] / [i915#93] / [i915#95]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-kbl2/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-kbl7/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-suspend:
- shard-skl: [INCOMPLETE][35] ([i915#123] / [i915#69]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-skl10/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-skl6/igt@[email protected]

* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [FAIL][37] ([i915#1188]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-skl1/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-skl1/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][39] ([fdo#108145] / [i915#265]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-skl4/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-skl2/igt@[email protected]

* igt@kms_psr@psr2_primary_render:
- shard-iclb: [SKIP][41] ([fdo#109441]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-iclb3/igt@kms_psr@psr2_primary_render.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-iclb2/igt@kms_psr@psr2_primary_render.html

* igt@kms_setmode@basic:
- shard-apl: [FAIL][43] ([i915#31]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-apl1/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-apl8/igt@[email protected]

#### Warnings ####

* igt@i915_pm_dc@dc6-psr:
- shard-tglb: [SKIP][45] ([i915#468]) -> [FAIL][46] ([i915#454])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-tglb2/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-tglb5/igt@[email protected]

* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [FAIL][47] ([i915#1515]) -> [WARN][48] ([i915#1515])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-iclb4/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-iclb6/igt@[email protected]

* igt@kms_content_protection@atomic:
- shard-apl: [TIMEOUT][49] ([i915#1319]) -> [FAIL][50] ([fdo#110321] / [fdo#110336])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-apl4/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-apl1/igt@[email protected]

* igt@kms_content_protection@atomic-dpms:
- shard-apl: [FAIL][51] ([fdo#110321] / [fdo#110336]) -> [TIMEOUT][52] ([i915#1319])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-apl8/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-apl7/igt@[email protected]

* igt@kms_content_protection@lic:
- shard-apl: [FAIL][53] ([fdo#110321]) -> [DMESG-FAIL][54] ([fdo#110321])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-apl6/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-apl2/igt@[email protected]

* igt@kms_content_protection@srm:
- shard-apl: [FAIL][55] ([fdo#110321]) -> [TIMEOUT][56] ([i915#1319])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-apl1/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-apl8/igt@[email protected]

* igt@kms_psr2_su@page_flip:
- shard-iclb: [FAIL][57] ([i915#608]) -> [SKIP][58] ([fdo#109642] / [fdo#111068])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-iclb2/igt@kms_psr2_su@page_flip.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-iclb6/igt@kms_psr2_su@page_flip.html

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
[fdo#110336]: https://bugs.freedesktop.org/show_bug.cgi?id=110336
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#123]: https://gitlab.freedesktop.org/drm/intel/issues/123
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1515]: https://gitlab.freedesktop.org/drm/intel/issues/1515
[i915#1528]: https://gitlab.freedesktop.org/drm/intel/issues/1528
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1559]: https://gitlab.freedesktop.org/drm/intel/issues/1559
[i915#1795]: https://gitlab.freedesktop.org/drm/intel/issues/1795
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1874]: https://gitlab.freedesktop.org/drm/intel/issues/1874
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#43]: https://gitlab.freedesktop.org/drm/intel/issues/43
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#608]: https://gitlab.freedesktop.org/drm/intel/issues/608
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#699]: https://gitlab.freedesktop.org/drm/intel/issues/699
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95

Participating hosts (11 -> 11)
------------------------------

No changes in participating hosts

Build changes
-------------

* Linux: CI_DRM_8515 -> Patchwork_17738

CI-20190529: 20190529
CI_DRM_8515: 41f9bb782f3bb2f30be09683184bbeecb1fd31bb @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5665: c5e5b0ce26fc321591a6d0235c639a1e8ec3cdfa @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17738: 7f3095d8f257cc9646071b19df534a8a5df7ed60 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

author Applied
#4 lore raw

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Add psr_safest_params

Quoted 5 lines · Patchwork

== Series Details ==

Series: drm/i915: Add psr_safest_params
URL : https://patchwork.freedesktop.org/series/77491/
State : success

Pushed to dinq, thanks for the review GG.

Quoted 543 lines

== Summary ==

CI Bug Log - changes from CI_DRM_8515_full -> Patchwork_17738_full
====================================================

Summary
-------

**WARNING**

Minor unknown changes coming with Patchwork_17738_full need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_17738_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_17738_full:

### IGT changes ###

#### Warnings ####

* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][1] ([i915#588]) -> [SKIP][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-iclb2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-iclb3/igt@[email protected]

New tests
---------

New tests have been introduced between CI_DRM_8515_full and Patchwork_17738_full:

### New IGT tests (74) ###

* igt@kms_big_fb@linear-16bpp-rotate-0:
- Statuses : 7 pass(s)
- Exec time: [1.51, 7.43] s

* igt@kms_big_fb@linear-16bpp-rotate-180:
- Statuses : 7 pass(s)
- Exec time: [1.61, 7.23] s

* igt@kms_big_fb@linear-16bpp-rotate-270:
- Statuses : 7 skip(s)
- Exec time: [0.01, 0.19] s

* igt@kms_big_fb@linear-16bpp-rotate-90:
- Statuses : 7 skip(s)
- Exec time: [0.02, 0.19] s

* igt@kms_big_fb@linear-32bpp-rotate-0:
- Statuses : 7 pass(s)
- Exec time: [1.65, 11.03] s

* igt@kms_big_fb@linear-32bpp-rotate-180:
- Statuses : 7 pass(s)
- Exec time: [1.63, 10.83] s

* igt@kms_big_fb@linear-32bpp-rotate-270:
- Statuses : 7 skip(s)
- Exec time: [0.01, 0.20] s

* igt@kms_big_fb@linear-32bpp-rotate-90:
- Statuses : 7 skip(s)
- Exec time: [0.01, 0.19] s

* igt@kms_big_fb@linear-64bpp-rotate-0:
- Statuses : 6 pass(s)
- Exec time: [1.91, 10.99] s

* igt@kms_big_fb@linear-64bpp-rotate-180:
- Statuses : 7 pass(s)
- Exec time: [1.92, 10.95] s

* igt@kms_big_fb@linear-64bpp-rotate-270:
- Statuses : 7 skip(s)
- Exec time: [0.04, 0.78] s

* igt@kms_big_fb@linear-64bpp-rotate-90:
- Statuses : 7 skip(s)
- Exec time: [0.06, 0.85] s

* igt@kms_big_fb@linear-8bpp-rotate-0:
- Statuses : 7 pass(s)
- Exec time: [1.46, 6.00] s

* igt@kms_big_fb@linear-8bpp-rotate-180:
- Statuses : 7 pass(s)
- Exec time: [1.48, 5.51] s

* igt@kms_big_fb@linear-8bpp-rotate-270:
- Statuses : 6 skip(s)
- Exec time: [0.02, 0.21] s

* igt@kms_big_fb@linear-8bpp-rotate-90:
- Statuses : 7 skip(s)
- Exec time: [0.02, 0.30] s

* igt@kms_big_fb@linear-addfb:
- Statuses : 7 pass(s)
- Exec time: [0.0, 0.00] s

* igt@kms_big_fb@x-tiled-16bpp-rotate-0:
- Statuses : 7 pass(s)
- Exec time: [1.46, 7.09] s

* igt@kms_big_fb@x-tiled-16bpp-rotate-180:
- Statuses : 7 pass(s)
- Exec time: [1.58, 7.07] s

* igt@kms_big_fb@x-tiled-16bpp-rotate-270:
- Statuses : 7 skip(s)
- Exec time: [0.01, 0.19] s

* igt@kms_big_fb@x-tiled-16bpp-rotate-90:
- Statuses : 6 skip(s)
- Exec time: [0.01, 0.20] s

* igt@kms_big_fb@x-tiled-32bpp-rotate-0:
- Statuses : 7 pass(s)
- Exec time: [1.56, 10.64] s

* igt@kms_big_fb@x-tiled-32bpp-rotate-180:
- Statuses : 7 pass(s)
- Exec time: [1.59, 10.58] s

* igt@kms_big_fb@x-tiled-32bpp-rotate-270:
- Statuses : 7 skip(s)
- Exec time: [0.01, 0.21] s

* igt@kms_big_fb@x-tiled-32bpp-rotate-90:
- Statuses : 7 skip(s)
- Exec time: [0.02, 0.21] s

* igt@kms_big_fb@x-tiled-64bpp-rotate-0:
- Statuses : 7 pass(s)
- Exec time: [1.87, 11.61] s

* igt@kms_big_fb@x-tiled-64bpp-rotate-180:
- Statuses : 7 pass(s)
- Exec time: [1.97, 10.64] s

* igt@kms_big_fb@x-tiled-64bpp-rotate-270:
- Statuses : 7 skip(s)
- Exec time: [0.04, 0.87] s

* igt@kms_big_fb@x-tiled-64bpp-rotate-90:
- Statuses : 6 skip(s)
- Exec time: [0.05, 0.76] s

* igt@kms_big_fb@x-tiled-8bpp-rotate-0:
- Statuses : 7 pass(s)
- Exec time: [1.28, 5.08] s

* igt@kms_big_fb@x-tiled-8bpp-rotate-180:
- Statuses : 7 pass(s)
- Exec time: [1.40, 5.49] s

* igt@kms_big_fb@x-tiled-8bpp-rotate-270:
- Statuses : 7 skip(s)
- Exec time: [0.02, 0.29] s

* igt@kms_big_fb@x-tiled-8bpp-rotate-90:
- Statuses : 7 skip(s)
- Exec time: [0.03, 0.42] s

* igt@kms_big_fb@x-tiled-addfb:
- Statuses : 7 pass(s)
- Exec time: [0.0, 0.00] s

* igt@kms_big_fb@x-tiled-addfb-size-offset-overflow:
- Statuses : 4 pass(s) 3 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@x-tiled-addfb-size-overflow:
- Statuses : 6 pass(s) 1 skip(s)
- Exec time: [0.0, 0.00] s

* igt@kms_big_fb@y-tiled-16bpp-rotate-0:
- Statuses : 5 pass(s) 1 skip(s)
- Exec time: [0.0, 7.18] s

* igt@kms_big_fb@y-tiled-16bpp-rotate-180:
- Statuses : 6 pass(s) 1 skip(s)
- Exec time: [0.0, 7.01] s

* igt@kms_big_fb@y-tiled-16bpp-rotate-270:
- Statuses : 2 pass(s) 5 skip(s)
- Exec time: [0.0, 1.64] s

* igt@kms_big_fb@y-tiled-16bpp-rotate-90:
- Statuses : 2 pass(s) 5 skip(s)
- Exec time: [0.0, 1.90] s

* igt@kms_big_fb@y-tiled-32bpp-rotate-0:
- Statuses : 6 pass(s) 1 skip(s)
- Exec time: [0.0, 10.76] s

* igt@kms_big_fb@y-tiled-32bpp-rotate-180:
- Statuses : 6 pass(s) 1 skip(s)
- Exec time: [0.0, 11.56] s

* igt@kms_big_fb@y-tiled-32bpp-rotate-270:
- Statuses : 6 pass(s) 1 skip(s)
- Exec time: [0.0, 11.24] s

* igt@kms_big_fb@y-tiled-32bpp-rotate-90:
- Statuses : 6 pass(s) 1 skip(s)
- Exec time: [0.0, 10.58] s

* igt@kms_big_fb@y-tiled-64bpp-rotate-0:
- Statuses : 5 pass(s) 2 skip(s)
- Exec time: [0.0, 7.04] s

* igt@kms_big_fb@y-tiled-64bpp-rotate-180:
- Statuses : 5 pass(s) 2 skip(s)
- Exec time: [0.0, 7.79] s

* igt@kms_big_fb@y-tiled-64bpp-rotate-270:
- Statuses : 7 skip(s)
- Exec time: [0.0, 0.99] s

* igt@kms_big_fb@y-tiled-64bpp-rotate-90:
- Statuses : 7 skip(s)
- Exec time: [0.0, 0.96] s

* igt@kms_big_fb@y-tiled-8bpp-rotate-0:
- Statuses : 5 pass(s) 1 skip(s)
- Exec time: [0.0, 2.45] s

* igt@kms_big_fb@y-tiled-8bpp-rotate-180:
- Statuses : 6 pass(s) 1 skip(s)
- Exec time: [0.0, 5.08] s

* igt@kms_big_fb@y-tiled-8bpp-rotate-270:
- Statuses : 7 skip(s)
- Exec time: [0.0, 0.34] s

* igt@kms_big_fb@y-tiled-8bpp-rotate-90:
- Statuses : 7 skip(s)
- Exec time: [0.0, 0.42] s

* igt@kms_big_fb@y-tiled-addfb:
- Statuses : 6 pass(s) 1 skip(s)
- Exec time: [0.0, 0.00] s

* igt@kms_big_fb@y-tiled-addfb-size-offset-overflow:
- Statuses : 4 pass(s) 3 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@y-tiled-addfb-size-overflow:
- Statuses : 6 pass(s) 1 skip(s)
- Exec time: [0.0, 0.00] s

* igt@kms_big_fb@yf-tiled-16bpp-rotate-0:
- Statuses : 5 pass(s) 2 skip(s)
- Exec time: [0.0, 7.47] s

* igt@kms_big_fb@yf-tiled-16bpp-rotate-180:
- Statuses : 5 pass(s) 2 skip(s)
- Exec time: [0.0, 7.14] s

* igt@kms_big_fb@yf-tiled-16bpp-rotate-270:
- Statuses : 1 pass(s) 5 skip(s)
- Exec time: [0.0, 1.85] s

* igt@kms_big_fb@yf-tiled-16bpp-rotate-90:
- Statuses : 1 pass(s) 5 skip(s)
- Exec time: [0.0, 1.68] s

* igt@kms_big_fb@yf-tiled-32bpp-rotate-0:
- Statuses : 5 pass(s) 2 skip(s)
- Exec time: [0.0, 11.56] s

* igt@kms_big_fb@yf-tiled-32bpp-rotate-180:
- Statuses : 5 pass(s) 2 skip(s)
- Exec time: [0.0, 11.05] s

* igt@kms_big_fb@yf-tiled-32bpp-rotate-270:
- Statuses : 5 pass(s) 2 skip(s)
- Exec time: [0.0, 13.39] s

* igt@kms_big_fb@yf-tiled-32bpp-rotate-90:
- Statuses : 5 pass(s) 2 skip(s)
- Exec time: [0.0, 11.89] s

* igt@kms_big_fb@yf-tiled-64bpp-rotate-0:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@yf-tiled-64bpp-rotate-180:
- Statuses : 7 skip(s)
- Exec time: [0.0, 0.05] s

* igt@kms_big_fb@yf-tiled-64bpp-rotate-270:
- Statuses : 7 skip(s)
- Exec time: [0.0, 0.05] s

* igt@kms_big_fb@yf-tiled-64bpp-rotate-90:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@yf-tiled-8bpp-rotate-0:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@yf-tiled-8bpp-rotate-180:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@yf-tiled-8bpp-rotate-270:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@yf-tiled-8bpp-rotate-90:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@yf-tiled-addfb:
- Statuses : 5 pass(s) 2 skip(s)
- Exec time: [0.0, 0.00] s

* igt@kms_big_fb@yf-tiled-addfb-size-offset-overflow:
- Statuses : 3 pass(s) 4 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@yf-tiled-addfb-size-overflow:
- Statuses : 5 pass(s) 2 skip(s)
- Exec time: [0.0, 0.00] s

Known issues
------------

Here are the changes found in Patchwork_17738_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gen9_exec_parse@allowed-all:
- shard-apl: [PASS][3] -> [DMESG-WARN][4] ([i915#1436] / [i915#716])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-apl3/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-apl6/igt@[email protected]

* igt@i915_selftest@live@execlists:
- shard-skl: [PASS][5] -> [INCOMPLETE][6] ([i915#1795] / [i915#1874])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-skl2/igt@i915_selftest@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-skl1/igt@i915_selftest@[email protected]

* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][7] -> [FAIL][8] ([i915#1188]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-skl7/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-skl8/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: [PASS][9] -> [DMESG-WARN][10] ([i915#180])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-apl1/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-apl8/igt@[email protected]
- shard-kbl: [PASS][11] -> [DMESG-WARN][12] ([i915#180]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-kbl4/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-kbl3/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [PASS][13] -> [FAIL][14] ([fdo#108145] / [i915#265])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-skl1/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-skl2/igt@[email protected]

* igt@kms_plane_cursor@pipe-a-overlay-size-256:
- shard-kbl: [PASS][15] -> [FAIL][16] ([i915#1559] / [i915#93] / [i915#95])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-kbl7/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-kbl1/igt@[email protected]
- shard-apl: [PASS][17] -> [FAIL][18] ([i915#1559] / [i915#95])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-apl8/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-apl3/igt@[email protected]

* igt@kms_psr@psr2_basic:
- shard-iclb: [PASS][19] -> [SKIP][20] ([fdo#109441])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-iclb2/igt@kms_psr@psr2_basic.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-iclb3/igt@kms_psr@psr2_basic.html

* igt@kms_psr@suspend:
- shard-skl: [PASS][21] -> [INCOMPLETE][22] ([i915#198])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-skl6/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-skl10/igt@[email protected]

* igt@kms_vblank@pipe-b-accuracy-idle:
- shard-glk: [PASS][23] -> [FAIL][24] ([i915#43])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-glk6/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-glk1/igt@[email protected]

#### Possible fixes ####

* igt@gem_ctx_persistence@legacy-engines-mixed-process@render:
- shard-apl: [FAIL][25] ([i915#1528]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-apl8/igt@gem_ctx_persistence@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-apl7/igt@gem_ctx_persistence@[email protected]

* {igt@kms_flip@flip-vs-suspend-interruptible@a-dp1}:
- shard-kbl: [DMESG-WARN][27] ([i915#180]) -> [PASS][28] +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-kbl3/igt@kms_flip@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-kbl4/igt@kms_flip@[email protected]
- shard-apl: [DMESG-WARN][29] ([i915#180]) -> [PASS][30] +6 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-apl3/igt@kms_flip@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-apl6/igt@kms_flip@[email protected]

* {igt@kms_flip@flip-vs-suspend-interruptible@b-edp1}:
- shard-skl: [INCOMPLETE][31] ([i915#198]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-skl6/igt@kms_flip@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-skl3/igt@kms_flip@[email protected]

* igt@kms_flip_tiling@flip-changes-tiling-yf:
- shard-kbl: [FAIL][33] ([i915#699] / [i915#93] / [i915#95]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-kbl2/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-kbl7/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-suspend:
- shard-skl: [INCOMPLETE][35] ([i915#123] / [i915#69]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-skl10/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-skl6/igt@[email protected]

* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [FAIL][37] ([i915#1188]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-skl1/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-skl1/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][39] ([fdo#108145] / [i915#265]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-skl4/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-skl2/igt@[email protected]

* igt@kms_psr@psr2_primary_render:
- shard-iclb: [SKIP][41] ([fdo#109441]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-iclb3/igt@kms_psr@psr2_primary_render.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-iclb2/igt@kms_psr@psr2_primary_render.html

* igt@kms_setmode@basic:
- shard-apl: [FAIL][43] ([i915#31]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-apl1/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-apl8/igt@[email protected]

#### Warnings ####

* igt@i915_pm_dc@dc6-psr:
- shard-tglb: [SKIP][45] ([i915#468]) -> [FAIL][46] ([i915#454])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-tglb2/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-tglb5/igt@[email protected]

* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [FAIL][47] ([i915#1515]) -> [WARN][48] ([i915#1515])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-iclb4/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-iclb6/igt@[email protected]

* igt@kms_content_protection@atomic:
- shard-apl: [TIMEOUT][49] ([i915#1319]) -> [FAIL][50] ([fdo#110321] / [fdo#110336])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-apl4/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-apl1/igt@[email protected]

* igt@kms_content_protection@atomic-dpms:
- shard-apl: [FAIL][51] ([fdo#110321] / [fdo#110336]) -> [TIMEOUT][52] ([i915#1319])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-apl8/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-apl7/igt@[email protected]

* igt@kms_content_protection@lic:
- shard-apl: [FAIL][53] ([fdo#110321]) -> [DMESG-FAIL][54] ([fdo#110321])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-apl6/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-apl2/igt@[email protected]

* igt@kms_content_protection@srm:
- shard-apl: [FAIL][55] ([fdo#110321]) -> [TIMEOUT][56] ([i915#1319])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-apl1/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-apl8/igt@[email protected]

* igt@kms_psr2_su@page_flip:
- shard-iclb: [FAIL][57] ([i915#608]) -> [SKIP][58] ([fdo#109642] / [fdo#111068])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8515/shard-iclb2/igt@kms_psr2_su@page_flip.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/shard-iclb6/igt@kms_psr2_su@page_flip.html

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
[fdo#110336]: https://bugs.freedesktop.org/show_bug.cgi?id=110336
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#123]: https://gitlab.freedesktop.org/drm/intel/issues/123
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1515]: https://gitlab.freedesktop.org/drm/intel/issues/1515
[i915#1528]: https://gitlab.freedesktop.org/drm/intel/issues/1528
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1559]: https://gitlab.freedesktop.org/drm/intel/issues/1559
[i915#1795]: https://gitlab.freedesktop.org/drm/intel/issues/1795
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1874]: https://gitlab.freedesktop.org/drm/intel/issues/1874
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#43]: https://gitlab.freedesktop.org/drm/intel/issues/43
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#608]: https://gitlab.freedesktop.org/drm/intel/issues/608
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#699]: https://gitlab.freedesktop.org/drm/intel/issues/699
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95

Participating hosts (11 -> 11)
------------------------------

No changes in participating hosts

Build changes
-------------

* Linux: CI_DRM_8515 -> Patchwork_17738

CI-20190529: 20190529
CI_DRM_8515: 41f9bb782f3bb2f30be09683184bbeecb1fd31bb @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5665: c5e5b0ce26fc321591a6d0235c639a1e8ec3cdfa @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17738: 7f3095d8f257cc9646071b19df534a8a5df7ed60 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

Quoted 3 lines

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17738/index.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by on v1 1/1
#5 lore raw
In reply to José Roberto de Souza

Looks good to me.

Quoted 122 lines · José Roberto de Souza

This parameter is meant to be used when PSR issues are found as some issues in the past was due wrong values set in VBT so this would be a quick and easy way to ask users or for us to check if the issue is due VBT values.

---
 drivers/gpu/drm/i915/display/intel_psr.c | 37 ++++++++++++++++++--
----
 drivers/gpu/drm/i915/i915_params.c       |  5 ++++
 drivers/gpu/drm/i915/i915_params.h       |  1 +
 3 files changed, 34 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/display/intel_psr.c +6 -0
index b7a2c102648a..859780853f42 100644
@@ -426,6 +426,12 @@ static u32 intel_psr1_get_tp_time(struct
 intel_dp *intel_dp)
 	if (INTEL_GEN(dev_priv) >= 11)
 		val |= EDP_PSR_TP4_TIME_0US;
 
+	if (i915_modparams.psr_safest_params) {
+		val |= EDP_PSR_TP1_TIME_2500us;
+		val |= EDP_PSR_TP2_TP3_TIME_2500us;
+		goto check_tp3_sel;
+	}
+
 	if (dev_priv->vbt.psr.tp1_wakeup_time_us == 0)
 		val |= EDP_PSR_TP1_TIME_0us;
drivers/gpu/drm/i915/display/intel_psr.c +1 -0
 	else if (dev_priv->vbt.psr.tp1_wakeup_time_us <= 100)
@@ -444,6 +450,7 @@ static u32 intel_psr1_get_tp_time(struct intel_dp
 *intel_dp)
 	else
 		val |= EDP_PSR_TP2_TP3_TIME_2500us;
 
+check_tp3_sel:
 	if (intel_dp_source_supports_hbr2(intel_dp) &&
 	    drm_dp_tps3_supported(intel_dp->dpcd))
drivers/gpu/drm/i915/display/intel_psr.c +23 -9
 		val |= EDP_PSR_TP1_TP3_SEL;
@@ -495,18 +502,13 @@ static void hsw_activate_psr1(struct intel_dp
 *intel_dp)
 	intel_de_write(dev_priv, EDP_PSR_CTL(dev_priv->psr.transcoder), 
 val);
 }
 
-static void hsw_activate_psr2(struct intel_dp *intel_dp)
+static u32 intel_psr2_get_tp_time(struct intel_dp *intel_dp)
 {
 	struct drm_i915_private *dev_priv = dp_to_i915(intel_dp);
-	u32 val;
-
-	val = psr_compute_idle_frames(intel_dp) <<
 EDP_PSR2_IDLE_FRAME_SHIFT;
-
-	val |= EDP_PSR2_ENABLE | EDP_SU_TRACK_ENABLE;
-	if (INTEL_GEN(dev_priv) >= 10 || IS_GEMINILAKE(dev_priv))
-		val |= EDP_Y_COORDINATE_ENABLE;
+	u32 val = 0;
 
-	val |= EDP_PSR2_FRAME_BEFORE_SU(dev_priv->psr.sink_sync_latency 
+ 1);
+	if (i915_modparams.psr_safest_params)
+		return EDP_PSR2_TP2_TIME_2500us;
 
 	if (dev_priv->vbt.psr.psr2_tp2_tp3_wakeup_time_us >= 0 &&
 	    dev_priv->vbt.psr.psr2_tp2_tp3_wakeup_time_us <= 50)
@@ -518,6 +520,23 @@ static void hsw_activate_psr2(struct intel_dp
 *intel_dp)
 	else
 		val |= EDP_PSR2_TP2_TIME_2500us;
 
+	return val;
+}
+
+static void hsw_activate_psr2(struct intel_dp *intel_dp)
+{
+	struct drm_i915_private *dev_priv = dp_to_i915(intel_dp);
+	u32 val;
+
+	val = psr_compute_idle_frames(intel_dp) <<
 EDP_PSR2_IDLE_FRAME_SHIFT;
+
+	val |= EDP_PSR2_ENABLE | EDP_SU_TRACK_ENABLE;
+	if (INTEL_GEN(dev_priv) >= 10 || IS_GEMINILAKE(dev_priv))
+		val |= EDP_Y_COORDINATE_ENABLE;
+
+	val |= EDP_PSR2_FRAME_BEFORE_SU(dev_priv->psr.sink_sync_latency 
+ 1);
+	val |= intel_psr2_get_tp_time(intel_dp);
+
 	/*
 	 * PSR2 HW is incorrectly using EDP_PSR_TP1_TP3_SEL and BSpec

is

drivers/gpu/drm/i915/display/intel_psr.c +0 -0
 	 * recommending keep this bit unset while PSR2 is enabled.
drivers/gpu/drm/i915/i915_params.c +2 -0
index add00ec1f787..307e4667fc62 100644
@@ -88,6 +88,11 @@ i915_param_named_unsafe(enable_psr, int, 0600,
 	"(0=disabled, 1=enabled) "
 	"Default: -1 (use per-chip default)");
 
+i915_param_named(psr_safest_params, bool, 0400,
+	"Replace PSR VBT parameters by the safest and not optimal ones.

This "

drivers/gpu/drm/i915/i915_params.c +1 -0
+	"is helpfull to detect if PSR issues are related to bad values

set in "

drivers/gpu/drm/i915/i915_params.c +2 -0
+	" VBT. (0=use VBT paramters, 1=use safest parameters)");
+
 i915_param_named_unsafe(force_probe, charp, 0400,
 	"Force probe the driver for specified devices. "
 	"See CONFIG_DRM_I915_FORCE_PROBE for details.");
drivers/gpu/drm/i915/i915_params.h +0 -0
index 45323732f099..2a99c908c7c8 100644

drivers/gpu/drm/i915/i915_params.h struct drm_printer; · line 59

Quoted 7 lines
drivers/gpu/drm/i915/i915_params.h +1 -0
@@ -53,6 +53,7 @@ struct drm_printer;
 	param(int, enable_dc, -1, 0400) \
 	param(int, enable_fbc, -1, 0600) \
 	param(int, enable_psr, -1, 0600) \
+	param(bool, psr_safest_params, false, 0600) \
 	param(int, disable_power_well, -1, 0400) \
 	param(int, enable_ips, 1, 0600) \
 	param(int, invert_brightness, 0, 0600) \

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx