Skip to contentSkip to conversation

Add SIMATIC IOT2050 board support

PATCH New Jan Kiszka 2 participants 8 messages Dec 4, 2020 – Dec 23, 2020

Subsystems (2)
lore
Share & tools
lore

Jan Kiszka

author
#0 lore raw

cover Add SIMATIC IOT2050 board support

This is the baseline support for the SIMATIC IOT2050 devices.

Allows to boot mainline 5.10 kernels, but not the original BSP-derived kernel we currently ship as reference. This is due to the TI sysfw ABI breakages between 2.x and 3.x. We will soon provide a transitional kernel that allows booting both firmware ABIs - as long as full upstream kernel support is work in progress.

Note that this baseline support lacks Ethernet drivers. We are working closely with TI to ensure that the to-be-upstreamed icssg-prueth driver will work both with new SR2.0 AM65x silicon as well as with SR1.0 which is used in the currently shipped IOT2050 devices.

Related but not strictly needed for baseline support is [1], i.e. embedding of the watchdog firmware that is required on the AM65x. I will soon pick up that discussion again.

A staging tree for complete IOT2050 support can be found at [2]. Full image integration is available via [3].

Jan

[1] https://patchwork.ozlabs.org/project/uboot/patch/a42ab2dde9a588a8efc186474becd837f2e470c5.1592910910.git.jan.kiszka at siemens.com/
[2] https://github.com/siemens/u-boot/commits/jan/iot2050
[3] https://github.com/siemens/meta-iot2050

Jan Kiszka (2):
arm: dts: Add IOT2050 device tree files
board: siemens: Add support for SIMATIC IOT2050 devices

 arch/arm/dts/Makefile                |   7 +-
 arch/arm/dts/iot2050-advanced.dts    |  62 +++++
 arch/arm/dts/iot2050-basic.dts       |  61 +++++
 arch/arm/dts/iot2050-boot-image.dtsi | 105 +++++++++
 arch/arm/dts/iot2050-common.dtsi     | 341 +++++++++++++++++++++++++++
 arch/arm/dts/iot2050-spl.dts         |  16 ++
 arch/arm/mach-k3/Kconfig             |   1 +
 board/siemens/iot2050/Kconfig        |  28 +++
 board/siemens/iot2050/MAINTAINERS    |   8 +
 board/siemens/iot2050/Makefile       |  10 +
 board/siemens/iot2050/README         |  65 +++++
 board/siemens/iot2050/board.c        | 229 ++++++++++++++++++
 board/siemens/iot2050/config.mk      |   8 +
 configs/iot2050_defconfig            | 136 +++++++++++
 include/configs/iot2050.h            |  60 +++++
 15 files changed, 1136 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/dts/iot2050-advanced.dts
 create mode 100644 arch/arm/dts/iot2050-basic.dts
 create mode 100644 arch/arm/dts/iot2050-boot-image.dtsi
 create mode 100644 arch/arm/dts/iot2050-common.dtsi
 create mode 100644 arch/arm/dts/iot2050-spl.dts
 create mode 100644 board/siemens/iot2050/Kconfig
 create mode 100644 board/siemens/iot2050/MAINTAINERS
 create mode 100644 board/siemens/iot2050/Makefile
 create mode 100644 board/siemens/iot2050/README
 create mode 100644 board/siemens/iot2050/board.c
 create mode 100644 board/siemens/iot2050/config.mk
 create mode 100644 configs/iot2050_defconfig
 create mode 100644 include/configs/iot2050.h
Signature · 1 line
2.26.2
author
#1 lore raw

PATCH 1/2 arm: dts: Add IOT2050 device tree files

From: Jan Kiszka <[email protected]>

Prepares for the addition of the IOT2050 board which is based on the TI AM65x. The board comes in two variants, Basic and Advanced, so there are separate dts files. Furthermore, the SPL has its own device tree.

Based on original board support by Le Jin, Gao Nian and Chao Zeng.

---
 arch/arm/dts/Makefile                |   7 +-
 arch/arm/dts/iot2050-advanced.dts    |  62 +++++
 arch/arm/dts/iot2050-basic.dts       |  61 +++++
 arch/arm/dts/iot2050-boot-image.dtsi | 105 +++++++++
 arch/arm/dts/iot2050-common.dtsi     | 341 +++++++++++++++++++++++++++
 arch/arm/dts/iot2050-spl.dts         |  16 ++
 6 files changed, 591 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/dts/iot2050-advanced.dts
 create mode 100644 arch/arm/dts/iot2050-basic.dts
 create mode 100644 arch/arm/dts/iot2050-boot-image.dtsi
 create mode 100644 arch/arm/dts/iot2050-common.dtsi
 create mode 100644 arch/arm/dts/iot2050-spl.dts
arch/arm/dts/Makefile +6 -1
index e2e8a5fb7a..bf2bd8e8a3 100644
@@ -968,7 +968,12 @@ dtb-$(CONFIG_STM32MP15x) += \
 	stm32mp15xx-dhcom-picoitx.dtb \
 	stm32mp15xx-dhcor-avenger96.dtb
 
-dtb-$(CONFIG_SOC_K3_AM6) += k3-am654-base-board.dtb k3-am654-r5-base-board.dtb
+dtb-$(CONFIG_SOC_K3_AM6) += \
+	k3-am654-base-board.dtb \
+	k3-am654-r5-base-board.dtb \
+	iot2050-spl.dtb \
+	iot2050-basic.dtb \
+	iot2050-advanced.dtb
 dtb-$(CONFIG_SOC_K3_J721E) += k3-j721e-common-proc-board.dtb \
 			      k3-j721e-r5-common-proc-board.dtb \
 			      k3-j7200-common-proc-board.dtb \
arch/arm/dts/iot2050-advanced.dts new file +62 -0

62 lines not on this page · raw message

arch/arm/dts/iot2050-basic.dts new file +61 -0

61 lines not on this page · raw message

arch/arm/dts/iot2050-boot-image.dtsi new file +105 -0

105 lines not on this page · raw message

arch/arm/dts/iot2050-common.dtsi new file +341 -0

341 lines not on this page · raw message

arch/arm/dts/iot2050-spl.dts new file +16 -0
new file mode 100644
index 0000000000..280a7c91e3
@@ -0,0 +1,16 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) Siemens AG, 2018-2020
+ *
+ * Authors:
+ *   Jan Kiszka <[email protected]>
+ */
+
+/dts-v1/;
+
+#include "iot2050-common.dtsi"
+
+/ {
+	compatible = "siemens,iot2050", "ti,am654";
+	model = "Siemens IOT2050";
+};
Signature · 1 line
2.26.2
author
#2 lore raw

PATCH 2/2 board: siemens: Add support for SIMATIC IOT2050 devices

In reply to Jan Kiszka

From: Jan Kiszka <[email protected]>

This adds support for the IOT2050 Basic and Advanced devices. The Basic used the dual-core AM6528 GP processor, the Advanced one the AM6548 HS quad-core version.

Both variants are booted via a Siemens-provided FSBL that runs on the R5 cores. Consequently, U-Boot support is targeting the A53 cores. U-Boot SPL, ATF and TEE have to reside in SPI flash.

Full integration into a bootable image can be found on
https://github.com/siemens/meta-iot2050

Based on original board support by Le Jin, Gao Nian and Chao Zeng.

---
 arch/arm/mach-k3/Kconfig          |   1 +
 board/siemens/iot2050/Kconfig     |  28 ++++
 board/siemens/iot2050/MAINTAINERS |   8 ++
 board/siemens/iot2050/Makefile    |  10 ++
 board/siemens/iot2050/README      |  65 +++++++++
 board/siemens/iot2050/board.c     | 229 ++++++++++++++++++++++++++++++
 board/siemens/iot2050/config.mk   |   8 ++
 configs/iot2050_defconfig         | 136 ++++++++++++++++++
 include/configs/iot2050.h         |  60 ++++++++
 9 files changed, 545 insertions(+)
 create mode 100644 board/siemens/iot2050/Kconfig
 create mode 100644 board/siemens/iot2050/MAINTAINERS
 create mode 100644 board/siemens/iot2050/Makefile
 create mode 100644 board/siemens/iot2050/README
 create mode 100644 board/siemens/iot2050/board.c
 create mode 100644 board/siemens/iot2050/config.mk
 create mode 100644 configs/iot2050_defconfig
 create mode 100644 include/configs/iot2050.h
arch/arm/mach-k3/Kconfig +1 -0
index c7d186149b..b191e88b13 100644
@@ -143,4 +143,5 @@ config SYS_K3_SPL_ATF
 
 source "board/ti/am65x/Kconfig"
 source "board/ti/j721e/Kconfig"
+source "board/siemens/iot2050/Kconfig"
 endif
board/siemens/iot2050/Kconfig new file +28 -0
new file mode 100644
index 0000000000..28ba746936
@@ -0,0 +1,28 @@
+# SPDX-License-Identifier: GPL-2.0+
+#
+# Copyright (c) Siemens AG, 2018-2020
+#
+# Authors:
+#   Le Jin <[email protected]>
+#   Jan Kiszka <[email protected]>
+
+config TARGET_IOT2050_A53
+	bool "IOT2050 running on A53"
+	select ARM64
+	select SOC_K3_AM6
+	select BOARD_LATE_INIT
+	select SYS_DISABLE_DCACHE_OPS
+	select BINMAN
+
+if TARGET_IOT2050_A53
+
+config SYS_BOARD
+       default "iot2050"
+
+config SYS_VENDOR
+       default "siemens"
+
+config SYS_CONFIG_NAME
+       default "iot2050"
+
+endif
board/siemens/iot2050/MAINTAINERS new file +8 -0
new file mode 100644
index 0000000000..028fd22960
@@ -0,0 +1,8 @@
+IOT2050 BOARD
+M:	Le Jin <[email protected]>
+M:	Jan Kiszka <[email protected]>
+S:	Maintained
+F:	board/siemens/iot2050/
+F:	include/configs/iot2050.h
+F:	configs/iot2050_defconfig
+F:	arch/arm/dts/iot2050-*
board/siemens/iot2050/Makefile new file +10 -0
new file mode 100644
index 0000000000..5f2cfa40e8
@@ -0,0 +1,10 @@
+# SPDX-License-Identifier: GPL-2.0+
+#
+# Makefile for Siemens IOT2050 board
+# Copyright (c) Siemens AG, 2018-2020
+#
+# Authors:
+#   Le Jin <[email protected]>
+#
+
+obj-y += board.o
board/siemens/iot2050/README new file +65 -0

65 lines not on this page · raw message

board/siemens/iot2050/board.c new file +229 -0

229 lines not on this page · raw message

board/siemens/iot2050/config.mk new file +8 -0
new file mode 100644
index 0000000000..951f72ba16
@@ -0,0 +1,8 @@
+# SPDX-License-Identifier: GPL-2.0+
+#
+# Copyright (c) Siemens AG, 2020
+#
+# Authors:
+#   Jan Kiszka <[email protected]>
+
+flash.bin: all
configs/iot2050_defconfig new file +136 -0

136 lines not on this page · raw message

include/configs/iot2050.h new file +60 -0

60 lines not on this page · raw message

Signature · 1 line
2.26.2
#3 lore raw

cover Add SIMATIC IOT2050 board support

In reply to Jan Kiszka

Hi Jan,
Sorry for the delayed response.

Quoted 8 lines · Jan Kiszka

This is the baseline support for the SIMATIC IOT2050 devices.

Allows to boot mainline 5.10 kernels, but not the original BSP-derived kernel we currently ship as reference. This is due to the TI sysfw ABI breakages between 2.x and 3.x. We will soon provide a transitional kernel that allows booting both firmware ABIs - as long as full upstream kernel support is work in progress.

Quoted 8 lines

Note that this baseline support lacks Ethernet drivers. We are working closely with TI to ensure that the to-be-upstreamed icssg-prueth driver will work both with new SR2.0 AM65x silicon as well as with SR1.0 which is used in the currently shipped IOT2050 devices.

Related but not strictly needed for baseline support is [1], i.e. embedding of the watchdog firmware that is required on the AM65x. I will soon pick up that discussion again.

yeah, long pending one.

Quoted 3 lines

A staging tree for complete IOT2050 support can be found at [2]. Full image integration is available via [3].

patches look good to me. Any chance these dts changes are reviewed in upstream Linux?

Thanks and regards,
Lokesh

Quoted 41 lines

Jan

[1] https://patchwork.ozlabs.org/project/uboot/patch/a42ab2dde9a588a8efc186474becd837f2e470c5.1592910910.git.jan.kiszka at siemens.com/
[2] https://github.com/siemens/u-boot/commits/jan/iot2050
[3] https://github.com/siemens/meta-iot2050

Jan Kiszka (2):
arm: dts: Add IOT2050 device tree files
board: siemens: Add support for SIMATIC IOT2050 devices

 arch/arm/dts/Makefile                |   7 +-
 arch/arm/dts/iot2050-advanced.dts    |  62 +++++
 arch/arm/dts/iot2050-basic.dts       |  61 +++++
 arch/arm/dts/iot2050-boot-image.dtsi | 105 +++++++++
 arch/arm/dts/iot2050-common.dtsi     | 341 +++++++++++++++++++++++++++
 arch/arm/dts/iot2050-spl.dts         |  16 ++
 arch/arm/mach-k3/Kconfig             |   1 +
 board/siemens/iot2050/Kconfig        |  28 +++
 board/siemens/iot2050/MAINTAINERS    |   8 +
 board/siemens/iot2050/Makefile       |  10 +
 board/siemens/iot2050/README         |  65 +++++
 board/siemens/iot2050/board.c        | 229 ++++++++++++++++++
 board/siemens/iot2050/config.mk      |   8 +
 configs/iot2050_defconfig            | 136 +++++++++++
 include/configs/iot2050.h            |  60 +++++
 15 files changed, 1136 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/dts/iot2050-advanced.dts
 create mode 100644 arch/arm/dts/iot2050-basic.dts
 create mode 100644 arch/arm/dts/iot2050-boot-image.dtsi
 create mode 100644 arch/arm/dts/iot2050-common.dtsi
 create mode 100644 arch/arm/dts/iot2050-spl.dts
 create mode 100644 board/siemens/iot2050/Kconfig
 create mode 100644 board/siemens/iot2050/MAINTAINERS
 create mode 100644 board/siemens/iot2050/Makefile
 create mode 100644 board/siemens/iot2050/README
 create mode 100644 board/siemens/iot2050/board.c
 create mode 100644 board/siemens/iot2050/config.mk
 create mode 100644 configs/iot2050_defconfig
 create mode 100644 include/configs/iot2050.h
author
#4 lore raw

cover Add SIMATIC IOT2050 board support

Quoted 21 lines · Lokesh Vutla

Hi Jan,
Sorry for the delayed response.

Quoted 8 lines · Jan Kiszka

This is the baseline support for the SIMATIC IOT2050 devices.

Allows to boot mainline 5.10 kernels, but not the original BSP-derived kernel we currently ship as reference. This is due to the TI sysfw ABI breakages between 2.x and 3.x. We will soon provide a transitional kernel that allows booting both firmware ABIs - as long as full upstream kernel support is work in progress.

Quoted 8 lines

Note that this baseline support lacks Ethernet drivers. We are working closely with TI to ensure that the to-be-upstreamed icssg-prueth driver will work both with new SR2.0 AM65x silicon as well as with SR1.0 which is used in the currently shipped IOT2050 devices.

Related but not strictly needed for baseline support is [1], i.e. embedding of the watchdog firmware that is required on the AM65x. I will soon pick up that discussion again.

Quoted 8 lines

yeah, long pending one.

Quoted 3 lines

A staging tree for complete IOT2050 support can be found at [2]. Full image integration is available via [3].

patches look good to me. Any chance these dts changes are reviewed in upstream Linux?

I didn't want to push them there first before publishing a firmware that allows to boot them - chicken-egg situation. I thought this way would be better and would also be no issue as we we are only using existing bindings. Obviously, any future changes to the kernel version would also be sync'ed back to U-Boot by us.

Jan

Signature · 2 lines
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
author
#5 lore raw

cover Add SIMATIC IOT2050 board support

Quoted 28 lines · Jan Kiszka
Quoted 27 lines · Lokesh Vutla

Hi Jan,
Sorry for the delayed response.

Quoted 8 lines · Jan Kiszka

This is the baseline support for the SIMATIC IOT2050 devices.

Allows to boot mainline 5.10 kernels, but not the original BSP-derived kernel we currently ship as reference. This is due to the TI sysfw ABI breakages between 2.x and 3.x. We will soon provide a transitional kernel that allows booting both firmware ABIs - as long as full upstream kernel support is work in progress.

Quoted 8 lines

Note that this baseline support lacks Ethernet drivers. We are working closely with TI to ensure that the to-be-upstreamed icssg-prueth driver will work both with new SR2.0 AM65x silicon as well as with SR1.0 which is used in the currently shipped IOT2050 devices.

Related but not strictly needed for baseline support is [1], i.e. embedding of the watchdog firmware that is required on the AM65x. I will soon pick up that discussion again.

yeah, long pending one.

Quoted 3 lines

A staging tree for complete IOT2050 support can be found at [2]. Full image integration is available via [3].

Quoted 8 lines
Quoted 2 lines

patches look good to me. Any chance these dts changes are reviewed in upstream Linux?

I didn't want to push them there first before publishing a firmware that allows to boot them - chicken-egg situation. I thought this way would be better and would also be no issue as we we are only using existing bindings. Obviously, any future changes to the kernel version would also be sync'ed back to U-Boot by us.

But good that you mentioned it: I just realized that the path we are using ("siemens/iot2050-{basic,advanced}.dtb") is probably not upstreamable. This may have to become "ti/k3-am65-iot2050-{basic,advanced}.dtb", and that is also an interface between kernel and U-Boot...

Jan

Signature · 2 lines
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
#6 lore raw

cover Add SIMATIC IOT2050 board support

Quoted 38 lines · Jan Kiszka
Quoted 28 lines · Jan Kiszka
Quoted 27 lines · Lokesh Vutla

Hi Jan,
Sorry for the delayed response.

Quoted 8 lines · Jan Kiszka

This is the baseline support for the SIMATIC IOT2050 devices.

Allows to boot mainline 5.10 kernels, but not the original BSP-derived kernel we currently ship as reference. This is due to the TI sysfw ABI breakages between 2.x and 3.x. We will soon provide a transitional kernel that allows booting both firmware ABIs - as long as full upstream kernel support is work in progress.

Quoted 8 lines

Note that this baseline support lacks Ethernet drivers. We are working closely with TI to ensure that the to-be-upstreamed icssg-prueth driver will work both with new SR2.0 AM65x silicon as well as with SR1.0 which is used in the currently shipped IOT2050 devices.

Related but not strictly needed for baseline support is [1], i.e. embedding of the watchdog firmware that is required on the AM65x. I will soon pick up that discussion again.

yeah, long pending one.

Quoted 3 lines

A staging tree for complete IOT2050 support can be found at [2]. Full image integration is available via [3].

Quoted 8 lines
Quoted 2 lines

patches look good to me. Any chance these dts changes are reviewed in upstream Linux?

I didn't want to push them there first before publishing a firmware that allows to boot them - chicken-egg situation. I thought this way would be better and would also be no issue as we we are only using existing bindings. Obviously, any future changes to the kernel version would also be sync'ed back to U-Boot by us.

Quoted 6 lines

But good that you mentioned it: I just realized that the path we are using ("siemens/iot2050-{basic,advanced}.dtb") is probably not upstreamable. This may have to become "ti/k3-am65-iot2050-{basic,advanced}.dtb", and that is also an interface between kernel and U-Boot...

Planning to repost the series?

Thanks and regards,
Lokesh

Quoted 2 lines

Jan

author
#7 lore raw

cover Add SIMATIC IOT2050 board support

Quoted 41 lines · Lokesh Vutla
Quoted 38 lines · Jan Kiszka
Quoted 36 lines · Jan Kiszka
Quoted 21 lines · Lokesh Vutla

Hi Jan,
Sorry for the delayed response.

Quoted 8 lines · Jan Kiszka

This is the baseline support for the SIMATIC IOT2050 devices.

Allows to boot mainline 5.10 kernels, but not the original BSP-derived kernel we currently ship as reference. This is due to the TI sysfw ABI breakages between 2.x and 3.x. We will soon provide a transitional kernel that allows booting both firmware ABIs - as long as full upstream kernel support is work in progress.

Quoted 8 lines

Note that this baseline support lacks Ethernet drivers. We are working closely with TI to ensure that the to-be-upstreamed icssg-prueth driver will work both with new SR2.0 AM65x silicon as well as with SR1.0 which is used in the currently shipped IOT2050 devices.

Related but not strictly needed for baseline support is [1], i.e. embedding of the watchdog firmware that is required on the AM65x. I will soon pick up that discussion again.

Quoted 8 lines

yeah, long pending one.

Quoted 3 lines

A staging tree for complete IOT2050 support can be found at [2]. Full image integration is available via [3].

patches look good to me. Any chance these dts changes are reviewed in upstream Linux?

I didn't want to push them there first before publishing a firmware that allows to boot them - chicken-egg situation. I thought this way would be better and would also be no issue as we we are only using existing bindings. Obviously, any future changes to the kernel version would also be sync'ed back to U-Boot by us.

Quoted 9 lines
Quoted 6 lines

But good that you mentioned it: I just realized that the path we are using ("siemens/iot2050-{basic,advanced}.dtb") is probably not upstreamable. This may have to become "ti/k3-am65-iot2050-{basic,advanced}.dtb", and that is also an interface between kernel and U-Boot...

Planning to repost the series?

Eventually. But we will likely follow your suggestion and first get the DTs upstream into the kernel.

Jan

Signature · 2 lines
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux