Skip to contentSkip to conversation

drm/amd/pm: Clean up errors in arcturus_ppt.c

PATCH Applied [email protected] 2 participants 2 messages Jul 24, 2023 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 drm/amd/pm: Clean up errors in arcturus_ppt.c

Fix the following errors reported by checkpatch:

ERROR: "foo* bar" should be "foo *bar"
ERROR: spaces required around that '=' (ctx:VxW)
ERROR: space prohibited before that close parenthesis ')'

---
 drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c +2 -2
index 3ecb900e6ecd..b26e9ac1ac30 100644
@@ -691,7 +691,7 @@ int smu_cmn_feature_set_enabled(struct smu_context *smu,
 
 #undef __SMU_DUMMY_MAP
 #define __SMU_DUMMY_MAP(fea)	#fea
-static const char* __smu_feature_names[] = {
+static const char *__smu_feature_names[] = {
 	SMU_FEATURE_MASKS
 };
 
@@ -927,7 +927,7 @@ int smu_cmn_get_metrics_table(struct smu_context *smu,
 			      void *metrics_table,
 			      bool bypass_cache)
 {
-	struct smu_table_context *smu_table= &smu->smu_table;
+	struct smu_table_context *smu_table = &smu->smu_table;
 	uint32_t table_size =
 		smu_table->tables[SMU_TABLE_SMU_METRICS].size;
 	int ret = 0;
@@ -969,7 +969,7 @@ void smu_cmn_init_soft_gpu_metrics(void *table, uint8_t frev, uint8_t crev)
 	struct metrics_table_header *header = (struct metrics_table_header 

*)table;
uint16_t structure_size;

-#define METRICS_VERSION(a, b) ((a << 16) | b )
+#define METRICS_VERSION(a, b) ((a << 16) | b)

switch (METRICS_VERSION(frev, crev)) {
case METRICS_VERSION(1, 0):

Applied
#2 lore raw

Applied. Thanks!

Quoted 48 lines · On Mon, Jul 24, 2023 at 3:49 AM <[email protected]> wrote:

Fix the following errors reported by checkpatch:

ERROR: "foo* bar" should be "foo *bar"
ERROR: spaces required around that '=' (ctx:VxW)
ERROR: space prohibited before that close parenthesis ')'

---
  drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c +2 -2
index 3ecb900e6ecd..b26e9ac1ac30 100644
@@ -691,7 +691,7 @@ int smu_cmn_feature_set_enabled(struct smu_context
 *smu,
 
  #undef __SMU_DUMMY_MAP
  #define __SMU_DUMMY_MAP(fea)  #fea
-static const char* __smu_feature_names[] = {
+static const char *__smu_feature_names[] = {
        SMU_FEATURE_MASKS
  };
@@ -927,7 +927,7 @@ int smu_cmn_get_metrics_table(struct smu_context
 *smu,
                              void *metrics_table,
                              bool bypass_cache)
  {
-       struct smu_table_context *smu_table= &smu->smu_table;
+       struct smu_table_context *smu_table = &smu->smu_table;
        uint32_t table_size =
                smu_table->tables[SMU_TABLE_SMU_METRICS].size;
        int ret = 0;
drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c +1 -1
@@ -969,7 +969,7 @@ void smu_cmn_init_soft_gpu_metrics(void *table,
 uint8_t frev, uint8_t crev)
        struct metrics_table_header *header = (struct metrics_table_header
 *)table;
        uint16_t structure_size;
 
-#define METRICS_VERSION(a, b)  ((a << 16) | b )
+#define METRICS_VERSION(a, b)  ((a << 16) | b)
 
        switch (METRICS_VERSION(frev, crev)) {
        case METRICS_VERSION(1, 0):