Skip to contentSkip to conversation

trace: atomic64_read(&ioc->vtime_rate) is assigned an extra semicolon

PATCH In review Li kunyu 3 participants 4 messages Jun 29, 2022 – Jul 11, 2022 Tracing

lore
Share & tools
lore

Li kunyu

author
#0 lore raw

PATCH 1/1 trace: atomic64_read(&ioc->vtime_rate) is assigned an extra semicolon

I think this semicolon could be deleted.

---
 include/trace/events/iocost.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/trace/events/iocost.h +1 -1
index e282ce02fa2d..6d1626e7a4ce 100644
@@ -160,7 +160,7 @@ TRACE_EVENT(iocost_ioc_vrate_adj,
 
 	TP_fast_assign(
 		__assign_str(devname, ioc_name(ioc));
-		__entry->old_vrate = atomic64_read(&ioc->vtime_rate);;
+		__entry->old_vrate = atomic64_read(&ioc->vtime_rate);
 		__entry->new_vrate = new_vrate;
 		__entry->busy_level = ioc->busy_level;
 		__entry->read_missed_ppm = missed_ppm[READ];
Signature · 1 line
2.18.2
maintainer
#1 lore raw

Jens,

Want to take this one? Or I can if you don't.

-- Steve

Quoted 20 lines · On Wed, 29 Jun 2022 11:00:13 +0800 Li kunyu <[email protected]> wrote:

I think this semicolon could be deleted.

---
 include/trace/events/iocost.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/trace/events/iocost.h +1 -1
index e282ce02fa2d..6d1626e7a4ce 100644
@@ -160,7 +160,7 @@ TRACE_EVENT(iocost_ioc_vrate_adj,
 
 	TP_fast_assign(
 		__assign_str(devname, ioc_name(ioc));
-		__entry->old_vrate = atomic64_read(&ioc->vtime_rate);;
+		__entry->old_vrate = atomic64_read(&ioc->vtime_rate);
 		__entry->new_vrate = new_vrate;
 		__entry->busy_level = ioc->busy_level;
 		__entry->read_missed_ppm = missed_ppm[READ];
#2 lore raw
Quoted 3 lines · Steven Rostedt

Jens,

Want to take this one? Or I can if you don't.

You can just include it in the trace commits, that's fine. Thanks!

Signature · 1 line
Jens Axboe
maintainer
#3 lore raw
Quoted 7 lines · On Mon, 11 Jul 2022 14:57:51 -0600 Jens Axboe <[email protected]> wrote:
Quoted 3 lines · Steven Rostedt

Jens,

Want to take this one? Or I can if you don't.

You can just include it in the trace commits, that's fine. Thanks!

Will do. I'm working on something to push for Linus this week, I'll include it with that. I don't think this needs to wait till the merge window.

-- Steve