Skip to contentSkip to conversation

KVM: x86: eliminate some unreachable code

PATCH linmiaohe 1 participant 1 message Feb 18, 2020 KVM

lore
Share & tools
lore

linmiaohe

author
#0 lore raw
Quoted 12 lines · Vitaly Kuznetsov

Review static bool rmode_exception(struct kvm_vcpu *vcpu, int vec) · line 4510

Quoted 8 lines · linmiaohe
(quoted diff) +0 -1
@@ -4505,7 +4505,6 @@ static bool rmode_exception(struct kvm_vcpu *vcpu, int vec)
 	case GP_VECTOR:
 	case MF_VECTOR:
 		return true;
-	break;
 	}
 	return false;
 }

Unrelated to your change but what I don't in rmode_exception() is the second "/* fall through */" instead of just 'return true;', it makes it harder to read.

Agree. I will do it in another patch as it's unrelated to this one. Many Thanks for your review and advice.