local.conf.sample: disable prelink
PATCH 1/1 local.conf.sample: disable prelink
Recent tests have not shown any improvement over not prelinking, and without a regression test it is very hard to say when and how this happened.[0]
There's also a concern that no one is maintaining the code, and there are open bugs (including serious ones such as [1]). Given that prelink does intricate address arithmetic and rewriting of binaries the best option is to disable the feature.
[0] https://lists.yoctoproject.org/g/poky/message/12467
[1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=14429
--- meta-poky/conf/local.conf.sample | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
meta-poky/conf/local.conf.sample +1 -2
@@ -148,8 +148,7 @@ EXTRA_IMAGE_FEATURES ?= "debug-tweaks" # enable extra features. Some available options which can be included in this variable # are: # - 'buildstats' collect build statistics -# - 'image-prelink' in order to prelink the filesystem image -USER_CLASSES ?= "buildstats image-prelink" +USER_CLASSES ?= "buildstats" # # Runtime testing of images
Signature · 1 line
2.31.1
Quoted 23 lines · Alexander Kanavin
Recent tests have not shown any improvement over not prelinking, and without a regression test it is very hard to say when and how this happened.[0]
There's also a concern that no one is maintaining the code, and there are open bugs (including serious ones such as [1]). Given that prelink does intricate address arithmetic and rewriting of binaries the best option is to disable the feature.
[0] https://lists.yoctoproject.org/g/poky/message/12467
[1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=14429Signed-off-by Alexander Kanavin <[email protected]>--- meta-poky/conf/local.conf.sample | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)meta-poky/conf/local.conf.sample +0
-0
meta-poky/conf/local.conf.sample EXTRA_IMAGE_FEATURES ?= "debug-tweaks" · line 151
Quoted 6 lines
meta-poky/conf/local.conf.sample +1
-2@@ -148,8 +148,7 @@ EXTRA_IMAGE_FEATURES ?= "debug-tweaks" # enable extra features. Some available options which can be included in this variable # are: # - 'buildstats' collect build statistics -# - 'image-prelink' in order to prelink the filesystem image -USER_CLASSES ?= "buildstats image-prelink" +USER_CLASSES ?= "buildstats"
just disable it for ppc32 since thats a broken case we know.
Quoted 9 lines
meta-poky/conf/local.conf.sample +0
-1# # Runtime testing of images --2.31.1
Quoted 19 lines · Khem Raj
Quoted 17 lines · Alexander Kanavin
Recent tests have not shown any improvement over not prelinking, and without a regression test it is very hard to say when and how this happened.[0]
There's also a concern that no one is maintaining the code, and there are open bugs (including serious ones such as [1]). Given that prelink does intricate address arithmetic and rewriting of binaries the best option is to disable the feature.
[0] https://lists.yoctoproject.org/g/poky/message/12467
[1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=14429Signed-off-by Alexander Kanavin <[email protected]>--- meta-poky/conf/local.conf.sample | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
Quoted 12 lines
meta-poky/conf/local.conf.sample EXTRA_IMAGE_FEATURES ?= "debug-tweaks" · line 151
Quoted 11 lines
meta-poky/conf/local.conf.sample +1
-2@@ -148,8 +148,7 @@ EXTRA_IMAGE_FEATURES ?= "debug-tweaks" # enable extra features. Some available options which can be included in this variable # are: # - 'buildstats' collect build statistics -# - 'image-prelink' in order to prelink the filesystem image -USER_CLASSES ?= "buildstats image-prelink" +USER_CLASSES ?= "buildstats"just disable it for ppc32 since thats a broken case we know.
So does PPC64 work with prelink? There is a long standing issue with it.
https://bugzilla.yoctoproject.org/show_bug.cgi?id=1331
-armin
Quoted 13 lines
Quoted 13 lines
meta-poky/conf/local.conf.sample +0
-1# # Runtime testing of images --2.31.1
Folks, I'm not proposing to disable it because of ppc32 (even though that was the initial trigger, and spending the whole day stepping assembly in gdb to figure it out was not a good use of time).
Once again:
1. No measurable benefit, and actually a regression in RAM consumption.
2. No maintainer.
(see the commit message)
Alex
Quoted 59 lines · Armin Kuster
Quoted 14 lines · Khem Raj
Quoted 12 lines · Alexander Kanavin
Recent tests have not shown any improvement over not prelinking, and without a regression test it is very hard to say when and how this happened.[0]
There's also a concern that no one is maintaining the code, and there are open bugs (including serious ones such as [1]). Given that prelink does intricate address arithmetic and rewriting of binaries the best option is to disable the feature.
[0] https://lists.yoctoproject.org/g/poky/message/12467
[1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=14429Quoted 6 lines
Review
Quoted 6 lines
Signed-off-by Alexander Kanavin <[email protected]>--- meta-poky/conf/local.conf.sample | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)(quoted diff) +0
-0b/meta-poky/conf/local.conf.sample
Quoted 5 lines
meta-poky/conf/local.conf.sample EXTRA_IMAGE_FEATURES ?= "debug-tweaks" · line 148
Quoted 5 lines
index fb14379d28..1794126672 100644
meta-poky/conf/local.conf.sample +0
-0@@ -148,8 +148,7 @@ EXTRA_IMAGE_FEATURES ?= "debug-tweaks" # enable extra features. Some available options which can be includedin this variable
Quoted 6 lines
meta-poky/conf/local.conf.sample EXTRA_IMAGE_FEATURES ?= "debug-tweaks" · line 151
Quoted 5 lines
meta-poky/conf/local.conf.sample +1
-2# are: # - 'buildstats' collect build statistics -# - 'image-prelink' in order to prelink the filesystem image -USER_CLASSES ?= "buildstats image-prelink" +USER_CLASSES ?= "buildstats"just disable it for ppc32 since thats a broken case we know.
So does PPC64 work with prelink? There is a long standing issue with it.
https://bugzilla.yoctoproject.org/show_bug.cgi?id=1331
-armin
Quoted 13 lines
Quoted 13 lines
meta-poky/conf/local.conf.sample +0
-1# # Runtime testing of images --2.31.1
Quoted 35 lines · Armin Kuster
Quoted 19 lines · Khem Raj
Quoted 17 lines · Alexander Kanavin
Recent tests have not shown any improvement over not prelinking, and without a regression test it is very hard to say when and how this happened.[0]
There's also a concern that no one is maintaining the code, and there are open bugs (including serious ones such as [1]). Given that prelink does intricate address arithmetic and rewriting of binaries the best option is to disable the feature.
[0] https://lists.yoctoproject.org/g/poky/message/12467
[1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=14429Signed-off-by Alexander Kanavin <[email protected]>--- meta-poky/conf/local.conf.sample | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)Quoted 12 lines
meta-poky/conf/local.conf.sample EXTRA_IMAGE_FEATURES ?= "debug-tweaks" · line 151
Quoted 11 lines
meta-poky/conf/local.conf.sample +1
-2@@ -148,8 +148,7 @@ EXTRA_IMAGE_FEATURES ?= "debug-tweaks" # enable extra features. Some available options which can be included in this variable # are: # - 'buildstats' collect build statistics -# - 'image-prelink' in order to prelink the filesystem image -USER_CLASSES ?= "buildstats image-prelink" +USER_CLASSES ?= "buildstats"just disable it for ppc32 since thats a broken case we know.
Quoted 4 lines
So does PPC64 work with prelink? There is a long standing issue with it.
we use ppc64le for qemuppc64 which uses ELFv2 and we have not explicitly disabled prelink and
it works fine, My hunch is that it just is a nop with ELFv2
Quoted 18 lines
-armin
Quoted 13 lines
Quoted 13 lines
meta-poky/conf/local.conf.sample +0
-1# # Runtime testing of images --2.31.1