Skip to contentSkip to conversation

drm/amd/display: Shorten name of FRL polling workqueue

PATCH In review Timur Kristóf 5 participants 9 messages Jul 11 – Jul 15

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 drm/amd/display: Shorten name of FRL polling workqueue

The current name is too long and triggers a warning.

---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +2 -2
index b97ceabe6173..6299f0e384f1 100644
@@ -829,9 +829,9 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
 	}
 	if (adev->dm.dc->caps.max_links > 0) {
 		adev->dm.hdmi_frl_status_polling_wq =
-			create_singlethread_workqueue("hdmi_frl_status_polling_workqueue");
+			create_singlethread_workqueue("hdmi_frl_status_polling_wq");
 		if (!adev->dm.hdmi_frl_status_polling_wq)
-			drm_err(adev_to_drm(adev), "failed to initialize hdmi_frl_status_polling_workqueue\n");
+			drm_err(adev_to_drm(adev), "failed to initialize hdmi_frl_status_polling_wq\n");
 	}
 	if (dc_is_dmub_outbox_supported(adev->dm.dc)) {
 		init_completion(&adev->dm.dmub_aux_transfer_done);
Signature · 1 line
2.55.0
#1 lore raw

PATCH 2/2 drm/amd/display: Check HDMI FRL support before creating polling workqueue

The workqueue is not necessary when FRL is not supported or when it's disabled. Add a helper to tell when the current board has any HDMI FRL capable connectors and call that before creating the workqueue.

---
 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |  2 +-
 drivers/gpu/drm/amd/display/dc/core/dc.c      | 26 +++++++++++++++++++
 drivers/gpu/drm/amd/display/dc/dc.h           |  2 ++
 3 files changed, 29 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +1 -1
index 6299f0e384f1..87d7b60ceb3f 100644
@@ -827,7 +827,7 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
 
 		dc_init_callbacks(adev->dm.dc, &init_params);
 	}
-	if (adev->dm.dc->caps.max_links > 0) {
+	if (dc_is_hdmi_frl_supported(adev->dm.dc)) {
 		adev->dm.hdmi_frl_status_polling_wq =
 			create_singlethread_workqueue("hdmi_frl_status_polling_wq");
 		if (!adev->dm.hdmi_frl_status_polling_wq)
drivers/gpu/drm/amd/display/dc/core/dc.c +26 -0
index 1b6627a92d24..1a7073abb8ba 100644
@@ -6592,6 +6592,32 @@ void dc_mclk_switch_using_fw_based_vblank_stretch_shut_down(struct dc *dc)
 		dc->current_state->bw_ctx.bw.dcn.clk.fw_based_mclk_switching_shut_down = true;
 }
 
+/**
+ * dc_is_hdmi_frl_supported() - Check HDMI FRL support
+ *
+ * @dc: [in] dc structure
+ *
+ * Return:
+ * True if the current board has any HDMI FRL capable connectors,
+ * False otherwise.
+ */
+bool dc_is_hdmi_frl_supported(struct dc *dc)
+{
+	int i;
+
+	if (!dc->config.enable_frl)
+		return false;
+
+	for (i = 0; i < dc->link_count; ++i) {
+		if (dc->links[i] &&
+		    dc->links[i]->link_enc &&
+		    dc->links[i]->link_enc->features.flags.bits.IS_HDMI_FRL_CAPABLE)
+			return true;
+	}
+
+	return false;
+}
+
 /**
  * dc_is_dmub_outbox_supported - Check if DMUB firmware support outbox notification
  *
drivers/gpu/drm/amd/display/dc/dc.h +2 -0
index 13c1f7cd9d7d..d27c7437ee7a 100644
@@ -3056,6 +3056,8 @@ bool dc_set_ips_disable(struct dc *dc, unsigned int disable_ips);
 void dc_z10_restore(const struct dc *dc);
 void dc_z10_save_init(struct dc *dc);
 
+bool dc_is_hdmi_frl_supported(struct dc *dc);
+
 bool dc_is_dmub_outbox_supported(struct dc *dc);
 bool dc_enable_dmub_notifications(struct dc *dc);
 
Signature · 1 line
2.55.0
#2 lore raw

RE: [PATCH 2/2] drm/amd/display: Check HDMI FRL support before creating polling workqueue

AMD General

It may not be necessary to identify whether it is FRL when creating the queue. FRL is not determined until link detection. Whether make the queue active or not is dynamically determined by whether an active FRL stream presents.

Quoted 96 lines

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Timur Kristóf
Sent: Saturday, July 11, 2026 07:30
To: [email protected]; Deucher, Alexander <[email protected]>; Tvrtko Ursulin <[email protected]>; Natalie Vock <[email protected]>; Melissa Wen <[email protected]>; Limonciello, Mario <[email protected]>; Hung, Alex <[email protected]>; Wentland, Harry <[email protected]>
Cc: Timur Kristóf <[email protected]>
Subject: [PATCH 2/2] drm/amd/display: Check HDMI FRL support before creating polling workqueue

The workqueue is not necessary when FRL is not supported or when it's disabled. Add a helper to tell when the current board has any HDMI FRL capable connectors and call that before creating the workqueue.

---
 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |  2 +-
 drivers/gpu/drm/amd/display/dc/core/dc.c      | 26 +++++++++++++++++++
 drivers/gpu/drm/amd/display/dc/dc.h           |  2 ++
 3 files changed, 29 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +1 -1
index 6299f0e384f1..87d7b60ceb3f 100644
@@ -827,7 +827,7 @@ static int amdgpu_dm_init(struct amdgpu_device
 *adev)
 
              dc_init_callbacks(adev->dm.dc, &init_params);
      }
-     if (adev->dm.dc->caps.max_links > 0) {
+     if (dc_is_hdmi_frl_supported(adev->dm.dc)) {
              adev->dm.hdmi_frl_status_polling_wq =
 
      create_singlethread_workqueue("hdmi_frl_status_polling_wq");
              if (!adev->dm.hdmi_frl_status_polling_wq)
drivers/gpu/drm/amd/display/dc/core/dc.c +25 -0
index 1b6627a92d24..1a7073abb8ba 100644
@@ -6592,6 +6592,32 @@ void
 dc_mclk_switch_using_fw_based_vblank_stretch_shut_down(struct dc *dc)
              dc->current_state-
 >bw_ctx.bw.dcn.clk.fw_based_mclk_switching_shut_down = true;  }
 
+/**
+ * dc_is_hdmi_frl_supported() - Check HDMI FRL support
+ *
+ * @dc: [in] dc structure
+ *
+ * Return:
+ * True if the current board has any HDMI FRL capable connectors,
+ * False otherwise.
+ */
+bool dc_is_hdmi_frl_supported(struct dc *dc) {
+     int i;
+
+     if (!dc->config.enable_frl)
+             return false;
+
+     for (i = 0; i < dc->link_count; ++i) {
+             if (dc->links[i] &&
+                 dc->links[i]->link_enc &&
+                 dc->links[i]->link_enc-
 >features.flags.bits.IS_HDMI_FRL_CAPABLE)
+                     return true;
+     }
+
+     return false;
+}
+
 /**
  * dc_is_dmub_outbox_supported - Check if DMUB firmware support outbox

notification
*

drivers/gpu/drm/amd/display/dc/dc.h +0 -0
index 13c1f7cd9d7d..d27c7437ee7a 100644
@@ -3056,6 +3056,8 @@ bool dc_set_ips_disable(struct dc *dc, unsigned int

disable_ips); void dc_z10_restore(const struct dc *dc); void dc_z10_save_init(struct dc *dc);

drivers/gpu/drm/amd/display/dc/dc.h +2 -0
+bool dc_is_hdmi_frl_supported(struct dc *dc);
+
 bool dc_is_dmub_outbox_supported(struct dc *dc);  bool

dc_enable_dmub_notifications(struct dc *dc);

--
2.55.0

maintainer
#3 lore raw

Re: [PATCH 2/2] drm/amd/display: Check HDMI FRL support before creating polling workqueue

Quoted 4 lines · Jerry

AMD General

It may not be necessary to identify whether it is FRL when creating the queue. FRL is not determined until link detection. Whether make the queue active or not is dynamically determined by whether an active FRL stream presents.

This checks whether the HW has any FRL capable encoders and only creates the workqueue if it does. The workqueue is still created regardless whether or not an FRL-capable device is plugged in.

Harry

Quoted 97 lines
Quoted 96 lines

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Timur Kristóf
Sent: Saturday, July 11, 2026 07:30
To: [email protected]; Deucher, Alexander <[email protected]>; Tvrtko Ursulin <[email protected]>; Natalie Vock <[email protected]>; Melissa Wen <[email protected]>; Limonciello, Mario <[email protected]>; Hung, Alex <[email protected]>; Wentland, Harry <[email protected]>
Cc: Timur Kristóf <[email protected]>
Subject: [PATCH 2/2] drm/amd/display: Check HDMI FRL support before creating polling workqueue

The workqueue is not necessary when FRL is not supported or when it's disabled. Add a helper to tell when the current board has any HDMI FRL capable connectors and call that before creating the workqueue.

---
 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |  2 +-
 drivers/gpu/drm/amd/display/dc/core/dc.c      | 26 +++++++++++++++++++
 drivers/gpu/drm/amd/display/dc/dc.h           |  2 ++
 3 files changed, 29 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +1 -1
index 6299f0e384f1..87d7b60ceb3f 100644
@@ -827,7 +827,7 @@ static int amdgpu_dm_init(struct amdgpu_device
 *adev)
 
              dc_init_callbacks(adev->dm.dc, &init_params);
      }
-     if (adev->dm.dc->caps.max_links > 0) {
+     if (dc_is_hdmi_frl_supported(adev->dm.dc)) {
              adev->dm.hdmi_frl_status_polling_wq =
 
      create_singlethread_workqueue("hdmi_frl_status_polling_wq");
              if (!adev->dm.hdmi_frl_status_polling_wq)
drivers/gpu/drm/amd/display/dc/core/dc.c +25 -0
index 1b6627a92d24..1a7073abb8ba 100644
@@ -6592,6 +6592,32 @@ void
 dc_mclk_switch_using_fw_based_vblank_stretch_shut_down(struct dc *dc)
              dc->current_state-
 > bw_ctx.bw.dcn.clk.fw_based_mclk_switching_shut_down = true;  }
 
+/**
+ * dc_is_hdmi_frl_supported() - Check HDMI FRL support
+ *
+ * @dc: [in] dc structure
+ *
+ * Return:
+ * True if the current board has any HDMI FRL capable connectors,
+ * False otherwise.
+ */
+bool dc_is_hdmi_frl_supported(struct dc *dc) {
+     int i;
+
+     if (!dc->config.enable_frl)
+             return false;
+
+     for (i = 0; i < dc->link_count; ++i) {
+             if (dc->links[i] &&
+                 dc->links[i]->link_enc &&
+                 dc->links[i]->link_enc-
 > features.flags.bits.IS_HDMI_FRL_CAPABLE)
+                     return true;
+     }
+
+     return false;
+}
+
 /**
  * dc_is_dmub_outbox_supported - Check if DMUB firmware support outbox

notification
*

drivers/gpu/drm/amd/display/dc/dc.h +0 -0
index 13c1f7cd9d7d..d27c7437ee7a 100644
@@ -3056,6 +3056,8 @@ bool dc_set_ips_disable(struct dc *dc, unsigned int

disable_ips); void dc_z10_restore(const struct dc *dc); void dc_z10_save_init(struct dc *dc);

drivers/gpu/drm/amd/display/dc/dc.h +2 -0
+bool dc_is_hdmi_frl_supported(struct dc *dc);
+
 bool dc_is_dmub_outbox_supported(struct dc *dc);  bool

dc_enable_dmub_notifications(struct dc *dc);

--
2.55.0

#4 lore raw

Re: [PATCH 2/2] drm/amd/display: Check HDMI FRL support before creating polling workqueue

Quoted 7 lines · On 2026. július 15., szerda 20:10:37 közép-európai nyári idő Harry Wentland…
Quoted 6 lines · Jerry

AMD General

It may not be necessary to identify whether it is FRL when creating the queue. FRL is not determined until link detection. Whether make the queue active or not is dynamically determined by whether an active FRL stream presents.

Quoted 5 lines

This checks whether the HW has any FRL capable encoders and only creates the workqueue if it does. The workqueue is still created regardless whether or not an FRL-capable device is plugged in.

Harry

Exactly as Harry says.
The workqueue should not be created when there is no FRL capable connector. For example DCE6-12 (and older DCN) never need this workqueue at all.

Quoted 114 lines
Quoted 114 lines
Quoted 114 lines

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Timur Kristóf
Sent: Saturday, July 11, 2026 07:30
To: [email protected]; Deucher, Alexander <[email protected]>; Tvrtko Ursulin <[email protected]>; Natalie Vock <[email protected]>; Melissa Wen <[email protected]>; Limonciello, Mario <[email protected]>; Hung, Alex <[email protected]>; Wentland, Harry <[email protected]>
Cc: Timur Kristóf <[email protected]>
Subject: [PATCH 2/2] drm/amd/display: Check HDMI FRL support before creating polling workqueue

The workqueue is not necessary when FRL is not supported or when it's disabled. Add a helper to tell when the current board has any HDMI FRL capable connectors and call that before creating the workqueue.

---

 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |  2 +-
 drivers/gpu/drm/amd/display/dc/core/dc.c      | 26 +++++++++++++++++++
 drivers/gpu/drm/amd/display/dc/dc.h           |  2 ++
 3 files changed, 29 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +1 -1
index 6299f0e384f1..87d7b60ceb3f 100644
@@ -827,7 +827,7 @@ static int amdgpu_dm_init(struct amdgpu_device
 *adev)
 
              dc_init_callbacks(adev->dm.dc, &init_params);
 
      }
 
-     if (adev->dm.dc->caps.max_links > 0) {
+     if (dc_is_hdmi_frl_supported(adev->dm.dc)) {
              adev->dm.hdmi_frl_status_polling_wq =
      
      create_singlethread_workqueue("hdmi_frl_status_polling_wq");
      
              if (!adev->dm.hdmi_frl_status_polling_wq)
drivers/gpu/drm/amd/display/dc/core/dc.c +0 -0
index 1b6627a92d24..1a7073abb8ba 100644
@@ -6592,6 +6592,32 @@ void
 dc_mclk_switch_using_fw_based_vblank_stretch_shut_down(struct dc *dc)
 
              dc->current_state-
Quoted 2 lines

bw_ctx.bw.dcn.clk.fw_based_mclk_switching_shut_down = true; }

drivers/gpu/drm/amd/display/dc/core/dc.c +19 -0
+/**
+ * dc_is_hdmi_frl_supported() - Check HDMI FRL support
+ *
+ * @dc: [in] dc structure
+ *
+ * Return:
+ * True if the current board has any HDMI FRL capable connectors,
+ * False otherwise.
+ */
+bool dc_is_hdmi_frl_supported(struct dc *dc) {
+     int i;
+
+     if (!dc->config.enable_frl)
+             return false;
+
+     for (i = 0; i < dc->link_count; ++i) {
+             if (dc->links[i] &&
+                 dc->links[i]->link_enc &&
+                 dc->links[i]->link_enc-
Quoted 2 lines

features.flags.bits.IS_HDMI_FRL_CAPABLE)

drivers/gpu/drm/amd/display/dc/core/dc.c +6 -0
+                     return true;
+     }
+
+     return false;
+}
+
 
 /**
 
  * dc_is_dmub_outbox_supported - Check if DMUB firmware support outbox

notification

*

drivers/gpu/drm/amd/display/dc/dc.h +0 -0
index 13c1f7cd9d7d..d27c7437ee7a 100644
@@ -3056,6 +3056,8 @@ bool dc_set_ips_disable(struct dc *dc, unsigned int

disable_ips); void dc_z10_restore(const struct dc *dc); void dc_z10_save_init(struct dc *dc);

drivers/gpu/drm/amd/display/dc/dc.h +2 -0
+bool dc_is_hdmi_frl_supported(struct dc *dc);
+
 
 bool dc_is_dmub_outbox_supported(struct dc *dc);  bool

dc_enable_dmub_notifications(struct dc *dc);

--
2.55.0

Reviewed-by on v1 1/2
#5 lore raw
In reply to Timur Kristóf
Quoted 13 lines · Timur Kristóf

The current name is too long and triggers a warning.

---
  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +0 -0
index b97ceabe6173..6299f0e384f1 100644
@@ -829,9 +829,9 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
  	}

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c static int amdgpu_dm_init(struct amdgpu_device *adev) · line 837

Quoted 10 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +2 -2
  	if (adev->dm.dc->caps.max_links > 0) {
  		adev->dm.hdmi_frl_status_polling_wq =
-			create_singlethread_workqueue("hdmi_frl_status_polling_workqueue");
+			create_singlethread_workqueue("hdmi_frl_status_polling_wq");
  		if (!adev->dm.hdmi_frl_status_polling_wq)
-			drm_err(adev_to_drm(adev), "failed to initialize hdmi_frl_status_polling_workqueue\n");
+			drm_err(adev_to_drm(adev), "failed to initialize hdmi_frl_status_polling_wq\n");
  	}
  	if (dc_is_dmub_outbox_supported(adev->dm.dc)) {
  		init_completion(&adev->dm.dmub_aux_transfer_done);

This one does not require display knowledge so I feel okay to review it:

Two nitpicks would be that the _wq suffix is even redundant since for the task name it will have the kworker/ prefix anyway. Second one is that while touching this it may make sense to replace the variable name from the error message with a human readable name like "failed to initialize HDMI FLR status polling". In fact, is this even an error or should be a warning given I do not see an immediate exit?

Regards,

Tvrtko

#6 lore raw
Quoted 32 lines · Tvrtko Ursulin
Quoted 18 lines · Timur Kristóf

The current name is too long and triggers a warning.

---
  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++--

  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +0 -0
index b97ceabe6173..6299f0e384f1 100644
@@ -829,9 +829,9 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
       }
       if (adev->dm.dc->caps.max_links > 0) {

          adev->dm.hdmi_frl_status_polling_wq =
- create_singlethread_workqueue("hdmi_frl_status_polling_workqueue"); +            create_singlethread_workqueue("hdmi_frl_status_polling_wq");

Quoted 8 lines

          if (!adev->dm.hdmi_frl_status_polling_wq) -            drm_err(adev_to_drm(adev), "failed to initialize hdmi_frl_status_polling_workqueue\n");
+            drm_err(adev_to_drm(adev), "failed to initialize hdmi_frl_status_polling_wq\n");
      }
      if (dc_is_dmub_outbox_supported(adev->dm.dc)) { init_completion(&adev->dm.dmub_aux_transfer_done);

This one does not require display knowledge so I feel okay to review it:

Quoted 4 lines

Two nitpicks would be that the _wq suffix is even redundant since for the task name it will have the kworker/ prefix anyway. Second one is that while touching this it may make sense to replace the variable name from the error message with a human readable name like "failed to initialize HDMI FLR status polling". In fact, is this even an error or should be a warning given I do not see an immediate exit?

I'd say fix those nitpicks in v2 so we don't need to spin it again over them later.

#7 lore raw
In reply to Tvrtko Ursulin
Quoted 16 lines · Central European Summer Time Tvrtko Ursulin
Quoted 15 lines · Timur Kristóf

The current name is too long and triggers a warning.

---

  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index b97ceabe6173..6299f0e384f1 100644

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +0 -0
@@ -829,9 +829,9 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
 
Quoted 6 lines

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c static int amdgpu_dm_init(struct amdgpu_device *adev)

Quoted 6 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +0 -1
  	}
  	if (adev->dm.dc->caps.max_links > 0) {
 
  		adev->dm.hdmi_frl_status_polling_wq =
 
-			

create_singlethread_workqueue("hdmi_frl_status_polling_workqueue");

Quoted 1 line

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c static int amdgpu_dm_init(struct amdgpu_device *adev) · line 835

Quoted 1 line
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +1 -0
+			

create_singlethread_workqueue("hdmi_frl_status_polling_wq");

Quoted 4 lines

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c static int amdgpu_dm_init(struct amdgpu_device *adev)

Quoted 4 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +0 -1
  		if (!adev->dm.hdmi_frl_status_polling_wq)
 
-			drm_err(adev_to_drm(adev), "failed to 

initialize

Quoted 1 line
Quoted 1 line

hdmi_frl_status_polling_workqueue\n"); +

drm_err(adev_to_drm(adev),

Quoted 4 lines
Quoted 4 lines

"failed to initialize hdmi_frl_status_polling_wq\n");>
}
if (dc_is_dmub_outbox_supported(adev->dm.dc)) {

Quoted 8 lines
Quoted 1 line
  		init_completion(&adev->dm.dmub_aux_transfer_done);

This one does not require display knowledge so I feel okay to review it:

Two nitpicks would be that the _wq suffix is even redundant since for the task name it will have the kworker/ prefix anyway.

Ok, what name do you suggest to use then?

Quoted 4 lines

Second one is
that while touching this it may make sense to replace the variable name from the error message with a human readable name like "failed to initialize HDMI FLR status polling".

Ok, can do.

Quoted 2 lines

In fact, is this even an error or
should be a warning given I do not see an immediate exit?

No idea, I just wanted to fix the warning that I saw.

Timur

#8 lore raw
Quoted 40 lines · Timur Kristóf
Quoted 16 lines · Central European Summer Time Tvrtko Ursulin
Quoted 15 lines · Timur Kristóf

The current name is too long and triggers a warning.

---

   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++--
   1 file changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index b97ceabe6173..6299f0e384f1 100644

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +0 -0
@@ -829,9 +829,9 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
 
Quoted 6 lines

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c static int amdgpu_dm_init(struct amdgpu_device *adev)

Quoted 6 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +0 -1
   	}
   	if (adev->dm.dc->caps.max_links > 0) {
 
   		adev->dm.hdmi_frl_status_polling_wq =
 
-			

create_singlethread_workqueue("hdmi_frl_status_polling_workqueue");

Quoted 1 line

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c static int amdgpu_dm_init(struct amdgpu_device *adev) · line 835

Quoted 1 line
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +1 -0
+			

create_singlethread_workqueue("hdmi_frl_status_polling_wq");

Quoted 4 lines

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c static int amdgpu_dm_init(struct amdgpu_device *adev)

Quoted 4 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +0 -1
   		if (!adev->dm.hdmi_frl_status_polling_wq)
 
-			drm_err(adev_to_drm(adev), "failed to

initialize

Quoted 1 line
Quoted 1 line

hdmi_frl_status_polling_workqueue\n"); +

drm_err(adev_to_drm(adev),

Quoted 6 lines
Quoted 5 lines

"failed to initialize hdmi_frl_status_polling_wq\n");>
}

   	if (dc_is_dmub_outbox_supported(adev->dm.dc)) {
   	
   		init_completion(&adev->dm.dmub_aux_transfer_done);
Quoted 8 lines
Quoted 6 lines

This one does not require display knowledge so I feel okay to review it:

Two nitpicks would be that the _wq suffix is even redundant since for the task name it will have the kworker/ prefix anyway.

Ok, what name do you suggest to use then?

Dropping the suffix. :)

Quoted 6 lines
Quoted 4 lines

Second one is
that while touching this it may make sense to replace the variable name from the error message with a human readable name like "failed to initialize HDMI FLR status polling".

Ok, can do.

You can leave it for follow up work. Perhaps to clarify things, when I give r-b that implies it is acceptable as is. Otherwise I would have said "with that fixed r-b".

Quoted 4 lines
Quoted 2 lines

In fact, is this even an error or
should be a warning given I do not see an immediate exit?

No idea, I just wanted to fix the warning that I saw.

drm_warn or drm_notice I would say is appropriate for things which failed, were expected to work, but do not prevent the driver to probe and work. Btw, on a glance, the neighbouring code is already confused with a mix or drm_err and drm_info for this class of issues.

Regards,

Tvrtko