Skip to contentSkip to conversation

pc: comment style fixup

PATCH In review Michael S. Tsirkin 3 participants 3 messages Nov 2, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 pc: comment style fixup

Fix up checkpatch comment style warnings.

---

changes from v1:
address philippe's comments
:w

 hw/i386/pc.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
hw/i386/pc.c +5 -4
index 416fb0e0f6..aae45ba779 100644
@@ -1149,10 +1149,11 @@ void pc_basic_device_init(struct PCMachineState *pcms,
             error_report("couldn't create HPET device");
             exit(1);
         }
-        /* For pc-piix-*, hpet's intcap is always IRQ2. For pc-q35-1.7
-            * and earlier, use IRQ2 for compat. Otherwise, use IRQ16~23,
-            * IRQ8 and IRQ2.
-            */
+        /*
+         * For pc-piix-*, hpet's intcap is always IRQ2. For pc-q35-1.7 and
+         * earlier, use IRQ2 for compat. Otherwise, use IRQ16~23, IRQ8 and
+         * IRQ2.
+         */
         uint8_t compat = object_property_get_uint(OBJECT(hpet),
                 HPET_INTCAP, NULL);
         if (!compat) {
Signature · 1 line
MST
Reviewed-by on v2 1/1
#2 lore raw
In reply to Michael S. Tsirkin
Quoted 42 lines

-----Original Message-----
From: Qemu-devel [mailto:[email protected]] On Behalf Of Michael S. Tsirkin
Sent: Monday, November 2, 2020 6:29 PM
To: [email protected]
Cc: Paolo Bonzini <[email protected]>; Eduardo Habkost <[email protected]>; Richard Henderson <[email protected]>
Subject: [PATCH v2] pc: comment style fixup

Fix up checkpatch comment style warnings.

---

changes from v1:
address philippe's comments
:w

 hw/i386/pc.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
hw/i386/pc.c +5 -4
@@ -1149,10 +1149,11 @@ void pc_basic_device_init(struct PCMachineState
 *pcms,
             error_report("couldn't create HPET device");
             exit(1);
         }
-        /* For pc-piix-*, hpet's intcap is always IRQ2. For pc-q35-1.7
-            * and earlier, use IRQ2 for compat. Otherwise, use IRQ16~23,
-            * IRQ8 and IRQ2.
-            */
+        /*
+         * For pc-piix-*, hpet's intcap is always IRQ2. For pc-q35-1.7 and
+         * earlier, use IRQ2 for compat. Otherwise, use IRQ16~23, IRQ8 and
+         * IRQ2.
+         */
         uint8_t compat = object_property_get_uint(OBJECT(hpet),
                 HPET_INTCAP, NULL);
         if (!compat) {
Quoted 3 lines

--
MST