Skip to contentSkip to conversation

drm/radeon: add missing spaces after ',' and else should follow close brace '}'

PATCH Applied [email protected] 2 participants 2 messages Jul 24, 2023 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 drm/radeon: add missing spaces after ',' and else should follow close brace '}'

ERROR: else should follow close brace '}'

ERROR: space required after that ',' (ctx:VxV)

---
 drivers/gpu/drm/radeon/radeon_connectors.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/gpu/drm/radeon/radeon_connectors.c +0 -0
index 07193cd0c417..4ceceb972e8d 100644
@@ -198,8 +198,7 @@ int radeon_get_monitor_bpc(struct drm_connector *connector)
 				DRM_DEBUG("%s: HDMI deep color 10 bpc exceeds max tmds clock. Using 

%d bpc.\n",
connector->name, bpc);
}
- }
- else if (bpc > 8) {
+ } else if (bpc > 8) {
/* max_tmds_clock missing, but hdmi spec mandates it for deep color.
*/
DRM_DEBUG("%s: Required max tmds clock for HDMI deep color missing.
Using 8 bpc.\n",
connector->name);
@@ -1372,7 +1371,7 @@ radeon_dvi_detect(struct drm_connector *connector, bool force)
/* assume digital unless load detected otherwise */ radeon_connector->use_digital = true; lret = encoder_funcs->detect(encoder, connector);
- DRM_DEBUG_KMS("load_detect %x returned: %x\n",encoder->encoder_type,lret);
+ DRM_DEBUG_KMS("load_detect %x returned: %x\n", encoder->encoder_type, lret);
if (lret == connector_status_connected)
radeon_connector->use_digital = false;
}

Applied
#2 lore raw

Applied. Thanks!

Alex

Quoted 41 lines · On Sun, Jul 23, 2023 at 11:30 PM <[email protected]> wrote:

ERROR: else should follow close brace '}'

ERROR: space required after that ',' (ctx:VxV)

---
  drivers/gpu/drm/radeon/radeon_connectors.c | 5 ++---
  1 file changed, 2 insertions(+), 3 deletions(-)
drivers/gpu/drm/radeon/radeon_connectors.c +1 -2
index 07193cd0c417..4ceceb972e8d 100644
@@ -198,8 +198,7 @@ int radeon_get_monitor_bpc(struct drm_connector
 *connector)
                                DRM_DEBUG("%s: HDMI deep color 10 bpc exceeds max tmds clock. Using
 %d bpc.\n",
                                                  connector->name, bpc);
                        }
-               }
-               else if (bpc > 8) {
+               } else if (bpc > 8) {
                        /* max_tmds_clock missing, but hdmi spec mandates it for deep color.

*/
DRM_DEBUG("%s: Required max tmds clock for HDMI deep color missing.
Using 8 bpc.\n",

                                          connector->name);
drivers/gpu/drm/radeon/radeon_connectors.c +1 -1
@@ -1372,7 +1371,7 @@ radeon_dvi_detect(struct drm_connector *connector,
 bool force)
                                        /* assume digital unless load detected otherwise */
                                        radeon_connector->use_digital = true;
                                        lret = encoder_funcs->detect(encoder, connector);
-                                       DRM_DEBUG_KMS("load_detect %x returned:
 %x\n",encoder->encoder_type,lret);
+                                       DRM_DEBUG_KMS("load_detect %x returned: %x\n",
 encoder->encoder_type, lret);
                                        if (lret == connector_status_connected)
                                                radeon_connector->use_digital = false;
                                }