cmd: clk: Handle ENODEV from clk_get_rate
PATCH v4 1/1 cmd: clk: Handle ENODEV from clk_get_rate
clk_get_rate may return -ENODEV if the clock isn't valid.
Also, make the error cases go through a single path.
for DM")
---
Notes:
Changes since v3:
- Moved the "rate" variable declaration to the begining of the function.
Changes since v2:
- Further improved commit message.
Changes since v1:
- Added further explanation to the commit message.
cmd/clk.c | 24 ++++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-)
cmd/clk.c +14 -10
@@ -17,6 +17,7 @@ int __weak soc_clk_dump(void)struct uclass *uc;struct clk clk;int ret; +ulong rate;/* Device addresses start at 1 */ ret =uclass_get (UCLASS_CLK , &uc);
@@ -26,20 +27,23 @@ int __weak soc_clk_dump(void) uclass_foreach_dev(dev, uc) {memset (&clk,0 ,sizeof (clk)); ret =device_probe (dev); -if (ret) { -printf ("%-30.30s : ? Hz\n" , dev->name); -continue ; - } +if (ret) + goto noclk; ret =clk_request (dev, &clk); -if (ret) { -printf ("%-30.30s : ? Hz\n" , dev->name); -continue ; - } - -printf ("%-30.30s : %lu Hz\n" , dev->name,clk_get_rate (&clk)); +if (ret) + goto noclk; + rate =clk_get_rate (&clk);clk_free (&clk); + +if (rate == -ENODEV ) + goto noclk; + +printf ("%-30.30s : %lu Hz\n" , dev->name, rate); +continue ; + noclk: +printf ("%-30.30s : ? Hz\n" , dev->name); }return 0 ;
base-commit: 9ba5e5bc261a16f51662490da0cf620dc7f29013
Signature · 1 line
2.19.1
PATCH v4 1/1 cmd: clk: Handle ENODEV from clk_get_rate
Quoted 10 lines · Ismael Luceno
clk_get_ratemay return-ENODEVif the clock isn't valid.Also, make the error cases go through a single path.
Fixes ff8eee0330a6 ("cmd: clk: Add trivial implementation of clock dumpfor DM")
Signed-off-by Ismael Luceno <[email protected]>Reviewed-by Matthias Brugger <[email protected]>Reviewed-by Marek Vasut <[email protected]>
<...>
Ping.
PATCH v4 1/1 cmd: clk: Handle ENODEV from clk_get_rate
Quoted 8 lines · Ismael Luceno Cortes
Quoted 7 lines · Ismael Luceno
clk_get_ratemay return-ENODEVif the clock isn't valid.Also, make the error cases go through a single path.
Fixes ff8eee0330a6 ("cmd: clk: Add trivial implementation of clock dumpfor DM")
Quoted 7 lines
Quoted 3 lines
Signed-off-by Ismael Luceno <[email protected]>Reviewed-by Matthias Brugger <[email protected]>Reviewed-by Marek Vasut <[email protected]><...>
Ping.
I'll pick it through the SH tree so it doesn't get forgotten.
Signature · 2 lines
Best regards, Marek Vasut