libceph: remove unused defined macro for port
PATCH 1/1 libceph: remove unused defined macro for port
1. monitor's default port is defined by CEPH_MON_PORT
2. CEPH_PORT_START & CEPH_PORT_LAST are not needed.
include/linux/ceph/msgr.h +0 -9
@@ -7,15 +7,6 @@#define CEPH_MON_PORT 6789/* default monitor port */ -/* -* client-side processes will try to bind to ports in this -* range, simply for the benefit of tools like nmap or wireshark -* that would like to identify the protocol. -*/ -#define CEPH_PORT_FIRST 6789 -#define CEPH_PORT_START 6800/* non-monitors start here */ -#define CEPH_PORT_LAST 6900 -/* * tcp connection banner. include a protocol version. and adjust * whenever the wire protocol changes. try to keep this string length
Signature · 1 line
2.25.1
Quoted 24 lines · On Tue, 2020-11-10 at 21:52 +0800, [email protected] wrote:
1. monitor's default port is defined by
CEPH_MON_PORT
2.CEPH_PORT_START&CEPH_PORT_LASTare not needed.Signed-off-by Changcheng Liu <[email protected]>include/linux/ceph/msgr.h +0
-0@@ -7,15 +7,6 @@#define
CEPH_MON_PORT6789 /* default monitor port */include/linux/ceph/msgr.h +0
-9-/* -* client-side processes will try to bind to ports in this -* range, simply for the benefit of tools like nmap or wireshark -* that would like to identify the protocol. -*/ -#define CEPH_PORT_FIRST 6789 -#define CEPH_PORT_START 6800/* non-monitors start here */ -#define CEPH_PORT_LAST 6900 -
Quoted 3 lines
/*
* tcp connection banner. include a protocol version. and adjust
* whenever the wire protocol changes. try to keep this string length
Thanks! Merged into testing branch.
Cheers,
Signature · 1 line
Jeff Layton <[email protected]>
Ilya Dryomov
maintainerQuoted 17 lines · Jeff Layton
Quoted 15 lines · On Tue, 2020-11-10 at 21:52 +0800, [email protected] wrote:
1. monitor's default port is defined by
CEPH_MON_PORT
2.CEPH_PORT_START&CEPH_PORT_LASTare not needed.Signed-off-by Changcheng Liu <[email protected]>include/linux/ceph/msgr.h +0
-0@@ -7,15 +7,6 @@#define CEPH_MON_PORT 6789/* default monitor port */
Quoted 14 lines
Quoted 10 lines
include/linux/ceph/msgr.h +0
-9-/* -* client-side processes will try to bind to ports in this -* range, simply for the benefit of tools like nmap or wireshark -* that would like to identify the protocol. -*/ -#define CEPH_PORT_FIRST 6789 -#define CEPH_PORT_START 6800/* non-monitors start here */ -#define CEPH_PORT_LAST 6900 -/* Quoted 2 lines
* tcp connection banner. include a protocol version. and adjust
* whenever the wire protocol changes. try to keep this string lengthThanks! Merged into testing branch.
Jeff, the From address doesn't match the SOB address here. A few weeks ago I asked Changcheng to resend because of this and it looks like he sent two copies of the same patch today. The other one seems to be in order -- please drop this one.
Thanks,
Ilya
Quoted 33 lines · Ilya Dryomov
Quoted 17 lines · Jeff Layton
Quoted 15 lines · On Tue, 2020-11-10 at 21:52 +0800, [email protected] wrote:
1. monitor's default port is defined by
CEPH_MON_PORT
2.CEPH_PORT_START&CEPH_PORT_LASTare not needed.Signed-off-by Changcheng Liu <[email protected]>include/linux/ceph/msgr.h +0
-0@@ -7,15 +7,6 @@ #define CEPH_MON_PORT 6789 /* default monitor port */Quoted 14 lines
Quoted 10 lines
include/linux/ceph/msgr.h +0
-9-/* -* client-side processes will try to bind to ports in this -* range, simply for the benefit of tools like nmap or wireshark -* that would like to identify the protocol. -*/ -#define CEPH_PORT_FIRST 6789 -#define CEPH_PORT_START 6800/* non-monitors start here */ -#define CEPH_PORT_LAST 6900 - /*Quoted 2 lines
* tcp connection banner. include a protocol version. and adjust
* whenever the wire protocol changes. try to keep this string lengthThanks! Merged into testing branch.
Quoted 5 lines
Jeff, the From address doesn't match the SOB address here. A few weeks ago I asked Changcheng to resend because of this and it looks like he sent two copies of the same patch today. The other one seems to be in order -- please drop this one.
Ok, dropped.
Signature · 1 line
Jeff Layton <[email protected]>