tee: client UUID: Skip REE kernel login method as well
PATCH 1/1 tee: client UUID: Skip REE kernel login method as well
Since the addition of session's client UUID generation via commit [1], login via REE kernel method was disallowed. So fix that via passing nill UUID in case of TEE_IOCTL_LOGIN_REE_KERNEL method as well.
--- drivers/tee/tee_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/tee/tee_core.c +2 -1
@@ -200,7 +200,8 @@ int tee_session_calc_client_uuid(uuid_t *uuid, u32 connection_method,int name_len;int rc; -if (connection_method ==TEE_IOCTL_LOGIN_PUBLIC ) { +if (connection_method ==TEE_IOCTL_LOGIN_PUBLIC || + connection_method ==TEE_IOCTL_LOGIN_REE_KERNEL ) {/* Nil UUID to be passed to TEE environment */ uuid_copy (uuid, &uuid_null);return 0 ;
Signature · 1 line
2.7.4
Hi Jens,
Quoted 11 lines · Sumit Garg
Since the addition of session's client UUID generation via commit [1], login via REE kernel method was disallowed. So fix that via passing nill UUID in case of
TEE_IOCTL_LOGIN_REE_KERNELmethod as well.Fixes e33bcbab16d1 ("tee: add support for session's client UUID generation") [1]Signed-off-by Sumit Garg <[email protected]>--- drivers/tee/tee_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Would you like to pick up this fix?
-Sumit
Quoted 17 lines
drivers/tee/tee_core.c +2
-2@@ -200,7 +200,8 @@ int tee_session_calc_client_uuid(uuid_t *uuid, u32 connection_method,int name_len;int rc; -if (connection_method ==TEE_IOCTL_LOGIN_PUBLIC ) { +if (connection_method ==TEE_IOCTL_LOGIN_PUBLIC || + connection_method ==TEE_IOCTL_LOGIN_REE_KERNEL ) {/* Nil UUID to be passed to TEE environment */ uuid_copy (uuid, &uuid_null);return 0 ; --2.7.4
Hi Sumit,
Quoted 9 lines · Sumit Garg
Hi Jens,
Quoted 5 lines · Sumit Garg
Since the addition of session's client UUID generation via commit [1], login via REE kernel method was disallowed. So fix that via passing nill UUID in case of
TEE_IOCTL_LOGIN_REE_KERNELmethod as well.
Quoted 8 lines
Quoted 6 lines
Fixes e33bcbab16d1 ("tee: add support for session's client UUID generation") [1]Signed-off-by Sumit Garg <[email protected]>--- drivers/tee/tee_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)Would you like to pick up this fix?
Thanks for the reminder.
This looks good to me. I'll pick up this unless someone objects. Vesa, does this look good to you too?
Cheers,
Jens
Quoted 20 lines
-Sumit
Quoted 17 lines
drivers/tee/tee_core.c +2
-2@@ -200,7 +200,8 @@ int tee_session_calc_client_uuid(uuid_t *uuid, u32 connection_method,int name_len;int rc; -if (connection_method ==TEE_IOCTL_LOGIN_PUBLIC ) { +if (connection_method ==TEE_IOCTL_LOGIN_PUBLIC || + connection_method ==TEE_IOCTL_LOGIN_REE_KERNEL ) {/* Nil UUID to be passed to TEE environment */ uuid_copy (uuid, &uuid_null);return 0 ; --2.7.4
Hi,
Quoted 19 lines · Jens Wiklander
Hi Sumit,
Quoted 16 lines · Sumit Garg
Hi Jens,
Quoted 11 lines · Sumit Garg
Since the addition of session's client UUID generation via commit [1], login via REE kernel method was disallowed. So fix that via passing nill UUID in case of
TEE_IOCTL_LOGIN_REE_KERNELmethod as well.Fixes e33bcbab16d1 ("tee: add support for session's client UUID generation") [1]Signed-off-by Sumit Garg <[email protected]>--- drivers/tee/tee_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 8 lines
Quoted 1 line
Would you like to pick up this fix?
Thanks for the reminder.
This looks good to me. I'll pick up this unless someone objects. Vesa, does this look good to you too?Cheers,
Jens
Sorry I have been away for a while from the mailing list.
It seems that this is merged -- only thing that came to my mind with this is that:
If we have some kernel protected keys or so -- should we have separate client UUID for kernel operations.
Like when TEE_IOCTL_LOGIN_REE_KERNEL is given then client UUID would be generated for "kernel".
This way we can make sure that kernel owned keys stays for kernel. Nil UUID is kinda reserved for public login.
Thanks,
Vesa Jääskeläinen
Quoted 21 lines
Quoted 21 lines
-Sumit
Quoted 17 lines
drivers/tee/tee_core.c +2
-2@@ -200,7 +200,8 @@ int tee_session_calc_client_uuid(uuid_t *uuid, u32 connection_method,int name_len;int rc; -if (connection_method ==TEE_IOCTL_LOGIN_PUBLIC ) { +if (connection_method ==TEE_IOCTL_LOGIN_PUBLIC || + connection_method ==TEE_IOCTL_LOGIN_REE_KERNEL ) {/* Nil UUID to be passed to TEE environment */ uuid_copy (uuid, &uuid_null);return 0 ; --2.7.4