Skip to contentSkip to conversation

drivers/gpu/drm/gud/gud_pipe.c:544 gud_pipe_update() error: we previously assumed 'fb' could be null (see line 536)

PATCH In review Dan Carpenter 3 participants 5 messages Mar 30, 2021 – Mar 31, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 3841/8469 drivers/gpu/drm/gud/gud_pipe.c:544 gud_pipe_update() error: we previously assumed 'fb' could be null (see line 536)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   9d49ed9ca93b8c564033c1d6808017bc9052b5db
commit: 40e1a70b4aedf2859a1829991b48ef0ebe650bf2 [3841/8469] drm: Add GUD USB Display driver
config: openrisc-randconfig-m031-20210330 (attached as .config)
compiler: or1k-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate

smatch warnings:
drivers/gpu/drm/gud/gud_pipe.c:544 gud_pipe_update() error: we previously assumed 'fb' could be null (see line 536)

vim +/fb +544 drivers/gpu/drm/gud/gud_pipe.c

40e1a70b4aedf2 Noralf Trønnes 2021-03-13  508  void gud_pipe_update(struct drm_simple_display_pipe *pipe,
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  509  		     struct drm_plane_state *old_state)
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  510  {
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  511  	struct drm_device *drm = pipe->crtc.dev;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  512  	struct gud_device *gdrm = to_gud_device(drm);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  513  	struct drm_plane_state *state = pipe->plane.state;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  514  	struct drm_framebuffer *fb = state->fb;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  515  	struct drm_crtc *crtc = &pipe->crtc;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  516  	struct drm_rect damage;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  517  	int idx;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  518  
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  519  	if (crtc->state->mode_changed || !crtc->state->enable) {
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  520  		cancel_work_sync(&gdrm->work);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  521  		mutex_lock(&gdrm->damage_lock);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  522  		if (gdrm->fb) {
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  523  			drm_framebuffer_put(gdrm->fb);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  524  			gdrm->fb = NULL;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  525  		}
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  526  		gud_clear_damage(gdrm);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  527  		mutex_unlock(&gdrm->damage_lock);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  528  	}
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  529  
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  530  	if (!drm_dev_enter(drm, &idx))
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  531  		return;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  532  
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  533  	if (!old_state->fb)
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  534  		gud_usb_set_u8(gdrm, GUD_REQ_SET_CONTROLLER_ENABLE, 1);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  535  
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 @536  	if (fb && (crtc->state->mode_changed || crtc->state->connectors_changed))
                                                    ^^

Can "fb" be NULL?

40e1a70b4aedf2 Noralf Trønnes 2021-03-13  537  		gud_usb_set(gdrm, GUD_REQ_SET_STATE_COMMIT, 0, NULL, 0);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  538  
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  539  	if (crtc->state->active_changed)
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  540  		gud_usb_set_u8(gdrm, GUD_REQ_SET_DISPLAY_ENABLE, crtc->state->active);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  541  
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  542  	if (drm_atomic_helper_damage_merged(old_state, state, &damage)) {
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  543  		if (gdrm->flags & GUD_DISPLAY_FLAG_FULL_UPDATE)
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 @544  			drm_rect_init(&damage, 0, 0, fb->width, fb->height);
                                                                                             ^^^^^^^^^^^^^^^^^^^^^

Unchecked dereferences.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

#1 lore raw

Den 30.03.2021 12.08, skrev Dan Carpenter:

Quoted 47 lines
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   9d49ed9ca93b8c564033c1d6808017bc9052b5db
commit: 40e1a70b4aedf2859a1829991b48ef0ebe650bf2 [3841/8469] drm: Add GUD USB Display driver
config: openrisc-randconfig-m031-20210330 (attached as .config)
compiler: or1k-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate

smatch warnings:
drivers/gpu/drm/gud/gud_pipe.c:544 gud_pipe_update() error: we previously assumed 'fb' could be null (see line 536)

vim +/fb +544 drivers/gpu/drm/gud/gud_pipe.c

40e1a70b4aedf2 Noralf Trønnes 2021-03-13  508  void gud_pipe_update(struct drm_simple_display_pipe *pipe,
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  509  		     struct drm_plane_state *old_state)
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  510  {
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  511  	struct drm_device *drm = pipe->crtc.dev;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  512  	struct gud_device *gdrm = to_gud_device(drm);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  513  	struct drm_plane_state *state = pipe->plane.state;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  514  	struct drm_framebuffer *fb = state->fb;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  515  	struct drm_crtc *crtc = &pipe->crtc;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  516  	struct drm_rect damage;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  517  	int idx;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  518  
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  519  	if (crtc->state->mode_changed || !crtc->state->enable) {
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  520  		cancel_work_sync(&gdrm->work);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  521  		mutex_lock(&gdrm->damage_lock);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  522  		if (gdrm->fb) {
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  523  			drm_framebuffer_put(gdrm->fb);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  524  			gdrm->fb = NULL;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  525  		}
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  526  		gud_clear_damage(gdrm);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  527  		mutex_unlock(&gdrm->damage_lock);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  528  	}
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  529  
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  530  	if (!drm_dev_enter(drm, &idx))
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  531  		return;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  532  
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  533  	if (!old_state->fb)
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  534  		gud_usb_set_u8(gdrm, GUD_REQ_SET_CONTROLLER_ENABLE, 1);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  535  
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 @536  	if (fb && (crtc->state->mode_changed || crtc->state->connectors_changed))
                                                    ^^

Can "fb" be NULL?

Quoted 9 lines
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  537  		gud_usb_set(gdrm, GUD_REQ_SET_STATE_COMMIT, 0, NULL, 0);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  538  
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  539  	if (crtc->state->active_changed)
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  540  		gud_usb_set_u8(gdrm, GUD_REQ_SET_DISPLAY_ENABLE, crtc->state->active);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  541  
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  542  	if (drm_atomic_helper_damage_merged(old_state, state, &damage)) {
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  543  		if (gdrm->flags & GUD_DISPLAY_FLAG_FULL_UPDATE)
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 @544  			drm_rect_init(&damage, 0, 0, fb->width, fb->height);
                                                                                             ^^^^^^^^^^^^^^^^^^^^^

drm_atomic_helper_damage_merged() returns false if state->fb is NULL, so this is good.

Noralf.

Quoted 6 lines

Unchecked dereferences.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

#2 lore raw
Quoted 60 lines · Noralf Trønnes

Den 30.03.2021 12.08, skrev Dan Carpenter:

Quoted 47 lines
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git  master
head:   9d49ed9ca93b8c564033c1d6808017bc9052b5db
commit: 40e1a70b4aedf2859a1829991b48ef0ebe650bf2 [3841/8469] drm: Add GUD USB Display driver
config: openrisc-randconfig-m031-20210330 (attached as .config)
compiler: or1k-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate

smatch warnings:
drivers/gpu/drm/gud/gud_pipe.c:544 gud_pipe_update() error: we previously assumed 'fb' could be null (see line 536)

vim +/fb +544 drivers/gpu/drm/gud/gud_pipe.c

40e1a70b4aedf2 Noralf Trønnes 2021-03-13  508  void gud_pipe_update(struct drm_simple_display_pipe *pipe,
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  509  		     struct drm_plane_state *old_state)
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  510  {
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  511  	struct drm_device *drm = pipe->crtc.dev;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  512  	struct gud_device *gdrm = to_gud_device(drm);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  513  	struct drm_plane_state *state = pipe->plane.state;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  514  	struct drm_framebuffer *fb = state->fb;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  515  	struct drm_crtc *crtc = &pipe->crtc;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  516  	struct drm_rect damage;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  517  	int idx;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  518  
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  519  	if (crtc->state->mode_changed || !crtc->state->enable) {
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  520  		cancel_work_sync(&gdrm->work);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  521  		mutex_lock(&gdrm->damage_lock);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  522  		if (gdrm->fb) {
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  523  			drm_framebuffer_put(gdrm->fb);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  524  			gdrm->fb = NULL;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  525  		}
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  526  		gud_clear_damage(gdrm);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  527  		mutex_unlock(&gdrm->damage_lock);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  528  	}
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  529  
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  530  	if (!drm_dev_enter(drm, &idx))
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  531  		return;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  532  
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  533  	if (!old_state->fb)
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  534  		gud_usb_set_u8(gdrm, GUD_REQ_SET_CONTROLLER_ENABLE, 1);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  535  
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 @536  	if (fb && (crtc->state->mode_changed || crtc->state->connectors_changed))
                                                    ^^

Can "fb" be NULL?

Quoted 9 lines
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  537  		gud_usb_set(gdrm, GUD_REQ_SET_STATE_COMMIT, 0, NULL, 0);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  538  
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  539  	if (crtc->state->active_changed)
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  540  		gud_usb_set_u8(gdrm, GUD_REQ_SET_DISPLAY_ENABLE, crtc->state->active);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  541  
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  542  	if (drm_atomic_helper_damage_merged(old_state, state, &damage)) {
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  543  		if (gdrm->flags & GUD_DISPLAY_FLAG_FULL_UPDATE)
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 @544  			drm_rect_init(&damage, 0, 0, fb->width, fb->height);
                                                                                             ^^^^^^^^^^^^^^^^^^^^^
Quoted 3 lines

drm_atomic_helper_damage_merged() returns false if state->fb is NULL, so this is good.

Thanks. These warnings are from the zero day bot. On my own system with the cross function DB then Smatch parses this correctly and does not print a warning. I probably should have looked at this harder before forwarding the warning.

regards,
dan carpenter

#3 lore raw
Quoted 62 lines · Dan Carpenter
Quoted 58 lines · Noralf Trønnes

Den 30.03.2021 12.08, skrev Dan Carpenter:

Quoted 47 lines
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git  master
head:   9d49ed9ca93b8c564033c1d6808017bc9052b5db
commit: 40e1a70b4aedf2859a1829991b48ef0ebe650bf2 [3841/8469] drm: Add GUD USB Display driver
config: openrisc-randconfig-m031-20210330 (attached as .config)
compiler: or1k-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate

smatch warnings:
drivers/gpu/drm/gud/gud_pipe.c:544 gud_pipe_update() error: we previously assumed 'fb' could be null (see line 536)

vim +/fb +544 drivers/gpu/drm/gud/gud_pipe.c

40e1a70b4aedf2 Noralf Trønnes 2021-03-13  508  void gud_pipe_update(struct drm_simple_display_pipe *pipe,
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  509  		     struct drm_plane_state *old_state)
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  510  {
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  511  	struct drm_device *drm = pipe->crtc.dev;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  512  	struct gud_device *gdrm = to_gud_device(drm);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  513  	struct drm_plane_state *state = pipe->plane.state;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  514  	struct drm_framebuffer *fb = state->fb;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  515  	struct drm_crtc *crtc = &pipe->crtc;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  516  	struct drm_rect damage;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  517  	int idx;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  518
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  519  	if (crtc->state->mode_changed || !crtc->state->enable) {
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  520  		cancel_work_sync(&gdrm->work);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  521  		mutex_lock(&gdrm->damage_lock);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  522  		if (gdrm->fb) {
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  523  			drm_framebuffer_put(gdrm->fb);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  524  			gdrm->fb = NULL;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  525  		}
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  526  		gud_clear_damage(gdrm);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  527  		mutex_unlock(&gdrm->damage_lock);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  528  	}
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  529
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  530  	if (!drm_dev_enter(drm, &idx))
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  531  		return;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  532
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  533  	if (!old_state->fb)
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  534  		gud_usb_set_u8(gdrm, GUD_REQ_SET_CONTROLLER_ENABLE, 1);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  535
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 @536  	if (fb && (crtc->state->mode_changed || crtc->state->connectors_changed))
                                                     ^^

Can "fb" be NULL?

Quoted 9 lines
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  537  		gud_usb_set(gdrm, GUD_REQ_SET_STATE_COMMIT, 0, NULL, 0);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  538
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  539  	if (crtc->state->active_changed)
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  540  		gud_usb_set_u8(gdrm, GUD_REQ_SET_DISPLAY_ENABLE, crtc->state->active);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  541
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  542  	if (drm_atomic_helper_damage_merged(old_state, state, &damage)) {
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  543  		if (gdrm->flags & GUD_DISPLAY_FLAG_FULL_UPDATE)
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 @544  			drm_rect_init(&damage, 0, 0, fb->width, fb->height);
                                                                                              ^^^^^^^^^^^^^^^^^^^^^
Quoted 3 lines

drm_atomic_helper_damage_merged() returns false if state->fb is NULL, so this is good.

Quoted 8 lines

Thanks. These warnings are from the zero day bot. On my own system with the cross function DB then Smatch parses this correctly and does not print a warning. I probably should have looked at this harder before forwarding the warning.

regards,
dan carpenter

Sorry for the inconvenience, we'll take a look from the zero day side.

Best Regards,
Rong Chen

#4 lore raw
Quoted 70 lines · Rong Chen
Quoted 67 lines · Dan Carpenter
Quoted 58 lines · Noralf Trønnes

Den 30.03.2021 12.08, skrev Dan Carpenter:

Quoted 47 lines
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git   master
head:   9d49ed9ca93b8c564033c1d6808017bc9052b5db
commit: 40e1a70b4aedf2859a1829991b48ef0ebe650bf2 [3841/8469] drm: Add GUD USB Display driver
config: openrisc-randconfig-m031-20210330 (attached as .config)
compiler: or1k-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate

smatch warnings:
drivers/gpu/drm/gud/gud_pipe.c:544 gud_pipe_update() error: we previously assumed 'fb' could be null (see line 536)

vim +/fb +544 drivers/gpu/drm/gud/gud_pipe.c

40e1a70b4aedf2 Noralf Trønnes 2021-03-13  508  void gud_pipe_update(struct drm_simple_display_pipe *pipe,
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  509  		     struct drm_plane_state *old_state)
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  510  {
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  511  	struct drm_device *drm = pipe->crtc.dev;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  512  	struct gud_device *gdrm = to_gud_device(drm);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  513  	struct drm_plane_state *state = pipe->plane.state;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  514  	struct drm_framebuffer *fb = state->fb;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  515  	struct drm_crtc *crtc = &pipe->crtc;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  516  	struct drm_rect damage;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  517  	int idx;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  518
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  519  	if (crtc->state->mode_changed || !crtc->state->enable) {
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  520  		cancel_work_sync(&gdrm->work);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  521  		mutex_lock(&gdrm->damage_lock);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  522  		if (gdrm->fb) {
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  523  			drm_framebuffer_put(gdrm->fb);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  524  			gdrm->fb = NULL;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  525  		}
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  526  		gud_clear_damage(gdrm);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  527  		mutex_unlock(&gdrm->damage_lock);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  528  	}
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  529
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  530  	if (!drm_dev_enter(drm, &idx))
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  531  		return;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  532
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  533  	if (!old_state->fb)
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  534  		gud_usb_set_u8(gdrm, GUD_REQ_SET_CONTROLLER_ENABLE, 1);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  535
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 @536  	if (fb && (crtc->state->mode_changed || crtc->state->connectors_changed))
                                                     ^^

Can "fb" be NULL?

Quoted 9 lines
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  537  		gud_usb_set(gdrm, GUD_REQ_SET_STATE_COMMIT, 0, NULL, 0);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  538
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  539  	if (crtc->state->active_changed)
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  540  		gud_usb_set_u8(gdrm, GUD_REQ_SET_DISPLAY_ENABLE, crtc->state->active);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  541
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  542  	if (drm_atomic_helper_damage_merged(old_state, state, &damage)) {
40e1a70b4aedf2 Noralf Trønnes 2021-03-13  543  		if (gdrm->flags & GUD_DISPLAY_FLAG_FULL_UPDATE)
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 @544  			drm_rect_init(&damage, 0, 0, fb->width, fb->height);
                                                                                              ^^^^^^^^^^^^^^^^^^^^^
Quoted 3 lines

drm_atomic_helper_damage_merged() returns false if state->fb is NULL, so this is good.

Thanks. These warnings are from the zero day bot. On my own system with the cross function DB then Smatch parses this correctly and does not print a warning. I probably should have looked at this harder before forwarding the warning.

Quoted 5 lines
Quoted 3 lines

regards,
dan carpenter

Sorry for the inconvenience, we'll take a look from the zero day side.

It's not a big deal. I don't really expect the kbuild bot to have a current cross function DB. And one that's slightly old can be more confusing sometimes.

regards,
dan carpenter