ceph: remove SLAB_MEM_SPREAD flag usage
Subsystems (2)
PATCH 1/1 ceph: remove SLAB_MEM_SPREAD flag usage
From: Chengming Zhou <[email protected]>
The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove its usage so we can delete it from slab. No functional change.
--- fs/ceph/super.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)
fs/ceph/super.c +9 -9
@@ -928,36 +928,36 @@ static int __init init_caches(void) ceph_inode_cachep =kmem_cache_create ("ceph_inode_info" ,sizeof (struct ceph_inode_info ), __alignof__(struct ceph_inode_info ), -SLAB_RECLAIM_ACCOUNT |SLAB_MEM_SPREAD | -SLAB_ACCOUNT , ceph_inode_init_once); +SLAB_RECLAIM_ACCOUNT |SLAB_ACCOUNT , + ceph_inode_init_once);if (!ceph_inode_cachep)return -ENOMEM ; - ceph_cap_cachep =KMEM_CACHE (ceph_cap,SLAB_MEM_SPREAD ); + ceph_cap_cachep =KMEM_CACHE (ceph_cap,0 );if (!ceph_cap_cachep) goto bad_cap; - ceph_cap_snap_cachep =KMEM_CACHE (ceph_cap_snap,SLAB_MEM_SPREAD ); + ceph_cap_snap_cachep =KMEM_CACHE (ceph_cap_snap,0 );if (!ceph_cap_snap_cachep) goto bad_cap_snap; ceph_cap_flush_cachep =KMEM_CACHE (ceph_cap_flush, -SLAB_RECLAIM_ACCOUNT |SLAB_MEM_SPREAD ); +SLAB_RECLAIM_ACCOUNT );if (!ceph_cap_flush_cachep) goto bad_cap_flush; ceph_dentry_cachep =KMEM_CACHE (ceph_dentry_info, -SLAB_RECLAIM_ACCOUNT |SLAB_MEM_SPREAD ); +SLAB_RECLAIM_ACCOUNT );if (!ceph_dentry_cachep) goto bad_dentry; - ceph_file_cachep =KMEM_CACHE (ceph_file_info,SLAB_MEM_SPREAD ); + ceph_file_cachep =KMEM_CACHE (ceph_file_info,0 );if (!ceph_file_cachep) goto bad_file; - ceph_dir_file_cachep =KMEM_CACHE (ceph_dir_file_info,SLAB_MEM_SPREAD ); + ceph_dir_file_cachep =KMEM_CACHE (ceph_dir_file_info,0 );if (!ceph_dir_file_cachep) goto bad_dir_file; - ceph_mds_request_cachep =KMEM_CACHE (ceph_mds_request,SLAB_MEM_SPREAD ); + ceph_mds_request_cachep =KMEM_CACHE (ceph_mds_request,0 );if (!ceph_mds_request_cachep) goto bad_mds_req;
Signature · 1 line
2.40.1
Hi Chengming,
Thanks for your patch.
BTW, could you share the link of the relevant patches to mark this a no-op ?
Thanks
- Xiubo
Quoted 60 lines · On 2/24/24 21:47, [email protected] wrote:
From: Chengming Zhou <[email protected]>
The
SLAB_MEM_SPREADflag is already a no-op as of 6.8-rc1, remove its usage so we can delete it from slab. No functional change.Signed-off-by Chengming Zhou <[email protected]>--- fs/ceph/super.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)fs/ceph/super.c +9
-9@@ -928,36 +928,36 @@ static int __init init_caches(void) ceph_inode_cachep =kmem_cache_create ("ceph_inode_info" ,sizeof (struct ceph_inode_info ), __alignof__(struct ceph_inode_info ), -SLAB_RECLAIM_ACCOUNT |SLAB_MEM_SPREAD | -SLAB_ACCOUNT , ceph_inode_init_once); +SLAB_RECLAIM_ACCOUNT |SLAB_ACCOUNT , + ceph_inode_init_once);if (!ceph_inode_cachep)return -ENOMEM ; - ceph_cap_cachep =KMEM_CACHE (ceph_cap,SLAB_MEM_SPREAD ); + ceph_cap_cachep =KMEM_CACHE (ceph_cap,0 );if (!ceph_cap_cachep) goto bad_cap; - ceph_cap_snap_cachep =KMEM_CACHE (ceph_cap_snap,SLAB_MEM_SPREAD ); + ceph_cap_snap_cachep =KMEM_CACHE (ceph_cap_snap,0 );if (!ceph_cap_snap_cachep) goto bad_cap_snap; ceph_cap_flush_cachep =KMEM_CACHE (ceph_cap_flush, -SLAB_RECLAIM_ACCOUNT |SLAB_MEM_SPREAD ); +SLAB_RECLAIM_ACCOUNT );if (!ceph_cap_flush_cachep) goto bad_cap_flush; ceph_dentry_cachep =KMEM_CACHE (ceph_dentry_info, -SLAB_RECLAIM_ACCOUNT |SLAB_MEM_SPREAD ); +SLAB_RECLAIM_ACCOUNT );if (!ceph_dentry_cachep) goto bad_dentry; - ceph_file_cachep =KMEM_CACHE (ceph_file_info,SLAB_MEM_SPREAD ); + ceph_file_cachep =KMEM_CACHE (ceph_file_info,0 );if (!ceph_file_cachep) goto bad_file; - ceph_dir_file_cachep =KMEM_CACHE (ceph_dir_file_info,SLAB_MEM_SPREAD ); + ceph_dir_file_cachep =KMEM_CACHE (ceph_dir_file_info,0 );if (!ceph_dir_file_cachep) goto bad_dir_file; - ceph_mds_request_cachep =KMEM_CACHE (ceph_mds_request,SLAB_MEM_SPREAD ); + ceph_mds_request_cachep =KMEM_CACHE (ceph_mds_request,0 );if (!ceph_mds_request_cachep) goto bad_mds_req;
Quoted 5 lines · Xiubo Li
Hi Chengming,
Thanks for your patch.
BTW, could you share the link of the relevant patches to mark this a no-op ?
Update changelog to make it clearer:
The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was removed as of v6.8-rc1, so it became a dead flag. And the series[1] went on to mark it obsolete to avoid confusion for users. Here we can just remove all its users, which has no functional change.
[1] https://lore.kernel.org/all/[email protected]/
Thanks!
Quoted 62 lines
Thanks
- Xiubo
Quoted 55 lines · On 2/24/24 21:47, [email protected] wrote:
From: Chengming Zhou <[email protected]>
The
SLAB_MEM_SPREADflag is already a no-op as of 6.8-rc1, remove its usage so we can delete it from slab. No functional change.Signed-off-by Chengming Zhou <[email protected]>---
fs/ceph/super.c| 18 +++++++++---------1 file changed, 9 insertions(+), 9 deletions(-)fs/ceph/super.c +9
-5@@ -928,36 +928,36 @@ static int __init init_caches(void) ceph_inode_cachep = kmem_cache_create("ceph_inode_info", sizeof(struct ceph_inode_info), __alignof__(struct ceph_inode_info), - SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD| - SLAB_ACCOUNT, ceph_inode_init_once); + SLAB_RECLAIM_ACCOUNT|SLAB_ACCOUNT, + ceph_inode_init_once); if (!ceph_inode_cachep) return -ENOMEM; - ceph_cap_cachep = KMEM_CACHE(ceph_cap, SLAB_MEM_SPREAD); + ceph_cap_cachep = KMEM_CACHE(ceph_cap, 0); if (!ceph_cap_cachep) goto bad_cap; - ceph_cap_snap_cachep = KMEM_CACHE(ceph_cap_snap, SLAB_MEM_SPREAD); + ceph_cap_snap_cachep = KMEM_CACHE(ceph_cap_snap, 0); if (!ceph_cap_snap_cachep) goto bad_cap_snap; ceph_cap_flush_cachep = KMEM_CACHE(ceph_cap_flush, - SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD); + SLAB_RECLAIM_ACCOUNT); if (!ceph_cap_flush_cachep) goto bad_cap_flush; ceph_dentry_cachep = KMEM_CACHE(ceph_dentry_info, - SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD); + SLAB_RECLAIM_ACCOUNT); if (!ceph_dentry_cachep) goto bad_dentry; - ceph_file_cachep = KMEM_CACHE(ceph_file_info, SLAB_MEM_SPREAD); + ceph_file_cachep = KMEM_CACHE(ceph_file_info, 0); if (!ceph_file_cachep) goto bad_file; - ceph_dir_file_cachep = KMEM_CACHE(ceph_dir_file_info, SLAB_MEM_SPREAD); + ceph_dir_file_cachep = KMEM_CACHE(ceph_dir_file_info, 0); if (!ceph_dir_file_cachep) goto bad_dir_file; - ceph_mds_request_cachep = KMEM_CACHE(ceph_mds_request, SLAB_MEM_SPREAD); + ceph_mds_request_cachep = KMEM_CACHE(ceph_mds_request, 0); if (!ceph_mds_request_cachep) goto bad_mds_req;
Quoted 6 lines · Chengming Zhou
Quoted 5 lines · Xiubo Li
Hi Chengming,
Thanks for your patch.
BTW, could you share the link of the relevant patches to mark this a no-op ?
Quoted 8 lines
Update changelog to make it clearer:
The
SLAB_MEM_SPREADflag used to be implemented in SLAB, which was removed as of v6.8-rc1, so it became a dead flag. And the series[1] went on to mark it obsolete to avoid confusion for users. Here we can just remove all its users, which has no functional change.
Thanks for your quick feedback.
BTW, I couldn't find this change in Linus' tree in the master and even the v6.8-rc1 tag, please see https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/include/linux/slab.h?h=master.
Did I miss something ? Or has this patch been merged ?
- Xiubo
Quoted 62 lines
Thanks!
Quoted 60 lines
Thanks
- Xiubo
Quoted 55 lines · On 2/24/24 21:47, [email protected] wrote:
From: Chengming Zhou <[email protected]>
The
SLAB_MEM_SPREADflag is already a no-op as of 6.8-rc1, remove its usage so we can delete it from slab. No functional change.Signed-off-by Chengming Zhou <[email protected]>--- fs/ceph/super.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)fs/ceph/super.c +9
-5@@ -928,36 +928,36 @@ static int __init init_caches(void) ceph_inode_cachep = kmem_cache_create("ceph_inode_info", sizeof(struct ceph_inode_info), __alignof__(struct ceph_inode_info), - SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD| - SLAB_ACCOUNT, ceph_inode_init_once); + SLAB_RECLAIM_ACCOUNT|SLAB_ACCOUNT, + ceph_inode_init_once); if (!ceph_inode_cachep) return -ENOMEM; - ceph_cap_cachep = KMEM_CACHE(ceph_cap, SLAB_MEM_SPREAD); + ceph_cap_cachep = KMEM_CACHE(ceph_cap, 0); if (!ceph_cap_cachep) goto bad_cap; - ceph_cap_snap_cachep = KMEM_CACHE(ceph_cap_snap, SLAB_MEM_SPREAD); + ceph_cap_snap_cachep = KMEM_CACHE(ceph_cap_snap, 0); if (!ceph_cap_snap_cachep) goto bad_cap_snap; ceph_cap_flush_cachep = KMEM_CACHE(ceph_cap_flush, - SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD); + SLAB_RECLAIM_ACCOUNT); if (!ceph_cap_flush_cachep) goto bad_cap_flush; ceph_dentry_cachep = KMEM_CACHE(ceph_dentry_info, - SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD); + SLAB_RECLAIM_ACCOUNT); if (!ceph_dentry_cachep) goto bad_dentry; - ceph_file_cachep = KMEM_CACHE(ceph_file_info, SLAB_MEM_SPREAD); + ceph_file_cachep = KMEM_CACHE(ceph_file_info, 0); if (!ceph_file_cachep) goto bad_file; - ceph_dir_file_cachep = KMEM_CACHE(ceph_dir_file_info, SLAB_MEM_SPREAD); + ceph_dir_file_cachep = KMEM_CACHE(ceph_dir_file_info, 0); if (!ceph_dir_file_cachep) goto bad_dir_file; - ceph_mds_request_cachep = KMEM_CACHE(ceph_mds_request, SLAB_MEM_SPREAD); + ceph_mds_request_cachep = KMEM_CACHE(ceph_mds_request, 0); if (!ceph_mds_request_cachep) goto bad_mds_req;
Quoted 15 lines · Xiubo Li
Quoted 13 lines · Chengming Zhou
Quoted 5 lines · Xiubo Li
Hi Chengming,
Thanks for your patch.
BTW, could you share the link of the relevant patches to mark this a no-op ?
Update changelog to make it clearer:
The
SLAB_MEM_SPREADflag used to be implemented in SLAB, which was removed as of v6.8-rc1, so it became a dead flag. And the series[1] went on to mark it obsolete to avoid confusion for users. Here we can just remove all its users, which has no functional change.
Quoted 7 lines
Quoted 1 line
Thanks for your quick feedback.
BTW, I couldn't find this change in Linus' tree in the master and even the v6.8-rc1 tag, please see https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/include/linux/slab.h?h=master.
Did I miss something ? Or has this patch been merged ?
You're right, this patch hasn't been merged. But it's already a dead flag as of v6.8-rc1.
Update changelog to make it clearer:
The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was removed as of v6.8-rc1, so it became a dead flag since the commit 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the series[1] went on to mark it obsolete to avoid confusion for users. Here we can just remove all its users, which has no functional change.
[1] https://lore.kernel.org/all/[email protected]/
Does this look clearer to you? I can improve it if there is still confusion.
Thanks!
Quoted 66 lines
- Xiubo
Quoted 62 lines
Thanks!
Quoted 60 lines
Thanks
- Xiubo
Quoted 55 lines · On 2/24/24 21:47, [email protected] wrote:
From: Chengming Zhou <[email protected]>
The
SLAB_MEM_SPREADflag is already a no-op as of 6.8-rc1, remove its usage so we can delete it from slab. No functional change.Signed-off-by Chengming Zhou <[email protected]>---
fs/ceph/super.c| 18 +++++++++---------1 file changed, 9 insertions(+), 9 deletions(-)fs/ceph/super.c +9
-5@@ -928,36 +928,36 @@ static int __init init_caches(void) ceph_inode_cachep = kmem_cache_create("ceph_inode_info", sizeof(struct ceph_inode_info), __alignof__(struct ceph_inode_info), - SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD| - SLAB_ACCOUNT, ceph_inode_init_once); + SLAB_RECLAIM_ACCOUNT|SLAB_ACCOUNT, + ceph_inode_init_once); if (!ceph_inode_cachep) return -ENOMEM; - ceph_cap_cachep = KMEM_CACHE(ceph_cap, SLAB_MEM_SPREAD); + ceph_cap_cachep = KMEM_CACHE(ceph_cap, 0); if (!ceph_cap_cachep) goto bad_cap; - ceph_cap_snap_cachep = KMEM_CACHE(ceph_cap_snap, SLAB_MEM_SPREAD); + ceph_cap_snap_cachep = KMEM_CACHE(ceph_cap_snap, 0); if (!ceph_cap_snap_cachep) goto bad_cap_snap; ceph_cap_flush_cachep = KMEM_CACHE(ceph_cap_flush, - SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD); + SLAB_RECLAIM_ACCOUNT); if (!ceph_cap_flush_cachep) goto bad_cap_flush; ceph_dentry_cachep = KMEM_CACHE(ceph_dentry_info, - SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD); + SLAB_RECLAIM_ACCOUNT); if (!ceph_dentry_cachep) goto bad_dentry; - ceph_file_cachep = KMEM_CACHE(ceph_file_info, SLAB_MEM_SPREAD); + ceph_file_cachep = KMEM_CACHE(ceph_file_info, 0); if (!ceph_file_cachep) goto bad_file; - ceph_dir_file_cachep = KMEM_CACHE(ceph_dir_file_info, SLAB_MEM_SPREAD); + ceph_dir_file_cachep = KMEM_CACHE(ceph_dir_file_info, 0); if (!ceph_dir_file_cachep) goto bad_dir_file; - ceph_mds_request_cachep = KMEM_CACHE(ceph_mds_request, SLAB_MEM_SPREAD); + ceph_mds_request_cachep = KMEM_CACHE(ceph_mds_request, 0); if (!ceph_mds_request_cachep) goto bad_mds_req;
Quoted 31 lines · Chengming Zhou
Quoted 14 lines · Xiubo Li
Quoted 13 lines · Chengming Zhou
Quoted 5 lines · Xiubo Li
Hi Chengming,
Thanks for your patch.
BTW, could you share the link of the relevant patches to mark this a no-op ?
Update changelog to make it clearer:
The
SLAB_MEM_SPREADflag used to be implemented in SLAB, which was removed as of v6.8-rc1, so it became a dead flag. And the series[1] went on to mark it obsolete to avoid confusion for users. Here we can just remove all its users, which has no functional change.Quoted 6 lines
Quoted 1 line
Thanks for your quick feedback.
BTW, I couldn't find this change in Linus' tree in the master and even the v6.8-rc1 tag, please see https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/include/linux/slab.h?h=master.
Did I miss something ? Or has this patch been merged ?
You're right, this patch hasn't been merged. But it's already a dead flag as of v6.8-rc1.
Update changelog to make it clearer:
The
SLAB_MEM_SPREADflag used to be implemented in SLAB, which was removed as of v6.8-rc1, so it became a dead flag since the commit16a1d968358a("mm/slab: removemm/slab.candslab_def.h"). And the series[1] went on to mark it obsolete to avoid confusion for users. Here we can just remove all its users, which has no functional change.
Quoted 3 lines
[1] https://lore.kernel.org/all/[email protected]/
Does this look clearer to you? I can improve it if there is still confusion.
Yeah, much clearer, thanks!
Maybe we should just wait for the [1] to get merged first ?
Ilya, what do you think ?
Thanks
- Xiubo
Quoted 66 lines
Thanks!
Quoted 64 lines
- Xiubo
Quoted 62 lines
Thanks!
Quoted 60 lines
Thanks
- Xiubo
Quoted 55 lines · On 2/24/24 21:47, [email protected] wrote:
From: Chengming Zhou <[email protected]>
The
SLAB_MEM_SPREADflag is already a no-op as of 6.8-rc1, remove its usage so we can delete it from slab. No functional change.Signed-off-by Chengming Zhou <[email protected]>--- fs/ceph/super.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)fs/ceph/super.c +9
-5@@ -928,36 +928,36 @@ static int __init init_caches(void) ceph_inode_cachep = kmem_cache_create("ceph_inode_info", sizeof(struct ceph_inode_info), __alignof__(struct ceph_inode_info), - SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD| - SLAB_ACCOUNT, ceph_inode_init_once); + SLAB_RECLAIM_ACCOUNT|SLAB_ACCOUNT, + ceph_inode_init_once); if (!ceph_inode_cachep) return -ENOMEM; - ceph_cap_cachep = KMEM_CACHE(ceph_cap, SLAB_MEM_SPREAD); + ceph_cap_cachep = KMEM_CACHE(ceph_cap, 0); if (!ceph_cap_cachep) goto bad_cap; - ceph_cap_snap_cachep = KMEM_CACHE(ceph_cap_snap, SLAB_MEM_SPREAD); + ceph_cap_snap_cachep = KMEM_CACHE(ceph_cap_snap, 0); if (!ceph_cap_snap_cachep) goto bad_cap_snap; ceph_cap_flush_cachep = KMEM_CACHE(ceph_cap_flush, - SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD); + SLAB_RECLAIM_ACCOUNT); if (!ceph_cap_flush_cachep) goto bad_cap_flush; ceph_dentry_cachep = KMEM_CACHE(ceph_dentry_info, - SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD); + SLAB_RECLAIM_ACCOUNT); if (!ceph_dentry_cachep) goto bad_dentry; - ceph_file_cachep = KMEM_CACHE(ceph_file_info, SLAB_MEM_SPREAD); + ceph_file_cachep = KMEM_CACHE(ceph_file_info, 0); if (!ceph_file_cachep) goto bad_file; - ceph_dir_file_cachep = KMEM_CACHE(ceph_dir_file_info, SLAB_MEM_SPREAD); + ceph_dir_file_cachep = KMEM_CACHE(ceph_dir_file_info, 0); if (!ceph_dir_file_cachep) goto bad_dir_file; - ceph_mds_request_cachep = KMEM_CACHE(ceph_mds_request, SLAB_MEM_SPREAD); + ceph_mds_request_cachep = KMEM_CACHE(ceph_mds_request, 0); if (!ceph_mds_request_cachep) goto bad_mds_req;
Quoted 33 lines · Xiubo Li
Quoted 31 lines · Chengming Zhou
Quoted 14 lines · Xiubo Li
Quoted 13 lines · Chengming Zhou
Quoted 5 lines · Xiubo Li
Hi Chengming,
Thanks for your patch.
BTW, could you share the link of the relevant patches to mark this a no-op ?
Update changelog to make it clearer:
The
SLAB_MEM_SPREADflag used to be implemented in SLAB, which was removed as of v6.8-rc1, so it became a dead flag. And the series[1] went on to mark it obsolete to avoid confusion for users. Here we can just remove all its users, which has no functional change.Quoted 6 lines
Quoted 1 line
Thanks for your quick feedback.
BTW, I couldn't find this change in Linus' tree in the master and even the v6.8-rc1 tag, please see https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/include/linux/slab.h?h=master.
Did I miss something ? Or has this patch been merged ?
You're right, this patch hasn't been merged. But it's already a dead flag as of v6.8-rc1.
Update changelog to make it clearer:
The
SLAB_MEM_SPREADflag used to be implemented in SLAB, which was removed as of v6.8-rc1, so it became a dead flag since the commit16a1d968358a("mm/slab: removemm/slab.candslab_def.h"). And the series[1] went on to mark it obsolete to avoid confusion for users. Here we can just remove all its users, which has no functional change.
Quoted 7 lines
Quoted 3 lines
[1] https://lore.kernel.org/all/[email protected]/
Does this look clearer to you? I can improve it if there is still confusion.
Yeah, much clearer, thanks!
Maybe we should just wait for the [1] to get merged first ?
It's really not necessary to wait, [1] just makes it explicit but the flag is really effectively dead since v6.8-rc1 because nothing acts on it.
Quoted 33 lines · Vlastimil Babka
Quoted 32 lines · Xiubo Li
Quoted 31 lines · Chengming Zhou
Quoted 14 lines · Xiubo Li
Quoted 13 lines · Chengming Zhou
Quoted 5 lines · Xiubo Li
Hi Chengming,
Thanks for your patch.
BTW, could you share the link of the relevant patches to mark this a no-op ?
Update changelog to make it clearer:
The
SLAB_MEM_SPREADflag used to be implemented in SLAB, which was removed as of v6.8-rc1, so it became a dead flag. And the series[1] went on to mark it obsolete to avoid confusion for users. Here we can just remove all its users, which has no functional change.Quoted 6 lines
Quoted 1 line
Thanks for your quick feedback.
BTW, I couldn't find this change in Linus' tree in the master and even the v6.8-rc1 tag, please see https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/include/linux/slab.h?h=master.
Did I miss something ? Or has this patch been merged ?
You're right, this patch hasn't been merged. But it's already a dead flag as of v6.8-rc1.
Update changelog to make it clearer:
The
SLAB_MEM_SPREADflag used to be implemented in SLAB, which was removed as of v6.8-rc1, so it became a dead flag since the commit16a1d968358a("mm/slab: removemm/slab.candslab_def.h"). And the series[1] went on to mark it obsolete to avoid confusion for users. Here we can just remove all its users, which has no functional change.
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
[1] https://lore.kernel.org/all/[email protected]/
Does this look clearer to you? I can improve it if there is still confusion.
Yeah, much clearer, thanks!
Maybe we should just wait for the [1] to get merged first ?
It's really not necessary to wait, [1] just makes it explicit but the flag is really effectively dead since v6.8-rc1 because nothing acts on it.
Okay, will apply this to ceph-client tree and run the tests.
Thanks
- Xiubo