r8169: re-enable MSI on RTL8168c
Heiner Kallweit
maintainerPATCH 1/1 r8169: re-enable MSI on RTL8168c
The original change fixed an issue on RTL8168b by mimicking the vendor driver behavior to disable MSI on chip versions before RTL8168d. This however now caused an issue on a system with RTL8168c, see [0]. Therefore leave MSI disabled on RTL8168b, but re-enable it on RTL8168c.
[0] https://bugzilla.redhat.com/show_bug.cgi?id=1792839
--- drivers/net/ethernet/realtek/r8169_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/realtek/r8169_main.c +1 -1
@@ -5091,7 +5091,7 @@ static int rtl_alloc_irq(struct rtl8169_private *tp)RTL_W8 (tp, Config2,RTL_R8 (tp, Config2) & ~MSIEnable);rtl_lock_config_regs (tp);/* fall through */ - case RTL_GIGA_MAC_VER_07 ... RTL_GIGA_MAC_VER_24: + case RTL_GIGA_MAC_VER_07 ... RTL_GIGA_MAC_VER_17: flags =PCI_IRQ_LEGACY ;break ;default :
Signature · 1 line
2.26.0
David Miller
maintainerFrom: Heiner Kallweit <[email protected]>
Date: Tue, 24 Mar 2020 20:58:29 +0100
Quoted 9 lines
The original change fixed an issue on RTL8168b by mimicking the vendor driver behavior to disable MSI on chip versions before RTL8168d. This however now caused an issue on a system with RTL8168c, see [0]. Therefore leave MSI disabled on RTL8168b, but re-enable it on RTL8168c.
[0] https://bugzilla.redhat.com/show_bug.cgi?id=1792839
Fixes 003bd5b4a7b4 ("r8169: don't use MSI before RTL8168d")Signed-off-by Heiner Kallweit <[email protected]>
Applied and queued up for -stable, thanks.