Skip to contentSkip to conversation

checkpatch.pl- Cleared some white spaces which generated warnings and errors.

PATCH Piyush Thange 2 participants 2 messages Aug 16, 2020 Checkpatch

lore
Share & tools
lore
#0 lore raw

commit eb027935d819a3160404f05633ae47f8b8a061c8

Author:     Piyush Thange <[email protected]>
AuthorDate: Sun Aug 16 17:52:26 2020 +0530
Commit:     Piyush Thange <[email protected]>
CommitDate: Sun Aug 16 17:52:26 2020 +0530

scripts:checkpatch.pl:Cleared the white spaces and errors occured
due to them.

I've removed the white spaced on the line 498, which generated
warning and
errors presented by checkpatch.pl.
Please provide review.

---
 scripts/checkpatch.pl | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)
scripts/checkpatch.pl +1 -11
index 2cbeae6d9aee..fa991a912d9b 100755
@@ -488,17 +488,7 @@ our $allocFunctions = qr{(?x:
     dma_alloc_coherent
 )};
 
-our $signature_tags = qr{(?xi:
-    Signed-off-by:|
-    Co-developed-by:|
-    Acked-by:|
-    Tested-by:|
-    Reviewed-by:|
-    Reported-by:|
-    Suggested-by:|
-    To:|
-    Cc:
-)};
+our $signature_tags = qr{(?xi:Signed-off-by:|Co-developed-by:|Acked-by:|Tested-by:|Reviewed-by:|Reported-by:|Suggested-by:|To:|Cc:)};
 
 our @typeListMisordered = (
     qr{char\s+(?:un)?signed},
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 1 line · Piyush Thange

commit eb027935d819a3160404f05633ae47f8b8a061c8

[]

Quoted 2 lines

scripts:checkpatch.pl:Cleared the white spaces and errors occured
due to them.

[]

scripts/checkpatch.pl

Quoted 1 line
scripts/checkpatch.pl +0 -0

[]

Quoted 7 lines
scripts/checkpatch.pl +0 -3
@@ -488,17 +488,7 @@ our $allocFunctions = qr{(?x:
      dma_alloc_coherent
  )};
 
-our $signature_tags = qr{(?xi:
-    Signed-off-by:|
-    Co-developed-by:|

scripts/checkpatch.pl our $allocFunctions = qr{(?x: · line 492

Quoted 10 lines
scripts/checkpatch.pl +1 -8
-    Acked-by:|
-    Tested-by:|
-    Reviewed-by:|
-    Reported-by:|
-    Suggested-by:|
-    To:|
-    Cc:
-)};
+our $signature_tags = 
 qr{(?xi:Signed-off-by:|Co-developed-by:|Acked-by:|Tested-by:|Reviewed-by:|Reported-by:|Suggested-by:|To:|Cc:)};

Do you think this is more readable now?
No thanks.