Skip to contentSkip to conversation

drm/panel : himax-hx83102: fix incorrect argument to mipi_dsi_msleep

PATCH Superseded Tejas Vipin 2 participants 2 messages Jun 8, 2024 – Jun 11, 2024

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/panel : himax-hx83102: fix incorrect argument to mipi_dsi_msleep

From: Tejas Vipin <[email protected]>
Subject: [PATCH] drm/panel : himax-hx83102: fix incorrect argument to
mipi_dsi_msleep

mipi_dsi_msleep expects struct mipi_dsi_multi_context to be passed as a value and not as a reference.

---
 drivers/gpu/drm/panel/panel-himax-hx83102.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/panel/panel-himax-hx83102.c +1 -1
index 6009a3fe1b8f..ab00fd92cce0 100644
@@ -479,7 +479,7 @@ static int hx83102_disable(struct drm_panel *panel)
 	mipi_dsi_dcs_set_display_off_multi(&dsi_ctx);
 	mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx);
 
-	mipi_dsi_msleep(&dsi_ctx, 150);
+	mipi_dsi_msleep(dsi_ctx, 150);
 
 	return dsi_ctx.accum_err;
 }
Signature · 1 line
2.45.2
#1 lore raw
Quoted 8 lines · Tejas Vipin

From: Tejas Vipin <[email protected]>
Subject: [PATCH] drm/panel : himax-hx83102: fix incorrect argument to
mipi_dsi_msleep

mipi_dsi_msleep expects struct mipi_dsi_multi_context to be passed as a value and not as a reference.

Please add a Fixes tag

Quoted 10 lines
---
  drivers/gpu/drm/panel/panel-himax-hx83102.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/panel/panel-himax-hx83102.c +0 -0
index 6009a3fe1b8f..ab00fd92cce0 100644

drivers/gpu/drm/panel/panel-himax-hx83102.c static int hx83102_disable(struct drm_panel *panel) · line 485

Quoted 8 lines
drivers/gpu/drm/panel/panel-himax-hx83102.c +1 -1
@@ -479,7 +479,7 @@ static int hx83102_disable(struct drm_panel *panel)
  	mipi_dsi_dcs_set_display_off_multi(&dsi_ctx);
  	mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx);
 
-	mipi_dsi_msleep(&dsi_ctx, 150);
+	mipi_dsi_msleep(dsi_ctx, 150);
 
  	return dsi_ctx.accum_err;
  }

Thanks,
Neil