Skip to contentSkip to conversation

ARM: dts: stm32: Add missing dm-spl props for SPI NOR on AV96

PATCH New Marek Vasut 3 participants 6 messages Oct 1, 2020 – Oct 2, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: stm32: Add missing dm-spl props for SPI NOR on AV96

The u-boot,dm-spl DT props are missing on AV96, hence the pinmux and flash0 nodes are not included in the reduced SPL DT. This prevents SPI NOR boot from working at all. Fix this by filling them in.

Cc Patrick Delaunay <[email protected]>
Cc Patrice Chotard <[email protected]>
---
 arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi +21 -0
index c73318488d..9d3db20876 100644
@@ -21,6 +21,10 @@
 	};
 };
 
+&flash0 {
+	u-boot,dm-spl;
+};
+
 &gpiof {
 	snor-nwp {
 		gpio-hog;
@@ -49,6 +53,23 @@
 	u-boot,dm-spl;
 };
 
+&qspi_clk_pins_a {
+	u-boot,dm-spl;
+	pins {
+		u-boot,dm-spl;
+	};
+};
+
+&qspi_bk1_pins_a {
+	u-boot,dm-spl;
+	pins1 {
+		u-boot,dm-spl;
+	};
+	pins2 {
+		u-boot,dm-spl;
+	};
+};
+
 &rcc {
 	st,clksrc = <
 		CLK_MPU_PLL1P
Signature · 1 line
2.28.0
#1 lore raw

PATCH 1/1 ARM: dts: stm32: Add missing dm-spl props for SPI NOR on AV96

Hi Marek

Quoted 40 lines · Marek Vasut

The u-boot,dm-spl DT props are missing on AV96, hence the pinmux and flash0 nodes are not included in the reduced SPL DT. This prevents SPI NOR boot from working at all. Fix this by filling them in.

Cc Patrick Delaunay <[email protected]>
Cc Patrice Chotard <[email protected]>
---
 arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi +14 -0
index c73318488d..9d3db20876 100644
@@ -21,6 +21,10 @@
 	};
 };
 
+&flash0 {
+	u-boot,dm-spl;
+};
+
 &gpiof {
 	snor-nwp {
 		gpio-hog;
@@ -49,6 +53,23 @@
 	u-boot,dm-spl;
 };
 
+&qspi_clk_pins_a {
+	u-boot,dm-spl;
+	pins {
+		u-boot,dm-spl;
+	};
+};
+
+&qspi_bk1_pins_a {
+	u-boot,dm-spl;
+	pins1 {

arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi line 75

Quoted 10 lines
arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi +7 -0
+		u-boot,dm-spl;
+	};
+	pins2 {
+		u-boot,dm-spl;
+	};
+};
+
 &rcc {
 	st,clksrc = <
 		CLK_MPU_PLL1P

Thanks

#2 lore raw

PATCH 1/1 ARM: dts: stm32: Add missing dm-spl props for SPI NOR on AV96

In reply to Marek Vasut

Hi Marek,

Quoted 7 lines

From: Marek Vasut <[email protected]>
Sent: jeudi 1 octobre 2020 12:26

The u-boot,dm-spl DT props are missing on AV96, hence the pinmux and flash0 nodes are not included in the reduced SPL DT. This prevents SPI NOR boot from working at all. Fix this by filling them in.

Quoted 7 lines
Cc Patrick Delaunay <[email protected]>
Cc Patrice Chotard <[email protected]>
---
 arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

2 questions;
It is a regression or SPI boot had never worked on AV96 ? And the expected target is v2020.10 or v2021.01-rc1 ?

I prefer v2021.01-rc1, except if it is blocking or it is a regression .....

Thanks

Patrick

#3 lore raw

PATCH 1/1 ARM: dts: stm32: Add missing dm-spl props for SPI NOR on AV96

Quoted 1 line · Patrick DELAUNAY

Hi Marek,

Hi,

Quoted 15 lines
Quoted 7 lines

From: Marek Vasut <[email protected]>
Sent: jeudi 1 octobre 2020 12:26

The u-boot,dm-spl DT props are missing on AV96, hence the pinmux and flash0 nodes are not included in the reduced SPL DT. This prevents SPI NOR boot from working at all. Fix this by filling them in.

Quoted 7 lines
Cc Patrick Delaunay <[email protected]>
Cc Patrice Chotard <[email protected]>
---
 arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
Quoted 7 lines

2 questions;
It is a regression or SPI boot had never worked on AV96 ? And the expected target is v2020.10 or v2021.01-rc1 ?

I prefer v2021.01-rc1, except if it is blocking or it is a regression .....

It used to work before, so 2020.10 please.

#4 lore raw

PATCH 1/1 ARM: dts: stm32: Add missing dm-spl props for SPI NOR on AV96

Hi,

Quoted 26 lines

From: Marek Vasut <[email protected]>
Sent: vendredi 2 octobre 2020 14:09

Quoted 1 line · Patrick DELAUNAY

Hi Marek,

Hi,

Quoted 18 lines
Quoted 7 lines

From: Marek Vasut <[email protected]>
Sent: jeudi 1 octobre 2020 12:26

The u-boot,dm-spl DT props are missing on AV96, hence the pinmux and flash0 nodes are not included in the reduced SPL DT. This prevents SPI NOR boot from working at all. Fix this by filling them in.

Quoted 8 lines
Cc Patrick Delaunay <[email protected]>
Cc Patrice Chotard <[email protected]>
---
 arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi | 21
+++++++++++++++++++++
 1 file changed, 21 insertions(+)
Quoted 7 lines
Quoted 5 lines

2 questions;
It is a regression or SPI boot had never worked on AV96 ? And the expected target is v2020.10 or v2021.01-rc1 ?

I prefer v2021.01-rc1, except if it is blocking or it is a regression .....

It used to work before, so 2020.10 please.

Ok

Applied to u-boot-stm/master, thanks!

Regards

Patrick

#5 lore raw

PATCH 1/1 ARM: dts: stm32: Add missing dm-spl props for SPI NOR on AV96

Quoted 32 lines · Patrick DELAUNAY

Hi,

Quoted 30 lines

From: Marek Vasut <[email protected]>
Sent: vendredi 2 octobre 2020 14:09

Quoted 1 line · Patrick DELAUNAY

Hi Marek,

Hi,

Quoted 22 lines
Quoted 7 lines

From: Marek Vasut <[email protected]>
Sent: jeudi 1 octobre 2020 12:26

The u-boot,dm-spl DT props are missing on AV96, hence the pinmux and flash0 nodes are not included in the reduced SPL DT. This prevents SPI NOR boot from working at all. Fix this by filling them in.

Quoted 8 lines
Cc Patrick Delaunay <[email protected]>
Cc Patrice Chotard <[email protected]>
---
 arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi | 21
+++++++++++++++++++++
 1 file changed, 21 insertions(+)

2 questions;
It is a regression or SPI boot had never worked on AV96 ? And the expected target is v2020.10 or v2021.01-rc1 ?

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

I prefer v2021.01-rc1, except if it is blocking or it is a regression .....

It used to work before, so 2020.10 please.

Ok

Applied to u-boot-stm/master, thanks!

Thanks