Skip to contentSkip to conversation

RDMA/rxe: get rid of create_user_ah

PATCH Superseded Yajun Deng 2 participants 3 messages Mar 8, 2022 – Mar 9, 2022

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Yajun Deng

author
#0 lore raw

PATCH 9/9 RDMA/rxe: get rid of create_user_ah

There is no create_user_ah in ib_device_ops, remove it.

---
 drivers/infiniband/sw/rxe/rxe_verbs.c | 1 -
 1 file changed, 1 deletion(-)
drivers/infiniband/sw/rxe/rxe_verbs.c +0 -1
index 80df9a8f71a1..fa0cf2554425 100644
@@ -1053,7 +1053,6 @@ static const struct ib_device_ops rxe_dev_ops = {
 	.create_cq = rxe_create_cq,
 	.create_qp = rxe_create_qp,
 	.create_srq = rxe_create_srq,
-	.create_user_ah = rxe_create_ah,
 	.dealloc_driver = rxe_dealloc,
 	.dealloc_mw = rxe_dealloc_mw,
 	.dealloc_pd = rxe_dealloc_pd,
Signature · 1 line
2.25.1
#1 lore raw
Quoted 1 line · Yajun Deng

There is no create_user_ah in ib_device_ops, remove it.

In the file include/rdma/ib_verbs.h:

2305 struct ib_device_ops {
...
2431 int (*create_user_ah)(struct ib_ah *ah, struct rdma_ah_init_attr *attr,
2432 struct ib_udata *udata);
...

create_user_ah exists.

Zhu Yanjun

Quoted 18 lines
---
  drivers/infiniband/sw/rxe/rxe_verbs.c | 1 -
  1 file changed, 1 deletion(-)
drivers/infiniband/sw/rxe/rxe_verbs.c +0 -1
index 80df9a8f71a1..fa0cf2554425 100644
@@ -1053,7 +1053,6 @@ static const struct ib_device_ops rxe_dev_ops = {
  	.create_cq = rxe_create_cq,
  	.create_qp = rxe_create_qp,
  	.create_srq = rxe_create_srq,
-	.create_user_ah = rxe_create_ah,
  	.dealloc_driver = rxe_dealloc,
  	.dealloc_mw = rxe_dealloc_mw,
  	.dealloc_pd = rxe_dealloc_pd,
#2 lore raw
Quoted 11 lines · Yanjun Zhu
Quoted 1 line · Yajun Deng

There is no create_user_ah in ib_device_ops, remove it.

In the file include/rdma/ib_verbs.h:

2305 struct ib_device_ops {
...
2431         int (*create_user_ah)(struct ib_ah *ah, struct rdma_ah_init_attr *attr, 2432                               struct ib_udata *udata);
...

create_user_ah exists.

I found your patch to remove create_user_ah.
IMO, you should merge the 2 patches as one.

Or after the patch to remove create_user_ah is merged in mainline, then this patch can be sent out.

As such this will not misguide us.

Zhu Yanjun

Quoted 21 lines

Zhu Yanjun

Quoted 18 lines

---
  drivers/infiniband/sw/rxe/rxe_verbs.c | 1 -

  1 file changed, 1 deletion(-)
drivers/infiniband/sw/rxe/rxe_verbs.c +0 -1
index 80df9a8f71a1..fa0cf2554425 100644
@@ -1053,7 +1053,6 @@ static const struct ib_device_ops rxe_dev_ops = {
       .create_cq = rxe_create_cq,
       .create_qp = rxe_create_qp,
       .create_srq = rxe_create_srq,
-    .create_user_ah = rxe_create_ah,
       .dealloc_driver = rxe_dealloc,
       .dealloc_mw = rxe_dealloc_mw,
       .dealloc_pd = rxe_dealloc_pd,