RDMA/rxe: get rid of create_user_ah
Subsystems (2)
PATCH 9/9 RDMA/rxe: get rid of create_user_ah
There is no create_user_ah in ib_device_ops, remove it.
--- drivers/infiniband/sw/rxe/rxe_verbs.c | 1 - 1 file changed, 1 deletion(-)
drivers/infiniband/sw/rxe/rxe_verbs.c +0 -1
@@ -1053,7 +1053,6 @@ static const struct ib_device_ops rxe_dev_ops = { .create_cq = rxe_create_cq, .create_qp = rxe_create_qp, .create_srq = rxe_create_srq, - .create_user_ah = rxe_create_ah, .dealloc_driver = rxe_dealloc, .dealloc_mw = rxe_dealloc_mw, .dealloc_pd = rxe_dealloc_pd,
Signature · 1 line
2.25.1
Quoted 1 line · Yajun Deng
There is no
create_user_ahinib_device_ops, remove it.
In the file include/rdma/ib_verbs.h:
2305 struct ib_device_ops {
...
2431 int (*create_user_ah)(struct ib_ah *ah, struct rdma_ah_init_attr *attr,
2432 struct ib_udata *udata);
...
create_user_ah exists.
Zhu Yanjun
Quoted 18 lines
Signed-off-by Yajun Deng <[email protected]>--- drivers/infiniband/sw/rxe/rxe_verbs.c | 1 - 1 file changed, 1 deletion(-)drivers/infiniband/sw/rxe/rxe_verbs.c +0
-1@@ -1053,7 +1053,6 @@ static const struct ib_device_ops rxe_dev_ops = { .create_cq = rxe_create_cq, .create_qp = rxe_create_qp, .create_srq = rxe_create_srq, - .create_user_ah = rxe_create_ah, .dealloc_driver = rxe_dealloc, .dealloc_mw = rxe_dealloc_mw, .dealloc_pd = rxe_dealloc_pd,
Quoted 11 lines · Yanjun Zhu
Quoted 1 line · Yajun Deng
There is no
create_user_ahinib_device_ops, remove it.In the file
include/rdma/ib_verbs.h:2305 struct
ib_device_ops{
...
2431 int (*create_user_ah)(structib_ah*ah, structrdma_ah_init_attr*attr, 2432 structib_udata*udata);
...
create_user_ahexists.
I found your patch to remove create_user_ah.
IMO, you should merge the 2 patches as one.
Or after the patch to remove create_user_ah is merged in mainline, then this patch can be sent out.
As such this will not misguide us.
Zhu Yanjun
Quoted 21 lines
Zhu Yanjun
Quoted 18 lines
Signed-off-by Yajun Deng <[email protected]>---
drivers/infiniband/sw/rxe/rxe_verbs.c| 1 -1 file changed, 1 deletion(-)drivers/infiniband/sw/rxe/rxe_verbs.c +0
-1@@ -1053,7 +1053,6 @@ static const struct ib_device_ops rxe_dev_ops = { .create_cq = rxe_create_cq, .create_qp = rxe_create_qp, .create_srq = rxe_create_srq, - .create_user_ah = rxe_create_ah, .dealloc_driver = rxe_dealloc, .dealloc_mw = rxe_dealloc_mw, .dealloc_pd = rxe_dealloc_pd,