Fix markup_oops.pl get error in x86
PATCH 1/1 Fix markup_oops.pl get error in x86
Hello,
When I try to use markup_oops.pl in x86, I always get:
cat 1 | perl markup_oops.pl ./vmlinux
objdump: --start-address: bad number: NaN
No matching code found
This is because in line:
if ($line =~ /EIP is at ([a-zA-Z0-9\_]+)\+0x([0-9a-f]+)\/[a-f0-9]/) { $function = $1;
$func_offset = $2;
}
$func_offset will get a number like "0x2"
But in follow code:
my $decodestart = Math::BigInt->from_hex("0x$target") - Math::BigInt->from_hex("0x$func_offset");
It add other ox to ox2.
Then this value will be set to NaN.
So I make a small patch to fix it.
Best regards,
Hui
--- scripts/markup_oops.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/markup_oops.pl +1 -1
@@ -154,7 +154,7 @@ while (<STDIN>) { if ($line =~ /RIP: 0010:\[\<([a-z0-9]+)\>\]/) { $target = $1; } - if ($line =~ /EIP is at ([a-zA-Z0-9\_]+)\+(0x[0-9a-f]+)\/0x[a-f0-9]/) { + if ($line =~ /EIP is at ([a-zA-Z0-9\_]+)\+0x([0-9a-f]+)\/[a-f0-9]/) { $function = $1; $func_offset = $2; }
scripts/markup_oops.pl while (<STDIN>) { · line 157
Quoted 12 lines · Hui Zhu
}
$func_offset will get a number like "0x2"
But in follow code:
my $decodestart =Math::BigInt->from_hex("0x$target")-Math::BigInt->from_hex("0x$func_offset");
It add other ox to ox2.
Then this value will be set to NaN.So I make a small patch to fix it.
scripts/markup_oops.pl +1
-1- if ($line =~ /EIP is at ([a-zA-Z0-9\_]+)\+(0x[0-9a-f]+)\/0x[a-f0-9]/) { + if ($line =~ /EIP is at ([a-zA-Z0-9\_]+)\+0x([0-9a-f]+)\/[a-f0-9]/) {
I think this makes sense, but would you not also need to add "x" to the list of allowed characters?
so [a-f0-9x]
?
Quoted 17 lines · Arjan van de Ven
Quoted 9 lines · Hui Zhu
}
$func_offset will get a number like "0x2"
But in follow code:
my $decodestart =Math::BigInt->from_hex("0x$target")-Math::BigInt->from_hex("0x$func_offset");
It add other ox to ox2.
Then this value will be set to NaN.Quoted 6 lines
So I make a small patch to fix it.
- if ($line =~ /EIP is at
([a-zA-Z0-9\_]+)\+(0x[0-9a-f]+)\/0x[a-f0-9]/) {
+ if ($line =~ /EIP is at
([a-zA-Z0-9\_]+)\+0x([0-9a-f]+)\/[a-f0-9]/) {
Quoted 6 lines
I think this makes sense, but would you not also need to add "x" to the list of allowed characters?
so [a-f0-9x]
?
Ah, sorry I make a mistake. I think the last 0x need be keep.
What about this version?
Thanks,
Hui
--- scripts/markup_oops.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/markup_oops.pl +1 -1
@@ -154,7 +154,7 @@ while (<STDIN>) { if ($line =~ /RIP: 0010:\[\<([a-z0-9]+)\>\]/) { $target = $1; } - if ($line =~ /EIP is at ([a-zA-Z0-9\_]+)\+(0x[0-9a-f]+)\/0x[a-f0-9]/) { + if ($line =~ /EIP is at ([a-zA-Z0-9\_]+)\+0x([0-9a-f]+)\/0x[a-f0-9]/) { $function = $1; $func_offset = $2; }
Arjan van de Ven
Acked-byQuoted 2 lines · Hui Zhu
What about this version?
looks great to me,
Quoted 19 lines
Thanks,
Hui--- scripts/markup_oops.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)scripts/markup_oops.pl +1
-1@@ -154,7 +154,7 @@ while (<STDIN>) { if ($line =~ /RIP: 0010:\[\<([a-z0-9]+)\>\]/) { $target = $1; } - if ($line =~ /EIP is at ([a-zA-Z0-9\_]+)\+(0x[0-9a-f]+)\/0x[a-f0-9]/) { + if ($line =~ /EIP is at ([a-zA-Z0-9\_]+)\+0x([0-9a-f]+)\/0x[a-f0-9]/) { $function = $1; $func_offset = $2; }
Thanks.
Hui
Quoted 31 lines · Arjan van de Ven
Quoted 2 lines · Hui Zhu
What about this version?
looks great to me,
Acked-by Arjan van de Ven <[email protected]>Quoted 21 lines
Thanks,
Hui---
scripts/markup_oops.pl | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)scripts/markup_oops.pl +1
-1@@ -154,7 +154,7 @@ while (<STDIN>) { if ($line =~ /RIP: 0010:\[\<([a-z0-9]+)\>\]/) { $target = $1; } - if ($line =~ /EIP is at ([a-zA-Z0-9\_]+)\+(0x[0-9a-f]+)\/0x[a-f0-9]/) { + if ($line =~ /EIP is at ([a-zA-Z0-9\_]+)\+0x([0-9a-f]+)\/0x[a-f0-9]/) { $function = $1;$func_offset = $2;
}
Sorry I forgot the Signed-off-by and CC in prev mail.
When I try to use markup_oops.pl in x86, I always get:
cat 1 | perl markup_oops.pl ./vmlinux
objdump: --start-address: bad number: NaN
No matching code found
This is because in line:
if ($line =~ /EIP is at ([a-zA-Z0-9\_]+)\+0x([0-9a-f]+)\/[a-f0-9]/) {
$function = $1;
$func_offset = $2;
}$func_offset will get a number like "0x2"
But in follow code:
my $decodestart = Math::BigInt->from_hex("0x$target") - Math::BigInt->from_hex("0x$func_offset");
It add other 0x to 0x2.
Then this value will be set to NaN.
This patch will fix it.
--- scripts/markup_oops.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/markup_oops.pl +1 -1
@@ -154,7 +154,7 @@ while (<STDIN>) { if ($line =~ /RIP: 0010:\[\<([a-z0-9]+)\>\]/) { $target = $1; } - if ($line =~ /EIP is at ([a-zA-Z0-9\_]+)\+(0x[0-9a-f]+)\/0x[a-f0-9]/) { + if ($line =~ /EIP is at ([a-zA-Z0-9\_]+)\+0x([0-9a-f]+)\/0x[a-f0-9]/) { $function = $1; $func_offset = $2; }
Hui Zhu wrote On 06-01-2010 11:23:
Quoted 3 lines
Hello,
When I try to use markup_oops.pl in x86, I always get:
I already mentioned that but wasn't able to get attention, and yes the current code doesn't work,
http://lkml.indiana.edu/hypermail/linux/kernel/0908.0/02222.html