Skip to contentSkip to conversation

riscv: dts: microchip: fix gpio1 reg property typo

PATCH In review Conor Paxton 4 participants 5 messages May 17, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 riscv: dts: microchip: fix gpio1 reg property typo

Fix reg address typo in the gpio1 stanza.

---
 arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi +1 -1
index 746c4d4e7686..cf2f55e1dcb6 100644
@@ -366,7 +366,7 @@ gpio0: gpio@20120000 {
 
 		gpio1: gpio@20121000 {
 			compatible = "microchip,mpfs-gpio";
-			reg = <000 0x20121000 0x0 0x1000>;
+			reg = <0x0 0x20121000 0x0 0x1000>;
 			interrupt-parent = <&plic>;
 			interrupt-controller;
 			#interrupt-cells = <1>;
Signature · 1 line
2.25.1
#2 lore raw
In reply to Conor Paxton
Quoted 5 lines · Conor Paxton

Fix reg address typo in the gpio1 stanza.

---
 arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 2 +-

Pressed send to fast...

Please add Fixes tag, unless fixed commit SHA is not considered stable.

Best regards,
Krzysztof

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

maintainer
#3 lore raw
Quoted 10 lines · On Tue, 17 May 2022 07:51:32 PDT (-0700), [email protected] wrote:
Quoted 5 lines · Conor Paxton

Fix reg address typo in the gpio1 stanza.

---
 arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 2 +-

Pressed send to fast...

Please add Fixes tag, unless fixed commit SHA is not considered stable.

Conor might be asleep, and as it's late in the cycle I figured I'd just chime in directly. This LGTM, I usually add fixes myself if there aren't any. Unless there's any objections to

Fixes 528a5b1f2556 ("riscv: dts: microchip: add new peripherals to icicle kit device tree")

I'll put this on fixes.

Thanks!

Quoted 4 lines

Best regards,
Krzysztof

maintainer Reviewed-by
#4 lore raw
Quoted 8 lines · Palmer Dabbelt
Quoted 7 lines · On Tue, 17 May 2022 07:51:32 PDT (-0700), [email protected] wrote:
Quoted 5 lines · Conor Paxton

Fix reg address typo in the gpio1 stanza.

---
 arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 2 +-

Quoted 5 lines
Quoted 3 lines

Pressed send to fast...

Please add Fixes tag, unless fixed commit SHA is not considered stable.

Conor might be asleep, and as it's late in the cycle I figured I'd just chime in directly.  This LGTM, I usually add fixes myself if there aren't any.  Unless there's any objections to

It's not even 1700 yet, neither Conor on the mail is asleep!

Quoted 2 lines
Fixes 528a5b1f2556 ("riscv: dts: microchip: add new peripherals to icicle kit device tree")

Saw Krzysztof's mail as I went out the door, I was gonna add an RB & the fixes tag once I got home but beaten to the punch.
FWIW at this point:

Quoted 10 lines

I'll put this on fixes.

Thanks!

Quoted 4 lines

Best regards,
Krzysztof