drm/ras: include linux/types.h in drm_ras.h
Subsystems (3)
PATCH 1/1 drm/ras: include linux/types.h in drm_ras.h
drm_ras.h uses u32. Include linux/types.h for it.
--- include/drm/drm_ras.h | 2 ++ 1 file changed, 2 insertions(+)
include/drm/drm_ras.h +2 -0
@@ -6,6 +6,8 @@#ifndef __DRM_RAS_H__#define __DRM_RAS_H__ +#include <linux/types.h> +#include <uapi/drm/drm_ras.h> /**
Signature · 1 line
2.47.3
Am 15.06.26 um 17:29 schrieb Jani Nikula:
Quoted 3 lines
drm_ras.huses u32. Includelinux/types.hfor it.Signed-off-by Jani Nikula <[email protected]>
with the question below answered
Quoted 9 lines
--- include/drm/drm_ras.h | 2 ++ 1 file changed, 2 insertions(+)include/drm/drm_ras.h +0
-0
include/drm/drm_ras.h line 11
Quoted 6 lines
include/drm/drm_ras.h +2
-0@@ -6,6 +6,8 @@#ifndef __DRM_RAS_H__#define __DRM_RAS_H__ +#include <linux/types.h> +#include <uapi/drm/drm_ras.h>
Should the uapi header be included first? That's what I've seen elsewhere and what seems more correct.
Best regards
Thomas
Quoted 2 lines
include/drm/drm_ras.h +0
-0/**
Signature · 6 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
Quoted 21 lines · Thomas Zimmermann
Am 15.06.26 um 17:29 schrieb Jani Nikula:
Quoted 3 lines
drm_ras.huses u32. Includelinux/types.hfor it.Signed-off-by Jani Nikula <[email protected]>Reviewed-by Thomas Zimmermann <[email protected]>with the question below answered
Quoted 12 lines
--- include/drm/drm_ras.h | 2 ++ 1 file changed, 2 insertions(+)include/drm/drm_ras.h +0
-0@@ -6,6 +6,8 @@#ifndef __DRM_RAS_H__#define __DRM_RAS_H__
Quoted 6 lines
include/drm/drm_ras.h line 11
Quoted 3 lines
include/drm/drm_ras.h +2
-0+#include <linux/types.h> +#include <uapi/drm/drm_ras.h> Should the uapi header be included first? That's what I've seen elsewhere and what seems more correct.
I'm not sure. I just pretty much always put linux includes before any drm includes, and I don't think the order should matter functionally. If it does, something else is wrong.
BR,
Jani.
Quoted 6 lines
Best regards
ThomasQuoted 2 lines
include/drm/drm_ras.h +0
-0/**
Signature · 1 line
Jani Nikula, Intel
Thomas Zimmermann
maintainerAm 30.06.26 um 12:57 schrieb Jani Nikula:
Quoted 21 lines · Thomas Zimmermann
Quoted 20 lines
Am 15.06.26 um 17:29 schrieb Jani Nikula:
Quoted 3 lines
drm_ras.huses u32. Includelinux/types.hfor it.Signed-off-by Jani Nikula <[email protected]>Reviewed-by Thomas Zimmermann <[email protected]>with the question below answered
Quoted 12 lines
--- include/drm/drm_ras.h | 2 ++ 1 file changed, 2 insertions(+)include/drm/drm_ras.h +0
-0@@ -6,6 +6,8 @@#ifndef __DRM_RAS_H__#define __DRM_RAS_H__
Quoted 8 lines
Quoted 5 lines
include/drm/drm_ras.h line 11
Quoted 3 lines
include/drm/drm_ras.h +2
-0+#include <linux/types.h> +#include <uapi/drm/drm_ras.h> Should the uapi header be included first? That's what I've seen elsewhere and what seems more correct.
I'm not sure. I just pretty much always put linux includes before any drm includes, and I don't think the order should matter functionally. If it does, something else is wrong.
Well, OK then. R-b: me.
Quoted 10 lines
BR,
Jani.Quoted 5 lines
Best regards
ThomasQuoted 2 lines
include/drm/drm_ras.h +0
-0/**
Signature · 6 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
Quoted 27 lines · Thomas Zimmermann
Am 30.06.26 um 12:57 schrieb Jani Nikula:
Quoted 26 lines · Thomas Zimmermann
Quoted 25 lines
Am 15.06.26 um 17:29 schrieb Jani Nikula:
Quoted 3 lines
drm_ras.huses u32. Includelinux/types.hfor it.Signed-off-by Jani Nikula <[email protected]>Reviewed-by Thomas Zimmermann <[email protected]>with the question below answered
Quoted 9 lines
--- include/drm/drm_ras.h | 2 ++ 1 file changed, 2 insertions(+)include/drm/drm_ras.h +0
-0include/drm/drm_ras.h line 11
Quoted 6 lines
include/drm/drm_ras.h +2
-0@@ -6,6 +6,8 @@#ifndef __DRM_RAS_H__#define __DRM_RAS_H__ +#include <linux/types.h> +#include <uapi/drm/drm_ras.h> Should the uapi header be included first? That's what I've seen elsewhere and what seems more correct.
Quoted 5 lines
Quoted 3 lines
I'm not sure. I just pretty much always put linux includes before any drm includes, and I don't think the order should matter functionally. If it does, something else is wrong.
Well, OK then. R-b: me.
Thanks, pushed to drm-misc-fixes.
BR,
Jani.
Quoted 11 lines
Quoted 11 lines
BR,
Jani.Quoted 5 lines
Best regards
ThomasQuoted 2 lines
include/drm/drm_ras.h +0
-0/**
Signature · 1 line
Jani Nikula, Intel