tiff: Add jbig PACKAGECONFIG and clarify CVE-2022-1210
PATCH 1/1 tiff: Add jbig PACKAGECONFIG and clarify CVE-2022-1210
We never depended upon libjbig so this was never present. Add the PACKAGECONFIG to make this explict.
CVE-2022-1210 is an issue in libjbig so we don't have a problem there, mark as such.
--- meta/recipes-multimedia/libtiff/tiff_4.3.0.bb | 4 ++++ 1 file changed, 4 insertions(+)
meta/recipes-multimedia/libtiff/tiff_4.3.0.bb +4 -0
@@ -32,6 +32,9 @@ CVE_CHECK_IGNORE += "CVE-2015-7313" # caused by 3079627e and fixed by b4e79bfa. CVE_CHECK_IGNORE += "CVE-2022-1622 CVE-2022-1623" +# Issue is in jbig which we don't enable +CVE_CHECK_IGNORE += "CVE-2022-1210" + inherit autotools multilib_header CACHED_CONFIGUREVARS = "ax_cv_check_gl_libgl=no"
@@ -40,6 +43,7 @@ PACKAGECONFIG ?= "cxx jpeg zlib lzma \ strip-chopping extrasample-as-alpha check-ycbcr-subsampling" PACKAGECONFIG[cxx] = "--enable-cxx,--disable-cxx,," +PACKAGECONFIG[jbig] = "--enable-jbig,--disable-jbig,jbig," PACKAGECONFIG[jpeg] = "--enable-jpeg,--disable-jpeg,jpeg," PACKAGECONFIG[zlib] = "--enable-zlib,--disable-zlib,zlib," PACKAGECONFIG[lzma] = "--enable-lzma,--disable-lzma,xz,"
Signature · 1 line
2.34.1
Quoted 5 lines · Richard Purdie
We never depended upon libjbig so this was never present. Add the PACKAGECONFIG to make this explict.
CVE-2022-1210 is an issue in libjbig so we don't have a problem there, mark as such.
But what if I am a user or have a customer that needs that enabled? Now that issue is masked if I run the CVE checking tools , I will have a false sense of security.
I understand that Redhat or Suse can make statements like that as they provide install-able binaries but for a Project that starts from build your own DISTRO, should the community take on this responsibility?
- armin
Quoted 31 lines
Signed-off-by Richard Purdie <[email protected]>--- meta/recipes-multimedia/libtiff/tiff_4.3.0.bb | 4 ++++ 1 file changed, 4 insertions(+)meta/recipes-multimedia/libtiff/tiff_4.3.0.bb +4
-0@@ -32,6 +32,9 @@ CVE_CHECK_IGNORE += "CVE-2015-7313" # caused by 3079627e and fixed by b4e79bfa. CVE_CHECK_IGNORE += "CVE-2022-1622 CVE-2022-1623" +# Issue is in jbig which we don't enable +CVE_CHECK_IGNORE += "CVE-2022-1210" + inherit autotools multilib_header CACHED_CONFIGUREVARS = "ax_cv_check_gl_libgl=no"@@ -40,6 +43,7 @@ PACKAGECONFIG ?= "cxx jpeg zlib lzma \ strip-chopping extrasample-as-alpha check-ycbcr-subsampling" PACKAGECONFIG[cxx] = "--enable-cxx,--disable-cxx,," +PACKAGECONFIG[jbig] = "--enable-jbig,--disable-jbig,jbig," PACKAGECONFIG[jpeg] = "--enable-jpeg,--disable-jpeg,jpeg," PACKAGECONFIG[zlib] = "--enable-zlib,--disable-zlib,zlib," PACKAGECONFIG[lzma] = "--enable-lzma,--disable-lzma,xz,"
Quoted 8 lines · akuster
Quoted 5 lines · Richard Purdie
We never depended upon libjbig so this was never present. Add the PACKAGECONFIG to make this explict.
CVE-2022-1210 is an issue in libjbig so we don't have a problem there, mark as such.
Quoted 7 lines
But what if I am a user or have a customer that needs that enabled? Now that issue is masked if I run the CVE checking tools , I will have a false sense of security.
I understand that Redhat or Suse can make statements like that as they provide install-able binaries but for a Project that starts from build your own DISTRO, should the community take on this responsibility?
This is the same as any of the other decisions we make for CVE_CHECK_IGNORE. If you bbappend and/or change the configs of recipes, you need to do some further due diligence.
The fact there isn't a PACKAGECONFIG for it at least suggests it isn't being used.
What is the alternative? We just list this as unpatched for OE-Core and let everyone have to look it up for themselves?
Cheers,
Richard
Quoted 14 lines · On 5/28/22 12:43, [email protected] wrote:
Quoted 6 lines · akuster
Quoted 5 lines · Richard Purdie
We never depended upon libjbig so this was never present. Add the PACKAGECONFIG to make this explict.
CVE-2022-1210 is an issue in libjbig so we don't have a problem there, mark as such.
Quoted 7 lines
But what if I am a user or have a customer that needs that enabled? Now that issue is masked if I run the CVE checking tools , I will have a false sense of security.
I understand that Redhat or Suse can make statements like that as they provide install-able binaries but for a Project that starts from build your own DISTRO, should the community take on this responsibility?
Quoted 6 lines
This is the same as any of the other decisions we make for
CVE_CHECK_IGNORE. If you bbappend and/or change the configs of recipes, you need to do some further due diligence.The fact there isn't a PACKAGECONFIG for it at least suggests it isn't being used.
Maybe.
Quoted 3 lines
What is the alternative? We just list this as unpatched for OE-Core and let everyone have to look it up for themselves?
The first two ideas that come to mind are:
1) Make the PACKAGECONFIG = CVE # and a note in the recipe to provide a clue.
2) Create some sort of frame work to warn if that pkg config is enabled.
- armin
Quoted 6 lines
Cheers,
Richard
Quoted 16 lines · akuster
Quoted 14 lines · On 5/28/22 12:43, [email protected] wrote:
Quoted 13 lines · akuster
Quoted 5 lines · Richard Purdie
We never depended upon libjbig so this was never present. Add the PACKAGECONFIG to make this explict.
CVE-2022-1210 is an issue in libjbig so we don't have a problem there, mark as such.
But what if I am a user or have a customer that needs that enabled? Now that issue is masked if I run the CVE checking tools , I will have a false sense of security.
I understand that Redhat or Suse can make statements like that as they provide install-able binaries but for a Project that starts from build your own DISTRO, should the community take on this responsibility?
Quoted 7 lines
Quoted 6 lines
This is the same as any of the other decisions we make for
CVE_CHECK_IGNORE. If you bbappend and/or change the configs of recipes, you need to do some further due diligence.The fact there isn't a PACKAGECONFIG for it at least suggests it isn't being used.
Maybe.
I did check and there is no recipe for jbig2-kit in the layer index which is what tiff would use.
Quoted 7 lines
Quoted 2 lines
What is the alternative? We just list this as unpatched for OE-Core and let everyone have to look it up for themselves?
The first two ideas that come to mind are:
1) Make the PACKAGECONFIG = CVE # and a note in the recipe to provide a clue.
2) Create some sort of frame work to warn if that pkg config is enabled.
I did document it in the recipe. The recipe name on the dependency the PACKAGECONFIG would add will break as things stand too so I'd hope someone would notice if they were trying to enable it.
Cheers,
Richard