target/arm/vfp_helper: Call set_fpscr_to_host before updating to FPSCR
PATCH 1/1 target/arm/vfp_helper: Call set_fpscr_to_host before updating to FPSCR
In commit e9d652824b0 we extracted the vfp_set_fpscr_to_host() function but failed at calling it in the correct place, we call it after xregs[ARM_VFP_FPSCR] is modified.
Fix by calling this function before we update FPSCR.
--- target/arm/vfp_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
target/arm/vfp_helper.c +2 -2
@@ -197,6 +197,8 @@ void HELPER(vfp_set_fpscr)(CPUARMState *env, uint32_t val) val &=0xf7c0009f ; } +vfp_set_fpscr_to_host (env, val); +/* * We don't implement trapped exception handling, so the * trap enable bits, IDE|IXE|UFE|OFE|DZE|IOE are all RAZ/WI (not RES0!)
@@ -217,8 +219,6 @@ void HELPER(vfp_set_fpscr)(CPUARMState *env, uint32_t val) env->vfp.qc[1 ] =0 ; env->vfp.qc[2 ] =0 ; env->vfp.qc[3 ] =0 ; - -vfp_set_fpscr_to_host (env, val); }void vfp_set_fpscr (CPUARMState *env,uint32_t val)
Signature · 1 line
2.20.1
Correct subject: "Call set_fpscr_to_host before updating FPSCR reg" (or without "reg").
Quoted 35 lines · Philippe Mathieu-Daudé
In commit
e9d652824b0we extracted thevfp_set_fpscr_to_host()function but failed at calling it in the correct place, we call it after xregs[ARM_VFP_FPSCR] is modified.Fix by calling this function before we update FPSCR.
Reported-by Laurent Desnogues <[email protected]>Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- target/arm/vfp_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)target/arm/vfp_helper.c +2
-2@@ -197,6 +197,8 @@ void HELPER(vfp_set_fpscr)(CPUARMState *env, uint32_t val) val &=0xf7c0009f ; } +vfp_set_fpscr_to_host (env, val); +/* * We don't implement trapped exception handling, so the * trap enable bits, IDE|IXE|UFE|OFE|DZE|IOE are all RAZ/WI (not RES0!) @@ -217,8 +219,6 @@ void HELPER(vfp_set_fpscr)(CPUARMState *env, uint32_t val) env->vfp.qc[1 ] =0 ; env->vfp.qc[2 ] =0 ; env->vfp.qc[3 ] =0 ; - -vfp_set_fpscr_to_host (env, val); }void vfp_set_fpscr (CPUARMState *env,uint32_t val)
Quoted 2 lines · Philippe Mathieu-Daudé
Correct subject: "Call
set_fpscr_to_hostbefore updating FPSCR reg" (or without "reg").
Queued to testing/next, thanks.
Quoted 35 lines · Philippe Mathieu-Daudé
Quoted 33 lines
In commit
e9d652824b0we extracted thevfp_set_fpscr_to_host()function but failed at calling it in the correct place, we call it after xregs[ARM_VFP_FPSCR] is modified.Fix by calling this function before we update FPSCR.
Reported-by Laurent Desnogues <[email protected]>Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- target/arm/vfp_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)target/arm/vfp_helper.c +2
-2@@ -197,6 +197,8 @@ void HELPER(vfp_set_fpscr)(CPUARMState *env, uint32_t val) val &=0xf7c0009f ; } +vfp_set_fpscr_to_host (env, val); +/* * We don't implement trapped exception handling, so the * trap enable bits, IDE|IXE|UFE|OFE|DZE|IOE are all RAZ/WI (not RES0!) @@ -217,8 +219,6 @@ void HELPER(vfp_set_fpscr)(CPUARMState *env, uint32_t val) env->vfp.qc[1 ] =0 ; env->vfp.qc[2 ] =0 ; env->vfp.qc[3 ] =0 ; - -vfp_set_fpscr_to_host (env, val); }
Quoted 2 lines
target/arm/vfp_helper.c void HELPER(vfp_set_fpscr)(CPUARMState *env, uint32_t val) · line 224
Quoted 2 lines
target/arm/vfp_helper.c +0
-0void vfp_set_fpscr (CPUARMState *env,uint32_t val)
--
Alex Bennée
Quoted 9 lines · Philippe Mathieu-Daudé
In commit
e9d652824b0we extracted thevfp_set_fpscr_to_host()function but failed at calling it in the correct place, we call it after xregs[ARM_VFP_FPSCR] is modified.Fix by calling this function before we update FPSCR.
Reported-by Laurent Desnogues <[email protected]>Signed-off-by Philippe Mathieu-Daudé <[email protected]>
Thanks,
Laurent
Quoted 29 lines
--- target/arm/vfp_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)target/arm/vfp_helper.c +2
-3@@ -197,6 +197,8 @@ void HELPER(vfp_set_fpscr)(CPUARMState *env, uint32_t val) val &=0xf7c0009f ; } +vfp_set_fpscr_to_host (env, val); +/* * We don't implement trapped exception handling, so the * trap enable bits, IDE|IXE|UFE|OFE|DZE|IOE are all RAZ/WI (not RES0!) @@ -217,8 +219,6 @@ void HELPER(vfp_set_fpscr)(CPUARMState *env, uint32_t val) env->vfp.qc[1 ] =0 ; env->vfp.qc[2 ] =0 ; env->vfp.qc[3 ] =0 ; - -vfp_set_fpscr_to_host (env, val); }void vfp_set_fpscr (CPUARMState *env,uint32_t val) --2.20.1