Coccinelle: api: Add SmPL script “use_platform_get_irq.cocci”
PATCH 1/1 Coccinelle: api: Add SmPL script “use_platform_get_irq.cocci”
From: Markus Elfring <[email protected]>
Date: Wed, 23 Sep 2020 18:30:25 +0200
A wrapper function is available since the commit 7723f4c5ecdb8d832f049f8483beb0d1081cedf6 ("driver core: platform: Add an error message to platform_get_irq*()"). Provide design options for the adjustment of affected source code
by the means of the semantic patch language (Coccinelle software).
Signed-off-by Markus Elfring <[email protected]>
--- .../coccinelle/api/use_platform_get_irq.cocci | 107 ++++++++++++++++++ 1 file changed, 107 insertions(+) create mode 100644 scripts/coccinelle/api/use_platform_get_irq.cocci
scripts/coccinelle/api/use_platform_get_irq.cocci new file +107 -0
@@ -0,0 +1,107 @@ +// SPDX-License-Identifier: GPL-2.0 +/// Simplify a function call combination by using a known wrapper function. +// +// Keywords: wrapper function conversion IRQ resources +// Confidence: High +// Options: --no-includes --include-headers + +virtual context, patch, report, org + +@depends on context@ +expression device, error_code, index, irq, resource, x; +identifier ri; +type t; +@@ +( +*resource = platform_get_resource(device, IORESOURCE_IRQ, index); +*if (resource == NULL) +*{ +* dev_err(&device->dev, ...); +* return error_code; +*} + irq = +* resource->start + ; +| +*t ri = platform_get_resource(device, IORESOURCE_IRQ, index); + ... when != ri + when != device = x +*if (ri == NULL) +*{ +* dev_err(&device->dev, ...); +* return error_code; +*} + irq = +* ri->start + ; +) + +@depends on patch@ +expression device, error_code, index, irq, resource, x; +identifier ri; +type t; +@@ +( +-resource = platform_get_resource(device, IORESOURCE_IRQ, index); +-if (resource == NULL) +-{ +- dev_err(&device->dev, ...); +- return error_code; +-} + irq = +- resource->start ++ platform_get_irq(device, index) + ; ++if (irq < 0) ++ return irq; +| +-t ri = platform_get_resource(device, IORESOURCE_IRQ, index); + ... when != ri + when != device = x +-if (ri == NULL) +-{ +- dev_err(&device->dev, ...); +- return error_code; +-} + irq = +- ri->start ++ platform_get_irq(device, index) + ; ++if (irq < 0) ++ return irq; +) + +@or depends on org || report@ +expression device, error_code, index, irq, resource, x; +identifier ri; +position p; +type t; +@@ +(resource = platform_get_resource(device, IORESOURCE_IRQ, index); + if (resource == NULL) + { + dev_err(&device->dev, ...); + return error_code; + } + irq = resource->start@p; +| + t ri = platform_get_resource(device, IORESOURCE_IRQ, index); + ... when != ri + when != device = x + if (ri == NULL) + { + dev_err(&device->dev, ...); + return error_code; + } + irq = ri->start@p; +) + +@script:python depends on org@ +p << or.p; +@@ +coccilib.org.print_todo(p[0], "WARNING: opportunity for platform_get_irq()") + +@script:python depends on report@ +p << or.p; +@@ +coccilib.report.print_report(p[0], "WARNING: opportunity for platform_get_irq()")
--
2.28.0
_______________________________________________
Cocci mailing list
[email protected]
https://systeme.lip6.fr/mailman/listinfo/cocci