target/hexagon/idef-parser: Remove self-assignment
PATCH 1/1 target/hexagon/idef-parser: Remove self-assignment
The self assignment is clearly useless, and @1.last_column does not have to be set for an expression with only a single token, so remove it.
--- target/hexagon/idef-parser/idef-parser.y | 1 - 1 file changed, 1 deletion(-)
target/hexagon/idef-parser/idef-parser.y +0 -1
@@ -802,7 +802,6 @@ rvalue : FAIL lvalue : FAIL { - @1.last_column = @1.last_column; yyassert(c, &@1, false, "Encountered a FAIL token as lvalue.\n"); } | REG
Signature · 1 line
2.41.0
Quoted 8 lines · Anton Johansson via
The self assignment is clearly useless, and @1.last_column does not have to be set for an expression with only a single token, so remove it.
Reported-by Peter Maydell <[email protected]>Signed-off-by Anton Johansson <[email protected]>--- target/hexagon/idef-parser/idef-parser.y | 1 - 1 file changed, 1 deletion(-)
Quoted 35 lines
-----Original Message-----
From: Anton Johansson <[email protected]>
Sent: Thursday, July 13, 2023 7:09 AM
To: [email protected]
Cc: Brian Cain <[email protected]>; [email protected]
Subject: [PATCH] target/hexagon/idef-parser: Remove self-assignmentWARNING: This email originated from outside of Qualcomm. Please be wary of any links or attachments, and do not enable macros.
The self assignment is clearly useless, and @1.last_column does not have to be set for an expression with only a single token, so remove it.
Reported-by Peter Maydell <[email protected]>Signed-off-by Anton Johansson <[email protected]>--- target/hexagon/idef-parser/idef-parser.y | 1 - 1 file changed, 1 deletion(-)target/hexagon/idef- renamed from target/hexagon/idef-parser/idef-parser.y +0
-0parser/idef-parser.y
indexcd2612eb8c..a6587f5bcc100644target/hexagon/idef-parser/idef-parser.y +0
-2@@ -802,7 +802,6 @@ rvalue : FAIL lvalue : FAIL { - @1.last_column = @1.last_column; yyassert(c, &@1, false, "Encountered a FAIL token as lvalue.\n"); } | REG --
Quoted 1 line
2.41.0
Quoted 29 lines · Brian Cain
Quoted 29 lines
-----Original Message-----
From: Anton Johansson <[email protected]>
Sent: Thursday, July 13, 2023 7:09 AM
To: [email protected]
Cc: Brian Cain <[email protected]>; [email protected]
Subject: [PATCH] target/hexagon/idef-parser: Remove self-assignmentWARNING: This email originated from outside of Qualcomm. Please be wary of any links or attachments, and do not enable macros.
The self assignment is clearly useless, and @1.last_column does not have to be set for an expression with only a single token, so remove it.
Reported-by Peter Maydell <[email protected]>Signed-off-by Anton Johansson <[email protected]>--- target/hexagon/idef-parser/idef-parser.y | 1 - 1 file changed, 1 deletion(-)target/hexagon/idef- renamed from target/hexagon/idef-parser/idef-parser.y +0
-0parser/idef-parser.y
indexcd2612eb8c..a6587f5bcc100644target/hexagon/idef-parser/idef-parser.y +0
-0@@ -802,7 +802,6 @@ rvalue : FAIL
Quoted 10 lines
Quoted 8 lines
target/hexagon/idef-parser/idef-parser.y +0
-2lvalue : FAIL { - @1.last_column = @1.last_column; yyassert(c, &@1, false, "Encountered a FAIL token as lvalue.\n"); } | REG --2.41.0
Reviewed-by Brian Cain <[email protected]>
Ping -- I just noticed that this patch never seems to have made it upstream. Brian, could you pick it up?
(This fixes a Coverity issue: CID 976926.)
thanks
-- PMM
Quoted 39 lines · Peter Maydell
Quoted 28 lines · Brian Cain
Quoted 28 lines
-----Original Message-----
From: Anton Johansson <[email protected]>
Sent: Thursday, July 13, 2023 7:09 AM
To: [email protected]
Cc: Brian Cain <[email protected]>; [email protected]
Subject: [PATCH] target/hexagon/idef-parser: Remove self-assignmentWARNING: This email originated from outside of Qualcomm. Please be wary of any links or attachments, and do not enable macros.
The self assignment is clearly useless, and @1.last_column does not have to be set for an expression with only a single token, so remove it.
Reported-by Peter Maydell <[email protected]>Signed-off-by Anton Johansson <[email protected]>--- target/hexagon/idef-parser/idef-parser.y | 1 - 1 file changed, 1 deletion(-)target/hexagon/idef- renamed from target/hexagon/idef-parser/idef-parser.y +0
-0parser/idef-parser.y
indexcd2612eb8c..a6587f5bcc100644target/hexagon/idef-parser/idef-parser.y +0
-0@@ -802,7 +802,6 @@ rvalue : FAILQuoted 9 lines
Quoted 8 lines
target/hexagon/idef-parser/idef-parser.y +0
-2lvalue : FAIL { - @1.last_column = @1.last_column; yyassert(c, &@1, false, "Encountered a FAIL token as lvalue.\n"); } | REG --2.41.0
Reviewed-by Brian Cain <[email protected]>
Quoted 4 lines
Ping -- I just noticed that this patch never seems to have made it upstream. Brian, could you pick it up?
(This fixes a Coverity issue: CID 976926.)
Sorry about that! Queued at https://github.com/quic/qemu/ hex.next -- will include it in an upcoming PR.