ARC: align child stack in clone
PATCH 1/1 ARC: align child stack in clone
From: Pavel Kozlov <[email protected]>
The ARCv2 ABI requires 4 byte stack pointer alignment. Don't allow to use unaligned child stack in clone. As the stack grows down, align it down.
This was pointed by misc/tst-misalign-clone-internal and misc/tst-misalign-clone tests. Stack alignmet fixes these tests fails.
--- sysdeps/unix/sysv/linux/arc/clone.S | 1 + 1 file changed, 1 insertion(+)
sysdeps/unix/sysv/linux/arc/clone.S +1 -0
@@ -41,6 +41,7 @@ ENTRY (__clone) cmp r0, 0 /* @fn can't be NULL. */ + and r1,r1,-4 /* @child_stack be 4 bytes aligned per ABI. */ cmp.ne r1, 0 /* @child_stack can't be NULL. */ bz L (__sys_err)
Signature · 7 lines
2.25.1 _______________________________________________ linux-snps-arc mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Quoted 9 lines · Pavel.Kozlov--- via Libc-alpha
From: Pavel Kozlov <[email protected]>
The ARCv2 ABI requires 4 byte stack pointer alignment. Don't allow to use unaligned child stack in clone. As the stack grows down, align it down.
This was pointed by misc/tst-misalign-clone-internal and misc/tst-misalign-clone tests. Stack alignmet fixes these tests fails.
LGTM, although I can't really test it since the Synopsys qemu tree does not have qemu-user support [1].
[1] https://github.com/foss-for-synopsys-dwc-arc-processors/qemu
Quoted 9 lines
--- sysdeps/unix/sysv/linux/arc/clone.S | 1 + 1 file changed, 1 insertion(+)sysdeps/unix/sysv/linux/arc/clone.S +0
-0
sysdeps/unix/sysv/linux/arc/clone.S line 47
Quoted 7 lines
sysdeps/unix/sysv/linux/arc/clone.S +1
-0@@ -41,6 +41,7 @@ ENTRY (__clone) cmp r0, 0 /* @fn can't be NULL. */ + and r1,r1,-4 /* @child_stack be 4 bytes aligned per ABI. */ cmp.ne r1, 0 /* @child_stack can't be NULL. */ bz L (__sys_err)
_______________________________________________
linux-snps-arc mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Quoted 2 lines
LGTM, although I can't really test it since the Synopsys qemu tree does not have qemu-user support [1].
Thank you for the review. I've checked this patch on QEMU with Linux system and on the ARC HSDK board.
Also, I can say that it is possible to run ARC binaries on QEMU [1] in user mode. Currently not all instructions are supported in ARC QEMU and it is recommended to build binaries with extra -mcpu=archs compiler option, to reduce instruction set. Maybe this [2] will be also useful. It will be great to have this patch in coming 2.37.
[1]
https://github.com/foss-for-synopsys-dwc-arc-processors/qemu
[2]
https://github.com/foss-for-synopsys-dwc-arc-processors/glibc/wiki/Glibc-test-suite-for-a-target-without-native-GNU-toolchain#glibc-test-suite-execution-with-qemu-user-mode-emulation
--
Pavel
_______________________________________________
linux-snps-arc mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-snps-arc