Skip to contentSkip to conversation

arm64: dts: Update cache properties for socionext

PATCH RESEND Applied Rob Herring 4 participants 5 messages Oct 20, 2023 – Oct 23, 2023

Subsystems (2)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH RESEND v2 1/1 arm64: dts: Update cache properties for socionext

From: Pierre Gondois <[email protected]>

The DeviceTree Specification v0.3 specifies that the cache node 'compatible' and 'cache-level' properties are 'required'. Cf. s3.8 Multi-level and Shared Cache Nodes
The 'cache-unified' property should be present if one of the properties for unified cache is present ('cache-size', ...).

Update the Device Trees accordingly.

---
I noticed this one fell thru the cracks from the rest of the series.

Arnd, Can you take this directly.

 arch/arm64/boot/dts/socionext/uniphier-ld11.dtsi | 1 +
 arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi | 2 ++
 arch/arm64/boot/dts/socionext/uniphier-pxs3.dtsi | 1 +
 3 files changed, 4 insertions(+)
arch/arm64/boot/dts/socionext/uniphier-ld11.dtsi +1 -0
index 7bb36b071475..54e58d945fd7 100644
@@ -52,6 +52,7 @@ cpu1: cpu@1 {
 
 		l2: l2-cache {
 			compatible = "cache";
+			cache-level = <2>;
 		};
 	};
 
arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi +2 -0
index 4e2171630272..18390cba2eda 100644
@@ -86,10 +86,12 @@ cpu3: cpu@101 {
 
 		a72_l2: l2-cache0 {
 			compatible = "cache";
+			cache-level = <2>;
 		};
 
 		a53_l2: l2-cache1 {
 			compatible = "cache";
+			cache-level = <2>;
 		};
 	};
 
arch/arm64/boot/dts/socionext/uniphier-pxs3.dtsi +1 -0
index 38ccfb46ea42..56e037900818 100644
@@ -83,6 +83,7 @@ cpu3: cpu@3 {
 
 		l2: l2-cache {
 			compatible = "cache";
+			cache-level = <2>;
 		};
 	};
 
Signature · 1 line
2.42.0
#1 lore raw
Quoted 10 lines · Rob Herring

From: Pierre Gondois <[email protected]>

The DeviceTree Specification v0.3 specifies that the cache node 'compatible' and 'cache-level' properties are 'required'. Cf. s3.8 Multi-level and Shared Cache Nodes
The 'cache-unified' property should be present if one of the properties for unified cache is present ('cache-size', ...).

Update the Device Trees accordingly.

Quoted 8 lines

---
I noticed this one fell thru the cracks from the rest of the series.

Arnd, Can you take this directly.

A bit after Pierre - in April 2023 - I sent similar which was said to be "applied":
https://lore.kernel.org/all/[email protected]/

Maybe the Socionext status in MAINTAINERS should be odd fixes?

Best regards,
Krzysztof

maintainer
#2 lore raw

Hi Krzysztof, Rob,

Quoted 19 lines · Krzysztof Kozlowski
Quoted 18 lines · Rob Herring

From: Pierre Gondois <[email protected]>

The DeviceTree Specification v0.3 specifies that the cache node 'compatible' and 'cache-level' properties are 'required'. Cf. s3.8 Multi-level and Shared Cache Nodes
The 'cache-unified' property should be present if one of the properties for unified cache is present ('cache-size', ...).

Update the Device Trees accordingly.

Link:
https://lore.kernel.org/r/[email protected]

---
I noticed this one fell thru the cracks from the rest of the series.

Quoted 7 lines
Quoted 1 line

Arnd, Can you take this directly.

A bit after Pierre - in April 2023 - I sent similar which was said to be "applied":
https://lore.kernel.org/all/[email protected]/

Maybe the Socionext status in MAINTAINERS should be odd fixes?

Sorry my mistake.
I thought Pierre's patch had been already applied, however,
I set Krzysztof's patch to "applied" but it was missing from the post to soc.

Since Krzysztof's patch includes the same "cache-level" lines as Pierre's, the lines needs to be removed.

I'll post the update series including both to soc.

Thank you,

---
Best Regards
Kunihiko Hayashi

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Reviewed-by on v2 1/1
#3 lore raw
In reply to Rob Herring
Quoted 8 lines · Rob Herring

From: Pierre Gondois <[email protected]>

The DeviceTree Specification v0.3 specifies that the cache node 'compatible' and 'cache-level' properties are 'required'. Cf. s3.8 Multi-level and Shared Cache Nodes
The 'cache-unified' property should be present if one of the properties for unified cache is present ('cache-size', ...).

Quoted 7 lines

Update the Device Trees accordingly.

---

Best regards,
Krzysztof

#4 lore raw
In reply to Rob Herring
This patch was applied to soc/soc.git (for-next) by Arnd Bergmann <[email protected]>:

Hello:

This patch was applied to soc/soc.git (for-next)
by Arnd Bergmann <[email protected]>:

Quoted 9 lines · On Fri, 20 Oct 2023 14:50:22 -0500 you wrote:

From: Pierre Gondois <[email protected]>

The DeviceTree Specification v0.3 specifies that the cache node 'compatible' and 'cache-level' properties are 'required'. Cf. s3.8 Multi-level and Shared Cache Nodes
The 'cache-unified' property should be present if one of the properties for unified cache is present ('cache-size', ...).

[...]

Here is the summary with links:
- [RESEND,v2] arm64: dts: Update cache properties for socionext

    https://git.kernel.org/soc/soc/c/8d4f9145f52e

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html