drm/amd/pm: Add information about SMU11 firmware version
Subsystems (3)
PATCH 1/2 drm/amd/pm: Add information about SMU11 firmware version
This information is useful for root causing issues with S0ix.
--- drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c +3 -0
@@ -272,6 +272,9 @@ int smu_v11_0_check_fw_version(struct smu_context *smu)break ; } +dev_info (smu->adev->dev,"smu fw reported version = 0x%08x (%d.%d.%d)\n" , + smu_version, smu_major, smu_minor, smu_debug); +/* * 1. if_version mismatch is not critical as our fw is designed * to be backward compatible.
Signature · 6 lines
2.25.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
PATCH 2/2 drm/amd/pm: Add information about SMU12 firmware version
This information is useful for root causing issues with S0ix.
--- drivers/gpu/drm/amd/pm/swsmu/smu12/smu_v12_0.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/gpu/drm/amd/pm/swsmu/smu12/smu_v12_0.c +3 -0
@@ -88,6 +88,9 @@ int smu_v12_0_check_fw_version(struct smu_context *smu)if (smu->is_apu) adev->pm.fw_version = smu_version; +dev_info (smu->adev->dev,"smu fw reported version = 0x%08x (%d.%d.%d)\n" , + smu_version, smu_major, smu_minor, smu_debug); +/* * 1. if_version mismatch is not critical as our fw is designed * to be backward compatible.
Signature · 6 lines
2.25.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[Public]
In the SMU issue troubleshooting process we also can check the SMU version by reading MP1 scratch register and from long term we may need put the SMC version collection in the debug sysfs amdgpu_firmware_info.
In this patch fashion, we better use dev_dbg instead of dev_info for only debug purpose.
Quoted 36 lines
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Mario Limonciello
Sent: Wednesday, July 21, 2021 12:18 AM
To: [email protected]
Cc: Limonciello, Mario <[email protected]>
Subject: [PATCH 1/2] drm/amd/pm: Add information about SMU11 firmware versionThis information is useful for root causing issues with S0ix.
Signed-off-by Mario Limonciello <[email protected]>--- drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c | 3 +++ 1 file changed, 3 insertions(+)drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c +3
-0@@ -272,6 +272,9 @@ int smu_v11_0_check_fw_version(struct smu_context *smu) break; } +dev_info (smu->adev->dev,"smu fw reported version = 0x%08x (%d.%d.%d)\n", + smu_version, smu_major, smu_minor, smu_debug); +/* * 1.
if_versionmismatch is not critical as our fw is designed
* to be backward compatible.
--
2.25.1
Quoted 11 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.f
reedesktop.org%2Fmailman%2Flistinfo%2Famd- gfx&data=04%7C01%7CPrike.Liang%40amd.com%7C62180964b7d24208 b59908d94b99f971%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C 637623947521949203%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwM DAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdat a=ACcymqjRA5e1wmQmBCPW5cwsM1tF5QXOXQRukuAgkeg%3D&reser ved=0
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quoted 5 lines · Prike
[Public]
In the SMU issue troubleshooting process we also can check the SMU version by reading MP1 scratch register and from long term we may need put the SMC version collection in the debug sysfs
amdgpu_firmware_infoIn this patch fashion, we better use
dev_dbginstead ofdev_infofor only debug purpose.
Actually SMUv13 files have it at info level, which is why it was modeled this way. Perhaps v13 should also decrease this to debug then.
Quoted 37 lines
Quoted 37 lines
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Mario Limonciello
Sent: Wednesday, July 21, 2021 12:18 AM
To: [email protected]
Cc: Limonciello, Mario <[email protected]>
Subject: [PATCH 1/2] drm/amd/pm: Add information about SMU11 firmware versionThis information is useful for root causing issues with S0ix.
Signed-off-by Mario Limonciello <[email protected]>--- drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c | 3 +++ 1 file changed, 3 insertions(+)drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c +3
-0@@ -272,6 +272,9 @@ int smu_v11_0_check_fw_version(struct smu_context *smu) break; } +dev_info (smu->adev->dev,"smu fw reported version = 0x%08x (%d.%d.%d)\n", + smu_version, smu_major, smu_minor, smu_debug); +/* * 1.
if_versionmismatch is not critical as our fw is designed
* to be backward compatible.
--
2.25.1
Quoted 11 lines
Quoted 11 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.f
reedesktop.org%2Fmailman%2Flistinfo%2Famd- gfx&data=04%7C01%7CPrike.Liang%40amd.com%7C62180964b7d24208 b59908d94b99f971%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C 637623947521949203%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwM DAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdat a=ACcymqjRA5e1wmQmBCPW5cwsM1tF5QXOXQRukuAgkeg%3D&reser ved=0
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[Public]
Quoted 15 lines
-----Original Message-----
From: Limonciello, Mario <[email protected]>
Sent: Wednesday, July 21, 2021 11:15 AM
To: Liang, Prike <[email protected]>; [email protected]
Subject: Re: [PATCH 1/2] drm/amd/pm: Add information about SMU11 firmware versionQuoted 7 lines · Prike
[Public]
In the SMU issue troubleshooting process we also can check the SMU version by reading MP1 scratch register and from long term we may need put the SMC version collection in the debug sysfs
amdgpu_firmware_info
Quoted 6 lines
Quoted 1 line
In this patch fashion, we better use
dev_dbginstead ofdev_infofor onlydebug purpose.
Actually SMUv13 files have it at info level, which is why it was modeled this way. Perhaps v13 should also decrease this to debug then.
[Prike] OK, that seems not great deal for setting print level here. Besides, now base on you patch we may also need clean up the SMU version in the header mismatch print info and just throw out the warning message like as following.
if (if_version != smu->smc_driver_if_version) {
dev_warn(smu->adev->dev, "SMU driver if version not matched\n");
}Quoted 48 lines
Quoted 8 lines
Quoted 8 lines
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Mario Limonciello
Sent: Wednesday, July 21, 2021 12:18 AM
To: [email protected]
Cc: Limonciello, Mario <[email protected]>
Subject: [PATCH 1/2] drm/amd/pm: Add information about SMU11firmware
Quoted 9 lines
Quoted 9 lines
version
This information is useful for root causing issues with S0ix.
Signed-off-by Mario Limonciello <[email protected]>--- drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c | 3 +++ 1 file changed, 3 insertions(+)Quoted 6 lines
drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c int smu_v11_0_check_fw_version(struct
Quoted 6 lines
drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c +0
-0@@ -272,6 +272,9 @@ int smu_v11_0_check_fw_version(struct
smu_contextQuoted 14 lines
Quoted 14 lines
drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c +3
-0*smu)break ; } +dev_info (smu->adev->dev,"smu fw reported version = 0x%08x (%d.%d.%d)\n", + smu_version, smu_major, smu_minor, smu_debug); +/* * 1.
if_versionmismatch is not critical as our fw is designed
* to be backward compatible.
--
2.25.1Quoted 7 lines
Quoted 7 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flis
ts.f
reedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7CPrike.Liang%40amd.com%7C62180964b7d24208
Quoted 1 line
Quoted 1 line
Quoted 8 lines
b59908d94b99f971%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C
Quoted 1 line
Quoted 1 line
637623947521949203%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwM
Quoted 1 line
Quoted 1 line
DAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdat
Quoted 1 line
Quoted 1 line
a=ACcymqjRA5e1wmQmBCPW5cwsM1tF5QXOXQRukuAgkeg%3D&reser
Quoted 1 line
Quoted 1 line
ved=0
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx