Skip to contentSkip to conversation

mmc: sdhci: Use debug for not supported SDMA info message

PATCH New matthias.bgg at kernel.org 3 participants 6 messages May 12, 2020 – May 13, 2020 MMC, SD and SDIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 mmc: sdhci: Use debug for not supported SDMA info message

From: Matthias Brugger <[email protected]>

If CONFIG_MMC_SDHCI_SDMA is enabled but the HW could not support it, we no longer error out. Instead we do not enable it in the host. Change the output from printf to debug as this isn't an error but only additional information now.

---

 drivers/mmc/sdhci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/mmc/sdhci.c +2 -2
index 6e8f6e3d17..8bb4393ce1 100644
@@ -744,8 +744,8 @@ int sdhci_setup_cfg(struct mmc_config *cfg, struct sdhci_host *host,
 	if ((caps & SDHCI_CAN_DO_SDMA)) {
 		host->flags |= USE_SDMA;
 	} else {
-		printf("%s: Your controller doesn't support SDMA!!\n",
-		       __func__);
+		debug("%s: Your controller doesn't support SDMA!!\n",
+		      __func__);
 	}
 #endif
 #if CONFIG_IS_ENABLED(MMC_SDHCI_ADMA)
Signature · 1 line
2.26.2
#1 lore raw

PATCH 2/2 configs: rpi_arm64: enable SDHCI SDMA support

From: Matthias Brugger <[email protected]>

RPi4 supports SDMA on it's SDHCI controller. Enable to option for the combine RPi3/4 config.

---

 configs/rpi_arm64_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/rpi_arm64_defconfig +1 -0
index b9bb083a1d..66c4a5368c 100644
@@ -23,6 +23,7 @@ CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
 CONFIG_DM_KEYBOARD=y
 CONFIG_DM_MMC=y
 CONFIG_MMC_SDHCI=y
+CONFIG_MMC_SDHCI_SDMA=y
 CONFIG_MMC_SDHCI_BCM2835=y
 CONFIG_DM_ETH=y
 CONFIG_BCMGENET=y
Signature · 1 line
2.26.2
#2 lore raw

PATCH 2/2 configs: rpi_arm64: enable SDHCI SDMA support

Quoted 19 lines

Subject: [PATCH 2/2] configs: rpi_arm64: enable SDHCI SDMA support

From: Matthias Brugger <[email protected]>

RPi4 supports SDMA on it's SDHCI controller. Enable to option for the combine RPi3/4 config.

---

 configs/rpi_arm64_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/rpi_arm64_defconfig index renamed from configs/rpi_arm64_defconfig +0 -0

b9bb083a1d..66c4a5368c 100644

configs/rpi_arm64_defconfig CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y · line 29

Quoted 7 lines
configs/rpi_arm64_defconfig +1 -0
@@ -23,6 +23,7 @@ CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
 CONFIG_DM_KEYBOARD=y
 CONFIG_DM_MMC=y
 CONFIG_MMC_SDHCI=y
+CONFIG_MMC_SDHCI_SDMA=y
 CONFIG_MMC_SDHCI_BCM2835=y
 CONFIG_DM_ETH=y
 CONFIG_BCMGENET=y
#3 lore raw

PATCH 2/2 configs: rpi_arm64: enable SDHCI SDMA support

In reply to matthias.bgg at kernel.org
Quoted 8 lines · matthias.bgg at kernel.org

From: Matthias Brugger <[email protected]>

RPi4 supports SDMA on it's SDHCI controller. Enable to option for the combine RPi3/4 config.

---

Queued for rpi-next

Quoted 17 lines
 configs/rpi_arm64_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/rpi_arm64_defconfig +1 -0
index b9bb083a1d..66c4a5368c 100644
@@ -23,6 +23,7 @@ CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
 CONFIG_DM_KEYBOARD=y
 CONFIG_DM_MMC=y
 CONFIG_MMC_SDHCI=y
+CONFIG_MMC_SDHCI_SDMA=y
 CONFIG_MMC_SDHCI_BCM2835=y
 CONFIG_DM_ETH=y
 CONFIG_BCMGENET=y
#4 lore raw

PATCH 1/2 mmc: sdhci: Use debug for not supported SDMA info message

In reply to matthias.bgg at kernel.org
Quoted 31 lines

Subject: [PATCH 1/2] mmc: sdhci: Use debug for not supported SDMA info message

From: Matthias Brugger <[email protected]>

If CONFIG_MMC_SDHCI_SDMA is enabled but the HW could not support it, we no longer error out. Instead we do not enable it in the host. Change the output from printf to debug as this isn't an error but only additional information now.

---

 drivers/mmc/sdhci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/mmc/sdhci.c index renamed from drivers/mmc/sdhci.c +0 -0

6e8f6e3d17..8bb4393ce1 100644

drivers/mmc/sdhci.c +2 -2
@@ -744,8 +744,8 @@ int sdhci_setup_cfg(struct mmc_config *cfg, struct
 sdhci_host *host,
 	if ((caps & SDHCI_CAN_DO_SDMA)) {
 		host->flags |= USE_SDMA;
 	} else {
-		printf("%s: Your controller doesn't support SDMA!!\n",
-		       __func__);
+		debug("%s: Your controller doesn't support SDMA!!\n",
+		      __func__);
 	}
 #endif
Quoted 2 lines

#if CONFIG_IS_ENABLED(MMC_SDHCI_ADMA)
--

#5 lore raw

PATCH 1/2 mmc: sdhci: Use debug for not supported SDMA info message

In reply to matthias.bgg at kernel.org
Quoted 8 lines · matthias.bgg at kernel.org

From: Matthias Brugger <[email protected]>

If CONFIG_MMC_SDHCI_SDMA is enabled but the HW could not support it, we no longer error out. Instead we do not enable it in the host. Change the output from printf to debug as this isn't an error but only additional information now.

Queued for rpi-next

Quoted 21 lines

---

 drivers/mmc/sdhci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/mmc/sdhci.c +2 -2
index 6e8f6e3d17..8bb4393ce1 100644
@@ -744,8 +744,8 @@ int sdhci_setup_cfg(struct mmc_config *cfg, struct sdhci_host *host,
 	if ((caps & SDHCI_CAN_DO_SDMA)) {
 		host->flags |= USE_SDMA;
 	} else {
-		printf("%s: Your controller doesn't support SDMA!!\n",
-		       __func__);
+		debug("%s: Your controller doesn't support SDMA!!\n",
+		      __func__);
 	}
 #endif
 #if CONFIG_IS_ENABLED(MMC_SDHCI_ADMA)