drm/i915: Media freq factor and per-gt enhancements/fixes
Subsystems (3)
v4 cover drm/i915: Media freq factor and per-gt enhancements/fixes
Some recent Intel dGfx platforms allow media IP to work at a different frequency from the base GT. This patch series exposes sysfs controls for this functionality in the new per-gt sysfs. Some enhancements and fixes to previous per-gt functionality are also included to complete the new functionality:
* Patches 1 and 2 implement basic sysfs controls for media freq
* Patch 3 extends previous pcode functions for multiple gt's and patch 4 adds a couple of pcode helpers
* Patch 5 uses the new pcode functions to retrieve media RP0/RPn freq
* Patch 6 fixes memory leaks in the previous per-gt sysfs implementation and some code refactoring
* Patch 7 creates a gt/gtN/.defaults directory to expose default RPS parameter values in the per-gt sysfs
* Patch 8 adds the default value for media_freq_factor to gt/gtN/.defaults
IGT tests for this new functionality have also been posted at:
https://patchwork.freedesktop.org/series/103107/
Test-with: [email protected]
v2: Fixed commit author on patches 5 and 6 (Rodrigo)
Added new patch 4
v3: Expose pcode functions in terms of uncore rather than gt (Jani/Rodrigo)
v4: Retain previous pcode function names to eliminate
needless #defines (Rodrigo)
Ashutosh Dixit (6):
drm/i915: Introduce has_media_ratio_mode
drm/i915/gt: Add media freq factor to per-gt sysfs drm/i915/pcode: Extend pcode functions for multiple gt's drm/i915/gt: Fix memory leaks in per-gt sysfs drm/i915/gt: Expose per-gt RPS defaults in sysfs drm/i915/gt: Expose default value for media_freq_factor in per-gt
sysfs
Dale B Stimson (2):
drm/i915/pcode: Add a couple of pcode helpers
drm/i915/gt: Add media RP0/RPn to per-gt sysfs
drivers/gpu/drm/i915/display/hsw_ips.c | 4 +- drivers/gpu/drm/i915/display/intel_bw.c | 6 +- drivers/gpu/drm/i915/display/intel_cdclk.c | 16 +- .../drm/i915/display/intel_display_power.c | 2 +- .../i915/display/intel_display_power_well.c | 4 +- drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +- drivers/gpu/drm/i915/gt/intel_gt.c | 1 + drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 4 +- drivers/gpu/drm/i915/gt/intel_gt_regs.h | 1 + drivers/gpu/drm/i915/gt/intel_gt_sysfs.c | 35 ++- drivers/gpu/drm/i915/gt/intel_gt_sysfs.h | 12 +- drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 246 ++++++++++++++++++ drivers/gpu/drm/i915/gt/intel_gt_types.h | 14 + drivers/gpu/drm/i915/gt/intel_llc.c | 3 +- drivers/gpu/drm/i915/gt/intel_rc6.c | 4 +- drivers/gpu/drm/i915/gt/intel_rps.c | 7 +- drivers/gpu/drm/i915/gt/selftest_llc.c | 2 +- drivers/gpu/drm/i915/gt/selftest_rps.c | 2 +- .../drm/i915/gt/uc/abi/guc_actions_slpc_abi.h | 6 + drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 39 ++- drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.h | 1 + .../gpu/drm/i915/gt/uc/intel_guc_slpc_types.h | 3 + drivers/gpu/drm/i915/i915_driver.c | 20 +- drivers/gpu/drm/i915/i915_drv.h | 2 + drivers/gpu/drm/i915/i915_pci.c | 2 + drivers/gpu/drm/i915/i915_reg.h | 11 + drivers/gpu/drm/i915/i915_sysfs.c | 2 + drivers/gpu/drm/i915/intel_device_info.h | 1 + drivers/gpu/drm/i915/intel_dram.c | 2 +- drivers/gpu/drm/i915/intel_pcode.c | 92 ++++--- drivers/gpu/drm/i915/intel_pcode.h | 20 +- drivers/gpu/drm/i915/intel_pm.c | 10 +- 32 files changed, 473 insertions(+), 103 deletions(-)
Signature · 1 line
2.34.1
PATCH v4 1/8 drm/i915: Introduce has_media_ratio_mode
Media ratio mode (the ability for media IP to work at a different frequency from the GT) is available for a subset of dGfx platforms supporting GuC/SLPC. Introduce 'has_media_ratio_mode' flag in intel_device_info to identify these platforms and set it for XEHPSDV and DG2/ATS-M.
--- drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/i915_pci.c | 2 ++ drivers/gpu/drm/i915/intel_device_info.h | 1 + 3 files changed, 5 insertions(+)
drivers/gpu/drm/i915/i915_drv.h +2 -0
@@ -1227,6 +1227,8 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,#define CCS_MASK (gt) \ ENGINE_INSTANCES_MASK(gt, CCS0, I915_MAX_CCS) +#define HAS_MEDIA_RATIO_MODE (dev_priv) (INTEL_INFO(dev_priv)->has_media_ratio_mode) +/* * The Gen7 cmdparser copies the scanned buffer to the ggtt for execution * All later gens can run the final buffer from the ppgtt
drivers/gpu/drm/i915/i915_pci.c +2 -0
@@ -1033,6 +1033,7 @@ static const struct intel_device_info xehpsdv_info = { .display = { }, .has_64k_pages = 1, .needs_compact_pt = 1, + .has_media_ratio_mode = 1, .platform_engine_mask =BIT (RCS0 ) |BIT (BCS0 ) | BIT(VECS0) | BIT(VECS1) | BIT(VECS2) | BIT(VECS3) |
@@ -1053,6 +1054,7 @@ static const struct intel_device_info xehpsdv_info = { .has_guc_deprivilege = 1, \ .has_heci_pxp = 1, \ .needs_compact_pt = 1, \ + .has_media_ratio_mode = 1, \ .platform_engine_mask = \BIT (RCS0 ) |BIT (BCS0 ) | \ BIT(VECS0) | BIT(VECS1) | \
drivers/gpu/drm/i915/intel_device_info.h +1 -0
@@ -153,6 +153,7 @@ enum intel_ppgtt_type {func (has_llc); \func (has_logical_ring_contexts); \func (has_logical_ring_elsq); \ +func (has_media_ratio_mode); \func (has_mslices); \func (has_pooled_eu); \func (has_pxp); \
Signature · 1 line
2.34.1
PATCH v4 2/8 drm/i915/gt: Add media freq factor to per-gt sysfs
In reply to Ashutosh DixitExpose new sysfs to program and retrieve media freq factor. Factor values of 0 (dynamic), 0.5 and 1.0 are supported via a u8.8 fixed point representation (corresponding to integer values of 0, 128 and 256 respectively).
Media freq factor is converted to media_ratio_mode for GuC. It is programmed into GuC using H2G SLPC interface. It is retrieved from GuC through a register read. A cached media_ratio_mode is maintained to preserve set values across GuC resets.
This patch adds the following sysfs files to gt/gtN sysfs:
* media_freq_factor
* media_freq_factor.scale
--- drivers/gpu/drm/i915/gt/intel_gt_regs.h | 1 + drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 130 ++++++++++++++++++ .../drm/i915/gt/uc/abi/guc_actions_slpc_abi.h | 6 + drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 20 +++ drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.h | 1 + .../gpu/drm/i915/gt/uc/intel_guc_slpc_types.h | 3 + 6 files changed, 161 insertions(+)
drivers/gpu/drm/i915/gt/intel_gt_regs.h +1 -0
@@ -732,6 +732,7 @@#define GEN6_AGGRESSIVE_TURBO (0 << 15)#define GEN9_SW_REQ_UNSLICE_RATIO_SHIFT 23#define GEN9_IGNORE_SLICE_RATIO (0 << 0) +#define GEN12_MEDIA_FREQ_RATIO REG_BIT(13)#define GEN6_RC_VIDEO_FREQ _MMIO(0xa00c)#define GEN6_RC_CTL_RC6pp_ENABLE (1 << 16)
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c +130 -0
140 lines not on this page · raw message
drivers/gpu/drm/i915/gt/uc/abi/guc_actions_slpc_abi.h +6 -0
@@ -122,6 +122,12 @@ enum slpc_param_id { SLPC_MAX_PARAM = 32, }; +enum slpc_media_ratio_mode { +SLPC_MEDIA_RATIO_MODE_DYNAMIC_CONTROL =0 , +SLPC_MEDIA_RATIO_MODE_FIXED_ONE_TO_ONE =1 , +SLPC_MEDIA_RATIO_MODE_FIXED_ONE_TO_TWO =2 , +}; +enum slpc_event_id {SLPC_EVENT_RESET =0 ,SLPC_EVENT_SHUTDOWN =1 ,
drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c +20 -0
@@ -260,6 +260,7 @@ int intel_guc_slpc_init(struct intel_guc_slpc *slpc) slpc->boost_freq =0 ;atomic_set (&slpc->num_waiters,0 ); slpc->num_boosts =0 ; + slpc->media_ratio_mode =SLPC_MEDIA_RATIO_MODE_DYNAMIC_CONTROL ;mutex_init (&slpc->lock);INIT_WORK (&slpc->boost_work, slpc_boost_work);
@@ -506,6 +507,22 @@ int intel_guc_slpc_get_min_freq(struct intel_guc_slpc *slpc, u32 *val)return ret; } +int intel_guc_slpc_set_media_ratio_mode (struct intel_guc_slpc *slpc,u32 val) +{ +struct drm_i915_private *i915 =slpc_to_i915 (slpc); +intel_wakeref_t wakeref; +int ret =0 ; + +if (!HAS_MEDIA_RATIO_MODE (i915)) +return -ENODEV ; + +with_intel_runtime_pm (&i915->runtime_pm, wakeref) + ret = slpc_set_param(slpc, +SLPC_PARAM_MEDIA_FF_RATIO_MODE , + val); +return ret; +} +void intel_guc_pm_intrmsk_enable (struct intel_gt *gt) {u32 pm_intrmsk_mbz =0 ;
@@ -654,6 +671,9 @@ int intel_guc_slpc_enable(struct intel_guc_slpc *slpc)return ret; } +/* Set cached media freq ratio mode */ +intel_guc_slpc_set_media_ratio_mode (slpc, slpc->media_ratio_mode); +return 0 ; }
drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.h +1 -0
@@ -38,6 +38,7 @@ int intel_guc_slpc_set_boost_freq(struct intel_guc_slpc *slpc, u32 val);int intel_guc_slpc_get_max_freq (struct intel_guc_slpc *slpc,u32 *val);int intel_guc_slpc_get_min_freq (struct intel_guc_slpc *slpc,u32 *val);int intel_guc_slpc_print_info (struct intel_guc_slpc *slpc,struct drm_printer *p); +int intel_guc_slpc_set_media_ratio_mode (struct intel_guc_slpc *slpc,u32 val);void intel_guc_pm_intrmsk_enable (struct intel_gt *gt);void intel_guc_slpc_boost (struct intel_guc_slpc *slpc);void intel_guc_slpc_dec_waiters (struct intel_guc_slpc *slpc);
drivers/gpu/drm/i915/gt/uc/intel_guc_slpc_types.h +3 -0
@@ -29,6 +29,9 @@ struct intel_guc_slpc {u32 min_freq_softlimit;u32 max_freq_softlimit; +/* cached media ratio mode */ +u32 media_ratio_mode; +/* Protects set/reset of boost freq * and value of num_waiters */
Signature · 1 line
2.34.1
Re: [Intel-gfx] [PATCH 2/8] drm/i915/gt: Add media freq factor to per-gt sysfs
Quoted 174 lines · Ashutosh Dixit
Expose new sysfs to program and retrieve media freq factor. Factor values of 0 (dynamic), 0.5 and 1.0 are supported via a u8.8 fixed point representation (corresponding to integer values of 0, 128 and 256 respectively).
Media freq factor is converted to
media_ratio_modefor GuC. It is programmed into GuC using H2G SLPC interface. It is retrieved from GuC through a register read. A cachedmedia_ratio_modeis maintained to preserve set values across GuC resets.This patch adds the following sysfs files to gt/gtN sysfs:
*media_freq_factor
* media_freq_factor.scaleCc Joonas Lahtinen <[email protected]>Signed-off-by Dale B Stimson <[email protected]>Signed-off-by Ashutosh Dixit <[email protected]>Reviewed-by Andi Shyti <[email protected]>Reviewed-by Rodrigo Vivi <[email protected]>--- drivers/gpu/drm/i915/gt/intel_gt_regs.h | 1 + drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 130 ++++++++++++++++++ .../drm/i915/gt/uc/abi/guc_actions_slpc_abi.h | 6 + drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 20 +++ drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.h | 1 + .../gpu/drm/i915/gt/uc/intel_guc_slpc_types.h | 3 + 6 files changed, 161 insertions(+)drivers/gpu/drm/i915/gt/intel_gt_regs.h +1
-0@@ -732,6 +732,7 @@#define GEN6_AGGRESSIVE_TURBO (0 << 15)#define GEN9_SW_REQ_UNSLICE_RATIO_SHIFT 23#define GEN9_IGNORE_SLICE_RATIO (0 << 0) +#define GEN12_MEDIA_FREQ_RATIO REG_BIT(13)#define GEN6_RC_VIDEO_FREQ _MMIO(0xa00c)#define GEN6_RC_CTL_RC6pp_ENABLE (1 << 16)drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c +122
-0@@ -557,6 +557,128 @@ static const struct attribute *freq_attrs[] = {NULL }; +/* +* Scaling for multipliers (aka frequency factors). +* The format of the value in the register is u8.8. +* +* The presentation to userspace is inspired by the perf event framework. +* See: +* Documentation/ABI/testing/sysfs-bus-event_source-devices-events +* for description of: +* /sys/bus/event_source/devices/<pmu>/events/<event>.scale +* +* Summary: Expose two sysfs files for each multiplier. +* +* 1. File <attr> contains a raw hardware value. +* 2. File <attr>.scale contains the multiplicative scale factor to be +* used by userspace to compute the actual value. +* +* So userspace knows that to get the frequency_factor it multiplies the +* provided value by the specified scale factor and vice-versa. +* +* That way there is no precision loss in the kernel interface and API +* is future proof should one day the hardware register change to u16.u16, +* on some platform. (Or any other fixed point representation.) +* +* Example: +* File <attr> contains the value 2.5, represented as u8.8 0x0280, which +* is comprised of: +* - an integer part of 2 +* - a fractional part of 0x80 (representing 0x80 / 2^8 == 0x80 / 256). +* File <attr>.scale contains a string representation of floating point +* value 0.00390625 (which is (1 / 256)). +* Userspace computes the actual value: +* 0x0280 * 0.00390625 -> 2.5 +* or converts an actual value to the value to be written into <attr>: +* 2.5 / 0.00390625 -> 0x0280 +*/ + +#define U8_8_VAL_MASK 0xffff +#define U8_8_SCALE_TO_VALUE "0.00390625" + +static ssize_t freq_factor_scale_show (struct device *dev, +struct device_attribute *attr, +char *buff) +{ +return sysfs_emit (buff,"%s\n" ,U8_8_SCALE_TO_VALUE ); +} + +static u32 media_ratio_mode_to_factor (u32 mode) +{ +/* 0 -> 0, 1 -> 256, 2 -> 128 */ +return !mode ? mode :256 / mode; +} + +static ssize_t media_freq_factor_show (struct device *dev, +struct device_attribute *attr, +char *buff) +{ +struct intel_gt *gt =intel_gt_sysfs_get_drvdata (dev, attr->attr.name); +struct intel_guc_slpc *slpc = >->uc.guc.slpc; +intel_wakeref_t wakeref; +u32 mode; + +/* +* Retrieve media_ratio_mode from GEN6_RPNSWREQ bit 13 set by +* GuC. GEN6_RPNSWREQ:13 value 0 represents 1:2 and 1 represents 1:1 +*/ +if (IS_XEHPSDV (gt->i915) && + slpc->media_ratio_mode ==SLPC_MEDIA_RATIO_MODE_DYNAMIC_CONTROL ) { +/* +* For XEHPSDV dynamic mode GEN6_RPNSWREQ:13 does not contain +* the media_ratio_mode, just return the cached media ratio +*/ + mode = slpc->media_ratio_mode; + }else { +with_intel_runtime_pm (gt->uncore->rpm, wakeref) + mode = intel_uncore_read(gt->uncore, GEN6_RPNSWREQ); + mode =REG_FIELD_GET (GEN12_MEDIA_FREQ_RATIO , mode) ? +SLPC_MEDIA_RATIO_MODE_FIXED_ONE_TO_ONE : +SLPC_MEDIA_RATIO_MODE_FIXED_ONE_TO_TWO ; + } + +return sysfs_emit (buff,"%u\n" ,media_ratio_mode_to_factor (mode)); +} + +static ssize_t media_freq_factor_store (struct device *dev, +struct device_attribute *attr, +const char *buff,size_t count) +{ +struct intel_gt *gt =intel_gt_sysfs_get_drvdata (dev, attr->attr.name); +struct intel_guc_slpc *slpc = >->uc.guc.slpc; +u32 factor, mode; +int err; + + err =kstrtou32 (buff,0 , &factor); +if (err) +return err; + +for (mode =SLPC_MEDIA_RATIO_MODE_DYNAMIC_CONTROL ; + mode <=SLPC_MEDIA_RATIO_MODE_FIXED_ONE_TO_TWO ; mode++) +if (factor ==media_ratio_mode_to_factor (mode)) +break ; + +if (mode >SLPC_MEDIA_RATIO_MODE_FIXED_ONE_TO_TWO ) +return -EINVAL ; + + err =intel_guc_slpc_set_media_ratio_mode (slpc, mode); +if (!err) { + slpc->media_ratio_mode = mode; +DRM_DEBUG ("Set slpc->media_ratio_mode to %d" , mode); + } +return err ?: count; +} + +static DEVICE_ATTR_RW (media_freq_factor); +static struct device_attribute dev_attr_media_freq_factor_scale = +__ATTR (media_freq_factor.scale,0444 , freq_factor_scale_show,NULL ); + +static const struct attribute *media_perf_power_attrs[] = { + &dev_attr_media_freq_factor.attr, + &dev_attr_media_freq_factor_scale.attr, +NULL +}; +static int intel_sysfs_rps_init (struct intel_gt *gt,struct kobject *kobj,const struct attribute *const *attrs) {
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c void intel_gt_sysfs_pm_init(struct intel_gt *gt, struct kobject *kobj) · line 728
Quoted 9 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c +6
-0@@ -598,4 +720,12 @@ void intel_gt_sysfs_pm_init(struct intel_gt *gt, struct kobject *kobj)drm_warn (>->i915->drm,"failed to create gt%u throttle sysfs files (%pe)" , gt->info.id,ERR_PTR (ret)); + +if (HAS_MEDIA_RATIO_MODE (gt->i915) &&intel_uc_uses_guc_slpc (>->uc)) { + ret =sysfs_create_files (kobj, media_perf_power_attrs); +if (ret) + drm_warn(>->i915->drm, + "failed to create add gt%u media_perf_power_attrs sysfs (%pe)\n",
Nit - "create add" - pick one?
Regards,
Tvrtko
Quoted 91 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c +2
-0+ gt->info.id, ERR_PTR(ret)); + } }drivers/gpu/drm/i915/gt/uc/abi/guc_actions_slpc_abi.h +6
-0@@ -122,6 +122,12 @@ enum slpc_param_id { SLPC_MAX_PARAM = 32, }; +enum slpc_media_ratio_mode { +SLPC_MEDIA_RATIO_MODE_DYNAMIC_CONTROL =0 , +SLPC_MEDIA_RATIO_MODE_FIXED_ONE_TO_ONE =1 , +SLPC_MEDIA_RATIO_MODE_FIXED_ONE_TO_TWO =2 , +}; +enum slpc_event_id {SLPC_EVENT_RESET =0 ,SLPC_EVENT_SHUTDOWN =1 ,drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c +20
-0@@ -260,6 +260,7 @@ int intel_guc_slpc_init(struct intel_guc_slpc *slpc) slpc->boost_freq =0 ;atomic_set (&slpc->num_waiters,0 ); slpc->num_boosts =0 ; + slpc->media_ratio_mode =SLPC_MEDIA_RATIO_MODE_DYNAMIC_CONTROL ;mutex_init (&slpc->lock);INIT_WORK (&slpc->boost_work, slpc_boost_work);@@ -506,6 +507,22 @@ int intel_guc_slpc_get_min_freq(struct intel_guc_slpc *slpc, u32 *val)return ret; } +int intel_guc_slpc_set_media_ratio_mode (struct intel_guc_slpc *slpc,u32 val) +{ +struct drm_i915_private *i915 =slpc_to_i915 (slpc); +intel_wakeref_t wakeref; +int ret =0 ; + +if (!HAS_MEDIA_RATIO_MODE (i915)) +return -ENODEV ; + +with_intel_runtime_pm (&i915->runtime_pm, wakeref) + ret = slpc_set_param(slpc, +SLPC_PARAM_MEDIA_FF_RATIO_MODE , + val); +return ret; +} +void intel_guc_pm_intrmsk_enable (struct intel_gt *gt) {u32 pm_intrmsk_mbz =0 ;@@ -654,6 +671,9 @@ int intel_guc_slpc_enable(struct intel_guc_slpc *slpc)return ret; } +/* Set cached media freq ratio mode */ +intel_guc_slpc_set_media_ratio_mode (slpc, slpc->media_ratio_mode); +return 0 ; }drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.h +1
-0@@ -38,6 +38,7 @@ int intel_guc_slpc_set_boost_freq(struct intel_guc_slpc *slpc, u32 val);int intel_guc_slpc_get_max_freq (struct intel_guc_slpc *slpc,u32 *val);int intel_guc_slpc_get_min_freq (struct intel_guc_slpc *slpc,u32 *val);int intel_guc_slpc_print_info (struct intel_guc_slpc *slpc,struct drm_printer *p); +int intel_guc_slpc_set_media_ratio_mode (struct intel_guc_slpc *slpc,u32 val);void intel_guc_pm_intrmsk_enable (struct intel_gt *gt);void intel_guc_slpc_boost (struct intel_guc_slpc *slpc);void intel_guc_slpc_dec_waiters (struct intel_guc_slpc *slpc);drivers/gpu/drm/i915/gt/uc/intel_guc_slpc_types.h +3
-0@@ -29,6 +29,9 @@ struct intel_guc_slpc {u32 min_freq_softlimit;u32 max_freq_softlimit; +/* cached media ratio mode */ +u32 media_ratio_mode; +/* Protects set/reset of boost freq * and value of num_waiters */
Re: [Intel-gfx] [PATCH 2/8] drm/i915/gt: Add media freq factor to per-gt sysfs
Quoted 13 lines · Tvrtko Ursulin
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c void intel_gt_sysfs_pm_init(struct intel_gt *gt, struct kobject *kobj) · line 728
Quoted 11 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c +6
-0@@ -598,4 +720,12 @@ void intel_gt_sysfs_pm_init(struct intel_gt *gt, struct kobject *kobj)drm_warn (>->i915->drm,"failed to create gt%u throttle sysfs files (%pe)" , gt->info.id,ERR_PTR (ret)); + +if (HAS_MEDIA_RATIO_MODE (gt->i915) &&intel_uc_uses_guc_slpc (>->uc)) { + ret =sysfs_create_files (kobj, media_perf_power_attrs); +if (ret) + drm_warn(>->i915->drm, + "failed to create add gt%u media_perf_power_attrs sysfs (%pe)\n",Nit - "create add" - pick one?
Fixed in Patch v2 (Series v5).
PATCH v4 3/8 drm/i915/pcode: Extend pcode functions for multiple gt's
In reply to Ashutosh DixitEach gt contains an independent instance of pcode. Extend pcode functions to interface with pcode on different gt's. To avoid creating dependency of display functionality on intel_gt, pcode function interfaces are exposed in terms of uncore rather than intel_gt. Callers have been converted to pass in the appropritate (i915 or intel_gt) uncore to the pcode functions.
v2: Expose pcode functions in terms of uncore rather than gt (Jani/Rodrigo)
v3: Retain previous function names to eliminate needless #defines (Rodrigo)
--- drivers/gpu/drm/i915/display/hsw_ips.c | 4 +- drivers/gpu/drm/i915/display/intel_bw.c | 6 +- drivers/gpu/drm/i915/display/intel_cdclk.c | 16 ++--- .../drm/i915/display/intel_display_power.c | 2 +- .../i915/display/intel_display_power_well.c | 4 +- drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +- drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 4 +- drivers/gpu/drm/i915/gt/intel_llc.c | 3 +- drivers/gpu/drm/i915/gt/intel_rc6.c | 4 +- drivers/gpu/drm/i915/gt/intel_rps.c | 4 +- drivers/gpu/drm/i915/gt/selftest_llc.c | 2 +- drivers/gpu/drm/i915/gt/selftest_rps.c | 2 +- drivers/gpu/drm/i915/i915_driver.c | 20 ++++++- drivers/gpu/drm/i915/intel_dram.c | 2 +- drivers/gpu/drm/i915/intel_pcode.c | 60 +++++++++---------- drivers/gpu/drm/i915/intel_pcode.h | 14 ++--- drivers/gpu/drm/i915/intel_pm.c | 10 ++-- 17 files changed, 86 insertions(+), 73 deletions(-)
drivers/gpu/drm/i915/display/hsw_ips.c +2 -2
@@ -28,7 +28,7 @@ static void hsw_ips_enable(const struct intel_crtc_state *crtc_state)if (IS_BROADWELL (i915)) {drm_WARN_ON (&i915->drm, -snb_pcode_write (i915,DISPLAY_IPS_CONTROL , +snb_pcode_write (&i915->uncore,DISPLAY_IPS_CONTROL ,IPS_ENABLE |IPS_PCODE_CONTROL ));/* * Quoting Art Runyan: "its not safe to expect any particular
@@ -62,7 +62,7 @@ bool hsw_ips_disable(const struct intel_crtc_state *crtc_state)if (IS_BROADWELL (i915)) {drm_WARN_ON (&i915->drm, -snb_pcode_write (i915,DISPLAY_IPS_CONTROL ,0 )); +snb_pcode_write (&i915->uncore,DISPLAY_IPS_CONTROL ,0 ));/* * Wait for PCODE to finish disabling IPS. The BSpec specified * 42ms timeout value leads to occasional timeouts so use 100ms
drivers/gpu/drm/i915/display/intel_bw.c +3 -3
@@ -78,7 +78,7 @@ static int icl_pcode_read_qgv_point_info(struct drm_i915_private *dev_priv,u16 dclk;int ret; - ret =snb_pcode_read (dev_priv,ICL_PCODE_MEM_SUBSYSYSTEM_INFO | + ret =snb_pcode_read (&dev_priv->uncore,ICL_PCODE_MEM_SUBSYSYSTEM_INFO |ICL_PCODE_MEM_SS_READ_QGV_POINT_INFO (point), &val, &val2);if (ret)
@@ -104,7 +104,7 @@ static int adls_pcode_read_psf_gv_point_info(struct drm_i915_private *dev_priv,int ret;int i; - ret =snb_pcode_read (dev_priv,ICL_PCODE_MEM_SUBSYSYSTEM_INFO | + ret =snb_pcode_read (&dev_priv->uncore,ICL_PCODE_MEM_SUBSYSYSTEM_INFO |ADL_PCODE_MEM_SS_READ_PSF_GV_INFO , &val,NULL );if (ret)return ret;
@@ -123,7 +123,7 @@ int icl_pcode_restrict_qgv_points(struct drm_i915_private *dev_priv,int ret;/* bspec says to keep retrying for at least 1 ms */ - ret = skl_pcode_request(dev_priv, ICL_PCODE_SAGV_DE_MEM_SS_CONFIG, + ret = skl_pcode_request(&dev_priv->uncore, ICL_PCODE_SAGV_DE_MEM_SS_CONFIG, points_mask, ICL_PCODE_REP_QGV_MASK | ADLS_PCODE_REP_PSF_MASK, ICL_PCODE_REP_QGV_SAFE | ADLS_PCODE_REP_PSF_SAFE,
drivers/gpu/drm/i915/display/intel_cdclk.c +8 -8
@@ -800,7 +800,7 @@ static void bdw_set_cdclk(struct drm_i915_private *dev_priv, "trying to change cdclk frequency with cdclk not enabled\n")) return; - ret =snb_pcode_write (dev_priv,BDW_PCODE_DISPLAY_FREQ_CHANGE_REQ ,0x0 ); + ret =snb_pcode_write (&dev_priv->uncore,BDW_PCODE_DISPLAY_FREQ_CHANGE_REQ ,0x0 );if (ret) {drm_err (&dev_priv->drm,"failed to inform pcode about cdclk change\n" );
@@ -828,7 +828,7 @@ static void bdw_set_cdclk(struct drm_i915_private *dev_priv, LCPLL_CD_SOURCE_FCLK_DONE) == 0, 1))drm_err (&dev_priv->drm,"Switching back to LCPLL failed\n" ); -snb_pcode_write (dev_priv,HSW_PCODE_DE_WRITE_FREQ_REQ , +snb_pcode_write (&dev_priv->uncore,HSW_PCODE_DE_WRITE_FREQ_REQ , cdclk_config->voltage_level); intel_de_write(dev_priv, CDCLK_FREQ,
@@ -1086,7 +1086,7 @@ static void skl_set_cdclk(struct drm_i915_private *dev_priv,drm_WARN_ON_ONCE (&dev_priv->drm,IS_SKYLAKE (dev_priv) && vco ==8640000 ); - ret =skl_pcode_request (dev_priv,SKL_PCODE_CDCLK_CONTROL , + ret =skl_pcode_request (&dev_priv->uncore,SKL_PCODE_CDCLK_CONTROL ,SKL_CDCLK_PREPARE_FOR_CHANGE ,SKL_CDCLK_READY_FOR_CHANGE ,SKL_CDCLK_READY_FOR_CHANGE ,3 );
@@ -1132,7 +1132,7 @@ static void skl_set_cdclk(struct drm_i915_private *dev_priv,intel_de_posting_read (dev_priv,CDCLK_CTL );/* inform PCU of the change */ -snb_pcode_write (dev_priv,SKL_PCODE_CDCLK_CONTROL , +snb_pcode_write (&dev_priv->uncore,SKL_PCODE_CDCLK_CONTROL , cdclk_config->voltage_level);intel_update_cdclk (dev_priv);
@@ -1702,7 +1702,7 @@ static void bxt_set_cdclk(struct drm_i915_private *dev_priv,/* Inform power controller of upcoming frequency change. */ if (DISPLAY_VER (dev_priv) >=11 ) - ret =skl_pcode_request (dev_priv,SKL_PCODE_CDCLK_CONTROL , + ret =skl_pcode_request (&dev_priv->uncore,SKL_PCODE_CDCLK_CONTROL ,SKL_CDCLK_PREPARE_FOR_CHANGE ,SKL_CDCLK_READY_FOR_CHANGE ,SKL_CDCLK_READY_FOR_CHANGE ,3 );
@@ -1711,7 +1711,7 @@ static void bxt_set_cdclk(struct drm_i915_private *dev_priv,* BSpec requires us to wait up to 150usec, but that leads to * timeouts; the 2ms used here is based on experiment. */ - ret =snb_pcode_write_timeout (dev_priv, + ret =snb_pcode_write_timeout (&dev_priv->uncore,HSW_PCODE_DE_WRITE_FREQ_REQ ,0x80000000 ,150 ,2 );if (ret) {
@@ -1774,7 +1774,7 @@ static void bxt_set_cdclk(struct drm_i915_private *dev_priv,intel_crtc_wait_for_next_vblank (intel_crtc_for_pipe (dev_priv, pipe));if (DISPLAY_VER (dev_priv) >=11 ) { - ret =snb_pcode_write (dev_priv,SKL_PCODE_CDCLK_CONTROL , + ret =snb_pcode_write (&dev_priv->uncore,SKL_PCODE_CDCLK_CONTROL , cdclk_config->voltage_level); }else {/*
@@ -1783,7 +1783,7 @@ static void bxt_set_cdclk(struct drm_i915_private *dev_priv,* FIXME: Waiting for the request completion could be delayed * until the next PCODE request based on BSpec. */ - ret =snb_pcode_write_timeout (dev_priv, + ret =snb_pcode_write_timeout (&dev_priv->uncore,HSW_PCODE_DE_WRITE_FREQ_REQ , cdclk_config->voltage_level,150 ,2 );
drivers/gpu/drm/i915/display/intel_display_power.c +1 -1
@@ -1194,7 +1194,7 @@ static u32 hsw_read_dcomp(struct drm_i915_private *dev_priv)static void hsw_write_dcomp (struct drm_i915_private *dev_priv,u32 val) {if (IS_HASWELL (dev_priv)) { -if (snb_pcode_write (dev_priv,GEN6_PCODE_WRITE_D_COMP , val)) +if (snb_pcode_write (&dev_priv->uncore,GEN6_PCODE_WRITE_D_COMP , val))drm_dbg_kms (&dev_priv->drm,"Failed to write to D_COMP\n" ); }else {
drivers/gpu/drm/i915/display/intel_display_power_well.c +2 -2
@@ -474,7 +474,7 @@ static void icl_tc_cold_exit(struct drm_i915_private *i915)int ret, tries =0 ;while (1 ) { - ret =snb_pcode_write_timeout (i915,ICL_PCODE_EXIT_TCCOLD ,0 , + ret =snb_pcode_write_timeout (&i915->uncore,ICL_PCODE_EXIT_TCCOLD ,0 ,250 ,1 );if (ret != -EAGAIN || ++tries ==3 )break ;
@@ -1739,7 +1739,7 @@ tgl_tc_cold_request(struct drm_i915_private *i915, bool block)* Spec states that we should timeout the request after 200us * but the function below will timeout after 500us */ - ret =snb_pcode_read (i915,TGL_PCODE_TCCOLD , &low_val, &high_val); + ret =snb_pcode_read (&i915->uncore,TGL_PCODE_TCCOLD , &low_val, &high_val);if (ret ==0 ) {if (block && (low_val &TGL_PCODE_EXIT_TCCOLD_DATA_L_EXIT_FAILED ))
drivers/gpu/drm/i915/display/intel_hdcp.c +1 -1
@@ -298,7 +298,7 @@ static int intel_hdcp_load_keys(struct drm_i915_private *dev_priv)* Mailbox interface. */ if (DISPLAY_VER (dev_priv) ==9 && !IS_BROXTON (dev_priv)) { - ret =snb_pcode_write (dev_priv,SKL_PCODE_LOAD_HDCP_KEYS ,1 ); + ret =snb_pcode_write (&dev_priv->uncore,SKL_PCODE_LOAD_HDCP_KEYS ,1 );if (ret) { drm_err(&dev_priv->drm, "Failed to initiate HDCP key load (%d)\n",
drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c +2 -2
@@ -138,7 +138,7 @@ static int gen6_drpc(struct seq_file *m) }if (GRAPHICS_VER (i915) <=7 ) -snb_pcode_read (i915,GEN6_PCODE_READ_RC6VIDS , &rc6vids,NULL ); +snb_pcode_read (gt->uncore,GEN6_PCODE_READ_RC6VIDS , &rc6vids,NULL );seq_printf (m,"RC1e Enabled: %s\n" ,str_yes_no (rcctl1 & GEN6_RC_CTL_RC1e_ENABLE));
@@ -545,7 +545,7 @@ static int llc_show(struct seq_file *m, void *data) wakeref =intel_runtime_pm_get (gt->uncore->rpm);for (gpu_freq = min_gpu_freq; gpu_freq <= max_gpu_freq; gpu_freq++) { ia_freq = gpu_freq; -snb_pcode_read (i915,GEN6_PCODE_READ_MIN_FREQ_TABLE , +snb_pcode_read (gt->uncore,GEN6_PCODE_READ_MIN_FREQ_TABLE , &ia_freq,NULL ); seq_printf(m, "%d\t\t%d\t\t\t\t%d\n", intel_gpu_freq(rps,
drivers/gpu/drm/i915/gt/intel_llc.c +1 -2
@@ -124,7 +124,6 @@ static void calc_ia_freq(struct intel_llc *llc,static void gen6_update_ring_freq (struct intel_llc *llc) { -struct drm_i915_private *i915 =llc_to_gt (llc)->i915;struct ia_constants consts;unsigned int gpu_freq;
@@ -142,7 +141,7 @@ static void gen6_update_ring_freq(struct intel_llc *llc)unsigned int ia_freq, ring_freq;calc_ia_freq (llc, gpu_freq, &consts, &ia_freq, &ring_freq); -snb_pcode_write (i915,GEN6_PCODE_WRITE_MIN_FREQ_TABLE , +snb_pcode_write (llc_to_gt (llc)->uncore,GEN6_PCODE_WRITE_MIN_FREQ_TABLE , ia_freq <<GEN6_PCODE_FREQ_IA_RATIO_SHIFT | ring_freq <<GEN6_PCODE_FREQ_RING_RATIO_SHIFT | gpu_freq);
drivers/gpu/drm/i915/gt/intel_rc6.c +2 -2
@@ -272,7 +272,7 @@ static void gen6_rc6_enable(struct intel_rc6 *rc6)GEN6_RC_CTL_HW_ENABLE ; rc6vids =0 ; - ret =snb_pcode_read (i915,GEN6_PCODE_READ_RC6VIDS , &rc6vids,NULL ); + ret =snb_pcode_read (rc6_to_gt (rc6)->uncore,GEN6_PCODE_READ_RC6VIDS , &rc6vids,NULL );if (GRAPHICS_VER (i915) ==6 && ret) {drm_dbg (&i915->drm,"Couldn't check for BIOS workaround\n" ); } else if (GRAPHICS_VER(i915) == 6 &&
@@ -282,7 +282,7 @@ static void gen6_rc6_enable(struct intel_rc6 *rc6) GEN6_DECODE_RC6_VID(rc6vids & 0xff), 450); rc6vids &=0xffff00 ; rc6vids |=GEN6_ENCODE_RC6_VID (450 ); - ret =snb_pcode_write (i915,GEN6_PCODE_WRITE_RC6VIDS , rc6vids); + ret =snb_pcode_write (rc6_to_gt (rc6)->uncore,GEN6_PCODE_WRITE_RC6VIDS , rc6vids);if (ret)drm_err (&i915->drm,"Couldn't fix incorrect rc6 voltage\n" );
drivers/gpu/drm/i915/gt/intel_rps.c +2 -2
@@ -1142,7 +1142,7 @@ static void gen6_rps_init(struct intel_rps *rps)if (IS_GEN9_BC (i915) ||GRAPHICS_VER (i915) >=11 ) mult =GEN9_FREQ_SCALER ; -if (snb_pcode_read (i915,HSW_PCODE_DYNAMIC_DUTY_CYCLE_CONTROL , +if (snb_pcode_read (rps_to_gt (rps)->uncore,HSW_PCODE_DYNAMIC_DUTY_CYCLE_CONTROL , &ddcc_status,NULL ) ==0 ) rps->efficient_freq = clamp_t(u32,
@@ -1982,7 +1982,7 @@ void intel_rps_init(struct intel_rps *rps)if (GRAPHICS_VER (i915) ==6 ||IS_IVYBRIDGE (i915) ||IS_HASWELL (i915)) {u32 params =0 ; -snb_pcode_read (i915,GEN6_READ_OC_PARAMS , ¶ms,NULL ); +snb_pcode_read (rps_to_gt (rps)->uncore,GEN6_READ_OC_PARAMS , ¶ms,NULL );if (params &BIT (31 )) {/* OC supported */ drm_dbg(&i915->drm, "Overclocking supported, max: %dMHz, overclock: %dMHz\n",
drivers/gpu/drm/i915/gt/selftest_llc.c +1 -1
@@ -31,7 +31,7 @@ static int gen6_verify_ring_freq(struct intel_llc *llc)calc_ia_freq (llc, gpu_freq, &consts, &ia_freq, &ring_freq); val = gpu_freq; -if (snb_pcode_read (i915,GEN6_PCODE_READ_MIN_FREQ_TABLE , +if (snb_pcode_read (llc_to_gt (llc)->uncore,GEN6_PCODE_READ_MIN_FREQ_TABLE , &val,NULL )) {pr_err ("Failed to read freq table[%d], range [%d, %d]\n" , gpu_freq, consts.min_gpu_freq, consts.max_gpu_freq);
drivers/gpu/drm/i915/gt/selftest_rps.c +1 -1
@@ -521,7 +521,7 @@ static void show_pcu_config(struct intel_rps *rps)for (gpu_freq = min_gpu_freq; gpu_freq <= max_gpu_freq; gpu_freq++) {int ia_freq = gpu_freq; -snb_pcode_read (i915,GEN6_PCODE_READ_MIN_FREQ_TABLE , +snb_pcode_read (rps_to_gt (rps)->uncore,GEN6_PCODE_READ_MIN_FREQ_TABLE , &ia_freq,NULL ); pr_info("%5d %5d %5d\n",
drivers/gpu/drm/i915/i915_driver.c +18 -2
@@ -520,6 +520,22 @@ static int i915_set_dma_info(struct drm_i915_private *i915)return ret; } +static int i915_pcode_init (struct drm_i915_private *i915) +{ +struct intel_gt *gt; +int id, ret; + +for_each_gt (gt, i915, id) { + ret =intel_pcode_init (gt->uncore); +if (ret) { +drm_err (>->i915->drm,"gt %d: intel_pcode_init failed %d\n" , id, ret); +return ret; + } + } + +return 0 ; +} +/** * i915_driver_hw_probe - setup state requiring device access * @dev_priv: device private
@@ -629,7 +645,7 @@ static int i915_driver_hw_probe(struct drm_i915_private *dev_priv)intel_opregion_setup (dev_priv); - ret =intel_pcode_init (dev_priv); + ret =i915_pcode_init (dev_priv);if (ret) goto err_msi;
@@ -1251,7 +1267,7 @@ static int i915_drm_resume(struct drm_device *dev)disable_rpm_wakeref_asserts (&dev_priv->runtime_pm); - ret =intel_pcode_init (dev_priv); + ret =i915_pcode_init (dev_priv);if (ret)return ret;
drivers/gpu/drm/i915/intel_dram.c +1 -1
@@ -393,7 +393,7 @@ static int icl_pcode_read_mem_global_info(struct drm_i915_private *dev_priv)u32 val =0 ;int ret; - ret =snb_pcode_read (dev_priv,ICL_PCODE_MEM_SUBSYSYSTEM_INFO | + ret =snb_pcode_read (&dev_priv->uncore,ICL_PCODE_MEM_SUBSYSYSTEM_INFO |ICL_PCODE_MEM_SS_READ_GLOBAL_INFO , &val,NULL );if (ret)return ret;
drivers/gpu/drm/i915/intel_pcode.c +29 -31
152 lines not on this page · raw message
drivers/gpu/drm/i915/intel_pcode.h +7 -7
@@ -8,17 +8,17 @@#include <linux/types.h> -struct drm_i915_private ; +struct intel_uncore ; -int snb_pcode_read (struct drm_i915_private *i915,u32 mbox,u32 *val,u32 *val1); -int snb_pcode_write_timeout (struct drm_i915_private *i915,u32 mbox,u32 val, +int snb_pcode_read (struct intel_uncore *uncore,u32 mbox,u32 *val,u32 *val1); +int snb_pcode_write_timeout (struct intel_uncore *uncore,u32 mbox,u32 val,int fast_timeout_us,int slow_timeout_ms); -#define snb_pcode_write (i915, mbox, val) \ - snb_pcode_write_timeout(i915, mbox, val, 500, 0) +#define snb_pcode_write (uncore, mbox, val) \ + snb_pcode_write_timeout(uncore, mbox, val, 500, 0) -int skl_pcode_request (struct drm_i915_private *i915,u32 mbox,u32 request, +int skl_pcode_request (struct intel_uncore *uncore,u32 mbox,u32 request,u32 reply_mask,u32 reply,int timeout_base_ms); -int intel_pcode_init (struct drm_i915_private *i915); +int intel_pcode_init (struct intel_uncore *uncore);#endif /* _INTEL_PCODE_H */
drivers/gpu/drm/i915/intel_pm.c +5 -5
@@ -2874,7 +2874,7 @@ static void intel_read_wm_latency(struct drm_i915_private *dev_priv,/* read the first set of memory latencies[0:3] */ val =0 ;/* data0 to be programmed to 0 for first set */ - ret =snb_pcode_read (dev_priv,GEN9_PCODE_READ_MEM_LATENCY , + ret =snb_pcode_read (&dev_priv->uncore,GEN9_PCODE_READ_MEM_LATENCY , &val,NULL );if (ret) {
@@ -2893,7 +2893,7 @@ static void intel_read_wm_latency(struct drm_i915_private *dev_priv,/* read the second set of memory latencies[4:7] */ val =1 ;/* data0 to be programmed to 1 for second set */ - ret =snb_pcode_read (dev_priv,GEN9_PCODE_READ_MEM_LATENCY , + ret =snb_pcode_read (&dev_priv->uncore,GEN9_PCODE_READ_MEM_LATENCY , &val,NULL );if (ret) { drm_err(&dev_priv->drm,
@@ -3679,7 +3679,7 @@ intel_sagv_block_time(struct drm_i915_private *dev_priv)u32 val =0 ;int ret; - ret =snb_pcode_read (dev_priv, + ret =snb_pcode_read (&dev_priv->uncore,GEN12_PCODE_READ_SAGV_BLOCK_TIME_US , &val,NULL );if (ret) {
@@ -3748,7 +3748,7 @@ static void skl_sagv_enable(struct drm_i915_private *dev_priv)return ;drm_dbg_kms (&dev_priv->drm,"Enabling SAGV\n" ); - ret =snb_pcode_write (dev_priv,GEN9_PCODE_SAGV_CONTROL , + ret =snb_pcode_write (&dev_priv->uncore,GEN9_PCODE_SAGV_CONTROL ,GEN9_SAGV_ENABLE );/* We don't need to wait for SAGV when enabling */
@@ -3781,7 +3781,7 @@ static void skl_sagv_disable(struct drm_i915_private *dev_priv)drm_dbg_kms (&dev_priv->drm,"Disabling SAGV\n" );/* bspec says to keep retrying for at least 1 ms */ - ret =skl_pcode_request (dev_priv,GEN9_PCODE_SAGV_CONTROL , + ret =skl_pcode_request (&dev_priv->uncore,GEN9_PCODE_SAGV_CONTROL ,GEN9_SAGV_DISABLE ,GEN9_SAGV_IS_DISABLED ,GEN9_SAGV_IS_DISABLED ,1 );
Signature · 1 line
2.34.1
Re: [Intel-gfx] [PATCH 3/8] drm/i915/pcode: Extend pcode functions for multiple gt's
Quoted 6 lines · Ashutosh Dixit
Each gt contains an independent instance of pcode. Extend pcode functions to interface with pcode on different gt's. To avoid creating dependency of display functionality on
intel_gt, pcode function interfaces are exposed in terms of uncore rather thanintel_gt. Callers have been converted to pass in the appropritate (i915 orintel_gt) uncore to the pcode functions.
Quoted 7 lines
v2: Expose pcode functions in terms of uncore rather than gt (Jani/Rodrigo)
v3: Retain previous function names to eliminate needless #defines (Rodrigo)Cc Rodrigo Vivi <[email protected]>Cc Jani Nikula <[email protected]>Cc Andi Shyti <[email protected]>Signed-off-by Ashutosh Dixit <[email protected]>
Quoted 611 lines
--- drivers/gpu/drm/i915/display/hsw_ips.c | 4 +- drivers/gpu/drm/i915/display/intel_bw.c | 6 +- drivers/gpu/drm/i915/display/intel_cdclk.c | 16 ++--- .../drm/i915/display/intel_display_power.c | 2 +- .../i915/display/intel_display_power_well.c | 4 +- drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +- drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 4 +- drivers/gpu/drm/i915/gt/intel_llc.c | 3 +- drivers/gpu/drm/i915/gt/intel_rc6.c | 4 +- drivers/gpu/drm/i915/gt/intel_rps.c | 4 +- drivers/gpu/drm/i915/gt/selftest_llc.c | 2 +- drivers/gpu/drm/i915/gt/selftest_rps.c | 2 +- drivers/gpu/drm/i915/i915_driver.c | 20 ++++++- drivers/gpu/drm/i915/intel_dram.c | 2 +- drivers/gpu/drm/i915/intel_pcode.c | 60 +++++++++---------- drivers/gpu/drm/i915/intel_pcode.h | 14 ++--- drivers/gpu/drm/i915/intel_pm.c | 10 ++-- 17 files changed, 86 insertions(+), 73 deletions(-)drivers/gpu/drm/i915/display/hsw_ips.c +2
-2@@ -28,7 +28,7 @@ static void hsw_ips_enable(const struct intel_crtc_state *crtc_state)if (IS_BROADWELL (i915)) {drm_WARN_ON (&i915->drm, -snb_pcode_write (i915,DISPLAY_IPS_CONTROL , +snb_pcode_write (&i915->uncore,DISPLAY_IPS_CONTROL ,IPS_ENABLE |IPS_PCODE_CONTROL ));/* * Quoting Art Runyan: "its not safe to expect any particular @@ -62,7 +62,7 @@ bool hsw_ips_disable(const struct intel_crtc_state *crtc_state)if (IS_BROADWELL (i915)) {drm_WARN_ON (&i915->drm, -snb_pcode_write (i915,DISPLAY_IPS_CONTROL ,0 )); +snb_pcode_write (&i915->uncore,DISPLAY_IPS_CONTROL ,0 ));/* * Wait for PCODE to finish disabling IPS. The BSpec specified * 42ms timeout value leads to occasional timeouts so use 100ms drivers/gpu/drm/i915/display/intel_bw.c +3
-3@@ -78,7 +78,7 @@ static int icl_pcode_read_qgv_point_info(struct drm_i915_private *dev_priv,u16 dclk;int ret; - ret =snb_pcode_read (dev_priv,ICL_PCODE_MEM_SUBSYSYSTEM_INFO | + ret =snb_pcode_read (&dev_priv->uncore,ICL_PCODE_MEM_SUBSYSYSTEM_INFO |ICL_PCODE_MEM_SS_READ_QGV_POINT_INFO (point), &val, &val2);if (ret)@@ -104,7 +104,7 @@ static int adls_pcode_read_psf_gv_point_info(struct drm_i915_private *dev_priv,int ret;int i; - ret =snb_pcode_read (dev_priv,ICL_PCODE_MEM_SUBSYSYSTEM_INFO | + ret =snb_pcode_read (&dev_priv->uncore,ICL_PCODE_MEM_SUBSYSYSTEM_INFO |ADL_PCODE_MEM_SS_READ_PSF_GV_INFO , &val,NULL );if (ret)return ret;@@ -123,7 +123,7 @@ int icl_pcode_restrict_qgv_points(struct drm_i915_private *dev_priv,int ret;/* bspec says to keep retrying for at least 1 ms */ - ret = skl_pcode_request(dev_priv, ICL_PCODE_SAGV_DE_MEM_SS_CONFIG, + ret = skl_pcode_request(&dev_priv->uncore, ICL_PCODE_SAGV_DE_MEM_SS_CONFIG, points_mask, ICL_PCODE_REP_QGV_MASK | ADLS_PCODE_REP_PSF_MASK, ICL_PCODE_REP_QGV_SAFE | ADLS_PCODE_REP_PSF_SAFE,drivers/gpu/drm/i915/display/intel_cdclk.c +8
-8@@ -800,7 +800,7 @@ static void bdw_set_cdclk(struct drm_i915_private *dev_priv, "trying to change cdclk frequency with cdclk not enabled\n")) return; - ret =snb_pcode_write (dev_priv,BDW_PCODE_DISPLAY_FREQ_CHANGE_REQ ,0x0 ); + ret =snb_pcode_write (&dev_priv->uncore,BDW_PCODE_DISPLAY_FREQ_CHANGE_REQ ,0x0 );if (ret) {drm_err (&dev_priv->drm,"failed to inform pcode about cdclk change\n" );@@ -828,7 +828,7 @@ static void bdw_set_cdclk(struct drm_i915_private *dev_priv, LCPLL_CD_SOURCE_FCLK_DONE) == 0, 1))drm_err (&dev_priv->drm,"Switching back to LCPLL failed\n" ); -snb_pcode_write (dev_priv,HSW_PCODE_DE_WRITE_FREQ_REQ , +snb_pcode_write (&dev_priv->uncore,HSW_PCODE_DE_WRITE_FREQ_REQ , cdclk_config->voltage_level); intel_de_write(dev_priv, CDCLK_FREQ,@@ -1086,7 +1086,7 @@ static void skl_set_cdclk(struct drm_i915_private *dev_priv,drm_WARN_ON_ONCE (&dev_priv->drm,IS_SKYLAKE (dev_priv) && vco ==8640000 ); - ret =skl_pcode_request (dev_priv,SKL_PCODE_CDCLK_CONTROL , + ret =skl_pcode_request (&dev_priv->uncore,SKL_PCODE_CDCLK_CONTROL ,SKL_CDCLK_PREPARE_FOR_CHANGE ,SKL_CDCLK_READY_FOR_CHANGE ,SKL_CDCLK_READY_FOR_CHANGE ,3 );@@ -1132,7 +1132,7 @@ static void skl_set_cdclk(struct drm_i915_private *dev_priv,intel_de_posting_read (dev_priv,CDCLK_CTL );/* inform PCU of the change */ -snb_pcode_write (dev_priv,SKL_PCODE_CDCLK_CONTROL , +snb_pcode_write (&dev_priv->uncore,SKL_PCODE_CDCLK_CONTROL , cdclk_config->voltage_level);intel_update_cdclk (dev_priv);@@ -1702,7 +1702,7 @@ static void bxt_set_cdclk(struct drm_i915_private *dev_priv,/* Inform power controller of upcoming frequency change. */ if (DISPLAY_VER (dev_priv) >=11 ) - ret =skl_pcode_request (dev_priv,SKL_PCODE_CDCLK_CONTROL , + ret =skl_pcode_request (&dev_priv->uncore,SKL_PCODE_CDCLK_CONTROL ,SKL_CDCLK_PREPARE_FOR_CHANGE ,SKL_CDCLK_READY_FOR_CHANGE ,SKL_CDCLK_READY_FOR_CHANGE ,3 );@@ -1711,7 +1711,7 @@ static void bxt_set_cdclk(struct drm_i915_private *dev_priv,* BSpec requires us to wait up to 150usec, but that leads to * timeouts; the 2ms used here is based on experiment. */ - ret =snb_pcode_write_timeout (dev_priv, + ret =snb_pcode_write_timeout (&dev_priv->uncore,HSW_PCODE_DE_WRITE_FREQ_REQ ,0x80000000 ,150 ,2 );if (ret) {@@ -1774,7 +1774,7 @@ static void bxt_set_cdclk(struct drm_i915_private *dev_priv,intel_crtc_wait_for_next_vblank (intel_crtc_for_pipe (dev_priv, pipe));if (DISPLAY_VER (dev_priv) >=11 ) { - ret =snb_pcode_write (dev_priv,SKL_PCODE_CDCLK_CONTROL , + ret =snb_pcode_write (&dev_priv->uncore,SKL_PCODE_CDCLK_CONTROL , cdclk_config->voltage_level); }else {/* @@ -1783,7 +1783,7 @@ static void bxt_set_cdclk(struct drm_i915_private *dev_priv,* FIXME: Waiting for the request completion could be delayed * until the next PCODE request based on BSpec. */ - ret =snb_pcode_write_timeout (dev_priv, + ret =snb_pcode_write_timeout (&dev_priv->uncore,HSW_PCODE_DE_WRITE_FREQ_REQ , cdclk_config->voltage_level,150 ,2 );drivers/gpu/drm/i915/display/intel_display_power.c +1
-1@@ -1194,7 +1194,7 @@ static u32 hsw_read_dcomp(struct drm_i915_private *dev_priv)static void hsw_write_dcomp (struct drm_i915_private *dev_priv,u32 val) {if (IS_HASWELL (dev_priv)) { -if (snb_pcode_write (dev_priv,GEN6_PCODE_WRITE_D_COMP , val)) +if (snb_pcode_write (&dev_priv->uncore,GEN6_PCODE_WRITE_D_COMP , val))drm_dbg_kms (&dev_priv->drm,"Failed to write to D_COMP\n" ); }else {drivers/gpu/drm/i915/display/intel_display_power_well.c +2
-2@@ -474,7 +474,7 @@ static void icl_tc_cold_exit(struct drm_i915_private *i915)int ret, tries =0 ;while (1 ) { - ret =snb_pcode_write_timeout (i915,ICL_PCODE_EXIT_TCCOLD ,0 , + ret =snb_pcode_write_timeout (&i915->uncore,ICL_PCODE_EXIT_TCCOLD ,0 ,250 ,1 );if (ret != -EAGAIN || ++tries ==3 )break ;@@ -1739,7 +1739,7 @@ tgl_tc_cold_request(struct drm_i915_private *i915, bool block)* Spec states that we should timeout the request after 200us * but the function below will timeout after 500us */ - ret =snb_pcode_read (i915,TGL_PCODE_TCCOLD , &low_val, &high_val); + ret =snb_pcode_read (&i915->uncore,TGL_PCODE_TCCOLD , &low_val, &high_val);if (ret ==0 ) {if (block && (low_val &TGL_PCODE_EXIT_TCCOLD_DATA_L_EXIT_FAILED ))drivers/gpu/drm/i915/display/intel_hdcp.c +1
-1@@ -298,7 +298,7 @@ static int intel_hdcp_load_keys(struct drm_i915_private *dev_priv)* Mailbox interface. */ if (DISPLAY_VER (dev_priv) ==9 && !IS_BROXTON (dev_priv)) { - ret =snb_pcode_write (dev_priv,SKL_PCODE_LOAD_HDCP_KEYS ,1 ); + ret =snb_pcode_write (&dev_priv->uncore,SKL_PCODE_LOAD_HDCP_KEYS ,1 );if (ret) { drm_err(&dev_priv->drm, "Failed to initiate HDCP key load (%d)\n",drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c +2
-2@@ -138,7 +138,7 @@ static int gen6_drpc(struct seq_file *m) }if (GRAPHICS_VER (i915) <=7 ) -snb_pcode_read (i915,GEN6_PCODE_READ_RC6VIDS , &rc6vids,NULL ); +snb_pcode_read (gt->uncore,GEN6_PCODE_READ_RC6VIDS , &rc6vids,NULL );seq_printf (m,"RC1e Enabled: %s\n" ,str_yes_no (rcctl1 & GEN6_RC_CTL_RC1e_ENABLE));@@ -545,7 +545,7 @@ static int llc_show(struct seq_file *m, void *data) wakeref =intel_runtime_pm_get (gt->uncore->rpm);for (gpu_freq = min_gpu_freq; gpu_freq <= max_gpu_freq; gpu_freq++) { ia_freq = gpu_freq; -snb_pcode_read (i915,GEN6_PCODE_READ_MIN_FREQ_TABLE , +snb_pcode_read (gt->uncore,GEN6_PCODE_READ_MIN_FREQ_TABLE , &ia_freq,NULL ); seq_printf(m, "%d\t\t%d\t\t\t\t%d\n", intel_gpu_freq(rps,drivers/gpu/drm/i915/gt/intel_llc.c +1
-2@@ -124,7 +124,6 @@ static void calc_ia_freq(struct intel_llc *llc,static void gen6_update_ring_freq (struct intel_llc *llc) { -struct drm_i915_private *i915 =llc_to_gt (llc)->i915;struct ia_constants consts;unsigned int gpu_freq;@@ -142,7 +141,7 @@ static void gen6_update_ring_freq(struct intel_llc *llc)unsigned int ia_freq, ring_freq;calc_ia_freq (llc, gpu_freq, &consts, &ia_freq, &ring_freq); -snb_pcode_write (i915,GEN6_PCODE_WRITE_MIN_FREQ_TABLE , +snb_pcode_write (llc_to_gt (llc)->uncore,GEN6_PCODE_WRITE_MIN_FREQ_TABLE , ia_freq <<GEN6_PCODE_FREQ_IA_RATIO_SHIFT | ring_freq <<GEN6_PCODE_FREQ_RING_RATIO_SHIFT | gpu_freq);drivers/gpu/drm/i915/gt/intel_rc6.c +2
-2@@ -272,7 +272,7 @@ static void gen6_rc6_enable(struct intel_rc6 *rc6)GEN6_RC_CTL_HW_ENABLE ; rc6vids =0 ; - ret =snb_pcode_read (i915,GEN6_PCODE_READ_RC6VIDS , &rc6vids,NULL ); + ret =snb_pcode_read (rc6_to_gt (rc6)->uncore,GEN6_PCODE_READ_RC6VIDS , &rc6vids,NULL );if (GRAPHICS_VER (i915) ==6 && ret) {drm_dbg (&i915->drm,"Couldn't check for BIOS workaround\n" ); } else if (GRAPHICS_VER(i915) == 6 &&@@ -282,7 +282,7 @@ static void gen6_rc6_enable(struct intel_rc6 *rc6) GEN6_DECODE_RC6_VID(rc6vids & 0xff), 450); rc6vids &=0xffff00 ; rc6vids |=GEN6_ENCODE_RC6_VID (450 ); - ret =snb_pcode_write (i915,GEN6_PCODE_WRITE_RC6VIDS , rc6vids); + ret =snb_pcode_write (rc6_to_gt (rc6)->uncore,GEN6_PCODE_WRITE_RC6VIDS , rc6vids);if (ret)drm_err (&i915->drm,"Couldn't fix incorrect rc6 voltage\n" );drivers/gpu/drm/i915/gt/intel_rps.c +2
-2@@ -1142,7 +1142,7 @@ static void gen6_rps_init(struct intel_rps *rps)if (IS_GEN9_BC (i915) ||GRAPHICS_VER (i915) >=11 ) mult =GEN9_FREQ_SCALER ; -if (snb_pcode_read (i915,HSW_PCODE_DYNAMIC_DUTY_CYCLE_CONTROL , +if (snb_pcode_read (rps_to_gt (rps)->uncore,HSW_PCODE_DYNAMIC_DUTY_CYCLE_CONTROL , &ddcc_status,NULL ) ==0 ) rps->efficient_freq = clamp_t(u32,@@ -1982,7 +1982,7 @@ void intel_rps_init(struct intel_rps *rps)if (GRAPHICS_VER (i915) ==6 ||IS_IVYBRIDGE (i915) ||IS_HASWELL (i915)) {u32 params =0 ; -snb_pcode_read (i915,GEN6_READ_OC_PARAMS , ¶ms,NULL ); +snb_pcode_read (rps_to_gt (rps)->uncore,GEN6_READ_OC_PARAMS , ¶ms,NULL );if (params &BIT (31 )) {/* OC supported */ drm_dbg(&i915->drm, "Overclocking supported, max: %dMHz, overclock: %dMHz\n",drivers/gpu/drm/i915/gt/selftest_llc.c +1
-1@@ -31,7 +31,7 @@ static int gen6_verify_ring_freq(struct intel_llc *llc)calc_ia_freq (llc, gpu_freq, &consts, &ia_freq, &ring_freq); val = gpu_freq; -if (snb_pcode_read (i915,GEN6_PCODE_READ_MIN_FREQ_TABLE , +if (snb_pcode_read (llc_to_gt (llc)->uncore,GEN6_PCODE_READ_MIN_FREQ_TABLE , &val,NULL )) {pr_err ("Failed to read freq table[%d], range [%d, %d]\n" , gpu_freq, consts.min_gpu_freq, consts.max_gpu_freq);drivers/gpu/drm/i915/gt/selftest_rps.c +1
-1@@ -521,7 +521,7 @@ static void show_pcu_config(struct intel_rps *rps)for (gpu_freq = min_gpu_freq; gpu_freq <= max_gpu_freq; gpu_freq++) {int ia_freq = gpu_freq; -snb_pcode_read (i915,GEN6_PCODE_READ_MIN_FREQ_TABLE , +snb_pcode_read (rps_to_gt (rps)->uncore,GEN6_PCODE_READ_MIN_FREQ_TABLE , &ia_freq,NULL ); pr_info("%5d %5d %5d\n",drivers/gpu/drm/i915/i915_driver.c +18
-2@@ -520,6 +520,22 @@ static int i915_set_dma_info(struct drm_i915_private *i915)return ret; } +static int i915_pcode_init (struct drm_i915_private *i915) +{ +struct intel_gt *gt; +int id, ret; + +for_each_gt (gt, i915, id) { + ret =intel_pcode_init (gt->uncore); +if (ret) { +drm_err (>->i915->drm,"gt %d: intel_pcode_init failed %d\n" , id, ret); +return ret; + } + } + +return 0 ; +} +/** * i915_driver_hw_probe - setup state requiring device access * @dev_priv: device private @@ -629,7 +645,7 @@ static int i915_driver_hw_probe(struct drm_i915_private *dev_priv)intel_opregion_setup (dev_priv); - ret =intel_pcode_init (dev_priv); + ret =i915_pcode_init (dev_priv);if (ret) goto err_msi;@@ -1251,7 +1267,7 @@ static int i915_drm_resume(struct drm_device *dev)disable_rpm_wakeref_asserts (&dev_priv->runtime_pm); - ret =intel_pcode_init (dev_priv); + ret =i915_pcode_init (dev_priv);if (ret)return ret;drivers/gpu/drm/i915/intel_dram.c +1
-1@@ -393,7 +393,7 @@ static int icl_pcode_read_mem_global_info(struct drm_i915_private *dev_priv)u32 val =0 ;int ret; - ret =snb_pcode_read (dev_priv,ICL_PCODE_MEM_SUBSYSYSTEM_INFO | + ret =snb_pcode_read (&dev_priv->uncore,ICL_PCODE_MEM_SUBSYSYSTEM_INFO |ICL_PCODE_MEM_SS_READ_GLOBAL_INFO , &val,NULL );if (ret)return ret;drivers/gpu/drm/i915/intel_pcode.c +29
-31@@ -52,14 +52,12 @@ static int gen7_check_mailbox_status(u32 mbox) } } -static int __snb_pcode_rw (struct drm_i915_private *i915,u32 mbox, +static int __snb_pcode_rw (struct intel_uncore *uncore,u32 mbox,u32 *val,u32 *val1,int fast_timeout_us,int slow_timeout_ms,bool is_read) { -struct intel_uncore *uncore = &i915->uncore; - -lockdep_assert_held (&i915->sb_lock); +lockdep_assert_held (&uncore->i915->sb_lock);/* * GEN6_PCODE_* are outside of the forcewake domain, we can use @@ -88,22 +86,22 @@ static int __snb_pcode_rw(struct drm_i915_private *i915, u32 mbox,if (is_read && val1) *val1 =intel_uncore_read_fw (uncore,GEN6_PCODE_DATA1 ); -if (GRAPHICS_VER (i915) >6 ) +if (GRAPHICS_VER (uncore->i915) >6 )return gen7_check_mailbox_status (mbox);else return gen6_check_mailbox_status (mbox); } -int snb_pcode_read (struct drm_i915_private *i915,u32 mbox,u32 *val,u32 *val1) +int snb_pcode_read (struct intel_uncore *uncore,u32 mbox,u32 *val,u32 *val1) {int err; -mutex_lock (&i915->sb_lock); - err =__snb_pcode_rw (i915, mbox, val, val1,500 ,20 , true); -mutex_unlock (&i915->sb_lock); +mutex_lock (&uncore->i915->sb_lock); + err =__snb_pcode_rw (uncore, mbox, val, val1,500 ,20 , true); +mutex_unlock (&uncore->i915->sb_lock);if (err) { -drm_dbg (&i915->drm, +drm_dbg (&uncore->i915->drm,"warning: pcode (read from mbox %x) mailbox access failed for %ps: %d\n" , mbox,__builtin_return_address (0 ), err); }@@ -111,18 +109,18 @@ int snb_pcode_read(struct drm_i915_private *i915, u32 mbox, u32 *val, u32 *val1)return err; } -int snb_pcode_write_timeout (struct drm_i915_private *i915,u32 mbox,u32 val, +int snb_pcode_write_timeout (struct intel_uncore *uncore,u32 mbox,u32 val,int fast_timeout_us,int slow_timeout_ms) {int err; -mutex_lock (&i915->sb_lock); - err =__snb_pcode_rw (i915, mbox, &val,NULL , +mutex_lock (&uncore->i915->sb_lock); + err =__snb_pcode_rw (uncore, mbox, &val,NULL , fast_timeout_us, slow_timeout_ms, false); -mutex_unlock (&i915->sb_lock); +mutex_unlock (&uncore->i915->sb_lock);if (err) { -drm_dbg (&i915->drm, +drm_dbg (&uncore->i915->drm,"warning: pcode (write of 0x%08x to mbox %x) mailbox access failed for %ps: %d\n" , val, mbox,__builtin_return_address (0 ), err); }@@ -130,18 +128,18 @@ int snb_pcode_write_timeout(struct drm_i915_private *i915, u32 mbox, u32 val,return err; } -static bool skl_pcode_try_request (struct drm_i915_private *i915,u32 mbox, +static bool skl_pcode_try_request (struct intel_uncore *uncore,u32 mbox,u32 request,u32 reply_mask,u32 reply,u32 *status) { - *status =__snb_pcode_rw (i915, mbox, &request,NULL ,500 ,0 , true); + *status =__snb_pcode_rw (uncore, mbox, &request,NULL ,500 ,0 , true);return (*status ==0 ) && ((request & reply_mask) == reply); }/** * skl_pcode_request - send PCODE request until acknowledgment -* @i915: device private +* @uncore: uncore * @mbox: PCODE mailbox ID the request is targeted for * @request: request ID * @reply_mask: mask used to check for request acknowledgment @@ -158,16 +156,16 @@ static bool skl_pcode_try_request(struct drm_i915_private *i915, u32 mbox,* Returns 0 on success, %-ETIMEDOUT in case of a timeout, <0 in case of some * other error as reported by PCODE. */ -int skl_pcode_request (struct drm_i915_private *i915,u32 mbox,u32 request, +int skl_pcode_request (struct intel_uncore *uncore,u32 mbox,u32 request,u32 reply_mask,u32 reply,int timeout_base_ms) {u32 status;int ret; -mutex_lock (&i915->sb_lock); +mutex_lock (&uncore->i915->sb_lock);#define COND \ - skl_pcode_try_request(i915, mbox, request, reply_mask, reply, &status) + skl_pcode_try_request(uncore, mbox, request, reply_mask, reply, &status)/* * Prime the PCODE by doing a request first. Normally it guarantees @@ -193,35 +191,35 @@ int skl_pcode_request(struct drm_i915_private *i915, u32 mbox, u32 request,* requests, and for any quirks of the PCODE firmware that delays * the request completion. */ -drm_dbg_kms (&i915->drm, +drm_dbg_kms (&uncore->i915->drm,"PCODE timeout, retrying with preemption disabled\n" ); -drm_WARN_ON_ONCE (&i915->drm, timeout_base_ms >3 ); +drm_WARN_ON_ONCE (&uncore->i915->drm, timeout_base_ms >3 );preempt_disable (); ret =wait_for_atomic (COND ,50 );preempt_enable (); out: -mutex_unlock (&i915->sb_lock); +mutex_unlock (&uncore->i915->sb_lock);return status ? status : ret;#undef COND } -int intel_pcode_init (struct drm_i915_private *i915) +int intel_pcode_init (struct intel_uncore *uncore) { -int ret =0 ; +int ret; -if (!IS_DGFX (i915)) -return ret; +if (!IS_DGFX (uncore->i915)) +return 0 ; - ret =skl_pcode_request (i915,DG1_PCODE_STATUS , + ret =skl_pcode_request (uncore,DG1_PCODE_STATUS ,DG1_UNCORE_GET_INIT_STATUS ,DG1_UNCORE_INIT_STATUS_COMPLETE ,DG1_UNCORE_INIT_STATUS_COMPLETE ,180000 ); -drm_dbg (&i915->drm,"PCODE init status %d\n" , ret); +drm_dbg (&uncore->i915->drm,"PCODE init status %d\n" , ret);if (ret) -drm_err (&i915->drm,"Pcode did not report uncore initialization completion!\n" ); +drm_err (&uncore->i915->drm,"Pcode did not report uncore initialization completion!\n" );return ret; }drivers/gpu/drm/i915/intel_pcode.h +7
-7@@ -8,17 +8,17 @@#include <linux/types.h> -struct drm_i915_private ; +struct intel_uncore ; -int snb_pcode_read (struct drm_i915_private *i915,u32 mbox,u32 *val,u32 *val1); -int snb_pcode_write_timeout (struct drm_i915_private *i915,u32 mbox,u32 val, +int snb_pcode_read (struct intel_uncore *uncore,u32 mbox,u32 *val,u32 *val1); +int snb_pcode_write_timeout (struct intel_uncore *uncore,u32 mbox,u32 val,int fast_timeout_us,int slow_timeout_ms); -#define snb_pcode_write (i915, mbox, val) \ - snb_pcode_write_timeout(i915, mbox, val, 500, 0) +#define snb_pcode_write (uncore, mbox, val) \ + snb_pcode_write_timeout(uncore, mbox, val, 500, 0) -int skl_pcode_request (struct drm_i915_private *i915,u32 mbox,u32 request, +int skl_pcode_request (struct intel_uncore *uncore,u32 mbox,u32 request,u32 reply_mask,u32 reply,int timeout_base_ms); -int intel_pcode_init (struct drm_i915_private *i915); +int intel_pcode_init (struct intel_uncore *uncore);#endif /* _INTEL_PCODE_H */ drivers/gpu/drm/i915/intel_pm.c +5
-5@@ -2874,7 +2874,7 @@ static void intel_read_wm_latency(struct drm_i915_private *dev_priv,/* read the first set of memory latencies[0:3] */ val =0 ;/* data0 to be programmed to 0 for first set */ - ret =snb_pcode_read (dev_priv,GEN9_PCODE_READ_MEM_LATENCY , + ret =snb_pcode_read (&dev_priv->uncore,GEN9_PCODE_READ_MEM_LATENCY , &val,NULL );if (ret) {@@ -2893,7 +2893,7 @@ static void intel_read_wm_latency(struct drm_i915_private *dev_priv,/* read the second set of memory latencies[4:7] */ val =1 ;/* data0 to be programmed to 1 for second set */ - ret =snb_pcode_read (dev_priv,GEN9_PCODE_READ_MEM_LATENCY , + ret =snb_pcode_read (&dev_priv->uncore,GEN9_PCODE_READ_MEM_LATENCY , &val,NULL );if (ret) { drm_err(&dev_priv->drm,@@ -3679,7 +3679,7 @@ intel_sagv_block_time(struct drm_i915_private *dev_priv)u32 val =0 ;int ret; - ret =snb_pcode_read (dev_priv, + ret =snb_pcode_read (&dev_priv->uncore,GEN12_PCODE_READ_SAGV_BLOCK_TIME_US , &val,NULL );if (ret) {@@ -3748,7 +3748,7 @@ static void skl_sagv_enable(struct drm_i915_private *dev_priv)return ;drm_dbg_kms (&dev_priv->drm,"Enabling SAGV\n" ); - ret =snb_pcode_write (dev_priv,GEN9_PCODE_SAGV_CONTROL , + ret =snb_pcode_write (&dev_priv->uncore,GEN9_PCODE_SAGV_CONTROL ,GEN9_SAGV_ENABLE );/* We don't need to wait for SAGV when enabling */ @@ -3781,7 +3781,7 @@ static void skl_sagv_disable(struct drm_i915_private *dev_priv)drm_dbg_kms (&dev_priv->drm,"Disabling SAGV\n" );/* bspec says to keep retrying for at least 1 ms */ - ret =skl_pcode_request (dev_priv,GEN9_PCODE_SAGV_CONTROL , + ret =skl_pcode_request (&dev_priv->uncore,GEN9_PCODE_SAGV_CONTROL ,GEN9_SAGV_DISABLE ,GEN9_SAGV_IS_DISABLED ,GEN9_SAGV_IS_DISABLED ,1 );Signature · 1 line
2.34.1
Re: [Intel-gfx] [PATCH 3/8] drm/i915/pcode: Extend pcode functions for multiple gt's
In reply to Ashutosh DixitHi Ashutosh,
Quoted 6 lines · Ashutosh Dixit
Each gt contains an independent instance of pcode. Extend pcode functions to interface with pcode on different gt's. To avoid creating dependency of display functionality on
intel_gt, pcode function interfaces are exposed in terms of uncore rather thanintel_gt. Callers have been converted to pass in the appropritate (i915 orintel_gt) uncore to the pcode functions.
Quoted 7 lines
v2: Expose pcode functions in terms of uncore rather than gt (Jani/Rodrigo)
v3: Retain previous function names to eliminate needless #defines (Rodrigo)Cc Rodrigo Vivi <[email protected]>Cc Jani Nikula <[email protected]>Cc Andi Shyti <[email protected]>Signed-off-by Ashutosh Dixit <[email protected]>
looks correct:
Thanks,
Andi
Re: [Intel-gfx] [PATCH 3/8] drm/i915/pcode: Extend pcode functions for multiple gt's
In reply to Ashutosh DixitQuoted 330 lines · Ashutosh Dixit
Each gt contains an independent instance of pcode. Extend pcode functions to interface with pcode on different gt's. To avoid creating dependency of display functionality on
intel_gt, pcode function interfaces are exposed in terms of uncore rather thanintel_gt. Callers have been converted to pass in the appropritate (i915 orintel_gt) uncore to the pcode functions.v2: Expose pcode functions in terms of uncore rather than gt (Jani/Rodrigo)
v3: Retain previous function names to eliminate needless #defines (Rodrigo)Cc Rodrigo Vivi <[email protected]>Cc Jani Nikula <[email protected]>Cc Andi Shyti <[email protected]>Signed-off-by Ashutosh Dixit <[email protected]>--- drivers/gpu/drm/i915/display/hsw_ips.c | 4 +- drivers/gpu/drm/i915/display/intel_bw.c | 6 +- drivers/gpu/drm/i915/display/intel_cdclk.c | 16 ++--- .../drm/i915/display/intel_display_power.c | 2 +- .../i915/display/intel_display_power_well.c | 4 +- drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +- drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 4 +- drivers/gpu/drm/i915/gt/intel_llc.c | 3 +- drivers/gpu/drm/i915/gt/intel_rc6.c | 4 +- drivers/gpu/drm/i915/gt/intel_rps.c | 4 +- drivers/gpu/drm/i915/gt/selftest_llc.c | 2 +- drivers/gpu/drm/i915/gt/selftest_rps.c | 2 +- drivers/gpu/drm/i915/i915_driver.c | 20 ++++++- drivers/gpu/drm/i915/intel_dram.c | 2 +- drivers/gpu/drm/i915/intel_pcode.c | 60 +++++++++---------- drivers/gpu/drm/i915/intel_pcode.h | 14 ++--- drivers/gpu/drm/i915/intel_pm.c | 10 ++-- 17 files changed, 86 insertions(+), 73 deletions(-)drivers/gpu/drm/i915/display/hsw_ips.c +2
-2@@ -28,7 +28,7 @@ static void hsw_ips_enable(const struct intel_crtc_state *crtc_state)if (IS_BROADWELL (i915)) {drm_WARN_ON (&i915->drm, -snb_pcode_write (i915,DISPLAY_IPS_CONTROL , +snb_pcode_write (&i915->uncore,DISPLAY_IPS_CONTROL ,IPS_ENABLE |IPS_PCODE_CONTROL ));/* * Quoting Art Runyan: "its not safe to expect any particular @@ -62,7 +62,7 @@ bool hsw_ips_disable(const struct intel_crtc_state *crtc_state)if (IS_BROADWELL (i915)) {drm_WARN_ON (&i915->drm, -snb_pcode_write (i915,DISPLAY_IPS_CONTROL ,0 )); +snb_pcode_write (&i915->uncore,DISPLAY_IPS_CONTROL ,0 ));/* * Wait for PCODE to finish disabling IPS. The BSpec specified * 42ms timeout value leads to occasional timeouts so use 100ms drivers/gpu/drm/i915/display/intel_bw.c +3
-3@@ -78,7 +78,7 @@ static int icl_pcode_read_qgv_point_info(struct drm_i915_private *dev_priv,u16 dclk;int ret; - ret =snb_pcode_read (dev_priv,ICL_PCODE_MEM_SUBSYSYSTEM_INFO | + ret =snb_pcode_read (&dev_priv->uncore,ICL_PCODE_MEM_SUBSYSYSTEM_INFO |ICL_PCODE_MEM_SS_READ_QGV_POINT_INFO (point), &val, &val2);if (ret)@@ -104,7 +104,7 @@ static int adls_pcode_read_psf_gv_point_info(struct drm_i915_private *dev_priv,int ret;int i; - ret =snb_pcode_read (dev_priv,ICL_PCODE_MEM_SUBSYSYSTEM_INFO | + ret =snb_pcode_read (&dev_priv->uncore,ICL_PCODE_MEM_SUBSYSYSTEM_INFO |ADL_PCODE_MEM_SS_READ_PSF_GV_INFO , &val,NULL );if (ret)return ret;@@ -123,7 +123,7 @@ int icl_pcode_restrict_qgv_points(struct drm_i915_private *dev_priv,int ret;/* bspec says to keep retrying for at least 1 ms */ - ret = skl_pcode_request(dev_priv, ICL_PCODE_SAGV_DE_MEM_SS_CONFIG, + ret = skl_pcode_request(&dev_priv->uncore, ICL_PCODE_SAGV_DE_MEM_SS_CONFIG, points_mask, ICL_PCODE_REP_QGV_MASK | ADLS_PCODE_REP_PSF_MASK, ICL_PCODE_REP_QGV_SAFE | ADLS_PCODE_REP_PSF_SAFE,drivers/gpu/drm/i915/display/intel_cdclk.c +8
-8@@ -800,7 +800,7 @@ static void bdw_set_cdclk(struct drm_i915_private *dev_priv, "trying to change cdclk frequency with cdclk not enabled\n")) return; - ret =snb_pcode_write (dev_priv,BDW_PCODE_DISPLAY_FREQ_CHANGE_REQ ,0x0 ); + ret =snb_pcode_write (&dev_priv->uncore,BDW_PCODE_DISPLAY_FREQ_CHANGE_REQ ,0x0 );if (ret) {drm_err (&dev_priv->drm,"failed to inform pcode about cdclk change\n" );@@ -828,7 +828,7 @@ static void bdw_set_cdclk(struct drm_i915_private *dev_priv, LCPLL_CD_SOURCE_FCLK_DONE) == 0, 1))drm_err (&dev_priv->drm,"Switching back to LCPLL failed\n" ); -snb_pcode_write (dev_priv,HSW_PCODE_DE_WRITE_FREQ_REQ , +snb_pcode_write (&dev_priv->uncore,HSW_PCODE_DE_WRITE_FREQ_REQ , cdclk_config->voltage_level); intel_de_write(dev_priv, CDCLK_FREQ,@@ -1086,7 +1086,7 @@ static void skl_set_cdclk(struct drm_i915_private *dev_priv,drm_WARN_ON_ONCE (&dev_priv->drm,IS_SKYLAKE (dev_priv) && vco ==8640000 ); - ret =skl_pcode_request (dev_priv,SKL_PCODE_CDCLK_CONTROL , + ret =skl_pcode_request (&dev_priv->uncore,SKL_PCODE_CDCLK_CONTROL ,SKL_CDCLK_PREPARE_FOR_CHANGE ,SKL_CDCLK_READY_FOR_CHANGE ,SKL_CDCLK_READY_FOR_CHANGE ,3 );@@ -1132,7 +1132,7 @@ static void skl_set_cdclk(struct drm_i915_private *dev_priv,intel_de_posting_read (dev_priv,CDCLK_CTL );/* inform PCU of the change */ -snb_pcode_write (dev_priv,SKL_PCODE_CDCLK_CONTROL , +snb_pcode_write (&dev_priv->uncore,SKL_PCODE_CDCLK_CONTROL , cdclk_config->voltage_level);intel_update_cdclk (dev_priv);@@ -1702,7 +1702,7 @@ static void bxt_set_cdclk(struct drm_i915_private *dev_priv,/* Inform power controller of upcoming frequency change. */ if (DISPLAY_VER (dev_priv) >=11 ) - ret =skl_pcode_request (dev_priv,SKL_PCODE_CDCLK_CONTROL , + ret =skl_pcode_request (&dev_priv->uncore,SKL_PCODE_CDCLK_CONTROL ,SKL_CDCLK_PREPARE_FOR_CHANGE ,SKL_CDCLK_READY_FOR_CHANGE ,SKL_CDCLK_READY_FOR_CHANGE ,3 );@@ -1711,7 +1711,7 @@ static void bxt_set_cdclk(struct drm_i915_private *dev_priv,* BSpec requires us to wait up to 150usec, but that leads to * timeouts; the 2ms used here is based on experiment. */ - ret =snb_pcode_write_timeout (dev_priv, + ret =snb_pcode_write_timeout (&dev_priv->uncore,HSW_PCODE_DE_WRITE_FREQ_REQ ,0x80000000 ,150 ,2 );if (ret) {@@ -1774,7 +1774,7 @@ static void bxt_set_cdclk(struct drm_i915_private *dev_priv,intel_crtc_wait_for_next_vblank (intel_crtc_for_pipe (dev_priv, pipe));if (DISPLAY_VER (dev_priv) >=11 ) { - ret =snb_pcode_write (dev_priv,SKL_PCODE_CDCLK_CONTROL , + ret =snb_pcode_write (&dev_priv->uncore,SKL_PCODE_CDCLK_CONTROL , cdclk_config->voltage_level); }else {/* @@ -1783,7 +1783,7 @@ static void bxt_set_cdclk(struct drm_i915_private *dev_priv,* FIXME: Waiting for the request completion could be delayed * until the next PCODE request based on BSpec. */ - ret =snb_pcode_write_timeout (dev_priv, + ret =snb_pcode_write_timeout (&dev_priv->uncore,HSW_PCODE_DE_WRITE_FREQ_REQ , cdclk_config->voltage_level,150 ,2 );drivers/gpu/drm/i915/display/intel_display_power.c +1
-1@@ -1194,7 +1194,7 @@ static u32 hsw_read_dcomp(struct drm_i915_private *dev_priv)static void hsw_write_dcomp (struct drm_i915_private *dev_priv,u32 val) {if (IS_HASWELL (dev_priv)) { -if (snb_pcode_write (dev_priv,GEN6_PCODE_WRITE_D_COMP , val)) +if (snb_pcode_write (&dev_priv->uncore,GEN6_PCODE_WRITE_D_COMP , val))drm_dbg_kms (&dev_priv->drm,"Failed to write to D_COMP\n" ); }else {drivers/gpu/drm/i915/display/intel_display_power_well.c +2
-2@@ -474,7 +474,7 @@ static void icl_tc_cold_exit(struct drm_i915_private *i915)int ret, tries =0 ;while (1 ) { - ret =snb_pcode_write_timeout (i915,ICL_PCODE_EXIT_TCCOLD ,0 , + ret =snb_pcode_write_timeout (&i915->uncore,ICL_PCODE_EXIT_TCCOLD ,0 ,250 ,1 );if (ret != -EAGAIN || ++tries ==3 )break ;@@ -1739,7 +1739,7 @@ tgl_tc_cold_request(struct drm_i915_private *i915, bool block)* Spec states that we should timeout the request after 200us * but the function below will timeout after 500us */ - ret =snb_pcode_read (i915,TGL_PCODE_TCCOLD , &low_val, &high_val); + ret =snb_pcode_read (&i915->uncore,TGL_PCODE_TCCOLD , &low_val, &high_val);if (ret ==0 ) {if (block && (low_val &TGL_PCODE_EXIT_TCCOLD_DATA_L_EXIT_FAILED ))drivers/gpu/drm/i915/display/intel_hdcp.c +1
-1@@ -298,7 +298,7 @@ static int intel_hdcp_load_keys(struct drm_i915_private *dev_priv)* Mailbox interface. */ if (DISPLAY_VER (dev_priv) ==9 && !IS_BROXTON (dev_priv)) { - ret =snb_pcode_write (dev_priv,SKL_PCODE_LOAD_HDCP_KEYS ,1 ); + ret =snb_pcode_write (&dev_priv->uncore,SKL_PCODE_LOAD_HDCP_KEYS ,1 );if (ret) { drm_err(&dev_priv->drm, "Failed to initiate HDCP key load (%d)\n",drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c +2
-2@@ -138,7 +138,7 @@ static int gen6_drpc(struct seq_file *m) }if (GRAPHICS_VER (i915) <=7 ) -snb_pcode_read (i915,GEN6_PCODE_READ_RC6VIDS , &rc6vids,NULL ); +snb_pcode_read (gt->uncore,GEN6_PCODE_READ_RC6VIDS , &rc6vids,NULL );seq_printf (m,"RC1e Enabled: %s\n" ,str_yes_no (rcctl1 & GEN6_RC_CTL_RC1e_ENABLE));@@ -545,7 +545,7 @@ static int llc_show(struct seq_file *m, void *data) wakeref =intel_runtime_pm_get (gt->uncore->rpm);for (gpu_freq = min_gpu_freq; gpu_freq <= max_gpu_freq; gpu_freq++) { ia_freq = gpu_freq; -snb_pcode_read (i915,GEN6_PCODE_READ_MIN_FREQ_TABLE , +snb_pcode_read (gt->uncore,GEN6_PCODE_READ_MIN_FREQ_TABLE , &ia_freq,NULL ); seq_printf(m, "%d\t\t%d\t\t\t\t%d\n", intel_gpu_freq(rps,drivers/gpu/drm/i915/gt/intel_llc.c +1
-2@@ -124,7 +124,6 @@ static void calc_ia_freq(struct intel_llc *llc,static void gen6_update_ring_freq (struct intel_llc *llc) { -struct drm_i915_private *i915 =llc_to_gt (llc)->i915;struct ia_constants consts;unsigned int gpu_freq;@@ -142,7 +141,7 @@ static void gen6_update_ring_freq(struct intel_llc *llc)unsigned int ia_freq, ring_freq;calc_ia_freq (llc, gpu_freq, &consts, &ia_freq, &ring_freq); -snb_pcode_write (i915,GEN6_PCODE_WRITE_MIN_FREQ_TABLE , +snb_pcode_write (llc_to_gt (llc)->uncore,GEN6_PCODE_WRITE_MIN_FREQ_TABLE , ia_freq <<GEN6_PCODE_FREQ_IA_RATIO_SHIFT | ring_freq <<GEN6_PCODE_FREQ_RING_RATIO_SHIFT | gpu_freq);drivers/gpu/drm/i915/gt/intel_rc6.c +2
-2@@ -272,7 +272,7 @@ static void gen6_rc6_enable(struct intel_rc6 *rc6)GEN6_RC_CTL_HW_ENABLE ; rc6vids =0 ; - ret =snb_pcode_read (i915,GEN6_PCODE_READ_RC6VIDS , &rc6vids,NULL ); + ret =snb_pcode_read (rc6_to_gt (rc6)->uncore,GEN6_PCODE_READ_RC6VIDS , &rc6vids,NULL );if (GRAPHICS_VER (i915) ==6 && ret) {drm_dbg (&i915->drm,"Couldn't check for BIOS workaround\n" ); } else if (GRAPHICS_VER(i915) == 6 &&@@ -282,7 +282,7 @@ static void gen6_rc6_enable(struct intel_rc6 *rc6) GEN6_DECODE_RC6_VID(rc6vids & 0xff), 450); rc6vids &=0xffff00 ; rc6vids |=GEN6_ENCODE_RC6_VID (450 ); - ret =snb_pcode_write (i915,GEN6_PCODE_WRITE_RC6VIDS , rc6vids); + ret =snb_pcode_write (rc6_to_gt (rc6)->uncore,GEN6_PCODE_WRITE_RC6VIDS , rc6vids);if (ret)drm_err (&i915->drm,"Couldn't fix incorrect rc6 voltage\n" );drivers/gpu/drm/i915/gt/intel_rps.c +2
-2@@ -1142,7 +1142,7 @@ static void gen6_rps_init(struct intel_rps *rps)if (IS_GEN9_BC (i915) ||GRAPHICS_VER (i915) >=11 ) mult =GEN9_FREQ_SCALER ; -if (snb_pcode_read (i915,HSW_PCODE_DYNAMIC_DUTY_CYCLE_CONTROL , +if (snb_pcode_read (rps_to_gt (rps)->uncore,HSW_PCODE_DYNAMIC_DUTY_CYCLE_CONTROL , &ddcc_status,NULL ) ==0 ) rps->efficient_freq = clamp_t(u32,@@ -1982,7 +1982,7 @@ void intel_rps_init(struct intel_rps *rps)if (GRAPHICS_VER (i915) ==6 ||IS_IVYBRIDGE (i915) ||IS_HASWELL (i915)) {u32 params =0 ; -snb_pcode_read (i915,GEN6_READ_OC_PARAMS , ¶ms,NULL ); +snb_pcode_read (rps_to_gt (rps)->uncore,GEN6_READ_OC_PARAMS , ¶ms,NULL );if (params &BIT (31 )) {/* OC supported */ drm_dbg(&i915->drm, "Overclocking supported, max: %dMHz, overclock: %dMHz\n",drivers/gpu/drm/i915/gt/selftest_llc.c +1
-1@@ -31,7 +31,7 @@ static int gen6_verify_ring_freq(struct intel_llc *llc)calc_ia_freq (llc, gpu_freq, &consts, &ia_freq, &ring_freq); val = gpu_freq; -if (snb_pcode_read (i915,GEN6_PCODE_READ_MIN_FREQ_TABLE , +if (snb_pcode_read (llc_to_gt (llc)->uncore,GEN6_PCODE_READ_MIN_FREQ_TABLE , &val,NULL )) {pr_err ("Failed to read freq table[%d], range [%d, %d]\n" , gpu_freq, consts.min_gpu_freq, consts.max_gpu_freq);drivers/gpu/drm/i915/gt/selftest_rps.c +1
-1@@ -521,7 +521,7 @@ static void show_pcu_config(struct intel_rps *rps)for (gpu_freq = min_gpu_freq; gpu_freq <= max_gpu_freq; gpu_freq++) {int ia_freq = gpu_freq; -snb_pcode_read (i915,GEN6_PCODE_READ_MIN_FREQ_TABLE , +snb_pcode_read (rps_to_gt (rps)->uncore,GEN6_PCODE_READ_MIN_FREQ_TABLE , &ia_freq,NULL ); pr_info("%5d %5d %5d\n",drivers/gpu/drm/i915/i915_driver.c +0
-0@@ -520,6 +520,22 @@ static int i915_set_dma_info(struct drm_i915_private *i915)return ret; }
drivers/gpu/drm/i915/i915_driver.c static int i915_set_dma_info(struct drm_i915_private *i915) · line 531
Quoted 10 lines
drivers/gpu/drm/i915/i915_driver.c +9
-0+static int i915_pcode_init (struct drm_i915_private *i915) +{ +struct intel_gt *gt; +int id, ret; + +for_each_gt (gt, i915, id) { + ret =intel_pcode_init (gt->uncore); +if (ret) { +drm_err (>->i915->drm,"gt %d: intel_pcode_init failed %d\n" , id, ret);
A few nits..
1) All other/current logs use "gt%d" (no space).
2) intel_pcode_init also logs a drm_err - do we need two? I suggest leaving this one only since it has more information.
3) It would have been nicer to have refactoring of intel_pcode_ to work on uncore separate from adding for_each_gt.
Regards,
Tvrtko
Quoted 281 lines
drivers/gpu/drm/i915/i915_driver.c +9
-2+return ret; + } + } + +return 0 ; +} +/** * i915_driver_hw_probe - setup state requiring device access * @dev_priv: device private @@ -629,7 +645,7 @@ static int i915_driver_hw_probe(struct drm_i915_private *dev_priv)intel_opregion_setup (dev_priv); - ret =intel_pcode_init (dev_priv); + ret =i915_pcode_init (dev_priv);if (ret) goto err_msi;@@ -1251,7 +1267,7 @@ static int i915_drm_resume(struct drm_device *dev)disable_rpm_wakeref_asserts (&dev_priv->runtime_pm); - ret =intel_pcode_init (dev_priv); + ret =i915_pcode_init (dev_priv);if (ret)return ret;drivers/gpu/drm/i915/intel_dram.c +1
-1@@ -393,7 +393,7 @@ static int icl_pcode_read_mem_global_info(struct drm_i915_private *dev_priv)u32 val =0 ;int ret; - ret =snb_pcode_read (dev_priv,ICL_PCODE_MEM_SUBSYSYSTEM_INFO | + ret =snb_pcode_read (&dev_priv->uncore,ICL_PCODE_MEM_SUBSYSYSTEM_INFO |ICL_PCODE_MEM_SS_READ_GLOBAL_INFO , &val,NULL );if (ret)return ret;drivers/gpu/drm/i915/intel_pcode.c +29
-31@@ -52,14 +52,12 @@ static int gen7_check_mailbox_status(u32 mbox) } } -static int __snb_pcode_rw (struct drm_i915_private *i915,u32 mbox, +static int __snb_pcode_rw (struct intel_uncore *uncore,u32 mbox,u32 *val,u32 *val1,int fast_timeout_us,int slow_timeout_ms,bool is_read) { -struct intel_uncore *uncore = &i915->uncore; - -lockdep_assert_held (&i915->sb_lock); +lockdep_assert_held (&uncore->i915->sb_lock);/* * GEN6_PCODE_* are outside of the forcewake domain, we can use @@ -88,22 +86,22 @@ static int __snb_pcode_rw(struct drm_i915_private *i915, u32 mbox,if (is_read && val1) *val1 =intel_uncore_read_fw (uncore,GEN6_PCODE_DATA1 ); -if (GRAPHICS_VER (i915) >6 ) +if (GRAPHICS_VER (uncore->i915) >6 )return gen7_check_mailbox_status (mbox);else return gen6_check_mailbox_status (mbox); } -int snb_pcode_read (struct drm_i915_private *i915,u32 mbox,u32 *val,u32 *val1) +int snb_pcode_read (struct intel_uncore *uncore,u32 mbox,u32 *val,u32 *val1) {int err; -mutex_lock (&i915->sb_lock); - err =__snb_pcode_rw (i915, mbox, val, val1,500 ,20 , true); -mutex_unlock (&i915->sb_lock); +mutex_lock (&uncore->i915->sb_lock); + err =__snb_pcode_rw (uncore, mbox, val, val1,500 ,20 , true); +mutex_unlock (&uncore->i915->sb_lock);if (err) { -drm_dbg (&i915->drm, +drm_dbg (&uncore->i915->drm,"warning: pcode (read from mbox %x) mailbox access failed for %ps: %d\n" , mbox,__builtin_return_address (0 ), err); }@@ -111,18 +109,18 @@ int snb_pcode_read(struct drm_i915_private *i915, u32 mbox, u32 *val, u32 *val1)return err; } -int snb_pcode_write_timeout (struct drm_i915_private *i915,u32 mbox,u32 val, +int snb_pcode_write_timeout (struct intel_uncore *uncore,u32 mbox,u32 val,int fast_timeout_us,int slow_timeout_ms) {int err; -mutex_lock (&i915->sb_lock); - err =__snb_pcode_rw (i915, mbox, &val,NULL , +mutex_lock (&uncore->i915->sb_lock); + err =__snb_pcode_rw (uncore, mbox, &val,NULL , fast_timeout_us, slow_timeout_ms, false); -mutex_unlock (&i915->sb_lock); +mutex_unlock (&uncore->i915->sb_lock);if (err) { -drm_dbg (&i915->drm, +drm_dbg (&uncore->i915->drm,"warning: pcode (write of 0x%08x to mbox %x) mailbox access failed for %ps: %d\n" , val, mbox,__builtin_return_address (0 ), err); }@@ -130,18 +128,18 @@ int snb_pcode_write_timeout(struct drm_i915_private *i915, u32 mbox, u32 val,return err; } -static bool skl_pcode_try_request (struct drm_i915_private *i915,u32 mbox, +static bool skl_pcode_try_request (struct intel_uncore *uncore,u32 mbox,u32 request,u32 reply_mask,u32 reply,u32 *status) { - *status =__snb_pcode_rw (i915, mbox, &request,NULL ,500 ,0 , true); + *status =__snb_pcode_rw (uncore, mbox, &request,NULL ,500 ,0 , true);return (*status ==0 ) && ((request & reply_mask) == reply); }/** * skl_pcode_request - send PCODE request until acknowledgment -* @i915: device private +* @uncore: uncore * @mbox: PCODE mailbox ID the request is targeted for * @request: request ID * @reply_mask: mask used to check for request acknowledgment @@ -158,16 +156,16 @@ static bool skl_pcode_try_request(struct drm_i915_private *i915, u32 mbox,* Returns 0 on success, %-ETIMEDOUT in case of a timeout, <0 in case of some * other error as reported by PCODE. */ -int skl_pcode_request (struct drm_i915_private *i915,u32 mbox,u32 request, +int skl_pcode_request (struct intel_uncore *uncore,u32 mbox,u32 request,u32 reply_mask,u32 reply,int timeout_base_ms) {u32 status;int ret; -mutex_lock (&i915->sb_lock); +mutex_lock (&uncore->i915->sb_lock);#define COND \ - skl_pcode_try_request(i915, mbox, request, reply_mask, reply, &status) + skl_pcode_try_request(uncore, mbox, request, reply_mask, reply, &status)/* * Prime the PCODE by doing a request first. Normally it guarantees @@ -193,35 +191,35 @@ int skl_pcode_request(struct drm_i915_private *i915, u32 mbox, u32 request,* requests, and for any quirks of the PCODE firmware that delays * the request completion. */ -drm_dbg_kms (&i915->drm, +drm_dbg_kms (&uncore->i915->drm,"PCODE timeout, retrying with preemption disabled\n" ); -drm_WARN_ON_ONCE (&i915->drm, timeout_base_ms >3 ); +drm_WARN_ON_ONCE (&uncore->i915->drm, timeout_base_ms >3 );preempt_disable (); ret =wait_for_atomic (COND ,50 );preempt_enable (); out: -mutex_unlock (&i915->sb_lock); +mutex_unlock (&uncore->i915->sb_lock);return status ? status : ret;#undef COND } -int intel_pcode_init (struct drm_i915_private *i915) +int intel_pcode_init (struct intel_uncore *uncore) { -int ret =0 ; +int ret; -if (!IS_DGFX (i915)) -return ret; +if (!IS_DGFX (uncore->i915)) +return 0 ; - ret =skl_pcode_request (i915,DG1_PCODE_STATUS , + ret =skl_pcode_request (uncore,DG1_PCODE_STATUS ,DG1_UNCORE_GET_INIT_STATUS ,DG1_UNCORE_INIT_STATUS_COMPLETE ,DG1_UNCORE_INIT_STATUS_COMPLETE ,180000 ); -drm_dbg (&i915->drm,"PCODE init status %d\n" , ret); +drm_dbg (&uncore->i915->drm,"PCODE init status %d\n" , ret);if (ret) -drm_err (&i915->drm,"Pcode did not report uncore initialization completion!\n" ); +drm_err (&uncore->i915->drm,"Pcode did not report uncore initialization completion!\n" );return ret; }drivers/gpu/drm/i915/intel_pcode.h +7
-7@@ -8,17 +8,17 @@#include <linux/types.h> -struct drm_i915_private ; +struct intel_uncore ; -int snb_pcode_read (struct drm_i915_private *i915,u32 mbox,u32 *val,u32 *val1); -int snb_pcode_write_timeout (struct drm_i915_private *i915,u32 mbox,u32 val, +int snb_pcode_read (struct intel_uncore *uncore,u32 mbox,u32 *val,u32 *val1); +int snb_pcode_write_timeout (struct intel_uncore *uncore,u32 mbox,u32 val,int fast_timeout_us,int slow_timeout_ms); -#define snb_pcode_write (i915, mbox, val) \ - snb_pcode_write_timeout(i915, mbox, val, 500, 0) +#define snb_pcode_write (uncore, mbox, val) \ + snb_pcode_write_timeout(uncore, mbox, val, 500, 0) -int skl_pcode_request (struct drm_i915_private *i915,u32 mbox,u32 request, +int skl_pcode_request (struct intel_uncore *uncore,u32 mbox,u32 request,u32 reply_mask,u32 reply,int timeout_base_ms); -int intel_pcode_init (struct drm_i915_private *i915); +int intel_pcode_init (struct intel_uncore *uncore);#endif /* _INTEL_PCODE_H */ drivers/gpu/drm/i915/intel_pm.c +5
-5@@ -2874,7 +2874,7 @@ static void intel_read_wm_latency(struct drm_i915_private *dev_priv,/* read the first set of memory latencies[0:3] */ val =0 ;/* data0 to be programmed to 0 for first set */ - ret =snb_pcode_read (dev_priv,GEN9_PCODE_READ_MEM_LATENCY , + ret =snb_pcode_read (&dev_priv->uncore,GEN9_PCODE_READ_MEM_LATENCY , &val,NULL );if (ret) {@@ -2893,7 +2893,7 @@ static void intel_read_wm_latency(struct drm_i915_private *dev_priv,/* read the second set of memory latencies[4:7] */ val =1 ;/* data0 to be programmed to 1 for second set */ - ret =snb_pcode_read (dev_priv,GEN9_PCODE_READ_MEM_LATENCY , + ret =snb_pcode_read (&dev_priv->uncore,GEN9_PCODE_READ_MEM_LATENCY , &val,NULL );if (ret) { drm_err(&dev_priv->drm,@@ -3679,7 +3679,7 @@ intel_sagv_block_time(struct drm_i915_private *dev_priv)u32 val =0 ;int ret; - ret =snb_pcode_read (dev_priv, + ret =snb_pcode_read (&dev_priv->uncore,GEN12_PCODE_READ_SAGV_BLOCK_TIME_US , &val,NULL );if (ret) {@@ -3748,7 +3748,7 @@ static void skl_sagv_enable(struct drm_i915_private *dev_priv)return ;drm_dbg_kms (&dev_priv->drm,"Enabling SAGV\n" ); - ret =snb_pcode_write (dev_priv,GEN9_PCODE_SAGV_CONTROL , + ret =snb_pcode_write (&dev_priv->uncore,GEN9_PCODE_SAGV_CONTROL ,GEN9_SAGV_ENABLE );/* We don't need to wait for SAGV when enabling */ @@ -3781,7 +3781,7 @@ static void skl_sagv_disable(struct drm_i915_private *dev_priv)drm_dbg_kms (&dev_priv->drm,"Disabling SAGV\n" );/* bspec says to keep retrying for at least 1 ms */ - ret =skl_pcode_request (dev_priv,GEN9_PCODE_SAGV_CONTROL , + ret =skl_pcode_request (&dev_priv->uncore,GEN9_PCODE_SAGV_CONTROL ,GEN9_SAGV_DISABLE ,GEN9_SAGV_IS_DISABLED ,GEN9_SAGV_IS_DISABLED ,1 );
Re: [Intel-gfx] [PATCH 3/8] drm/i915/pcode: Extend pcode functions for multiple gt's
Quoted 344 lines · Tvrtko Ursulin
Quoted 330 lines · Ashutosh Dixit
Each gt contains an independent instance of pcode. Extend pcode functions to interface with pcode on different gt's. To avoid creating dependency of display functionality on
intel_gt, pcode function interfaces are exposed in terms of uncore rather thanintel_gt. Callers have been converted to pass in the appropritate (i915 orintel_gt) uncore to the pcode functions.v2: Expose pcode functions in terms of uncore rather than gt (Jani/Rodrigo)
v3: Retain previous function names to eliminate needless #defines (Rodrigo)Cc Rodrigo Vivi <[email protected]>Cc Jani Nikula <[email protected]>Cc Andi Shyti <[email protected]>Signed-off-by Ashutosh Dixit <[email protected]>--- drivers/gpu/drm/i915/display/hsw_ips.c | 4 +- drivers/gpu/drm/i915/display/intel_bw.c | 6 +- drivers/gpu/drm/i915/display/intel_cdclk.c | 16 ++--- .../drm/i915/display/intel_display_power.c | 2 +- .../i915/display/intel_display_power_well.c | 4 +- drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +- drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 4 +- drivers/gpu/drm/i915/gt/intel_llc.c | 3 +- drivers/gpu/drm/i915/gt/intel_rc6.c | 4 +- drivers/gpu/drm/i915/gt/intel_rps.c | 4 +- drivers/gpu/drm/i915/gt/selftest_llc.c | 2 +- drivers/gpu/drm/i915/gt/selftest_rps.c | 2 +- drivers/gpu/drm/i915/i915_driver.c | 20 ++++++- drivers/gpu/drm/i915/intel_dram.c | 2 +- drivers/gpu/drm/i915/intel_pcode.c | 60 +++++++++---------- drivers/gpu/drm/i915/intel_pcode.h | 14 ++--- drivers/gpu/drm/i915/intel_pm.c | 10 ++-- 17 files changed, 86 insertions(+), 73 deletions(-)drivers/gpu/drm/i915/display/hsw_ips.c +2
-2@@ -28,7 +28,7 @@ static void hsw_ips_enable(const struct intel_crtc_state *crtc_state)if (IS_BROADWELL (i915)) {drm_WARN_ON (&i915->drm, -snb_pcode_write (i915,DISPLAY_IPS_CONTROL , +snb_pcode_write (&i915->uncore,DISPLAY_IPS_CONTROL ,IPS_ENABLE |IPS_PCODE_CONTROL ));/* * Quoting Art Runyan: "its not safe to expect any particular @@ -62,7 +62,7 @@ bool hsw_ips_disable(const struct intel_crtc_state *crtc_state)if (IS_BROADWELL (i915)) {drm_WARN_ON (&i915->drm, -snb_pcode_write (i915,DISPLAY_IPS_CONTROL ,0 )); +snb_pcode_write (&i915->uncore,DISPLAY_IPS_CONTROL ,0 ));/* * Wait for PCODE to finish disabling IPS. The BSpec specified * 42ms timeout value leads to occasional timeouts so use 100ms drivers/gpu/drm/i915/display/intel_bw.c +3
-3@@ -78,7 +78,7 @@ static int icl_pcode_read_qgv_point_info(struct drm_i915_private *dev_priv,u16 dclk;int ret; - ret =snb_pcode_read (dev_priv,ICL_PCODE_MEM_SUBSYSYSTEM_INFO | + ret =snb_pcode_read (&dev_priv->uncore,ICL_PCODE_MEM_SUBSYSYSTEM_INFO |ICL_PCODE_MEM_SS_READ_QGV_POINT_INFO (point), &val, &val2);if (ret)@@ -104,7 +104,7 @@ static int adls_pcode_read_psf_gv_point_info(struct drm_i915_private *dev_priv,int ret;int i; - ret =snb_pcode_read (dev_priv,ICL_PCODE_MEM_SUBSYSYSTEM_INFO | + ret =snb_pcode_read (&dev_priv->uncore,ICL_PCODE_MEM_SUBSYSYSTEM_INFO |ADL_PCODE_MEM_SS_READ_PSF_GV_INFO , &val,NULL );if (ret)return ret;@@ -123,7 +123,7 @@ int icl_pcode_restrict_qgv_points(struct drm_i915_private *dev_priv,int ret;/* bspec says to keep retrying for at least 1 ms */ - ret = skl_pcode_request(dev_priv, ICL_PCODE_SAGV_DE_MEM_SS_CONFIG, + ret = skl_pcode_request(&dev_priv->uncore, ICL_PCODE_SAGV_DE_MEM_SS_CONFIG, points_mask, ICL_PCODE_REP_QGV_MASK | ADLS_PCODE_REP_PSF_MASK, ICL_PCODE_REP_QGV_SAFE | ADLS_PCODE_REP_PSF_SAFE,drivers/gpu/drm/i915/display/intel_cdclk.c +8
-8@@ -800,7 +800,7 @@ static void bdw_set_cdclk(struct drm_i915_private *dev_priv, "trying to change cdclk frequency with cdclk not enabled\n")) return; - ret =snb_pcode_write (dev_priv,BDW_PCODE_DISPLAY_FREQ_CHANGE_REQ ,0x0 ); + ret =snb_pcode_write (&dev_priv->uncore,BDW_PCODE_DISPLAY_FREQ_CHANGE_REQ ,0x0 );if (ret) {drm_err (&dev_priv->drm,"failed to inform pcode about cdclk change\n" );@@ -828,7 +828,7 @@ static void bdw_set_cdclk(struct drm_i915_private *dev_priv, LCPLL_CD_SOURCE_FCLK_DONE) == 0, 1))drm_err (&dev_priv->drm,"Switching back to LCPLL failed\n" ); -snb_pcode_write (dev_priv,HSW_PCODE_DE_WRITE_FREQ_REQ , +snb_pcode_write (&dev_priv->uncore,HSW_PCODE_DE_WRITE_FREQ_REQ , cdclk_config->voltage_level); intel_de_write(dev_priv, CDCLK_FREQ,@@ -1086,7 +1086,7 @@ static void skl_set_cdclk(struct drm_i915_private *dev_priv,drm_WARN_ON_ONCE (&dev_priv->drm,IS_SKYLAKE (dev_priv) && vco ==8640000 ); - ret =skl_pcode_request (dev_priv,SKL_PCODE_CDCLK_CONTROL , + ret =skl_pcode_request (&dev_priv->uncore,SKL_PCODE_CDCLK_CONTROL ,SKL_CDCLK_PREPARE_FOR_CHANGE ,SKL_CDCLK_READY_FOR_CHANGE ,SKL_CDCLK_READY_FOR_CHANGE ,3 );@@ -1132,7 +1132,7 @@ static void skl_set_cdclk(struct drm_i915_private *dev_priv,intel_de_posting_read (dev_priv,CDCLK_CTL );/* inform PCU of the change */ -snb_pcode_write (dev_priv,SKL_PCODE_CDCLK_CONTROL , +snb_pcode_write (&dev_priv->uncore,SKL_PCODE_CDCLK_CONTROL , cdclk_config->voltage_level);intel_update_cdclk (dev_priv);@@ -1702,7 +1702,7 @@ static void bxt_set_cdclk(struct drm_i915_private *dev_priv,/* Inform power controller of upcoming frequency change. */ if (DISPLAY_VER (dev_priv) >=11 ) - ret =skl_pcode_request (dev_priv,SKL_PCODE_CDCLK_CONTROL , + ret =skl_pcode_request (&dev_priv->uncore,SKL_PCODE_CDCLK_CONTROL ,SKL_CDCLK_PREPARE_FOR_CHANGE ,SKL_CDCLK_READY_FOR_CHANGE ,SKL_CDCLK_READY_FOR_CHANGE ,3 );@@ -1711,7 +1711,7 @@ static void bxt_set_cdclk(struct drm_i915_private *dev_priv,* BSpec requires us to wait up to 150usec, but that leads to * timeouts; the 2ms used here is based on experiment. */ - ret =snb_pcode_write_timeout (dev_priv, + ret =snb_pcode_write_timeout (&dev_priv->uncore,HSW_PCODE_DE_WRITE_FREQ_REQ ,0x80000000 ,150 ,2 );if (ret) {@@ -1774,7 +1774,7 @@ static void bxt_set_cdclk(struct drm_i915_private *dev_priv,intel_crtc_wait_for_next_vblank (intel_crtc_for_pipe (dev_priv, pipe));if (DISPLAY_VER (dev_priv) >=11 ) { - ret =snb_pcode_write (dev_priv,SKL_PCODE_CDCLK_CONTROL , + ret =snb_pcode_write (&dev_priv->uncore,SKL_PCODE_CDCLK_CONTROL , cdclk_config->voltage_level); }else {/* @@ -1783,7 +1783,7 @@ static void bxt_set_cdclk(struct drm_i915_private *dev_priv,* FIXME: Waiting for the request completion could be delayed * until the next PCODE request based on BSpec. */ - ret =snb_pcode_write_timeout (dev_priv, + ret =snb_pcode_write_timeout (&dev_priv->uncore,HSW_PCODE_DE_WRITE_FREQ_REQ , cdclk_config->voltage_level,150 ,2 );drivers/gpu/drm/i915/display/intel_display_power.c +1
-1@@ -1194,7 +1194,7 @@ static u32 hsw_read_dcomp(struct drm_i915_private *dev_priv)static void hsw_write_dcomp (struct drm_i915_private *dev_priv,u32 val) {if (IS_HASWELL (dev_priv)) { -if (snb_pcode_write (dev_priv,GEN6_PCODE_WRITE_D_COMP , val)) +if (snb_pcode_write (&dev_priv->uncore,GEN6_PCODE_WRITE_D_COMP , val))drm_dbg_kms (&dev_priv->drm,"Failed to write to D_COMP\n" ); }else {drivers/gpu/drm/i915/display/intel_display_power_well.c +2
-2@@ -474,7 +474,7 @@ static void icl_tc_cold_exit(struct drm_i915_private *i915)int ret, tries =0 ;while (1 ) { - ret =snb_pcode_write_timeout (i915,ICL_PCODE_EXIT_TCCOLD ,0 , + ret =snb_pcode_write_timeout (&i915->uncore,ICL_PCODE_EXIT_TCCOLD ,0 ,250 ,1 );if (ret != -EAGAIN || ++tries ==3 )break ;@@ -1739,7 +1739,7 @@ tgl_tc_cold_request(struct drm_i915_private *i915, bool block)* Spec states that we should timeout the request after 200us * but the function below will timeout after 500us */ - ret =snb_pcode_read (i915,TGL_PCODE_TCCOLD , &low_val, &high_val); + ret =snb_pcode_read (&i915->uncore,TGL_PCODE_TCCOLD , &low_val, &high_val);if (ret ==0 ) {if (block && (low_val &TGL_PCODE_EXIT_TCCOLD_DATA_L_EXIT_FAILED ))drivers/gpu/drm/i915/display/intel_hdcp.c +1
-1@@ -298,7 +298,7 @@ static int intel_hdcp_load_keys(struct drm_i915_private *dev_priv)* Mailbox interface. */ if (DISPLAY_VER (dev_priv) ==9 && !IS_BROXTON (dev_priv)) { - ret =snb_pcode_write (dev_priv,SKL_PCODE_LOAD_HDCP_KEYS ,1 ); + ret =snb_pcode_write (&dev_priv->uncore,SKL_PCODE_LOAD_HDCP_KEYS ,1 );if (ret) { drm_err(&dev_priv->drm, "Failed to initiate HDCP key load (%d)\n",drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c +2
-2@@ -138,7 +138,7 @@ static int gen6_drpc(struct seq_file *m) }if (GRAPHICS_VER (i915) <=7 ) -snb_pcode_read (i915,GEN6_PCODE_READ_RC6VIDS , &rc6vids,NULL ); +snb_pcode_read (gt->uncore,GEN6_PCODE_READ_RC6VIDS , &rc6vids,NULL );seq_printf (m,"RC1e Enabled: %s\n" ,str_yes_no (rcctl1 & GEN6_RC_CTL_RC1e_ENABLE));@@ -545,7 +545,7 @@ static int llc_show(struct seq_file *m, void *data) wakeref =intel_runtime_pm_get (gt->uncore->rpm);for (gpu_freq = min_gpu_freq; gpu_freq <= max_gpu_freq; gpu_freq++) { ia_freq = gpu_freq; -snb_pcode_read (i915,GEN6_PCODE_READ_MIN_FREQ_TABLE , +snb_pcode_read (gt->uncore,GEN6_PCODE_READ_MIN_FREQ_TABLE , &ia_freq,NULL ); seq_printf(m, "%d\t\t%d\t\t\t\t%d\n", intel_gpu_freq(rps,drivers/gpu/drm/i915/gt/intel_llc.c +1
-2@@ -124,7 +124,6 @@ static void calc_ia_freq(struct intel_llc *llc,static void gen6_update_ring_freq (struct intel_llc *llc) { -struct drm_i915_private *i915 =llc_to_gt (llc)->i915;struct ia_constants consts;unsigned int gpu_freq;@@ -142,7 +141,7 @@ static void gen6_update_ring_freq(struct intel_llc *llc)unsigned int ia_freq, ring_freq;calc_ia_freq (llc, gpu_freq, &consts, &ia_freq, &ring_freq); -snb_pcode_write (i915,GEN6_PCODE_WRITE_MIN_FREQ_TABLE , +snb_pcode_write (llc_to_gt (llc)->uncore,GEN6_PCODE_WRITE_MIN_FREQ_TABLE , ia_freq <<GEN6_PCODE_FREQ_IA_RATIO_SHIFT | ring_freq <<GEN6_PCODE_FREQ_RING_RATIO_SHIFT | gpu_freq);drivers/gpu/drm/i915/gt/intel_rc6.c +2
-2@@ -272,7 +272,7 @@ static void gen6_rc6_enable(struct intel_rc6 *rc6)GEN6_RC_CTL_HW_ENABLE ; rc6vids =0 ; - ret =snb_pcode_read (i915,GEN6_PCODE_READ_RC6VIDS , &rc6vids,NULL ); + ret =snb_pcode_read (rc6_to_gt (rc6)->uncore,GEN6_PCODE_READ_RC6VIDS , &rc6vids,NULL );if (GRAPHICS_VER (i915) ==6 && ret) {drm_dbg (&i915->drm,"Couldn't check for BIOS workaround\n" ); } else if (GRAPHICS_VER(i915) == 6 &&@@ -282,7 +282,7 @@ static void gen6_rc6_enable(struct intel_rc6 *rc6) GEN6_DECODE_RC6_VID(rc6vids & 0xff), 450); rc6vids &=0xffff00 ; rc6vids |=GEN6_ENCODE_RC6_VID (450 ); - ret =snb_pcode_write (i915,GEN6_PCODE_WRITE_RC6VIDS , rc6vids); + ret =snb_pcode_write (rc6_to_gt (rc6)->uncore,GEN6_PCODE_WRITE_RC6VIDS , rc6vids);if (ret)drm_err (&i915->drm,"Couldn't fix incorrect rc6 voltage\n" );drivers/gpu/drm/i915/gt/intel_rps.c +2
-2@@ -1142,7 +1142,7 @@ static void gen6_rps_init(struct intel_rps *rps)if (IS_GEN9_BC (i915) ||GRAPHICS_VER (i915) >=11 ) mult =GEN9_FREQ_SCALER ; -if (snb_pcode_read (i915,HSW_PCODE_DYNAMIC_DUTY_CYCLE_CONTROL , +if (snb_pcode_read (rps_to_gt (rps)->uncore,HSW_PCODE_DYNAMIC_DUTY_CYCLE_CONTROL , &ddcc_status,NULL ) ==0 ) rps->efficient_freq = clamp_t(u32,@@ -1982,7 +1982,7 @@ void intel_rps_init(struct intel_rps *rps)if (GRAPHICS_VER (i915) ==6 ||IS_IVYBRIDGE (i915) ||IS_HASWELL (i915)) {u32 params =0 ; -snb_pcode_read (i915,GEN6_READ_OC_PARAMS , ¶ms,NULL ); +snb_pcode_read (rps_to_gt (rps)->uncore,GEN6_READ_OC_PARAMS , ¶ms,NULL );if (params &BIT (31 )) {/* OC supported */ drm_dbg(&i915->drm, "Overclocking supported, max: %dMHz, overclock: %dMHz\n",drivers/gpu/drm/i915/gt/selftest_llc.c +1
-1@@ -31,7 +31,7 @@ static int gen6_verify_ring_freq(struct intel_llc *llc)calc_ia_freq (llc, gpu_freq, &consts, &ia_freq, &ring_freq); val = gpu_freq; -if (snb_pcode_read (i915,GEN6_PCODE_READ_MIN_FREQ_TABLE , +if (snb_pcode_read (llc_to_gt (llc)->uncore,GEN6_PCODE_READ_MIN_FREQ_TABLE , &val,NULL )) {pr_err ("Failed to read freq table[%d], range [%d, %d]\n" , gpu_freq, consts.min_gpu_freq, consts.max_gpu_freq);drivers/gpu/drm/i915/gt/selftest_rps.c +1
-1@@ -521,7 +521,7 @@ static void show_pcu_config(struct intel_rps *rps)for (gpu_freq = min_gpu_freq; gpu_freq <= max_gpu_freq; gpu_freq++) {int ia_freq = gpu_freq; -snb_pcode_read (i915,GEN6_PCODE_READ_MIN_FREQ_TABLE , +snb_pcode_read (rps_to_gt (rps)->uncore,GEN6_PCODE_READ_MIN_FREQ_TABLE , &ia_freq,NULL ); pr_info("%5d %5d %5d\n",drivers/gpu/drm/i915/i915_driver.c +0
-0@@ -520,6 +520,22 @@ static int i915_set_dma_info(struct drm_i915_private *i915)return ret; }drivers/gpu/drm/i915/i915_driver.c static int i915_set_dma_info(struct drm_i915_private *i915) · line 531
Quoted 10 lines
drivers/gpu/drm/i915/i915_driver.c +9
-0+static int i915_pcode_init (struct drm_i915_private *i915) +{ +struct intel_gt *gt; +int id, ret; + +for_each_gt (gt, i915, id) { + ret =intel_pcode_init (gt->uncore); +if (ret) { +drm_err (>->i915->drm,"gt %d: intel_pcode_init failed %d\n" , id, ret);A few nits..
Quoted 7 lines
1) All other/current logs use "gt%d" (no space).
2)
intel_pcode_initalso logs adrm_err- do we need two? I suggest leaving this one only since it has more information.3) It would have been nicer to have refactoring of
intel_pcode_to work on uncore separate from addingfor_each_gt.
Yeah.
Also the obvious first patch would've been to convert intel_pcode.c functions from struct drm_i915_private * to intel_uncore *.
BR,
Jani.
Quoted 286 lines
Regards,
Tvrtko
Quoted 281 lines
drivers/gpu/drm/i915/i915_driver.c +9
-2+return ret; + } + } + +return 0 ; +} +/** * i915_driver_hw_probe - setup state requiring device access * @dev_priv: device private @@ -629,7 +645,7 @@ static int i915_driver_hw_probe(struct drm_i915_private *dev_priv)intel_opregion_setup (dev_priv); - ret =intel_pcode_init (dev_priv); + ret =i915_pcode_init (dev_priv);if (ret) goto err_msi;@@ -1251,7 +1267,7 @@ static int i915_drm_resume(struct drm_device *dev)disable_rpm_wakeref_asserts (&dev_priv->runtime_pm); - ret =intel_pcode_init (dev_priv); + ret =i915_pcode_init (dev_priv);if (ret)return ret;drivers/gpu/drm/i915/intel_dram.c +1
-1@@ -393,7 +393,7 @@ static int icl_pcode_read_mem_global_info(struct drm_i915_private *dev_priv)u32 val =0 ;int ret; - ret =snb_pcode_read (dev_priv,ICL_PCODE_MEM_SUBSYSYSTEM_INFO | + ret =snb_pcode_read (&dev_priv->uncore,ICL_PCODE_MEM_SUBSYSYSTEM_INFO |ICL_PCODE_MEM_SS_READ_GLOBAL_INFO , &val,NULL );if (ret)return ret;drivers/gpu/drm/i915/intel_pcode.c +29
-31@@ -52,14 +52,12 @@ static int gen7_check_mailbox_status(u32 mbox) } } -static int __snb_pcode_rw (struct drm_i915_private *i915,u32 mbox, +static int __snb_pcode_rw (struct intel_uncore *uncore,u32 mbox,u32 *val,u32 *val1,int fast_timeout_us,int slow_timeout_ms,bool is_read) { -struct intel_uncore *uncore = &i915->uncore; - -lockdep_assert_held (&i915->sb_lock); +lockdep_assert_held (&uncore->i915->sb_lock);/* * GEN6_PCODE_* are outside of the forcewake domain, we can use @@ -88,22 +86,22 @@ static int __snb_pcode_rw(struct drm_i915_private *i915, u32 mbox,if (is_read && val1) *val1 =intel_uncore_read_fw (uncore,GEN6_PCODE_DATA1 ); -if (GRAPHICS_VER (i915) >6 ) +if (GRAPHICS_VER (uncore->i915) >6 )return gen7_check_mailbox_status (mbox);else return gen6_check_mailbox_status (mbox); } -int snb_pcode_read (struct drm_i915_private *i915,u32 mbox,u32 *val,u32 *val1) +int snb_pcode_read (struct intel_uncore *uncore,u32 mbox,u32 *val,u32 *val1) {int err; -mutex_lock (&i915->sb_lock); - err =__snb_pcode_rw (i915, mbox, val, val1,500 ,20 , true); -mutex_unlock (&i915->sb_lock); +mutex_lock (&uncore->i915->sb_lock); + err =__snb_pcode_rw (uncore, mbox, val, val1,500 ,20 , true); +mutex_unlock (&uncore->i915->sb_lock);if (err) { -drm_dbg (&i915->drm, +drm_dbg (&uncore->i915->drm,"warning: pcode (read from mbox %x) mailbox access failed for %ps: %d\n" , mbox,__builtin_return_address (0 ), err); }@@ -111,18 +109,18 @@ int snb_pcode_read(struct drm_i915_private *i915, u32 mbox, u32 *val, u32 *val1)return err; } -int snb_pcode_write_timeout (struct drm_i915_private *i915,u32 mbox,u32 val, +int snb_pcode_write_timeout (struct intel_uncore *uncore,u32 mbox,u32 val,int fast_timeout_us,int slow_timeout_ms) {int err; -mutex_lock (&i915->sb_lock); - err =__snb_pcode_rw (i915, mbox, &val,NULL , +mutex_lock (&uncore->i915->sb_lock); + err =__snb_pcode_rw (uncore, mbox, &val,NULL , fast_timeout_us, slow_timeout_ms, false); -mutex_unlock (&i915->sb_lock); +mutex_unlock (&uncore->i915->sb_lock);if (err) { -drm_dbg (&i915->drm, +drm_dbg (&uncore->i915->drm,"warning: pcode (write of 0x%08x to mbox %x) mailbox access failed for %ps: %d\n" , val, mbox,__builtin_return_address (0 ), err); }@@ -130,18 +128,18 @@ int snb_pcode_write_timeout(struct drm_i915_private *i915, u32 mbox, u32 val,return err; } -static bool skl_pcode_try_request (struct drm_i915_private *i915,u32 mbox, +static bool skl_pcode_try_request (struct intel_uncore *uncore,u32 mbox,u32 request,u32 reply_mask,u32 reply,u32 *status) { - *status =__snb_pcode_rw (i915, mbox, &request,NULL ,500 ,0 , true); + *status =__snb_pcode_rw (uncore, mbox, &request,NULL ,500 ,0 , true);return (*status ==0 ) && ((request & reply_mask) == reply); }/** * skl_pcode_request - send PCODE request until acknowledgment -* @i915: device private +* @uncore: uncore * @mbox: PCODE mailbox ID the request is targeted for * @request: request ID * @reply_mask: mask used to check for request acknowledgment @@ -158,16 +156,16 @@ static bool skl_pcode_try_request(struct drm_i915_private *i915, u32 mbox,* Returns 0 on success, %-ETIMEDOUT in case of a timeout, <0 in case of some * other error as reported by PCODE. */ -int skl_pcode_request (struct drm_i915_private *i915,u32 mbox,u32 request, +int skl_pcode_request (struct intel_uncore *uncore,u32 mbox,u32 request,u32 reply_mask,u32 reply,int timeout_base_ms) {u32 status;int ret; -mutex_lock (&i915->sb_lock); +mutex_lock (&uncore->i915->sb_lock);#define COND \ - skl_pcode_try_request(i915, mbox, request, reply_mask, reply, &status) + skl_pcode_try_request(uncore, mbox, request, reply_mask, reply, &status)/* * Prime the PCODE by doing a request first. Normally it guarantees @@ -193,35 +191,35 @@ int skl_pcode_request(struct drm_i915_private *i915, u32 mbox, u32 request,* requests, and for any quirks of the PCODE firmware that delays * the request completion. */ -drm_dbg_kms (&i915->drm, +drm_dbg_kms (&uncore->i915->drm,"PCODE timeout, retrying with preemption disabled\n" ); -drm_WARN_ON_ONCE (&i915->drm, timeout_base_ms >3 ); +drm_WARN_ON_ONCE (&uncore->i915->drm, timeout_base_ms >3 );preempt_disable (); ret =wait_for_atomic (COND ,50 );preempt_enable (); out: -mutex_unlock (&i915->sb_lock); +mutex_unlock (&uncore->i915->sb_lock);return status ? status : ret;#undef COND } -int intel_pcode_init (struct drm_i915_private *i915) +int intel_pcode_init (struct intel_uncore *uncore) { -int ret =0 ; +int ret; -if (!IS_DGFX (i915)) -return ret; +if (!IS_DGFX (uncore->i915)) +return 0 ; - ret =skl_pcode_request (i915,DG1_PCODE_STATUS , + ret =skl_pcode_request (uncore,DG1_PCODE_STATUS ,DG1_UNCORE_GET_INIT_STATUS ,DG1_UNCORE_INIT_STATUS_COMPLETE ,DG1_UNCORE_INIT_STATUS_COMPLETE ,180000 ); -drm_dbg (&i915->drm,"PCODE init status %d\n" , ret); +drm_dbg (&uncore->i915->drm,"PCODE init status %d\n" , ret);if (ret) -drm_err (&i915->drm,"Pcode did not report uncore initialization completion!\n" ); +drm_err (&uncore->i915->drm,"Pcode did not report uncore initialization completion!\n" );return ret; }drivers/gpu/drm/i915/intel_pcode.h +7
-7@@ -8,17 +8,17 @@#include <linux/types.h> -struct drm_i915_private ; +struct intel_uncore ; -int snb_pcode_read (struct drm_i915_private *i915,u32 mbox,u32 *val,u32 *val1); -int snb_pcode_write_timeout (struct drm_i915_private *i915,u32 mbox,u32 val, +int snb_pcode_read (struct intel_uncore *uncore,u32 mbox,u32 *val,u32 *val1); +int snb_pcode_write_timeout (struct intel_uncore *uncore,u32 mbox,u32 val,int fast_timeout_us,int slow_timeout_ms); -#define snb_pcode_write (i915, mbox, val) \ - snb_pcode_write_timeout(i915, mbox, val, 500, 0) +#define snb_pcode_write (uncore, mbox, val) \ + snb_pcode_write_timeout(uncore, mbox, val, 500, 0) -int skl_pcode_request (struct drm_i915_private *i915,u32 mbox,u32 request, +int skl_pcode_request (struct intel_uncore *uncore,u32 mbox,u32 request,u32 reply_mask,u32 reply,int timeout_base_ms); -int intel_pcode_init (struct drm_i915_private *i915); +int intel_pcode_init (struct intel_uncore *uncore);#endif /* _INTEL_PCODE_H */ drivers/gpu/drm/i915/intel_pm.c +5
-5@@ -2874,7 +2874,7 @@ static void intel_read_wm_latency(struct drm_i915_private *dev_priv,/* read the first set of memory latencies[0:3] */ val =0 ;/* data0 to be programmed to 0 for first set */ - ret =snb_pcode_read (dev_priv,GEN9_PCODE_READ_MEM_LATENCY , + ret =snb_pcode_read (&dev_priv->uncore,GEN9_PCODE_READ_MEM_LATENCY , &val,NULL );if (ret) {@@ -2893,7 +2893,7 @@ static void intel_read_wm_latency(struct drm_i915_private *dev_priv,/* read the second set of memory latencies[4:7] */ val =1 ;/* data0 to be programmed to 1 for second set */ - ret =snb_pcode_read (dev_priv,GEN9_PCODE_READ_MEM_LATENCY , + ret =snb_pcode_read (&dev_priv->uncore,GEN9_PCODE_READ_MEM_LATENCY , &val,NULL );if (ret) { drm_err(&dev_priv->drm,@@ -3679,7 +3679,7 @@ intel_sagv_block_time(struct drm_i915_private *dev_priv)u32 val =0 ;int ret; - ret =snb_pcode_read (dev_priv, + ret =snb_pcode_read (&dev_priv->uncore,GEN12_PCODE_READ_SAGV_BLOCK_TIME_US , &val,NULL );if (ret) {@@ -3748,7 +3748,7 @@ static void skl_sagv_enable(struct drm_i915_private *dev_priv)return ;drm_dbg_kms (&dev_priv->drm,"Enabling SAGV\n" ); - ret =snb_pcode_write (dev_priv,GEN9_PCODE_SAGV_CONTROL , + ret =snb_pcode_write (&dev_priv->uncore,GEN9_PCODE_SAGV_CONTROL ,GEN9_SAGV_ENABLE );/* We don't need to wait for SAGV when enabling */ @@ -3781,7 +3781,7 @@ static void skl_sagv_disable(struct drm_i915_private *dev_priv)drm_dbg_kms (&dev_priv->drm,"Disabling SAGV\n" );/* bspec says to keep retrying for at least 1 ms */ - ret =skl_pcode_request (dev_priv,GEN9_PCODE_SAGV_CONTROL , + ret =skl_pcode_request (&dev_priv->uncore,GEN9_PCODE_SAGV_CONTROL ,GEN9_SAGV_DISABLE ,GEN9_SAGV_IS_DISABLED ,GEN9_SAGV_IS_DISABLED ,1 );
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
Re: [Intel-gfx] [PATCH 3/8] drm/i915/pcode: Extend pcode functions for multiple gt's
Quoted 27 lines · Jani Nikula
Quoted 26 lines · Tvrtko Ursulin
Quoted 7 lines · Ashutosh Dixit
drivers/gpu/drm/i915/i915_driver.c +0
-0@@ -520,6 +520,22 @@ static int i915_set_dma_info(struct drm_i915_private *i915)return ret; }drivers/gpu/drm/i915/i915_driver.c static int i915_set_dma_info(struct drm_i915_private *i915) · line 531
Quoted 10 lines
drivers/gpu/drm/i915/i915_driver.c +9
-0+static int i915_pcode_init (struct drm_i915_private *i915) +{ +struct intel_gt *gt; +int id, ret; + +for_each_gt (gt, i915, id) { + ret =intel_pcode_init (gt->uncore); +if (ret) { +drm_err (>->i915->drm,"gt %d: intel_pcode_init failed %d\n" , id, ret);A few nits..
1) All other/current logs use "gt%d" (no space).
2)
intel_pcode_initalso logs adrm_err- do we need two? I suggest leaving this one only since it has more information.
Quoted 7 lines
Quoted 2 lines
3) It would have been nicer to have refactoring of
intel_pcode_to work on uncore separate from addingfor_each_gt.Yeah.
Also the obvious first patch would've been to convert
intel_pcode.cfunctions from structdrm_i915_private* tointel_uncore*.
Will fix up the first 2 points but about this last point, to not break incremental compile all callers of the pcode functions also need to be converted to i915->uncore or gt->uncore (so it's not possible to convert just intel_pcode.c functions without also converting all callers, if that was the intent of this comment, unless I am missing something).
But yes the i915_pcode_init() above can be separated out to a separate patch so I can do that.
Thanks.
--
Ashutosh
Re: [Intel-gfx] [PATCH 3/8] drm/i915/pcode: Extend pcode functions for multiple gt's
Quoted 33 lines · Ashutosh
Quoted 32 lines · Jani Nikula
Quoted 21 lines · Tvrtko Ursulin
Quoted 7 lines · Ashutosh Dixit
drivers/gpu/drm/i915/i915_driver.c +0
-0@@ -520,6 +520,22 @@ static int i915_set_dma_info(struct drm_i915_private *i915)return ret; }drivers/gpu/drm/i915/i915_driver.c static int i915_set_dma_info(struct drm_i915_private *i915) · line 531
Quoted 10 lines
drivers/gpu/drm/i915/i915_driver.c +9
-0+static int i915_pcode_init (struct drm_i915_private *i915) +{ +struct intel_gt *gt; +int id, ret; + +for_each_gt (gt, i915, id) { + ret =intel_pcode_init (gt->uncore); +if (ret) { +drm_err (>->i915->drm,"gt %d: intel_pcode_init failed %d\n" , id, ret);A few nits..
Quoted 7 lines
1) All other/current logs use "gt%d" (no space).
2)
intel_pcode_initalso logs adrm_err- do we need two? I suggest leaving this one only since it has more information.3) It would have been nicer to have refactoring of
intel_pcode_to work on uncore separate from addingfor_each_gt.Yeah.
Quoted 8 lines
Quoted 2 lines
Also the obvious first patch would've been to convert
intel_pcode.cfunctions from structdrm_i915_private* tointel_uncore*.Will fix up the first 2 points but about this last point, to not break incremental compile all callers of the pcode functions also need to be converted to
i915->uncoreorgt->uncore(so it's not possible to convert justintel_pcode.cfunctions without also converting all callers, if that was the intent of this comment, unless I am missing something).
Yes the implication is to convert the callers when doing such conversion, we never do broken commits.
Quoted 2 lines
But yes the
i915_pcode_init()above can be separated out to a separate patch so I can do that.
AFAIR that will achieve what is suggested, thanks!
Regards,
Tvrtko
Re: [Intel-gfx] [PATCH 3/8] drm/i915/pcode: Extend pcode functions for multiple gt's
Quoted 24 lines · Tvrtko Ursulin
Quoted 23 lines · Ashutosh
Quoted 22 lines · Jani Nikula
Quoted 21 lines · Tvrtko Ursulin
Quoted 7 lines · Ashutosh Dixit
drivers/gpu/drm/i915/i915_driver.c +0
-0@@ -520,6 +520,22 @@ static int i915_set_dma_info(struct drm_i915_private *i915)return ret; }drivers/gpu/drm/i915/i915_driver.c static int i915_set_dma_info(struct drm_i915_private *i915) · line 531
Quoted 10 lines
drivers/gpu/drm/i915/i915_driver.c +9
-0+static int i915_pcode_init (struct drm_i915_private *i915) +{ +struct intel_gt *gt; +int id, ret; + +for_each_gt (gt, i915, id) { + ret =intel_pcode_init (gt->uncore); +if (ret) { +drm_err (>->i915->drm,"gt %d: intel_pcode_init failed %d\n" , id, ret);A few nits..
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
1) All other/current logs use "gt%d" (no space).
Fixed.
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
2)
intel_pcode_initalso logs adrm_err- do we need two? I suggest leaving this one only since it has more information.
Remove duplicated drm_err and also drm_dbg from intel_pcode_init() in Patch v4 (Series v5).
Quoted 15 lines
Quoted 6 lines
Quoted 6 lines
Quoted 3 lines
3) It would have been nicer to have refactoring of
intel_pcode_to work on uncore separate from addingfor_each_gt.Yeah.
Quoted 8 lines
Quoted 2 lines
Also the obvious first patch would've been to convert
intel_pcode.cfunctions from structdrm_i915_private* tointel_uncore*.Will fix up the first 2 points but about this last point, to not break incremental compile all callers of the pcode functions also need to be converted to
i915->uncoreorgt->uncore(so it's not possible to convert justintel_pcode.cfunctions without also converting all callers, if that was the intent of this comment, unless I am missing something).
Quoted 7 lines
Yes the implication is to convert the callers when doing such conversion, we never do broken commits.
Quoted 2 lines
But yes the
i915_pcode_init()above can be separated out to a separate patch so I can do that.AFAIR that will achieve what is suggested, thanks!
Move out i915_pcode_init() to a separate patch "drm/i915/pcode: Init pcode on different gt's" in Patch v4 (Series v5).
Thanks.
--
Ashutosh
PATCH v4 4/8 drm/i915/pcode: Add a couple of pcode helpers
In reply to Ashutosh DixitFrom: Dale B Stimson <[email protected]>
Some dGfx pcode commands take additional sub-commands and parameters. Add a couple of helpers to help formatting these commands to improve code readability.
v2: Fixed commit author (Rodrigo)
v3: Function rename and convert to new uncore interface for pcode functions
Remove unnecessary #define's (Andi)
v4: Another function rename
--- drivers/gpu/drm/i915/i915_reg.h | 3 +++ drivers/gpu/drm/i915/intel_pcode.c | 32 ++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_pcode.h | 6 ++++++ 3 files changed, 41 insertions(+)
drivers/gpu/drm/i915/i915_reg.h +3 -0
@@ -6689,6 +6689,9 @@#define GEN6_PCODE_MAILBOX _MMIO(0x138124)#define GEN6_PCODE_READY (1 << 31) +#define GEN6_PCODE_MB_PARAM2 REG_GENMASK(23, 16) +#define GEN6_PCODE_MB_PARAM1 REG_GENMASK(15, 8) +#define GEN6_PCODE_MB_COMMAND REG_GENMASK(7, 0)#define GEN6_PCODE_ERROR_MASK 0xFF#define GEN6_PCODE_SUCCESS 0x0#define GEN6_PCODE_ILLEGAL_CMD 0x1
drivers/gpu/drm/i915/intel_pcode.c +32 -0
@@ -223,3 +223,35 @@ int intel_pcode_init(struct intel_uncore *uncore)return ret; } + +int snb_pcode_read_p (struct intel_uncore *uncore,u32 mbcmd,u32 p1,u32 p2,u32 *val) +{ +intel_wakeref_t wakeref; +u32 mbox; +int err; + + mbox =REG_FIELD_PREP (GEN6_PCODE_MB_COMMAND , mbcmd) + |REG_FIELD_PREP (GEN6_PCODE_MB_PARAM1 , p1) + |REG_FIELD_PREP (GEN6_PCODE_MB_PARAM2 , p2); + +with_intel_runtime_pm (uncore->rpm, wakeref) + err = snb_pcode_read(uncore, mbox, val, NULL); + +return err; +} + +int snb_pcode_write_p (struct intel_uncore *uncore,u32 mbcmd,u32 p1,u32 p2,u32 val) +{ +intel_wakeref_t wakeref; +u32 mbox; +int err; + + mbox =REG_FIELD_PREP (GEN6_PCODE_MB_COMMAND , mbcmd) + |REG_FIELD_PREP (GEN6_PCODE_MB_PARAM1 , p1) + |REG_FIELD_PREP (GEN6_PCODE_MB_PARAM2 , p2); + +with_intel_runtime_pm (uncore->rpm, wakeref) + err = snb_pcode_write(uncore, mbox, val); + +return err; +}
drivers/gpu/drm/i915/intel_pcode.h +6 -0
@@ -21,4 +21,10 @@ int skl_pcode_request(struct intel_uncore *uncore, u32 mbox, u32 request,int intel_pcode_init (struct intel_uncore *uncore); +/* +* Helpers for dGfx PCODE mailbox command formatting +*/ +int snb_pcode_read_p (struct intel_uncore *uncore,u32 mbcmd,u32 p1,u32 p2,u32 *val); +int snb_pcode_write_p (struct intel_uncore *uncore,u32 mbcmd,u32 p1,u32 p2,u32 val); +#endif /* _INTEL_PCODE_H */
Signature · 1 line
2.34.1
PATCH v4 5/8 drm/i915/gt: Add media RP0/RPn to per-gt sysfs
In reply to Ashutosh DixitFrom: Dale B Stimson <[email protected]>
Retrieve RP0 and RPn freq for media IP from PCODE and display in per-gt sysfs. This patch adds the following files to gt/gtN sysfs:
* media_RP0_freq_mhz
* media_RPn_freq_mhz
v2: Fixed commit author (Rodrigo)
v3: Convert to new uncore interface for pcode functions
v4: Adapt to intel_pcode.* function rename
--- drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 47 +++++++++++++++++++++ drivers/gpu/drm/i915/i915_reg.h | 8 ++++ 2 files changed, 55 insertions(+)
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c +47 -0
@@ -12,6 +12,7 @@#include "i915_sysfs.h" #include "intel_gt.h" #include "intel_gt_regs.h" +#include "intel_pcode.h" #include "intel_gt_sysfs.h" #include "intel_gt_sysfs_pm.h" #include "intel_rc6.h"
@@ -669,13 +670,59 @@ static ssize_t media_freq_factor_store(struct device *dev,return err ?: count; } +static ssize_t media_RP0_freq_mhz_show (struct device *dev, +struct device_attribute *attr, +char *buff) +{ +struct intel_gt *gt =intel_gt_sysfs_get_drvdata (dev, attr->attr.name); +u32 val; +int err; + + err =snb_pcode_read_p (gt->uncore,XEHPSDV_PCODE_FREQUENCY_CONFIG , +PCODE_MBOX_FC_SC_READ_FUSED_P0 , +PCODE_MBOX_DOMAIN_MEDIAFF , &val); + +if (err) +return err; + +/* Fused media RP0 read from pcode is in units of 50 MHz */ + val *=GT_FREQUENCY_MULTIPLIER ; + +return sysfs_emit (buff,"%u\n" , val); +} + +static ssize_t media_RPn_freq_mhz_show (struct device *dev, +struct device_attribute *attr, +char *buff) +{ +struct intel_gt *gt =intel_gt_sysfs_get_drvdata (dev, attr->attr.name); +u32 val; +int err; + + err =snb_pcode_read_p (gt->uncore,XEHPSDV_PCODE_FREQUENCY_CONFIG , +PCODE_MBOX_FC_SC_READ_FUSED_PN , +PCODE_MBOX_DOMAIN_MEDIAFF , &val); + +if (err) +return err; + +/* Fused media RPn read from pcode is in units of 50 MHz */ + val *=GT_FREQUENCY_MULTIPLIER ; + +return sysfs_emit (buff,"%u\n" , val); +} +static DEVICE_ATTR_RW (media_freq_factor);static struct device_attribute dev_attr_media_freq_factor_scale =__ATTR (media_freq_factor.scale,0444 , freq_factor_scale_show,NULL ); +static DEVICE_ATTR_RO (media_RP0_freq_mhz); +static DEVICE_ATTR_RO (media_RPn_freq_mhz);static const struct attribute *media_perf_power_attrs[] = { &dev_attr_media_freq_factor.attr, &dev_attr_media_freq_factor_scale.attr, + &dev_attr_media_RP0_freq_mhz.attr, + &dev_attr_media_RPn_freq_mhz.attr,NULL };
drivers/gpu/drm/i915/i915_reg.h +8 -0
@@ -6758,6 +6758,14 @@#define DG1_UNCORE_GET_INIT_STATUS 0x0#define DG1_UNCORE_INIT_STATUS_COMPLETE 0x1#define GEN12_PCODE_READ_SAGV_BLOCK_TIME_US 0x23 +#define XEHPSDV_PCODE_FREQUENCY_CONFIG 0x6e/* xehpsdv, pvc */ +/* XEHPSDV_PCODE_FREQUENCY_CONFIG sub-commands (param1) */ +#define PCODE_MBOX_FC_SC_READ_FUSED_P0 0x0 +#define PCODE_MBOX_FC_SC_READ_FUSED_PN 0x1 +/* PCODE_MBOX_DOMAIN_* - mailbox domain IDs */ +/* XEHPSDV_PCODE_FREQUENCY_CONFIG param2 */ +#define PCODE_MBOX_DOMAIN_NONE 0x0 +#define PCODE_MBOX_DOMAIN_MEDIAFF 0x3#define GEN6_PCODE_DATA _MMIO(0x138128)#define GEN6_PCODE_FREQ_IA_RATIO_SHIFT 8#define GEN6_PCODE_FREQ_RING_RATIO_SHIFT 16
Signature · 1 line
2.34.1
Re: [Intel-gfx] [PATCH 5/8] drm/i915/gt: Add media RP0/RPn to per-gt sysfs
Quoted 26 lines · Ashutosh Dixit
From: Dale B Stimson <[email protected]>
Retrieve RP0 and RPn freq for media IP from PCODE and display in per-gt sysfs. This patch adds the following files to gt/gtN sysfs:
*media_RP0_freq_mhz
*media_RPn_freq_mhzv2: Fixed commit author (Rodrigo)
v3: Convert to new uncore interface for pcode functions
v4: Adapt to intel_pcode.* function renameCc Rodrigo Vivi <[email protected]>Cc Joonas Lahtinen <[email protected]>Signed-off-by Dale B Stimson <[email protected]>Signed-off-by Ashutosh Dixit <[email protected]>Reviewed-by Andi Shyti <[email protected]>--- drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 47 +++++++++++++++++++++ drivers/gpu/drm/i915/i915_reg.h | 8 ++++ 2 files changed, 55 insertions(+)drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c +0
-0
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c line 15
Quoted 4 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c +1
-0@@ -12,6 +12,7 @@#include "i915_sysfs.h" #include "intel_gt.h" #include "intel_gt_regs.h" +#include "intel_pcode.h"
Nit - in an alphabetical sandwich.
Regards,
Tvrtko
Quoted 82 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c +46
-0#include "intel_gt_sysfs.h" #include "intel_gt_sysfs_pm.h" #include "intel_rc6.h" @@ -669,13 +670,59 @@ static ssize_t media_freq_factor_store(struct device *dev,return err ?: count; } +static ssize_t media_RP0_freq_mhz_show (struct device *dev, +struct device_attribute *attr, +char *buff) +{ +struct intel_gt *gt =intel_gt_sysfs_get_drvdata (dev, attr->attr.name); +u32 val; +int err; + + err =snb_pcode_read_p (gt->uncore,XEHPSDV_PCODE_FREQUENCY_CONFIG , +PCODE_MBOX_FC_SC_READ_FUSED_P0 , +PCODE_MBOX_DOMAIN_MEDIAFF , &val); + +if (err) +return err; + +/* Fused media RP0 read from pcode is in units of 50 MHz */ + val *=GT_FREQUENCY_MULTIPLIER ; + +return sysfs_emit (buff,"%u\n" , val); +} + +static ssize_t media_RPn_freq_mhz_show (struct device *dev, +struct device_attribute *attr, +char *buff) +{ +struct intel_gt *gt =intel_gt_sysfs_get_drvdata (dev, attr->attr.name); +u32 val; +int err; + + err =snb_pcode_read_p (gt->uncore,XEHPSDV_PCODE_FREQUENCY_CONFIG , +PCODE_MBOX_FC_SC_READ_FUSED_PN , +PCODE_MBOX_DOMAIN_MEDIAFF , &val); + +if (err) +return err; + +/* Fused media RPn read from pcode is in units of 50 MHz */ + val *=GT_FREQUENCY_MULTIPLIER ; + +return sysfs_emit (buff,"%u\n" , val); +} +static DEVICE_ATTR_RW (media_freq_factor);static struct device_attribute dev_attr_media_freq_factor_scale =__ATTR (media_freq_factor.scale,0444 , freq_factor_scale_show,NULL ); +static DEVICE_ATTR_RO (media_RP0_freq_mhz); +static DEVICE_ATTR_RO (media_RPn_freq_mhz);static const struct attribute *media_perf_power_attrs[] = { &dev_attr_media_freq_factor.attr, &dev_attr_media_freq_factor_scale.attr, + &dev_attr_media_RP0_freq_mhz.attr, + &dev_attr_media_RPn_freq_mhz.attr,NULL };drivers/gpu/drm/i915/i915_reg.h +8
-0@@ -6758,6 +6758,14 @@#define DG1_UNCORE_GET_INIT_STATUS 0x0#define DG1_UNCORE_INIT_STATUS_COMPLETE 0x1#define GEN12_PCODE_READ_SAGV_BLOCK_TIME_US 0x23 +#define XEHPSDV_PCODE_FREQUENCY_CONFIG 0x6e/* xehpsdv, pvc */ +/* XEHPSDV_PCODE_FREQUENCY_CONFIG sub-commands (param1) */ +#define PCODE_MBOX_FC_SC_READ_FUSED_P0 0x0 +#define PCODE_MBOX_FC_SC_READ_FUSED_PN 0x1 +/* PCODE_MBOX_DOMAIN_* - mailbox domain IDs */ +/* XEHPSDV_PCODE_FREQUENCY_CONFIG param2 */ +#define PCODE_MBOX_DOMAIN_NONE 0x0 +#define PCODE_MBOX_DOMAIN_MEDIAFF 0x3#define GEN6_PCODE_DATA _MMIO(0x138128)#define GEN6_PCODE_FREQ_IA_RATIO_SHIFT 8#define GEN6_PCODE_FREQ_RING_RATIO_SHIFT 16
Re: [Intel-gfx] [PATCH 5/8] drm/i915/gt: Add media RP0/RPn to per-gt sysfs
Quoted 11 lines · Tvrtko Ursulin
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c line 15
Quoted 9 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c +1
-0@@ -12,6 +12,7 @@#include "i915_sysfs.h" #include "intel_gt.h" #include "intel_gt_regs.h" +#include "intel_pcode.h" Nit - in an alphabetical sandwich.
Fixed in Patch v5 (Series v5).
PATCH v4 6/8 drm/i915/gt: Fix memory leaks in per-gt sysfs
In reply to Ashutosh DixitAll kmalloc'd kobjects need a kobject_put() to free memory. For example in previous code, kobj_gt_release() never gets called. The requirement of kobject_put() now results in a slightly different code organization.
v2: s/gtn/gt/ (Andi)
--- drivers/gpu/drm/i915/gt/intel_gt.c | 1 + drivers/gpu/drm/i915/gt/intel_gt_sysfs.c | 29 ++++++++++-------------- drivers/gpu/drm/i915/gt/intel_gt_sysfs.h | 6 +---- drivers/gpu/drm/i915/gt/intel_gt_types.h | 3 +++ drivers/gpu/drm/i915/i915_sysfs.c | 2 ++ 5 files changed, 19 insertions(+), 22 deletions(-)
drivers/gpu/drm/i915/gt/intel_gt.c +1 -0
@@ -785,6 +785,7 @@ void intel_gt_driver_unregister(struct intel_gt *gt) {intel_wakeref_t wakeref; +intel_gt_sysfs_unregister (gt);intel_rps_driver_unregister (>->rps);intel_gsc_fini (>->gsc);
drivers/gpu/drm/i915/gt/intel_gt_sysfs.c +12 -17
@@ -24,7 +24,7 @@ bool is_object_gt(struct kobject *kobj)static struct intel_gt *kobj_to_gt (struct kobject *kobj) { - return container_of(kobj, struct kobj_gt, base)->gt; + return container_of(kobj, struct intel_gt, sysfs_gt); } struct intel_gt *intel_gt_sysfs_get_drvdata(struct device *dev,
@@ -72,9 +72,9 @@ static struct attribute *id_attrs[] = { };ATTRIBUTE_GROUPS (id); +/* A kobject needs a release() method even if it does nothing */ static void kobj_gt_release (struct kobject *kobj) { -kfree (kobj); }static struct kobj_type kobj_gt_type = {
@@ -85,8 +85,6 @@ static struct kobj_type kobj_gt_type = {void intel_gt_sysfs_register (struct intel_gt *gt) { -struct kobj_gt *kg; -/* * We need to make things right with the * ABI compatibility. The files were originally
@@ -98,25 +96,22 @@ void intel_gt_sysfs_register(struct intel_gt *gt)if (gt_is_root (gt))intel_gt_sysfs_pm_init (gt,gt_get_parent_obj (gt)); - kg =kzalloc (sizeof (*kg),GFP_KERNEL ); -if (!kg) +/* init and xfer ownership to sysfs tree */ +if (kobject_init_and_add (>->sysfs_gt, &kobj_gt_type, + gt->i915->sysfs_gt,"gt%d" , gt->info.id)) goto exit_fail; -kobject_init (&kg->base, &kobj_gt_type); - kg->gt = gt; - -/* xfer ownership to sysfs tree */ -if (kobject_add (&kg->base, gt->i915->sysfs_gt,"gt%d" , gt->info.id)) - goto exit_kobj_put; - -intel_gt_sysfs_pm_init (gt, &kg->base); +intel_gt_sysfs_pm_init (gt, >->sysfs_gt);return ; -exit_kobj_put: -kobject_put (&kg->base); - exit_fail: +kobject_put (>->sysfs_gt);drm_warn (>->i915->drm,"failed to initialize gt%d sysfs root\n" , gt->info.id); } + +void intel_gt_sysfs_unregister (struct intel_gt *gt) +{ +kobject_put (>->sysfs_gt); +}
drivers/gpu/drm/i915/gt/intel_gt_sysfs.h +1 -5
@@ -13,11 +13,6 @@struct intel_gt ; -struct kobj_gt { -struct kobject base; -struct intel_gt *gt; -}; -bool is_object_gt (struct kobject *kobj);struct drm_i915_private *kobj_to_i915 (struct kobject *kobj);
@@ -28,6 +23,7 @@ intel_gt_create_kobj(struct intel_gt *gt, const char *name);void intel_gt_sysfs_register (struct intel_gt *gt); +void intel_gt_sysfs_unregister (struct intel_gt *gt);struct intel_gt *intel_gt_sysfs_get_drvdata (struct device *dev,const char *name);
drivers/gpu/drm/i915/gt/intel_gt_types.h +3 -0
@@ -224,6 +224,9 @@ struct intel_gt { } mocs;struct intel_pxp pxp; + +/* gt/gtN sysfs */ +struct kobject sysfs_gt; };enum intel_gt_scratch_field {
drivers/gpu/drm/i915/i915_sysfs.c +2 -0
@@ -259,4 +259,6 @@ void i915_teardown_sysfs(struct drm_i915_private *dev_priv)device_remove_bin_file (kdev, &dpf_attrs_1);device_remove_bin_file (kdev, &dpf_attrs); + +kobject_put (dev_priv->sysfs_gt); }
Signature · 1 line
2.34.1
Re: [Intel-gfx] [PATCH 6/8] drm/i915/gt: Fix memory leaks in per-gt sysfs
Hi Ashutosh,
Quoted 10 lines · Ashutosh Dixit
All kmalloc'd kobjects need a
kobject_put()to free memory. For example in previous code,kobj_gt_release()never gets called. The requirement ofkobject_put()now results in a slightly different code organization.v2: s/gtn/gt/ (Andi)
Cc Andi Shyti <[email protected]>Cc Andrzej Hajda <[email protected]>Fixes b770bcfae9ad ("drm/i915/gt: create per-tile sysfs interface")Signed-off-by Ashutosh Dixit <[email protected]>
I tagget the wrong version (which is the same as this one):
Andi
Re: [Intel-gfx] [PATCH 6/8] drm/i915/gt: Fix memory leaks in per-gt sysfs
In reply to Ashutosh DixitQuoted 64 lines · Ashutosh Dixit
All kmalloc'd kobjects need a
kobject_put()to free memory. For example in previous code,kobj_gt_release()never gets called. The requirement ofkobject_put()now results in a slightly different code organization.v2: s/gtn/gt/ (Andi)
Cc Andi Shyti <[email protected]>Cc Andrzej Hajda <[email protected]>Fixes b770bcfae9ad ("drm/i915/gt: create per-tile sysfs interface")Signed-off-by Ashutosh Dixit <[email protected]>--- drivers/gpu/drm/i915/gt/intel_gt.c | 1 + drivers/gpu/drm/i915/gt/intel_gt_sysfs.c | 29 ++++++++++-------------- drivers/gpu/drm/i915/gt/intel_gt_sysfs.h | 6 +---- drivers/gpu/drm/i915/gt/intel_gt_types.h | 3 +++ drivers/gpu/drm/i915/i915_sysfs.c | 2 ++ 5 files changed, 19 insertions(+), 22 deletions(-)drivers/gpu/drm/i915/gt/intel_gt.c +1
-0@@ -785,6 +785,7 @@ void intel_gt_driver_unregister(struct intel_gt *gt) {intel_wakeref_t wakeref; +intel_gt_sysfs_unregister (gt);intel_rps_driver_unregister (>->rps);intel_gsc_fini (>->gsc);drivers/gpu/drm/i915/gt/intel_gt_sysfs.c +2
-4@@ -24,7 +24,7 @@ bool is_object_gt(struct kobject *kobj)static struct intel_gt *kobj_to_gt (struct kobject *kobj) { - return container_of(kobj, struct kobj_gt, base)->gt; + return container_of(kobj, struct intel_gt, sysfs_gt); } struct intel_gt *intel_gt_sysfs_get_drvdata(struct device *dev,@@ -72,9 +72,9 @@ static struct attribute *id_attrs[] = { };ATTRIBUTE_GROUPS (id); +/* A kobject needs a release() method even if it does nothing */ static void kobj_gt_release (struct kobject *kobj) { -kfree (kobj); }static struct kobj_type kobj_gt_type = {@@ -85,8 +85,6 @@ static struct kobj_type kobj_gt_type = {void intel_gt_sysfs_register (struct intel_gt *gt) { -struct kobj_gt *kg; -/* * We need to make things right with the * ABI compatibility. The files were originally
drivers/gpu/drm/i915/gt/intel_gt_sysfs.c void intel_gt_sysfs_register(struct intel_gt *gt) · line 101
Quoted 8 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs.c +3
-2@@ -98,25 +96,22 @@ void intel_gt_sysfs_register(struct intel_gt *gt)if (gt_is_root (gt))intel_gt_sysfs_pm_init (gt,gt_get_parent_obj (gt)); - kg =kzalloc (sizeof (*kg),GFP_KERNEL ); -if (!kg) +/* init and xfer ownership to sysfs tree */ +if (kobject_init_and_add (>->sysfs_gt, &kobj_gt_type, + gt->i915->sysfs_gt,"gt%d" , gt->info.id))
Was there closure/agreement on the matter of whether or not there is a potential race between "kfree(gt)" and sysfs access (last put from sysfs that is)? I've noticed Andrzej and Ashutosh were discussing it but did not read all the details.
Regards,
Tvrtko
Quoted 76 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs.c +7
-11goto exit_fail; -kobject_init (&kg->base, &kobj_gt_type); - kg->gt = gt; - -/* xfer ownership to sysfs tree */ -if (kobject_add (&kg->base, gt->i915->sysfs_gt,"gt%d" , gt->info.id)) - goto exit_kobj_put; - -intel_gt_sysfs_pm_init (gt, &kg->base); +intel_gt_sysfs_pm_init (gt, >->sysfs_gt);return ; -exit_kobj_put: -kobject_put (&kg->base); - exit_fail: +kobject_put (>->sysfs_gt);drm_warn (>->i915->drm,"failed to initialize gt%d sysfs root\n" , gt->info.id); } + +void intel_gt_sysfs_unregister (struct intel_gt *gt) +{ +kobject_put (>->sysfs_gt); +}drivers/gpu/drm/i915/gt/intel_gt_sysfs.h +1
-5@@ -13,11 +13,6 @@struct intel_gt ; -struct kobj_gt { -struct kobject base; -struct intel_gt *gt; -}; -bool is_object_gt (struct kobject *kobj);struct drm_i915_private *kobj_to_i915 (struct kobject *kobj);@@ -28,6 +23,7 @@ intel_gt_create_kobj(struct intel_gt *gt, const char *name);void intel_gt_sysfs_register (struct intel_gt *gt); +void intel_gt_sysfs_unregister (struct intel_gt *gt);struct intel_gt *intel_gt_sysfs_get_drvdata (struct device *dev,const char *name);drivers/gpu/drm/i915/gt/intel_gt_types.h +3
-0@@ -224,6 +224,9 @@ struct intel_gt { } mocs;struct intel_pxp pxp; + +/* gt/gtN sysfs */ +struct kobject sysfs_gt; };enum intel_gt_scratch_field {drivers/gpu/drm/i915/i915_sysfs.c +2
-0@@ -259,4 +259,6 @@ void i915_teardown_sysfs(struct drm_i915_private *dev_priv)device_remove_bin_file (kdev, &dpf_attrs_1);device_remove_bin_file (kdev, &dpf_attrs); + +kobject_put (dev_priv->sysfs_gt); }
Andrzej Hajda
Acked-byRe: [Intel-gfx] [PATCH 6/8] drm/i915/gt: Fix memory leaks in per-gt sysfs
Hi Tvrtko,
Quoted 60 lines · Tvrtko Ursulin
Quoted 58 lines · Ashutosh Dixit
All kmalloc'd kobjects need a
kobject_put()to free memory. For example in previous code,kobj_gt_release()never gets called. The requirement ofkobject_put()now results in a slightly different code organization.v2: s/gtn/gt/ (Andi)
Cc Andi Shyti <[email protected]>Cc Andrzej Hajda <[email protected]>Fixes b770bcfae9ad ("drm/i915/gt: create per-tile sysfs interface")Signed-off-by Ashutosh Dixit <[email protected]>---
drivers/gpu/drm/i915/gt/intel_gt.c | 1 +drivers/gpu/drm/i915/gt/intel_gt_sysfs.c | 29 ++++++++++-------------- drivers/gpu/drm/i915/gt/intel_gt_sysfs.h | 6 +---- drivers/gpu/drm/i915/gt/intel_gt_types.h | 3 +++ drivers/gpu/drm/i915/i915_sysfs.c | 2 ++ 5 files changed, 19 insertions(+), 22 deletions(-)drivers/gpu/drm/i915/gt/intel_gt.c +0
-0@@ -785,6 +785,7 @@ void intel_gt_driver_unregister(struct intel_gt *gt) { intel_wakeref_t wakeref; + intel_gt_sysfs_unregister(gt); intel_rps_driver_unregister(>->rps); intel_gsc_fini(>->gsc);diff --git
a/drivers/gpu/drm/i915/gt/intel_gt_sysfs.cb/drivers/gpu/drm/i915/gt/intel_gt_sysfs.cindex8ec8bc660c8c..9e4ebf53379b100644drivers/gpu/drm/i915/gt/intel_gt_sysfs.c +1
-1@@ -24,7 +24,7 @@ bool is_object_gt(struct kobject *kobj) static struct intel_gt *kobj_to_gt(struct kobject *kobj) { - return container_of(kobj, struct kobj_gt, base)->gt; + return container_of(kobj, struct intel_gt, sysfs_gt); } struct intel_gt *intel_gt_sysfs_get_drvdata(struct device *dev,@@ -72,9 +72,9 @@ static struct attribute *id_attrs[] = { }; ATTRIBUTE_GROUPS(id);+/* A kobject needs a
release()method even if it does nothing */ static voidkobj_gt_release(struct kobject *kobj)
{
- kfree(kobj);
}
static structkobj_typekobj_gt_type= {drivers/gpu/drm/i915/gt/intel_gt_sysfs.c +0
-2@@ -85,8 +85,6 @@ static struct kobj_type kobj_gt_type = { void intel_gt_sysfs_register(struct intel_gt *gt) { - struct kobj_gt *kg; - /** We need to make things right with the * ABI compatibility. The files were originally @@ -98,25 +96,22 @@ void intel_gt_sysfs_register(struct intel_gt *gt) if (gt_is_root(gt))
Quoted 9 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs.c void intel_gt_sysfs_register(struct intel_gt *gt) · line 101
Quoted 6 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs.c +3
-1intel_gt_sysfs_pm_init(gt, gt_get_parent_obj(gt)); - kg = kzalloc(sizeof(*kg), GFP_KERNEL); - if (!kg) + /* init and xfer ownership to sysfs tree */ + if (kobject_init_and_add(>->sysfs_gt, &kobj_gt_type, + gt->i915->sysfs_gt, "gt%d", gt->info.id))Was there closure/agreement on the matter of whether or not there is a potential race between "kfree(gt)" and sysfs access (last put from sysfs that is)? I've noticed Andrzej and Ashutosh were discussing it but did not read all the details.
Not really :)
IMO docs are against this practice, Ashutosh shows examples of this practice in code and according to his analysis it is safe.
I gave up looking for contradictions :) Either it is OK, kobject is not fully shared object, docs are obsolete and needs update, either the patch is wrong. Anyway finally I tend to accept this solution, I failed to prove it is wrong :)
Regards
Andrzej
Regards
Andrzej
Re: [Intel-gfx] [PATCH 6/8] drm/i915/gt: Fix memory leaks in per-gt sysfs
Quoted 73 lines · Andrzej Hajda
Hi Tvrtko,
Quoted 60 lines · Tvrtko Ursulin
Quoted 58 lines · Ashutosh Dixit
All kmalloc'd kobjects need a
kobject_put()to free memory. For example in previous code,kobj_gt_release()never gets called. The requirement ofkobject_put()now results in a slightly different code organization.v2: s/gtn/gt/ (Andi)
Cc Andi Shyti <[email protected]>Cc Andrzej Hajda <[email protected]>Fixes b770bcfae9ad ("drm/i915/gt: create per-tile sysfs interface")Signed-off-by Ashutosh Dixit <[email protected]>---
drivers/gpu/drm/i915/gt/intel_gt.c | 1 +drivers/gpu/drm/i915/gt/intel_gt_sysfs.c | 29 ++++++++++-------------- drivers/gpu/drm/i915/gt/intel_gt_sysfs.h | 6 +---- drivers/gpu/drm/i915/gt/intel_gt_types.h | 3 +++ drivers/gpu/drm/i915/i915_sysfs.c | 2 ++ 5 files changed, 19 insertions(+), 22 deletions(-)drivers/gpu/drm/i915/gt/intel_gt.c +0
-0@@ -785,6 +785,7 @@ void intel_gt_driver_unregister(struct intel_gt *gt) { intel_wakeref_t wakeref; + intel_gt_sysfs_unregister(gt); intel_rps_driver_unregister(>->rps); intel_gsc_fini(>->gsc);diff --git
a/drivers/gpu/drm/i915/gt/intel_gt_sysfs.cb/drivers/gpu/drm/i915/gt/intel_gt_sysfs.cindex8ec8bc660c8c..9e4ebf53379b100644drivers/gpu/drm/i915/gt/intel_gt_sysfs.c +1
-1@@ -24,7 +24,7 @@ bool is_object_gt(struct kobject *kobj) static struct intel_gt *kobj_to_gt(struct kobject *kobj) { - return container_of(kobj, struct kobj_gt, base)->gt; + return container_of(kobj, struct intel_gt, sysfs_gt); } struct intel_gt *intel_gt_sysfs_get_drvdata(struct device *dev,@@ -72,9 +72,9 @@ static struct attribute *id_attrs[] = { }; ATTRIBUTE_GROUPS(id);+/* A kobject needs a
release()method even if it does nothing */ static voidkobj_gt_release(struct kobject *kobj)
{
- kfree(kobj);
}
static structkobj_typekobj_gt_type= {drivers/gpu/drm/i915/gt/intel_gt_sysfs.c +0
-2@@ -85,8 +85,6 @@ static struct kobj_type kobj_gt_type = { void intel_gt_sysfs_register(struct intel_gt *gt) { - struct kobj_gt *kg; - /** We need to make things right with the * ABI compatibility. The files were originally @@ -98,25 +96,22 @@ void intel_gt_sysfs_register(struct intel_gt *gt) if (gt_is_root(gt))Quoted 9 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs.c void intel_gt_sysfs_register(struct intel_gt *gt) · line 101
Quoted 6 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs.c +3
-1intel_gt_sysfs_pm_init(gt, gt_get_parent_obj(gt)); - kg = kzalloc(sizeof(*kg), GFP_KERNEL); - if (!kg) + /* init and xfer ownership to sysfs tree */ + if (kobject_init_and_add(>->sysfs_gt, &kobj_gt_type, + gt->i915->sysfs_gt, "gt%d", gt->info.id))Was there closure/agreement on the matter of whether or not there is a potential race between "kfree(gt)" and sysfs access (last put from sysfs that is)? I've noticed Andrzej and Ashutosh were discussing it but did not read all the details.
Quoted 4 lines
Not really :)
IMO docs are against this practice, Ashutosh shows examples of this practice in code and according to his analysis it is safe.
I gave up looking for contradictions :) Either it is OK, kobject is not fully shared object, docs are obsolete and needs update, either the patch is wrong. Anyway finally I tend to accept this solution, I failed to prove it is wrong :)
Like a question of whether hotunplug can be triggered while userspace is sitting in a sysfs hook? Final kfree then has to be delayed until userspace exists.
Btw where is the "kfree(gt)" for the tiles on the PCI remove path? I can't find it.. Do we have a leak?
Regards,
Tvrtko
Re: [Intel-gfx] [PATCH 6/8] drm/i915/gt: Fix memory leaks in per-gt sysfs
Quoted 77 lines · Tvrtko Ursulin
Quoted 75 lines · Andrzej Hajda
Hi Tvrtko,
Quoted 71 lines · Tvrtko Ursulin
Quoted 59 lines · Ashutosh Dixit
All kmalloc'd kobjects need a
kobject_put()to free memory. For example in previous code,kobj_gt_release()never gets called. The requirement ofkobject_put()now results in a slightly different code organization.v2: s/gtn/gt/ (Andi)
Cc Andi Shyti <[email protected]>Cc Andrzej Hajda <[email protected]>Fixes b770bcfae9ad ("drm/i915/gt: create per-tile sysfs interface")Signed-off-by Ashutosh Dixit <[email protected]>---
drivers/gpu/drm/i915/gt/intel_gt.c | 1 +drivers/gpu/drm/i915/gt/intel_gt_sysfs.c| 29
++++++++++--------------
drivers/gpu/drm/i915/gt/intel_gt_sysfs.h| 6 +----drivers/gpu/drm/i915/gt/intel_gt_types.h| 3 +++ drivers/gpu/drm/i915/i915_sysfs.c | 2 ++5 files changed, 19 insertions(+), 22 deletions(-)drivers/gpu/drm/i915/gt/intel_gt.c +0
-0@@ -785,6 +785,7 @@ void intel_gt_driver_unregister(struct intel_gt *gt) { intel_wakeref_t wakeref; + intel_gt_sysfs_unregister(gt); intel_rps_driver_unregister(>->rps); intel_gsc_fini(>->gsc);diff --git
a/drivers/gpu/drm/i915/gt/intel_gt_sysfs.cb/drivers/gpu/drm/i915/gt/intel_gt_sysfs.cindex8ec8bc660c8c..9e4ebf53379b100644drivers/gpu/drm/i915/gt/intel_gt_sysfs.c +1
-1@@ -24,7 +24,7 @@ bool is_object_gt(struct kobject *kobj) static struct intel_gt *kobj_to_gt(struct kobject *kobj) { - return container_of(kobj, struct kobj_gt, base)->gt; + return container_of(kobj, struct intel_gt, sysfs_gt); } struct intel_gt *intel_gt_sysfs_get_drvdata(struct device *dev,@@ -72,9 +72,9 @@ static struct attribute *id_attrs[] = { }; ATTRIBUTE_GROUPS(id);+/* A kobject needs a
release()method even if it does nothing */ static voidkobj_gt_release(struct kobject *kobj)
{
- kfree(kobj);
}
static structkobj_typekobj_gt_type= {drivers/gpu/drm/i915/gt/intel_gt_sysfs.c +0
-2@@ -85,8 +85,6 @@ static struct kobj_type kobj_gt_type = { void intel_gt_sysfs_register(struct intel_gt *gt) { - struct kobj_gt *kg; - /** We need to make things right with the * ABI compatibility. The files were originally drivers/gpu/drm/i915/gt/intel_gt_sysfs.c void intel_gt_sysfs_register(struct intel_gt *gt) · line 101
Quoted 7 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs.c +3
-1@@ -98,25 +96,22 @@ void intel_gt_sysfs_register(struct intel_gt *gt) if (gt_is_root(gt)) intel_gt_sysfs_pm_init(gt, gt_get_parent_obj(gt)); - kg = kzalloc(sizeof(*kg), GFP_KERNEL); - if (!kg) + /* init and xfer ownership to sysfs tree */ + if (kobject_init_and_add(>->sysfs_gt, &kobj_gt_type, + gt->i915->sysfs_gt, "gt%d", gt->info.id))Was there closure/agreement on the matter of whether or not there is a potential race between "kfree(gt)" and sysfs access (last put from sysfs that is)? I've noticed Andrzej and Ashutosh were discussing it but did not read all the details.
Quoted 8 lines
Quoted 4 lines
Not really :)
IMO docs are against this practice, Ashutosh shows examples of this practice in code and according to his analysis it is safe.
I gave up looking for contradictions :) Either it is OK, kobject is not fully shared object, docs are obsolete and needs update, either the patch is wrong. Anyway finally I tend to accept this solution, I failed to prove it is wrong :)Like a question of whether hotunplug can be triggered while userspace is sitting in a sysfs hook? Final kfree then has to be delayed until userspace exists.
Btw where is the "kfree(gt)" for the tiles on the PCI remove path? I can't find it.. Do we have a leak?
intel_gt_tile_cleanup ?
Quoted 4 lines
Regards,
Tvrtko
Re: [Intel-gfx] [PATCH 6/8] drm/i915/gt: Fix memory leaks in per-gt sysfs
Quoted 83 lines · Andrzej Hajda
Quoted 82 lines · Tvrtko Ursulin
Quoted 79 lines · Andrzej Hajda
Hi Tvrtko,
Quoted 62 lines · Tvrtko Ursulin
Quoted 60 lines · Ashutosh Dixit
All kmalloc'd kobjects need a
kobject_put()to free memory. For example in previous code,kobj_gt_release()never gets called. The requirement ofkobject_put()now results in a slightly different code organization.v2: s/gtn/gt/ (Andi)
Cc Andi Shyti <[email protected]>Cc Andrzej Hajda <[email protected]>Fixes b770bcfae9ad ("drm/i915/gt: create per-tile sysfs interface")Signed-off-by Ashutosh Dixit <[email protected]>---
drivers/gpu/drm/i915/gt/intel_gt.c | 1 +drivers/gpu/drm/i915/gt/intel_gt_sysfs.c| 29
++++++++++--------------
drivers/gpu/drm/i915/gt/intel_gt_sysfs.h| 6 +----drivers/gpu/drm/i915/gt/intel_gt_types.h| 3 +++ drivers/gpu/drm/i915/i915_sysfs.c | 2 ++5 files changed, 19 insertions(+), 22 deletions(-)drivers/gpu/drm/i915/gt/intel_gt.c +0
-0@@ -785,6 +785,7 @@ void intel_gt_driver_unregister(struct intel_gt *gt) { intel_wakeref_t wakeref; + intel_gt_sysfs_unregister(gt); intel_rps_driver_unregister(>->rps); intel_gsc_fini(>->gsc);diff --git
a/drivers/gpu/drm/i915/gt/intel_gt_sysfs.cb/drivers/gpu/drm/i915/gt/intel_gt_sysfs.cindex8ec8bc660c8c..9e4ebf53379b100644drivers/gpu/drm/i915/gt/intel_gt_sysfs.c +1
-1@@ -24,7 +24,7 @@ bool is_object_gt(struct kobject *kobj) static struct intel_gt *kobj_to_gt(struct kobject *kobj) { - return container_of(kobj, struct kobj_gt, base)->gt; + return container_of(kobj, struct intel_gt, sysfs_gt); } struct intel_gt *intel_gt_sysfs_get_drvdata(struct device *dev,@@ -72,9 +72,9 @@ static struct attribute *id_attrs[] = { }; ATTRIBUTE_GROUPS(id);+/* A kobject needs a
release()method even if it does nothing */ static voidkobj_gt_release(struct kobject *kobj)
{
- kfree(kobj);
}
static structkobj_typekobj_gt_type= {drivers/gpu/drm/i915/gt/intel_gt_sysfs.c +0
-2@@ -85,8 +85,6 @@ static struct kobj_type kobj_gt_type = { void intel_gt_sysfs_register(struct intel_gt *gt) { - struct kobj_gt *kg; - /** We need to make things right with the * ABI compatibility. The files were originally @@ -98,25 +96,22 @@ void intel_gt_sysfs_register(struct intel_gt *gt) if (gt_is_root(gt))Quoted 9 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs.c void intel_gt_sysfs_register(struct intel_gt *gt) · line 101
Quoted 6 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs.c +3
-1intel_gt_sysfs_pm_init(gt, gt_get_parent_obj(gt)); - kg = kzalloc(sizeof(*kg), GFP_KERNEL); - if (!kg) + /* init and xfer ownership to sysfs tree */ + if (kobject_init_and_add(>->sysfs_gt, &kobj_gt_type, + gt->i915->sysfs_gt, "gt%d", gt->info.id))Was there closure/agreement on the matter of whether or not there is a potential race between "kfree(gt)" and sysfs access (last put from sysfs that is)? I've noticed Andrzej and Ashutosh were discussing it but did not read all the details.
Not really :)
IMO docs are against this practice, Ashutosh shows examples of this practice in code and according to his analysis it is safe.
I gave up looking for contradictions :) Either it is OK, kobject is not fully shared object, docs are obsolete and needs update, either the patch is wrong. Anyway finally I tend to accept this solution, I failed to prove it is wrong :)
Quoted 5 lines
Quoted 3 lines
Like a question of whether hotunplug can be triggered while userspace is sitting in a sysfs hook? Final kfree then has to be delayed until userspace exists.
Btw where is the "kfree(gt)" for the tiles on the PCI remove path? I can't find it.. Do we have a leak?
intel_gt_tile_cleanup?
Called from intel_gt_release_all, whose only caller is the failure path of i915_driver_probe. Feels like something is missing?
Regards,
Tvrtko
Re: [Intel-gfx] [PATCH 6/8] drm/i915/gt: Fix memory leaks in per-gt sysfs
Quoted 86 lines · Tvrtko Ursulin
Quoted 84 lines · Andrzej Hajda
Quoted 83 lines · Tvrtko Ursulin
Quoted 80 lines · Andrzej Hajda
Hi Tvrtko,
Quoted 63 lines · Tvrtko Ursulin
Quoted 61 lines · Ashutosh Dixit
All kmalloc'd kobjects need a
kobject_put()to free memory. For example in previous code,kobj_gt_release()never gets called. The requirement ofkobject_put()now results in a slightly different code organization.v2: s/gtn/gt/ (Andi)
Cc Andi Shyti <[email protected]>Cc Andrzej Hajda <[email protected]>Fixes b770bcfae9ad ("drm/i915/gt: create per-tile sysfs interface")Signed-off-by Ashutosh Dixit <[email protected]>---
drivers/gpu/drm/i915/gt/intel_gt.c | 1 +drivers/gpu/drm/i915/gt/intel_gt_sysfs.c| 29
++++++++++--------------
drivers/gpu/drm/i915/gt/intel_gt_sysfs.h| 6 +----drivers/gpu/drm/i915/gt/intel_gt_types.h| 3 +++ drivers/gpu/drm/i915/i915_sysfs.c | 2 ++5 files changed, 19 insertions(+), 22 deletions(-)drivers/gpu/drm/i915/gt/intel_gt.c +0
-0@@ -785,6 +785,7 @@ void intel_gt_driver_unregister(struct intel_gt *gt) { intel_wakeref_t wakeref; + intel_gt_sysfs_unregister(gt); intel_rps_driver_unregister(>->rps); intel_gsc_fini(>->gsc);diff --git
a/drivers/gpu/drm/i915/gt/intel_gt_sysfs.cb/drivers/gpu/drm/i915/gt/intel_gt_sysfs.cindex8ec8bc660c8c..9e4ebf53379b100644drivers/gpu/drm/i915/gt/intel_gt_sysfs.c +1
-1@@ -24,7 +24,7 @@ bool is_object_gt(struct kobject *kobj) static struct intel_gt *kobj_to_gt(struct kobject *kobj) { - return container_of(kobj, struct kobj_gt, base)->gt; + return container_of(kobj, struct intel_gt, sysfs_gt); } struct intel_gt *intel_gt_sysfs_get_drvdata(struct device *dev,@@ -72,9 +72,9 @@ static struct attribute *id_attrs[] = { }; ATTRIBUTE_GROUPS(id);+/* A kobject needs a
release()method even if it does nothing */ static voidkobj_gt_release(struct kobject *kobj)
{
- kfree(kobj);
}
static structkobj_typekobj_gt_type= {drivers/gpu/drm/i915/gt/intel_gt_sysfs.c +0
-2@@ -85,8 +85,6 @@ static struct kobj_type kobj_gt_type = { void intel_gt_sysfs_register(struct intel_gt *gt) { - struct kobj_gt *kg; - /** We need to make things right with the * ABI compatibility. The files were originally @@ -98,25 +96,22 @@ void intel_gt_sysfs_register(struct intel_gt *gt) if (gt_is_root(gt))Quoted 9 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs.c void intel_gt_sysfs_register(struct intel_gt *gt) · line 101
Quoted 6 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs.c +3
-1intel_gt_sysfs_pm_init(gt, gt_get_parent_obj(gt)); - kg = kzalloc(sizeof(*kg), GFP_KERNEL); - if (!kg) + /* init and xfer ownership to sysfs tree */ + if (kobject_init_and_add(>->sysfs_gt, &kobj_gt_type, + gt->i915->sysfs_gt, "gt%d", gt->info.id))Was there closure/agreement on the matter of whether or not there is a potential race between "kfree(gt)" and sysfs access (last put from sysfs that is)? I've noticed Andrzej and Ashutosh were discussing it but did not read all the details.
Not really :)
IMO docs are against this practice, Ashutosh shows examples of this practice in code and according to his analysis it is safe.
I gave up looking for contradictions :) Either it is OK, kobject is not fully shared object, docs are obsolete and needs update, either the patch is wrong. Anyway finally I tend to accept this solution, I failed to prove it is wrong :)
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Like a question of whether hotunplug can be triggered while userspace is sitting in a sysfs hook? Final kfree then has to be delayed until userspace exists.
Btw where is the "kfree(gt)" for the tiles on the PCI remove path? I can't find it.. Do we have a leak?
intel_gt_tile_cleanup?Called from
intel_gt_release_all, whose only caller is the failure path ofi915_driver_probe. Feels like something is missing?
This is final proof this patch is safe - no kfree, no UAF :)
Apparently it is broken in internal branch as well. Should I take care of it?
Regards
Andrzej
Quoted 4 lines
Regards,
Tvrtko
Re: [Intel-gfx] [PATCH 6/8] drm/i915/gt: Fix memory leaks in per-gt sysfs
Quoted 90 lines · Andrzej Hajda
Quoted 89 lines · Tvrtko Ursulin
Quoted 88 lines · Andrzej Hajda
Quoted 86 lines · Tvrtko Ursulin
Quoted 76 lines · Andrzej Hajda
Hi Tvrtko,
Quoted 63 lines · Tvrtko Ursulin
Quoted 61 lines · Ashutosh Dixit
All kmalloc'd kobjects need a
kobject_put()to free memory. For example in previous code,kobj_gt_release()never gets called. The requirement ofkobject_put()now results in a slightly different code organization.v2: s/gtn/gt/ (Andi)
Cc Andi Shyti <[email protected]>Cc Andrzej Hajda <[email protected]>Fixes b770bcfae9ad ("drm/i915/gt: create per-tile sysfs interface")Signed-off-by Ashutosh Dixit <[email protected]>---
drivers/gpu/drm/i915/gt/intel_gt.c | 1 +drivers/gpu/drm/i915/gt/intel_gt_sysfs.c| 29
++++++++++--------------
drivers/gpu/drm/i915/gt/intel_gt_sysfs.h| 6 +----drivers/gpu/drm/i915/gt/intel_gt_types.h| 3 +++ drivers/gpu/drm/i915/i915_sysfs.c | 2 ++5 files changed, 19 insertions(+), 22 deletions(-)drivers/gpu/drm/i915/gt/intel_gt.c +0
-0@@ -785,6 +785,7 @@ void intel_gt_driver_unregister(struct intel_gt *gt) { intel_wakeref_t wakeref; + intel_gt_sysfs_unregister(gt); intel_rps_driver_unregister(>->rps); intel_gsc_fini(>->gsc);diff --git
a/drivers/gpu/drm/i915/gt/intel_gt_sysfs.cb/drivers/gpu/drm/i915/gt/intel_gt_sysfs.cindex8ec8bc660c8c..9e4ebf53379b100644drivers/gpu/drm/i915/gt/intel_gt_sysfs.c +1
-1@@ -24,7 +24,7 @@ bool is_object_gt(struct kobject *kobj) static struct intel_gt *kobj_to_gt(struct kobject *kobj) { - return container_of(kobj, struct kobj_gt, base)->gt; + return container_of(kobj, struct intel_gt, sysfs_gt); } struct intel_gt *intel_gt_sysfs_get_drvdata(struct device *dev,@@ -72,9 +72,9 @@ static struct attribute *id_attrs[] = { }; ATTRIBUTE_GROUPS(id);+/* A kobject needs a
release()method even if it does nothing */ static voidkobj_gt_release(struct kobject *kobj)
{
- kfree(kobj);
}
static structkobj_typekobj_gt_type= {drivers/gpu/drm/i915/gt/intel_gt_sysfs.c +0
-2@@ -85,8 +85,6 @@ static struct kobj_type kobj_gt_type = { void intel_gt_sysfs_register(struct intel_gt *gt) { - struct kobj_gt *kg; - /** We need to make things right with the * ABI compatibility. The files were originally @@ -98,25 +96,22 @@ void intel_gt_sysfs_register(struct intel_gt *gt) if (gt_is_root(gt))Quoted 9 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs.c void intel_gt_sysfs_register(struct intel_gt · line 102
Quoted 6 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs.c +3
-1intel_gt_sysfs_pm_init(gt, gt_get_parent_obj(gt)); - kg = kzalloc(sizeof(*kg), GFP_KERNEL); - if (!kg) + /* init and xfer ownership to sysfs tree */ + if (kobject_init_and_add(>->sysfs_gt, &kobj_gt_type, + gt->i915->sysfs_gt, "gt%d", gt->info.id))Was there closure/agreement on the matter of whether or not there is a potential race between "kfree(gt)" and sysfs access (last put from sysfs that is)? I've noticed Andrzej and Ashutosh were discussing it but did not read all the details.
Quoted 4 lines
Not really :)
IMO docs are against this practice, Ashutosh shows examples of this practice in code and according to his analysis it is safe.
I gave up looking for contradictions :) Either it is OK, kobject is not fully shared object, docs are obsolete and needs update, either the patch is wrong. Anyway finally I tend to accept this solution, I failed to prove it is wrong :)Like a question of whether hotunplug can be triggered while userspace is sitting in a sysfs hook? Final kfree then has to be delayed until userspace exists.
Btw where is the "kfree(gt)" for the tiles on the PCI remove path? I can't find it.. Do we have a leak?
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
intel_gt_tile_cleanup?Called from
intel_gt_release_all, whose only caller is the failure path ofi915_driver_probe. Feels like something is missing?This is final proof this patch is safe - no kfree, no UAF :)
Apparently it is broken in internal branch as well. Should I take care of it?
Don't know - can you see with Andi?
I *think* even though the patch which added this code carries my name, it is probably quite far from what I originally wrote. (I alluded to that in [email protected], maybe I should have been more explicit that I don't think it should have preserved my authorship.) At least I checked that my late 2019. version and it did not seem to have the gt leak issue. If it did I would have felt responsible to fix it. :) As it stands init/de-init paths are always tricky and need more time to look into than I have at the moment.
Regards,
Tvrtko
Re: [Intel-gfx] [PATCH 6/8] drm/i915/gt: Fix memory leaks in per-gt sysfs
In reply to Andrzej HajdaQuoted 28 lines · Andrzej Hajda
Quoted 27 lines · Tvrtko Ursulin
Quoted 25 lines · Andrzej Hajda
Quoted 16 lines · Tvrtko Ursulin
Quoted 7 lines
Quoted 6 lines
Was there closure/agreement on the matter of whether or not there is a potential race between "kfree(gt)" and sysfs access (last put from sysfs that is)? I've noticed Andrzej and Ashutosh were discussing it but did not read all the details.
Quoted 8 lines
Not really :)
IMO docs are against this practice, Ashutosh shows examples of this practice in code and according to his analysis it is safe. I gave up looking for contradictions :) Either it is OK, kobject is not fully shared object, docs are obsolete and needs update, either the patch is wrong.
Anyway finally I tend to accept this solution, I failed to prove it is wrong :)Quoted 6 lines
Like a question of whether hotunplug can be triggered while userspace is sitting in a sysfs hook? Final kfree then has to be delayed until userspace exists.
Btw where is the "kfree(gt)" for the tiles on the PCI remove path? I can't find it.. Do we have a leak?
intel_gt_tile_cleanup?
Quoted 7 lines
Quoted 2 lines
Called from
intel_gt_release_all, whose only caller is the failure path ofi915_driver_probe. Feels like something is missing?This is final proof this patch is safe - no kfree, no UAF :)
Apparently it is broken in internal branch as well. Should I take care of it?
See Daniele's comment here:
https://patchwork.freedesktop.org/patch/478856/?series=101551&rev=1
We clean up the gt sysfs during PCI device remove (i915_driver_remove -> i915_driver_unregister -> intel_gt_driver_unregister -> intel_gt_sysfs_unregister (added in this patch)). But from Daniele's mail it appears that "kfree(gt)" can only be done from i915_driver_release().
So as long as i915_driver_release() always happens after i915_driver_remove() (which seems to be the case though I couldn't figure out why (i.e. who is putting the final reference of the drm device)) there is no UAF and no race. Thanks!
Re: [Intel-gfx] [PATCH 6/8] drm/i915/gt: Fix memory leaks in per-gt sysfs
Quoted 32 lines · Ashutosh
Quoted 31 lines · Andrzej Hajda
Quoted 29 lines · Tvrtko Ursulin
Quoted 17 lines · Andrzej Hajda
Quoted 16 lines · Tvrtko Ursulin
Quoted 15 lines
Quoted 6 lines
Was there closure/agreement on the matter of whether or not there is a potential race between "kfree(gt)" and sysfs access (last put from sysfs that is)? I've noticed Andrzej and Ashutosh were discussing it but did not read all the details.
Not really :)
IMO docs are against this practice, Ashutosh shows examples of this practice in code and according to his analysis it is safe. I gave up looking for contradictions :) Either it is OK, kobject is not fully shared object, docs are obsolete and needs update, either the patch is wrong.
Anyway finally I tend to accept this solution, I failed to prove it is wrong :)Quoted 8 lines
Quoted 6 lines
Like a question of whether hotunplug can be triggered while userspace is sitting in a sysfs hook? Final kfree then has to be delayed until userspace exists.
Btw where is the "kfree(gt)" for the tiles on the PCI remove path? I can't find it.. Do we have a leak?
intel_gt_tile_cleanup?Called from
intel_gt_release_all, whose only caller is the failure path ofi915_driver_probe. Feels like something is missing?
Quoted 8 lines
Quoted 4 lines
This is final proof this patch is safe - no kfree, no UAF :)
Apparently it is broken in internal branch as well. Should I take care of it?
See Daniele's comment here:
https://patchwork.freedesktop.org/patch/478856/?series=101551&rev=1
Yeah we found that same leak yesterday, or the day before in this thread.
Quoted 9 lines
We clean up the gt sysfs during PCI device remove (
i915_driver_remove->i915_driver_unregister->intel_gt_driver_unregister->intel_gt_sysfs_unregister(added in this patch)). But from Daniele's mail it appears that "kfree(gt)" can only be done fromi915_driver_release().So as long as
i915_driver_release()always happens afteri915_driver_remove()(which seems to be the case though I couldn't figure out why (i.e. who is putting the final reference of the drm device)) there is no UAF and no race. Thanks!
No worried by the unknown? I had a quick look whether core_hotunplug tests for sysfs interactions but couldn't spot it. What I had in mind is userspace stuck in a sysfs hook (say read into a userfaultfd buffer) with device hotunplug in parallel. Maybe it is all handled already, not claiming that it isn't.
Regards,
Tvrtko
Re: [Intel-gfx] [PATCH 6/8] drm/i915/gt: Fix memory leaks in per-gt sysfs
On Thu, 12 May 2022 00:48:08 -0700, Tvrtko Ursulin wrote:
Hi Tvrtko,
Quoted 49 lines · Ashutosh
Quoted 32 lines · Andrzej Hajda
Quoted 31 lines · Tvrtko Ursulin
Quoted 29 lines · Andrzej Hajda
Quoted 17 lines · Tvrtko Ursulin
Quoted 16 lines
Quoted 15 lines
Quoted 6 lines
Was there closure/agreement on the matter of whether or not there is a potential race between "kfree(gt)" and sysfs access (last put from sysfs that is)? I've noticed Andrzej and Ashutosh were discussing it but did not read all the details.
Not really :)
IMO docs are against this practice, Ashutosh shows examples of this practice in code and according to his analysis it is safe. I gave up looking for contradictions :) Either it is OK, kobject is not fully shared object, docs are obsolete and needs update, either the patch is wrong.
Anyway finally I tend to accept this solution, I failed to prove it is wrong :)Quoted 8 lines
Quoted 6 lines
Like a question of whether hotunplug can be triggered while userspace is sitting in a sysfs hook? Final kfree then has to be delayed until userspace exists.
Btw where is the "kfree(gt)" for the tiles on the PCI remove path? I can't find it.. Do we have a leak?
intel_gt_tile_cleanup?Called from
intel_gt_release_all, whose only caller is the failure path ofi915_driver_probe. Feels like something is missing?Quoted 8 lines
Quoted 4 lines
This is final proof this patch is safe - no kfree, no UAF :)
Apparently it is broken in internal branch as well. Should I take care of it?
See Daniele's comment here:
https://patchwork.freedesktop.org/patch/478856/?series=101551&rev=1
Yeah we found that same leak yesterday, or the day before in this thread.
Quoted 5 lines
We clean up the gt sysfs during PCI device remove (
i915_driver_remove->i915_driver_unregister->intel_gt_driver_unregister->intel_gt_sysfs_unregister(added in this patch)). But from Daniele's mail it appears that "kfree(gt)" can only be done fromi915_driver_release().
Quoted 6 lines
Quoted 4 lines
So as long as
i915_driver_release()always happens afteri915_driver_remove()(which seems to be the case though I couldn't figure out why (i.e. who is putting the final reference of the drm device)) there is no UAF and no race. Thanks!No worried by the unknown?
Well if release() happens before or during remove() then (as is clear from Daniele's mail) we have a much bigger problem than sysfs on our hands and will see UAF crashes during device remove/unbind. But as far as we know no such crashes have been reported.
Quoted 4 lines
I had a quick look whether
core_hotunplugtests for sysfs interactions but couldn't spot it. What I had in mind is userspace stuck in a sysfs hook (say read into a userfaultfd buffer) with device hotunplug in parallel. Maybe it is all handled already, not claiming that it isn't.
This is the 20 year old issue mentioned by Andrzej here:
https://lwn.net/Articles/36850/
So I thought I'll try this out today and see what actually happens to settle this. And you will see it makes perfect sense. So this is what I did:
* Change IGT to add a 20 second sleep after opening a sysfs file
* In that 20 second period, with an open fd, unbind the device using:
echo -n "0000:03:00.0" > /sys/bus/pci/drivers/i915/unbind
And also rmmod i915.
So this is what we see when we do this:
* As soon as the device is unbound, the complete i915 sysfs tree (under /sys/card/drm/card0) is cleanly removed (even with the open fd in IGT).
* The fd open in IGT is now orphan/invalid, so when IGT resumes and tries to use that fd IGT crashes.
* So no problem with device unbind but if IGT is still hanging around rmmod fails (saying module is in use, most likely due to the still open drm fd) but after IGT is completely killed rmmod is also fine.
So this confirms all this is correctly handled.
Separately, note that kobject_put's introduced in this patch are only needed for freeing the memory allocated for the kobject's themselves (or their containing struct's). kobject_put's don't play a role in cleaning up the sysfs hierarchy itself (which will get cleaned up even without the kobject_put's). Further, child kobject's take a reference on their parents so child kobjects need a kobject_put before the parent kobject_put to free the memory allocated for the parent (i.e. doing a kobject_put on the parent will not automatically free all the child kobjects).
Thanks.
--
Ashutosh
Re: [Intel-gfx] [PATCH 6/8] drm/i915/gt: Fix memory leaks in per-gt sysfs
Quoted 91 lines · Ashutosh
On Thu, 12 May 2022 00:48:08 -0700, Tvrtko Ursulin wrote:
Hi Tvrtko,
Quoted 49 lines · Ashutosh
Quoted 32 lines · Andrzej Hajda
Quoted 31 lines · Tvrtko Ursulin
Quoted 29 lines · Andrzej Hajda
Quoted 17 lines · Tvrtko Ursulin
Quoted 16 lines
Quoted 15 lines
Quoted 6 lines
Was there closure/agreement on the matter of whether or not there is a potential race between "kfree(gt)" and sysfs access (last put from sysfs that is)? I've noticed Andrzej and Ashutosh were discussing it but did not read all the details.
Not really :)
IMO docs are against this practice, Ashutosh shows examples of this practice in code and according to his analysis it is safe. I gave up looking for contradictions :) Either it is OK, kobject is not fully shared object, docs are obsolete and needs update, either the patch is wrong.
Anyway finally I tend to accept this solution, I failed to prove it is wrong :)Quoted 8 lines
Quoted 6 lines
Like a question of whether hotunplug can be triggered while userspace is sitting in a sysfs hook? Final kfree then has to be delayed until userspace exists.
Btw where is the "kfree(gt)" for the tiles on the PCI remove path? I can't find it.. Do we have a leak?
intel_gt_tile_cleanup?Called from
intel_gt_release_all, whose only caller is the failure path ofi915_driver_probe. Feels like something is missing?Quoted 8 lines
Quoted 4 lines
This is final proof this patch is safe - no kfree, no UAF :)
Apparently it is broken in internal branch as well. Should I take care of it?
See Daniele's comment here:
https://patchwork.freedesktop.org/patch/478856/?series=101551&rev=1
Yeah we found that same leak yesterday, or the day before in this thread.
Quoted 5 lines
We clean up the gt sysfs during PCI device remove (
i915_driver_remove->i915_driver_unregister->intel_gt_driver_unregister->intel_gt_sysfs_unregister(added in this patch)). But from Daniele's mail it appears that "kfree(gt)" can only be done fromi915_driver_release().Quoted 6 lines
Quoted 4 lines
So as long as
i915_driver_release()always happens afteri915_driver_remove()(which seems to be the case though I couldn't figure out why (i.e. who is putting the final reference of the drm device)) there is no UAF and no race. Thanks!No worried by the unknown?
Well if
release()happens before or duringremove()then (as is clear from Daniele's mail) we have a much bigger problem than sysfs on our hands and will see UAF crashes during device remove/unbind. But as far as we know no such crashes have been reported.Quoted 4 lines
I had a quick look whether
core_hotunplugtests for sysfs interactions but couldn't spot it. What I had in mind is userspace stuck in a sysfs hook (say read into a userfaultfd buffer) with device hotunplug in parallel. Maybe it is all handled already, not claiming that it isn't.This is the 20 year old issue mentioned by Andrzej here:
https://lwn.net/Articles/36850/So I thought I'll try this out today and see what actually happens to settle this. And you will see it makes perfect sense. So this is what I did:
* Change IGT to add a 20 second sleep after opening a sysfs file
* In that 20 second period, with an open fd, unbind the device using:echo -n "0000:03:00.0" > /sys/bus/pci/drivers/i915/unbindAnd also rmmod i915.
So this is what we see when we do this:
* As soon as the device is unbound, the complete i915 sysfs tree (under/sys/card/drm/card0) is cleanly removed (even with the open fd in IGT).
* The fd open in IGT is now orphan/invalid, so when IGT resumes and tries to use that fd IGT crashes.
* So no problem with device unbind but if IGT is still hanging around rmmod fails (saying module is in use, most likely due to the still open drm fd) but after IGT is completely killed rmmod is also fine.
Quoted 1 line
So this confirms all this is correctly handled.
I was unsure what does "IGT crashes" exactly meant so I went to try it out myself. It's -ENODEV from read(2) it receives so it all indeed seems handled fine.
Although hotunplug seems generally very unhealthy, at least on 5.18.0-rc8 I tested on.. I'll send my subtest to the mailing list in case it is consider useful to have it.
Regards,
Tvrtko
Quoted 13 lines
Separately, note that kobject_put's introduced in this patch are only needed for freeing the memory allocated for the kobject's themselves (or their containing struct's). kobject_put's don't play a role in cleaning up the sysfs hierarchy itself (which will get cleaned up even without the kobject_put's). Further, child kobject's take a reference on their parents so child kobjects need a
kobject_putbefore the parentkobject_putto free the memory allocated for the parent (i.e. doing akobject_puton the parent will not automatically free all the child kobjects).Thanks.
--
Ashutosh
PATCH v4 7/8 drm/i915/gt: Expose per-gt RPS defaults in sysfs
In reply to Ashutosh DixitCreate a gt/gtN/.defaults directory (similar to engine/<engine-name>/.defaults) to expose default parameter values for each gt in sysfs. Populate the .defaults directory with RPS parameter default values in order to allow userspace to revert to default values when needed.
This patch adds the following sysfs files to gt/gtN/.defaults:
* default_min_freq_mhz
* default_max_freq_mhz
* default_boost_freq_mhz
--- drivers/gpu/drm/i915/gt/intel_gt_sysfs.c | 10 ++-- drivers/gpu/drm/i915/gt/intel_gt_sysfs.h | 6 +++ drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 51 +++++++++++++++++++++ drivers/gpu/drm/i915/gt/intel_gt_types.h | 10 ++++ drivers/gpu/drm/i915/gt/intel_rps.c | 3 ++ drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 17 +++++-- 6 files changed, 87 insertions(+), 10 deletions(-)
drivers/gpu/drm/i915/gt/intel_gt_sysfs.c +5 -5
@@ -22,11 +22,6 @@ bool is_object_gt(struct kobject *kobj)return !strncmp (kobj->name,"gt" ,2 ); } -static struct intel_gt *kobj_to_gt (struct kobject *kobj) -{ - return container_of(kobj, struct intel_gt, sysfs_gt); -} -struct intel_gt *intel_gt_sysfs_get_drvdata (struct device *dev,const char *name) {
@@ -101,6 +96,10 @@ void intel_gt_sysfs_register(struct intel_gt *gt) gt->i915->sysfs_gt, "gt%d", gt->info.id)) goto exit_fail; + gt->sysfs_defaults =kobject_create_and_add (".defaults" , >->sysfs_gt); +if (!gt->sysfs_defaults) + goto exit_fail; +intel_gt_sysfs_pm_init (gt, >->sysfs_gt);return ;
@@ -113,5 +112,6 @@ void intel_gt_sysfs_register(struct intel_gt *gt)void intel_gt_sysfs_unregister (struct intel_gt *gt) { +kobject_put (gt->sysfs_defaults);kobject_put (>->sysfs_gt); }
drivers/gpu/drm/i915/gt/intel_gt_sysfs.h +6 -0
@@ -10,6 +10,7 @@#include <linux/kobject.h> #include "i915_gem.h" /* GEM_BUG_ON() */ +#include "intel_gt_types.h" struct intel_gt ;
@@ -22,6 +23,11 @@ intel_gt_create_kobj(struct intel_gt *gt,struct kobject *dir, const char *name); +static inline struct intel_gt *kobj_to_gt (struct kobject *kobj) +{ + return container_of(kobj, struct intel_gt, sysfs_gt); +} +void intel_gt_sysfs_register (struct intel_gt *gt);void intel_gt_sysfs_unregister (struct intel_gt *gt); struct intel_gt *intel_gt_sysfs_get_drvdata(struct device *dev,
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c +51 -0
61 lines not on this page · raw message
drivers/gpu/drm/i915/gt/intel_gt_types.h +10 -0
@@ -62,6 +62,12 @@ enum intel_steering_type {NUM_STEERING_TYPES }; +struct intel_rps_defaults { +u32 min_freq; +u32 max_freq; +u32 boost_freq; +}; +enum intel_submission_method {INTEL_SUBMISSION_RING ,INTEL_SUBMISSION_ELSP ,
@@ -227,6 +233,10 @@ struct intel_gt {/* gt/gtN sysfs */ struct kobject sysfs_gt; + +/* sysfs defaults per gt */ +struct intel_rps_defaults rps_defaults; +struct kobject *sysfs_defaults; };enum intel_gt_scratch_field {
drivers/gpu/drm/i915/gt/intel_rps.c +3 -0
@@ -1976,7 +1976,9 @@ void intel_rps_init(struct intel_rps *rps)/* Derive initial user preferences/limits from the hardware limits */ rps->max_freq_softlimit = rps->max_freq; +rps_to_gt (rps)->rps_defaults.max_freq = rps->max_freq_softlimit; rps->min_freq_softlimit = rps->min_freq; +rps_to_gt (rps)->rps_defaults.min_freq = rps->min_freq_softlimit;/* After setting max-softlimit, find the overclock max freq */ if (GRAPHICS_VER (i915) ==6 ||IS_IVYBRIDGE (i915) ||IS_HASWELL (i915)) {
@@ -1994,6 +1996,7 @@ void intel_rps_init(struct intel_rps *rps)/* Finally allow us to boost to max by default */ rps->boost_freq = rps->max_freq; +rps_to_gt (rps)->rps_defaults.boost_freq = rps->boost_freq; rps->idle_freq = rps->min_freq;/* Start in the middle, from here we will autotune based on workload */
drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c +12 -5
@@ -547,20 +547,24 @@ static int slpc_set_softlimits(struct intel_guc_slpc *slpc)* unless they have deviated from defaults, in which case, * we retain the values and set min/max accordingly. */ -if (!slpc->max_freq_softlimit) +if (!slpc->max_freq_softlimit) { slpc->max_freq_softlimit = slpc->rp0_freq; -else if (slpc->max_freq_softlimit != slpc->rp0_freq) +slpc_to_gt (slpc)->rps_defaults.max_freq = slpc->max_freq_softlimit; + }else if (slpc->max_freq_softlimit != slpc->rp0_freq) { ret =intel_guc_slpc_set_max_freq (slpc, slpc->max_freq_softlimit); + }if (unlikely (ret))return ret; -if (!slpc->min_freq_softlimit) +if (!slpc->min_freq_softlimit) { slpc->min_freq_softlimit = slpc->min_freq; -else if (slpc->min_freq_softlimit != slpc->min_freq) +slpc_to_gt (slpc)->rps_defaults.min_freq = slpc->min_freq_softlimit; + }else if (slpc->min_freq_softlimit != slpc->min_freq) {return intel_guc_slpc_set_min_freq (slpc, slpc->min_freq_softlimit); + }return 0 ; }
@@ -606,8 +610,11 @@ static void slpc_get_rp_values(struct intel_guc_slpc *slpc) slpc->rp1_freq =intel_gpu_freq (rps, caps.rp1_freq); slpc->min_freq =intel_gpu_freq (rps, caps.min_freq); -if (!slpc->boost_freq) +/* Boost freq is RP0, unless already set */ +if (!slpc->boost_freq) { slpc->boost_freq = slpc->rp0_freq; +slpc_to_gt (slpc)->rps_defaults.boost_freq = slpc->boost_freq; + } }/*
Signature · 1 line
2.34.1
Re: [Intel-gfx] [PATCH 7/8] drm/i915/gt: Expose per-gt RPS defaults in sysfs
Quoted 9 lines · Ashutosh Dixit
Create a gt/gtN/.defaults directory (similar to engine/<engine-name>/.defaults) to expose default parameter values for each gt in sysfs. Populate the .defaults directory with RPS parameter default values in order to allow userspace to revert to default values when needed.
This patch adds the following sysfs files to gt/gtN/.defaults:
*default_min_freq_mhz
*default_max_freq_mhz
*default_boost_freq_mhz
Possibly an uninformed question - max will not be the existing rp0, min rpN, and boost I don't know?
Quoted 41 lines
Cc Joonas Lahtinen <[email protected]>Signed-off-by Ashutosh Dixit <[email protected]>Reviewed-by Rodrigo Vivi <[email protected]>--- drivers/gpu/drm/i915/gt/intel_gt_sysfs.c | 10 ++-- drivers/gpu/drm/i915/gt/intel_gt_sysfs.h | 6 +++ drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 51 +++++++++++++++++++++ drivers/gpu/drm/i915/gt/intel_gt_types.h | 10 ++++ drivers/gpu/drm/i915/gt/intel_rps.c | 3 ++ drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 17 +++++-- 6 files changed, 87 insertions(+), 10 deletions(-)drivers/gpu/drm/i915/gt/intel_gt_sysfs.c +4
-5@@ -22,11 +22,6 @@ bool is_object_gt(struct kobject *kobj)return !strncmp (kobj->name,"gt" ,2 ); } -static struct intel_gt *kobj_to_gt (struct kobject *kobj) -{ - return container_of(kobj, struct intel_gt, sysfs_gt); -} -struct intel_gt *intel_gt_sysfs_get_drvdata (struct device *dev,const char *name) {@@ -101,6 +96,10 @@ void intel_gt_sysfs_register(struct intel_gt *gt) gt->i915->sysfs_gt, "gt%d", gt->info.id)) goto exit_fail; + gt->sysfs_defaults =kobject_create_and_add (".defaults" , >->sysfs_gt); +if (!gt->sysfs_defaults) + goto exit_fail; +intel_gt_sysfs_pm_init (gt, >->sysfs_gt);return ;
drivers/gpu/drm/i915/gt/intel_gt_sysfs.c void intel_gt_sysfs_register(struct intel_gt *gt) · line 115
Quoted 4 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs.c +1
-0@@ -113,5 +112,6 @@ void intel_gt_sysfs_register(struct intel_gt *gt)void intel_gt_sysfs_unregister (struct intel_gt *gt) { +kobject_put (gt->sysfs_defaults);
Is this needed - won't below clean it up?
And not sure I am liking the mix of embedded and allocated kobjects.. Why we couldn't have it uniform?
Quoted 177 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs.c +0
-0kobject_put (>->sysfs_gt); }drivers/gpu/drm/i915/gt/intel_gt_sysfs.h +6
-0@@ -10,6 +10,7 @@#include <linux/kobject.h> #include "i915_gem.h" /* GEM_BUG_ON() */ +#include "intel_gt_types.h" struct intel_gt ;@@ -22,6 +23,11 @@ intel_gt_create_kobj(struct intel_gt *gt,struct kobject *dir, const char *name); +static inline struct intel_gt *kobj_to_gt (struct kobject *kobj) +{ + return container_of(kobj, struct intel_gt, sysfs_gt); +} +void intel_gt_sysfs_register (struct intel_gt *gt);void intel_gt_sysfs_unregister (struct intel_gt *gt); struct intel_gt *intel_gt_sysfs_get_drvdata(struct device *dev,drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c +51
-0@@ -726,6 +726,51 @@ static const struct attribute *media_perf_power_attrs[] = { NULL }; +static ssize_t +default_min_freq_mhz_show (struct kobject *kobj,struct kobj_attribute *attr,char *buf) +{ +struct intel_gt *gt =kobj_to_gt (kobj->parent); + +return sysfs_emit (buf,"%d\n" , gt->rps_defaults.min_freq); +} + +static struct kobj_attribute default_min_freq_mhz = +__ATTR (rps_min_freq_mhz,0444 , default_min_freq_mhz_show,NULL ); + +static ssize_t +default_max_freq_mhz_show (struct kobject *kobj,struct kobj_attribute *attr,char *buf) +{ +struct intel_gt *gt =kobj_to_gt (kobj->parent); + +return sysfs_emit (buf,"%d\n" , gt->rps_defaults.max_freq); +} + +static struct kobj_attribute default_max_freq_mhz = +__ATTR (rps_max_freq_mhz,0444 , default_max_freq_mhz_show,NULL ); + +static ssize_t +default_boost_freq_mhz_show (struct kobject *kobj,struct kobj_attribute *attr,char *buf) +{ +struct intel_gt *gt =kobj_to_gt (kobj->parent); + +return sysfs_emit (buf,"%d\n" , gt->rps_defaults.boost_freq); +} + +static struct kobj_attribute default_boost_freq_mhz = +__ATTR (rps_boost_freq_mhz,0444 , default_boost_freq_mhz_show,NULL ); + +static const struct attribute *const rps_defaults_attrs[] = { + &default_min_freq_mhz.attr, + &default_max_freq_mhz.attr, + &default_boost_freq_mhz.attr, +NULL +}; + +static int add_rps_defaults (struct intel_gt *gt) +{ +return sysfs_create_files (gt->sysfs_defaults, rps_defaults_attrs); +} +static int intel_sysfs_rps_init (struct intel_gt *gt,struct kobject *kobj,const struct attribute *const *attrs) {@@ -775,4 +820,10 @@ void intel_gt_sysfs_pm_init(struct intel_gt *gt, struct kobject *kobj)"failed to create add gt%u media_perf_power_attrs sysfs (%pe)\n" , gt->info.id, ERR_PTR(ret)); } + + ret =add_rps_defaults (gt); +if (ret) +drm_warn (>->i915->drm, +"failed to add gt%u rps defaults (%pe)\n" , + gt->info.id,ERR_PTR (ret)); }drivers/gpu/drm/i915/gt/intel_gt_types.h +10
-0@@ -62,6 +62,12 @@ enum intel_steering_type {NUM_STEERING_TYPES }; +struct intel_rps_defaults { +u32 min_freq; +u32 max_freq; +u32 boost_freq; +}; +enum intel_submission_method {INTEL_SUBMISSION_RING ,INTEL_SUBMISSION_ELSP ,@@ -227,6 +233,10 @@ struct intel_gt {/* gt/gtN sysfs */ struct kobject sysfs_gt; + +/* sysfs defaults per gt */ +struct intel_rps_defaults rps_defaults; +struct kobject *sysfs_defaults; };enum intel_gt_scratch_field {drivers/gpu/drm/i915/gt/intel_rps.c +3
-0@@ -1976,7 +1976,9 @@ void intel_rps_init(struct intel_rps *rps)/* Derive initial user preferences/limits from the hardware limits */ rps->max_freq_softlimit = rps->max_freq; +rps_to_gt (rps)->rps_defaults.max_freq = rps->max_freq_softlimit; rps->min_freq_softlimit = rps->min_freq; +rps_to_gt (rps)->rps_defaults.min_freq = rps->min_freq_softlimit;/* After setting max-softlimit, find the overclock max freq */ if (GRAPHICS_VER (i915) ==6 ||IS_IVYBRIDGE (i915) ||IS_HASWELL (i915)) {@@ -1994,6 +1996,7 @@ void intel_rps_init(struct intel_rps *rps)/* Finally allow us to boost to max by default */ rps->boost_freq = rps->max_freq; +rps_to_gt (rps)->rps_defaults.boost_freq = rps->boost_freq; rps->idle_freq = rps->min_freq;/* Start in the middle, from here we will autotune based on workload */ drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c +8
-4@@ -547,20 +547,24 @@ static int slpc_set_softlimits(struct intel_guc_slpc *slpc)* unless they have deviated from defaults, in which case, * we retain the values and set min/max accordingly. */ -if (!slpc->max_freq_softlimit) +if (!slpc->max_freq_softlimit) { slpc->max_freq_softlimit = slpc->rp0_freq; -else if (slpc->max_freq_softlimit != slpc->rp0_freq) +slpc_to_gt (slpc)->rps_defaults.max_freq = slpc->max_freq_softlimit; + }else if (slpc->max_freq_softlimit != slpc->rp0_freq) { ret =intel_guc_slpc_set_max_freq (slpc, slpc->max_freq_softlimit); + }if (unlikely (ret))return ret; -if (!slpc->min_freq_softlimit) +if (!slpc->min_freq_softlimit) { slpc->min_freq_softlimit = slpc->min_freq; -else if (slpc->min_freq_softlimit != slpc->min_freq) +slpc_to_gt (slpc)->rps_defaults.min_freq = slpc->min_freq_softlimit; + }else if (slpc->min_freq_softlimit != slpc->min_freq) {return intel_guc_slpc_set_min_freq (slpc, slpc->min_freq_softlimit); + }return 0 ; }
drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c static void slpc_get_rp_values(struct intel_guc_slpc *slpc) · line 617
Quoted 9 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c +4
-1@@ -606,8 +610,11 @@ static void slpc_get_rp_values(struct intel_guc_slpc *slpc) slpc->rp1_freq =intel_gpu_freq (rps, caps.rp1_freq); slpc->min_freq =intel_gpu_freq (rps, caps.min_freq); -if (!slpc->boost_freq) +/* Boost freq is RP0, unless already set */ +if (!slpc->boost_freq) { slpc->boost_freq = slpc->rp0_freq; +slpc_to_gt (slpc)->rps_defaults.boost_freq = slpc->boost_freq; + }
Not liking that there are two places which set each of the default. Is it that there are GuC and non-GuC paths which initialize the parent struct? Is there a way to set the defaults at one common place after either branch has run?
Regards,
Tvrtko
Quoted 3 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c +0
-0}/*
Re: [Intel-gfx] [PATCH 7/8] drm/i915/gt: Expose per-gt RPS defaults in sysfs
Hi Ashutosh,
Quoted 6 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c static const struct attribute *media_perf_power_attrs[] = { · line 734
Quoted 6 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c +6
-0+static ssize_t +default_min_freq_mhz_show (struct kobject *kobj,struct kobj_attribute *attr,char *buf) +{ +struct intel_gt *gt =kobj_to_gt (kobj->parent); + +return sysfs_emit (buf,"%d\n" , gt->rps_defaults.min_freq);
I guess this is %u.
Quoted 25 lines
Quoted 25 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c +25
-0+} + +static struct kobj_attribute default_min_freq_mhz = +__ATTR (rps_min_freq_mhz,0444 , default_min_freq_mhz_show,NULL ); + +static ssize_t +default_max_freq_mhz_show (struct kobject *kobj,struct kobj_attribute *attr,char *buf) +{ +struct intel_gt *gt =kobj_to_gt (kobj->parent); + +return sysfs_emit (buf,"%d\n" , gt->rps_defaults.max_freq); +} + +static struct kobj_attribute default_max_freq_mhz = +__ATTR (rps_max_freq_mhz,0444 , default_max_freq_mhz_show,NULL ); + +static ssize_t +default_boost_freq_mhz_show (struct kobject *kobj,struct kobj_attribute *attr,char *buf) +{ +struct intel_gt *gt =kobj_to_gt (kobj->parent); + +return sysfs_emit (buf,"%d\n" , gt->rps_defaults.boost_freq); +} + +static struct kobj_attribute default_boost_freq_mhz =
Quoted 8 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c static const struct attribute *media_perf_power_attrs[] = { · line 767
Quoted 8 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c +8
-0+__ATTR (rps_boost_freq_mhz,0444 , default_boost_freq_mhz_show,NULL ); + +static const struct attribute *const rps_defaults_attrs[] = { + &default_min_freq_mhz.attr, + &default_max_freq_mhz.attr, + &default_boost_freq_mhz.attr, +NULL +};
Do you think this in the default group of kobj_gt_type like the gt_id?
[...]
Quoted 7 lines
Quoted 7 lines
drivers/gpu/drm/i915/gt/intel_gt_types.h +6
-0+struct intel_rps_defaults { +u32 min_freq; +u32 max_freq; +u32 boost_freq; +}; +enum intel_submission_method {
Quoted 8 lines
drivers/gpu/drm/i915/gt/intel_gt_types.h struct intel_gt { · line 237
Quoted 8 lines
INTEL_SUBMISSION_RING,
INTEL_SUBMISSION_ELSP,drivers/gpu/drm/i915/gt/intel_gt_types.h +3
-0@@ -227,6 +233,10 @@ struct intel_gt {/* gt/gtN sysfs */ struct kobject sysfs_gt; + +/* sysfs defaults per gt */ +struct intel_rps_defaults rps_defaults;
more of a matter of taste, but this looks natural to me to be in rps rather then in the gt.
[...]
Andi
Re: [Intel-gfx] [PATCH 7/8] drm/i915/gt: Expose per-gt RPS defaults in sysfs
Quoted 2 lines · Andi Shyti
Hi Ashutosh,
Hi Andi,
Quoted 8 lines
Quoted 6 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c static const struct attribute *media_perf_power_attrs[] = { · line 734
Quoted 6 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c +6
-0+static ssize_t +default_min_freq_mhz_show (struct kobject *kobj,struct kobj_attribute *attr,char *buf) +{ +struct intel_gt *gt =kobj_to_gt (kobj->parent); + +return sysfs_emit (buf,"%d\n" , gt->rps_defaults.min_freq);I guess this is %u.
Fixed in v2.
Quoted 28 lines
Quoted 28 lines
Quoted 28 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c +28
-0+} + +static struct kobj_attribute default_min_freq_mhz = +__ATTR (rps_min_freq_mhz,0444 , default_min_freq_mhz_show,NULL ); + +static ssize_t +default_max_freq_mhz_show (struct kobject *kobj,struct kobj_attribute *attr,char *buf) +{ +struct intel_gt *gt =kobj_to_gt (kobj->parent); + +return sysfs_emit (buf,"%d\n" , gt->rps_defaults.max_freq); +} + +static struct kobj_attribute default_max_freq_mhz = +__ATTR (rps_max_freq_mhz,0444 , default_max_freq_mhz_show,NULL ); + +static ssize_t +default_boost_freq_mhz_show (struct kobject *kobj,struct kobj_attribute *attr,char *buf) +{ +struct intel_gt *gt =kobj_to_gt (kobj->parent); + +return sysfs_emit (buf,"%d\n" , gt->rps_defaults.boost_freq); +} + +static struct kobj_attribute default_boost_freq_mhz = +__ATTR (rps_boost_freq_mhz,0444 , default_boost_freq_mhz_show,NULL ); + +static const struct attribute *const rps_defaults_attrs[] = {
Quoted 8 lines
Quoted 5 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c static const struct attribute *media_perf_power_attrs[] = { · line 767
Quoted 5 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c +5
-0+ &default_min_freq_mhz.attr, + &default_max_freq_mhz.attr, + &default_boost_freq_mhz.attr, + NULL +};Do you think this in the default group of
kobj_gt_typelike thegt_id?
gt_id I think fits well in the category of a "default" attribute for a gt. I am not sure if these attributes similarly qualify as "default" attributes (for the .defaults sysfs), what do you think? That is why I have followed what is done in the engine sysfs which also does not use default attributes. But we can revisit based on your comments.
Quoted 13 lines
[...]
Quoted 10 lines
Quoted 10 lines
drivers/gpu/drm/i915/gt/intel_gt_types.h +6
-0+struct intel_rps_defaults { +u32 min_freq; +u32 max_freq; +u32 boost_freq; +}; +enum intel_submission_method {
INTEL_SUBMISSION_RING,
INTEL_SUBMISSION_ELSP,(quoted diff) +0
-0@@ -227,6 +233,10 @@ struct intel_gt {
Quoted 8 lines
Quoted 5 lines
drivers/gpu/drm/i915/gt/intel_gt_types.h struct intel_gt { · line 238
Quoted 5 lines
drivers/gpu/drm/i915/gt/intel_gt_types.h +3
-0/* gt/gtN sysfs */ struct kobject sysfs_gt; + +/* sysfs defaults per gt */ +struct intel_rps_defaults rps_defaults;more of a matter of taste, but this looks natural to me to be in rps rather then in the gt.
In v2 I have changed the name of this from 'struct intel_rps_defaults' to 'struct gt_defaults'. So the idea is to have a central place in the gt where any "module" (RPS, PM, ...) can store their defaults which are then exposed via sysfs files in gt/gtN/.defaults directory. There are multiple ways of doing this but this is what I've done in this series, basically to keep things simple.
Thanks.
--
Ashutosh
Re: [Intel-gfx] [PATCH 7/8] drm/i915/gt: Expose per-gt RPS defaults in sysfs
In reply to Tvrtko UrsulinQuoted 7 lines · Tvrtko Ursulin
Quoted 5 lines · Ashutosh Dixit
Create a gt/gtN/.defaults directory (similar to engine/<engine-name>/.defaults) to expose default parameter values for each gt in sysfs. Populate the .defaults directory with RPS parameter default values in order to allow userspace to revert to default values when needed.
Quoted 7 lines
Quoted 4 lines
This patch adds the following sysfs files to gt/gtN/.defaults:
*default_min_freq_mhz
*default_max_freq_mhz
*default_boost_freq_mhzPossibly an uninformed question - max will not be the existing rp0, min rpN, and boost I don't know?
This is actually the case at present (with boost also RP0). However, PVC also sets min to RP0 (instead of RPn).
And then there is a completely different scheme being considered for GuC where min = max = boost = "-1" where -1 denotes a "default managed by firmware". For it is not clear why i915 should set these min/max in FW (which is autonomous and can better manage the freq control algorithm) especially when these controls are exposed to userspace in sysfs.
This patch was written because user space was asking a control to restore all RPS parameters to their default values. Then Chris suggested doing the same for gt sysfs as what we do for the engine sysfs, expose default values in sysfs and have userspace restore them when needed.
Quoted 35 lines
Quoted 35 lines
Cc Joonas Lahtinen <[email protected]>Signed-off-by Ashutosh Dixit <[email protected]>Reviewed-by Rodrigo Vivi <[email protected]>--- drivers/gpu/drm/i915/gt/intel_gt_sysfs.c | 10 ++-- drivers/gpu/drm/i915/gt/intel_gt_sysfs.h | 6 +++ drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 51 +++++++++++++++++++++ drivers/gpu/drm/i915/gt/intel_gt_types.h | 10 ++++ drivers/gpu/drm/i915/gt/intel_rps.c | 3 ++ drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 17 +++++-- 6 files changed, 87 insertions(+), 10 deletions(-)drivers/gpu/drm/i915/gt/intel_gt_sysfs.c +3
-4@@ -22,11 +22,6 @@ bool is_object_gt(struct kobject *kobj)return !strncmp (kobj->name,"gt" ,2 ); } -static struct intel_gt *kobj_to_gt(struct kobject *kobj) -{ - return container_of(kobj, struct intel_gt, sysfs_gt); -} - struct intel_gt *intel_gt_sysfs_get_drvdata(struct device *dev,const char *name) {@@ -101,6 +96,10 @@ void intel_gt_sysfs_register(struct intel_gt *gt) gt->i915->sysfs_gt, "gt%d", gt->info.id)) goto exit_fail; + gt->sysfs_defaults =kobject_create_and_add (".defaults" , >->sysfs_gt); +if (!gt->sysfs_defaults) + goto exit_fail; +
Quoted 8 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs.c void intel_gt_sysfs_register(struct intel_gt *gt) · line 114
Quoted 6 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs.c +1
-0intel_gt_sysfs_pm_init (gt, >->sysfs_gt);return ;@@ -113,5 +112,6 @@ void intel_gt_sysfs_register(struct intel_gt *gt)void intel_gt_sysfs_unregister (struct intel_gt *gt) { +kobject_put (gt->sysfs_defaults);Is this needed - won't below clean it up?
Child kobject's take a reference on their parents so child kobjects need a kobject_put before the parent kobject_put to free the memory allocated for the parent (i.e. doing a kobject_put on the parent will not automatically free all the child kobjects).
Quoted 106 lines
Quoted 106 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs.c +0
-0kobject_put (>->sysfs_gt); }drivers/gpu/drm/i915/gt/intel_gt_sysfs.h +1
-0@@ -10,6 +10,7 @@#include <linux/kobject.h> #include "i915_gem.h" /* GEM_BUG_ON() */ +#include "intel_gt_types.h" struct intel_gt ; @@ -22,6 +23,11 @@ intel_gt_create_kobj(struct intel_gt *gt, struct kobject *dir, const char *name);+static inline struct
intel_gt*kobj_to_gt(struct kobject *kobj)drivers/gpu/drm/i915/gt/intel_gt_sysfs.h +4
-0+{ + return container_of(kobj, struct intel_gt, sysfs_gt); +} +void intel_gt_sysfs_register (struct intel_gt *gt);void intel_gt_sysfs_unregister (struct intel_gt *gt); struct intel_gt *intel_gt_sysfs_get_drvdata(struct device *dev,drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c +50
-0@@ -726,6 +726,51 @@ static const struct attribute *media_perf_power_attrs[] = {NULL }; +static ssize_t +default_min_freq_mhz_show (struct kobject *kobj,struct kobj_attribute *attr,char *buf) +{ +struct intel_gt *gt =kobj_to_gt (kobj->parent); + +return sysfs_emit (buf,"%d\n" , gt->rps_defaults.min_freq); +} + +static struct kobj_attribute default_min_freq_mhz = +__ATTR (rps_min_freq_mhz,0444 , default_min_freq_mhz_show,NULL ); + +static ssize_t +default_max_freq_mhz_show (struct kobject *kobj,struct kobj_attribute *attr,char *buf) +{ +struct intel_gt *gt =kobj_to_gt (kobj->parent); + +return sysfs_emit (buf,"%d\n" , gt->rps_defaults.max_freq); +} + +static struct kobj_attribute default_max_freq_mhz = +__ATTR (rps_max_freq_mhz,0444 , default_max_freq_mhz_show,NULL ); + +static ssize_t +default_boost_freq_mhz_show (struct kobject *kobj,struct kobj_attribute *attr,char *buf) +{ +struct intel_gt *gt =kobj_to_gt (kobj->parent); + +return sysfs_emit (buf,"%d\n" , gt->rps_defaults.boost_freq); +} + +static struct kobj_attribute default_boost_freq_mhz = +__ATTR (rps_boost_freq_mhz,0444 , default_boost_freq_mhz_show,NULL ); + +static const struct attribute *const rps_defaults_attrs[] = { + &default_min_freq_mhz.attr, + &default_max_freq_mhz.attr, + &default_boost_freq_mhz.attr, +NULL +}; + +static int add_rps_defaults (struct intel_gt *gt) +{ +return sysfs_create_files (gt->sysfs_defaults, rps_defaults_attrs); +} +static int intel_sysfs_rps_init (struct intel_gt *gt,struct kobject *kobj,const struct attribute *const *attrs) {@@ -775,4 +820,10 @@ void intel_gt_sysfs_pm_init(struct intel_gt *gt, struct kobject *kobj)"failed to create add gt%u media_perf_power_attrs sysfs (%pe)\n" , gt->info.id, ERR_PTR(ret)); } + + ret =add_rps_defaults (gt); +if (ret) +drm_warn (>->i915->drm, +"failed to add gt%u rps defaults (%pe)\n" , + gt->info.id,ERR_PTR (ret)); }drivers/gpu/drm/i915/gt/intel_gt_types.h +5
-0@@ -62,6 +62,12 @@ enum intel_steering_type {NUM_STEERING_TYPES }; +struct intel_rps_defaults { +u32 min_freq; +u32 max_freq; +u32 boost_freq; +}; +enum intel_submission_method {INTEL_SUBMISSION_RING ,INTEL_SUBMISSION_ELSP ,@@ -227,6 +233,10 @@ struct intel_gt {/* gt/gtN sysfs */
Quoted 8 lines
drivers/gpu/drm/i915/gt/intel_gt_types.h struct intel_gt { · line 239
Quoted 5 lines
drivers/gpu/drm/i915/gt/intel_gt_types.h +4
-0struct kobject sysfs_gt; + +/* sysfs defaults per gt */ +struct intel_rps_defaults rps_defaults; +struct kobject *sysfs_defaults;And not sure I am liking the mix of embedded and allocated kobjects.. Why we couldn't have it uniform?
We could use an embedded sysfs_defaults kobject but it is more code, the simplest code pattern is to use an allocated kobject (the kernel takes care of everything in this case).
There were two reasons for the embedded sysfs_gt kobject: (a) it had default attributes (default_groups) and (b) embedded allows using container_of() to get to the gt (see kobj_to_gt()).
Still talking to Andi about whether we need default attributes for sysfs_defaults too and if that happens we'll need to convert this to an embedded kobject too. But otherwise I prefer to leave this as is (and imo promoting multiple valid code patterns should be fine).
Quoted 58 lines
Quoted 58 lines
drivers/gpu/drm/i915/gt/intel_gt_types.h +0
-0};enum intel_gt_scratch_field {drivers/gpu/drm/i915/gt/intel_rps.c +3
-0@@ -1976,7 +1976,9 @@ void intel_rps_init(struct intel_rps *rps)/* Derive initial user preferences/limits from the hardware limits */ rps->max_freq_softlimit = rps->max_freq; +rps_to_gt (rps)->rps_defaults.max_freq = rps->max_freq_softlimit; rps->min_freq_softlimit = rps->min_freq; +rps_to_gt (rps)->rps_defaults.min_freq = rps->min_freq_softlimit;/* After setting max-softlimit, find the overclock max freq */ if (GRAPHICS_VER (i915) ==6 ||IS_IVYBRIDGE (i915) ||IS_HASWELL (i915)) {@@ -1994,6 +1996,7 @@ void intel_rps_init(struct intel_rps *rps)/* Finally allow us to boost to max by default */ rps->boost_freq = rps->max_freq; +rps_to_gt (rps)->rps_defaults.boost_freq = rps->boost_freq; rps->idle_freq = rps->min_freq;/* Start in the middle, from here we will autotune based on workload */
drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c +10
-3@@ -547,20 +547,24 @@ static int slpc_set_softlimits(struct intel_guc_slpc *slpc)* unless they have deviated from defaults, in which case, * we retain the values and set min/max accordingly. */ -if (!slpc->max_freq_softlimit) +if (!slpc->max_freq_softlimit) { slpc->max_freq_softlimit = slpc->rp0_freq; -else if (slpc->max_freq_softlimit != slpc->rp0_freq) +slpc_to_gt (slpc)->rps_defaults.max_freq = slpc->max_freq_softlimit; + }else if (slpc->max_freq_softlimit != slpc->rp0_freq) { ret =intel_guc_slpc_set_max_freq (slpc, slpc->max_freq_softlimit); + }if (unlikely (ret))return ret; - if (!slpc->min_freq_softlimit) +if (!slpc->min_freq_softlimit) { slpc->min_freq_softlimit = slpc->min_freq; - else if (slpc->min_freq_softlimit != slpc->min_freq) +slpc_to_gt (slpc)->rps_defaults.min_freq = slpc->min_freq_softlimit; + }else if (slpc->min_freq_softlimit != slpc->min_freq) {return intel_guc_slpc_set_min_freq (slpc, slpc->min_freq_softlimit); + }return 0 ; }@@ -606,8 +610,11 @@ static void slpc_get_rp_values(struct intel_guc_slpc *slpc) slpc->rp1_freq =intel_gpu_freq (rps, caps.rp1_freq); slpc->min_freq =intel_gpu_freq (rps, caps.min_freq); - if (!slpc->boost_freq) + /* Boost freq is RP0, unless already set */ +if (!slpc->boost_freq) {
Quoted 8 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c static void slpc_get_rp_values(struct intel_guc_slpc *slpc) · line 617
Quoted 3 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c +2
-0slpc->boost_freq = slpc->rp0_freq; +slpc_to_gt (slpc)->rps_defaults.boost_freq = slpc->boost_freq; + }Not liking that there are two places which set each of the default. Is it that there are GuC and non-GuC paths which initialize the parent struct? Is there a way to set the defaults at one common place after either branch has run?
Basically the RPS (non-GuC) and SLPC (Guc) are independent algorithms with independent data structs. So I think we would need to set the default inside those RPS and SLPC "modules" (or files).
My approach was to "capture" the defaults in places in the code where they are set (since the values sometimes change later even during the course of initialization). The issue with doing it this way is that we don't necessarily clearly see what those defaults are, they are just set at the right place in the code. So that is something we can debate about.
So an alternative would be to e.g. set defaults in rps_set_defaults() and slpc_set_defaults() functions (which would use explicit knowledge of what those defaults are). So I would be open to this if you think that's a better way to go. I think these functions can just be called during the course of RPS or SLPC initialization so I don't really see the need for doing it from a common place.
Thanks,
Ashutosh
PS: I have now sent out a new series for these patches, latest rev here:
https://patchwork.freedesktop.org/series/104423/
PATCH v4 8/8 drm/i915/gt: Expose default value for media_freq_factor in per-gt sysfs
In reply to Ashutosh DixitAdd the following sysfs file to gt/gtN/.defaults:
* media_freq_factor
--- drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 18 ++++++++++++++++++ drivers/gpu/drm/i915/gt/intel_gt_types.h | 1 + drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 2 ++ 3 files changed, 21 insertions(+)
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c +18 -0
@@ -759,6 +759,18 @@ default_boost_freq_mhz_show(struct kobject *kobj, struct kobj_attribute *attr, cstatic struct kobj_attribute default_boost_freq_mhz =__ATTR (rps_boost_freq_mhz,0444 , default_boost_freq_mhz_show,NULL ); +static ssize_t +default_media_freq_factor_show (struct kobject *kobj,struct kobj_attribute *attr,char *buf) +{ +struct intel_gt *gt =kobj_to_gt (kobj->parent); + +return sysfs_emit (buf,"%d\n" , +media_ratio_mode_to_factor (gt->rps_defaults.media_ratio_mode)); +} + +static struct kobj_attribute default_media_freq_factor = +__ATTR (media_freq_factor,0444 , default_media_freq_factor_show,NULL ); +static const struct attribute *const rps_defaults_attrs[] = { &default_min_freq_mhz.attr, &default_max_freq_mhz.attr,
@@ -819,6 +831,12 @@ void intel_gt_sysfs_pm_init(struct intel_gt *gt, struct kobject *kobj)drm_warn (>->i915->drm,"failed to create add gt%u media_perf_power_attrs sysfs (%pe)\n" , gt->info.id,ERR_PTR (ret)); + + ret =sysfs_create_file (gt->sysfs_defaults, &default_media_freq_factor.attr); +if (ret) +drm_warn (>->i915->drm, +"failed to add gt%u default_media_freq_factor sysfs (%pe)\n" , + gt->info.id,ERR_PTR (ret)); } ret =add_rps_defaults (gt);
drivers/gpu/drm/i915/gt/intel_gt_types.h +1 -0
@@ -66,6 +66,7 @@ struct intel_rps_defaults {u32 min_freq;u32 max_freq;u32 boost_freq; +u32 media_ratio_mode; };enum intel_submission_method {
drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c +2 -0
@@ -260,7 +260,9 @@ int intel_guc_slpc_init(struct intel_guc_slpc *slpc) slpc->boost_freq =0 ;atomic_set (&slpc->num_waiters,0 ); slpc->num_boosts =0 ; + slpc->media_ratio_mode =SLPC_MEDIA_RATIO_MODE_DYNAMIC_CONTROL ; +slpc_to_gt (slpc)->rps_defaults.media_ratio_mode = slpc->media_ratio_mode;mutex_init (&slpc->lock);INIT_WORK (&slpc->boost_work, slpc_boost_work);
Signature · 1 line
2.34.1
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Media freq factor and per-gt enhancements/fixes (rev4)
In reply to Ashutosh Dixit== Series Details ==
== Series Details ==
Series: drm/i915: Media freq factor and per-gt enhancements/fixes (rev4)
URL : https://patchwork.freedesktop.org/series/102665/
State : warning
== Summary ==
Error: dim checkpatch failed720f593ecbb4 drm/i915: Introduce has_media_ratio_mode 3c55d72952c7 drm/i915/gt: Add media freq factor to per-gt sysfs 7d95ec03bc5c drm/i915/pcode: Extend pcode functions for multiple gt's d4d085d5329c drm/i915/pcode: Add a couple of pcode helpers 87ee92d4c079 drm/i915/gt: Add media RP0/RPn to per-gt sysfs -:83: CHECK:CAMELCASE: Avoid CamelCase: <media_RPn_freq_mhz> #83: FILE: drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c:719:
+static DEVICE_ATTR_RO(media_RPn_freq_mhz);
-:89: CHECK:CAMELCASE: Avoid CamelCase: <dev_attr_media_RPn_freq_mhz> #89: FILE: drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c:725:
+ &dev_attr_media_RPn_freq_mhz.attr,
total: 0 errors, 0 warnings, 2 checks, 80 lines checked8ab6df0311f7 drm/i915/gt: Fix memory leaks in per-gt sysfs e7bbfef93b31 drm/i915/gt: Expose per-gt RPS defaults in sysfs ffca9fefe5d0 drm/i915/gt: Expose default value for media_freq_factor in per-gt sysfs
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Media freq factor and per-gt enhancements/fixes (rev4)
In reply to Ashutosh Dixit== Series Details ==
== Series Details ==
Series: drm/i915: Media freq factor and per-gt enhancements/fixes (rev4)
URL : https://patchwork.freedesktop.org/series/102665/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Media freq factor and per-gt enhancements/fixes (rev4)
In reply to Ashutosh Dixit== Series Details ==
== Series Details ==
Series: drm/i915: Media freq factor and per-gt enhancements/fixes (rev4)
URL : https://patchwork.freedesktop.org/series/102665/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11583 -> Patchwork_102665v4
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/index.html
Participating hosts (43 -> 45)
------------------------------
Additional (4): bat-rpls-1 fi-rkl-11600 fi-icl-u2 bat-dg1-5
Missing (2): fi-hsw-4770 fi-bsw-cyan
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_102665v4:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@i915_selftest@live@gem_contexts:
- {bat-rpls-1}: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/bat-rpls-1/igt@i915_selftest@live@gem_contexts.html
* igt@i915_selftest@live@mman:
- {bat-jsl-1}: [PASS][2] -> [INCOMPLETE][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/bat-jsl-1/igt@i915_selftest@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/bat-jsl-1/igt@i915_selftest@[email protected]
Known issues
------------
Here are the changes found in Patchwork_102665v4 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@fbdev@write:
- bat-dg1-5: NOTRUN -> [SKIP][4] ([i915#2582]) +4 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/bat-dg1-5/igt@[email protected]
* igt@gem_exec_suspend@basic-s0@smem:
- bat-dg1-6: NOTRUN -> [INCOMPLETE][5] ([i915#5827])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/bat-dg1-6/igt@gem_exec_suspend@[email protected]
- bat-dg1-5: NOTRUN -> [INCOMPLETE][6] ([i915#5827])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/bat-dg1-5/igt@gem_exec_suspend@[email protected]
* igt@gem_exec_suspend@basic-s3@smem:
- fi-bdw-5557u: NOTRUN -> [INCOMPLETE][7] ([i915#146])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/fi-bdw-5557u/igt@gem_exec_suspend@[email protected]
- fi-rkl-11600: NOTRUN -> [INCOMPLETE][8] ([i915#5127] / [i915#5857])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/fi-rkl-11600/igt@gem_exec_suspend@[email protected]
* igt@gem_huc_copy@huc-copy:
- fi-icl-u2: NOTRUN -> [SKIP][9] ([i915#2190])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/fi-icl-u2/igt@[email protected]
* igt@gem_lmem_swapping@parallel-random-engines:
- fi-icl-u2: NOTRUN -> [SKIP][10] ([i915#4613]) +3 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/fi-icl-u2/igt@[email protected]
* igt@i915_module_load@reload:
- fi-bsw-kefka: [PASS][11] -> [DMESG-WARN][12] ([i915#1982])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/fi-bsw-kefka/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/fi-bsw-kefka/igt@[email protected]
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-tgl-1115g4: NOTRUN -> [SKIP][13] ([fdo#111827])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/fi-tgl-1115g4/igt@[email protected]
- fi-kbl-soraka: NOTRUN -> [SKIP][14] ([fdo#109271] / [fdo#111827])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/fi-kbl-soraka/igt@[email protected]
- fi-snb-2600: NOTRUN -> [SKIP][15] ([fdo#109271] / [fdo#111827])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/fi-snb-2600/igt@[email protected]
- fi-kbl-guc: NOTRUN -> [SKIP][16] ([fdo#109271] / [fdo#111827])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/fi-kbl-guc/igt@[email protected]
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u2: NOTRUN -> [SKIP][17] ([fdo#111827]) +8 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/fi-icl-u2/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-icl-u2: NOTRUN -> [SKIP][18] ([fdo#109278]) +2 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/fi-icl-u2/igt@[email protected]
* igt@kms_force_connector_basic@force-load-detect:
- fi-icl-u2: NOTRUN -> [SKIP][19] ([fdo#109285])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/fi-icl-u2/igt@[email protected]
* igt@kms_setmode@basic-clone-single-crtc:
- fi-icl-u2: NOTRUN -> [SKIP][20] ([i915#3555])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/fi-icl-u2/igt@[email protected]
* igt@prime_vgem@basic-userptr:
- fi-icl-u2: NOTRUN -> [SKIP][21] ([i915#3301])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/fi-icl-u2/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0@smem:
- {fi-ehl-2}: [DMESG-WARN][22] ([i915#5122]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/fi-ehl-2/igt@gem_exec_suspend@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/fi-ehl-2/igt@gem_exec_suspend@[email protected]
- fi-tgl-1115g4: [DMESG-WARN][24] ([i915#5122]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/fi-tgl-1115g4/igt@gem_exec_suspend@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/fi-tgl-1115g4/igt@gem_exec_suspend@[email protected]
* igt@i915_selftest@live@gt_mocs:
- fi-rkl-guc: [DMESG-WARN][26] -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/fi-rkl-guc/igt@i915_selftest@live@gt_mocs.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/fi-rkl-guc/igt@i915_selftest@live@gt_mocs.html
* igt@i915_selftest@live@gt_pm:
- fi-tgl-1115g4: [DMESG-FAIL][28] ([i915#3987]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/fi-tgl-1115g4/igt@i915_selftest@live@gt_pm.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/fi-tgl-1115g4/igt@i915_selftest@live@gt_pm.html
* igt@kms_flip@basic-flip-vs-modeset@b-edp1:
- {bat-adlp-6}: [DMESG-WARN][30] ([i915#3576]) -> [PASS][31] +1 similar issue
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/bat-adlp-6/igt@kms_flip@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/bat-adlp-6/igt@kms_flip@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3987]: https://gitlab.freedesktop.org/drm/intel/issues/3987
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5127]: https://gitlab.freedesktop.org/drm/intel/issues/5127
[i915#5153]: https://gitlab.freedesktop.org/drm/intel/issues/5153
[i915#5278]: https://gitlab.freedesktop.org/drm/intel/issues/5278
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5763]: https://gitlab.freedesktop.org/drm/intel/issues/5763
[i915#5820]: https://gitlab.freedesktop.org/drm/intel/issues/5820
[i915#5827]: https://gitlab.freedesktop.org/drm/intel/issues/5827
[i915#5857]: https://gitlab.freedesktop.org/drm/intel/issues/5857
Build changes
-------------
* IGT: IGT_6464 -> IGTPW_7000
* Linux: CI_DRM_11583 -> Patchwork_102665v4
CI-20190529: 20190529
CI_DRM_11583: 828a5e99fd22d846ff49df61bcc5e9e5c21d562a @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_7000: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7000/index.html
IGT_6464: eddc67c5c85b8ee6eb4d13752ca43da5073dc985 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_102665v4: 828a5e99fd22d846ff49df61bcc5e9e5c21d562a @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
c4d63cc2e600 drm/i915/gt: Expose default value for media_freq_factor in per-gt sysfs 9456fd0de07a drm/i915/gt: Expose per-gt RPS defaults in sysfs 565bacfd0388 drm/i915/gt: Fix memory leaks in per-gt sysfs dfdc7b6f840b drm/i915/gt: Add media RP0/RPn to per-gt sysfs b646ac85f3c7 drm/i915/pcode: Add a couple of pcode helpers 62edd3b6431a drm/i915/pcode: Extend pcode functions for multiple gt's 2feb0d62907e drm/i915/gt: Add media freq factor to per-gt sysfs 1a8fac3af868 drm/i915: Introduce has_media_ratio_mode
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/index.html
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Media freq factor and per-gt enhancements/fixes (rev4)
In reply to Ashutosh Dixit== Series Details ==
== Series Details ==
Series: drm/i915: Media freq factor and per-gt enhancements/fixes (rev4)
URL : https://patchwork.freedesktop.org/series/102665/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11583_full -> Patchwork_102665v4_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_102665v4_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_102665v4_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Participating hosts (10 -> 13)
------------------------------
Additional (3): shard-rkl shard-dg1 shard-tglu
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_102665v4_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_eio@in-flight-suspend:
- shard-skl: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-skl4/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl10/igt@[email protected]
* {igt@i915_pm_disag_freq@media-freq@gt0} (NEW):
- shard-iclb: NOTRUN -> [SKIP][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb2/igt@i915_pm_disag_freq@[email protected]
- shard-tglb: NOTRUN -> [SKIP][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb3/igt@i915_pm_disag_freq@[email protected]
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-xtiled:
- shard-kbl: [PASS][5] -> [FAIL][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-kbl7/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl6/igt@[email protected]
New tests
---------
New tests have been introduced between CI_DRM_11583_full and Patchwork_102665v4_full:
### New IGT tests (1) ###
* igt@i915_pm_disag_freq@media-freq@gt0:
- Statuses : 7 skip(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_102665v4_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_busy@close-race:
- shard-snb: [PASS][7] -> [TIMEOUT][8] ([i915#5748])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-snb4/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-snb5/igt@[email protected]
* igt@gem_ccs@ctrl-surf-copy:
- shard-tglb: NOTRUN -> [SKIP][9] ([i915#3555] / [i915#5325])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb3/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][10] ([i915#5327])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb2/igt@[email protected]
* igt@gem_ctx_persistence@legacy-engines-mixed-process:
- shard-snb: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#1099]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-snb2/igt@[email protected]
* igt@gem_eio@in-flight-contexts-immediate:
- shard-tglb: [PASS][12] -> [TIMEOUT][13] ([i915#3063])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-tglb6/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb8/igt@[email protected]
* igt@gem_exec_balancer@parallel-keep-in-fence:
- shard-kbl: NOTRUN -> [DMESG-WARN][14] ([i915#5076] / [i915#5614])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl7/igt@[email protected]
* igt@gem_exec_balancer@parallel-ordering:
- shard-iclb: NOTRUN -> [DMESG-FAIL][15] ([i915#5614])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb1/igt@[email protected]
- shard-tglb: NOTRUN -> [DMESG-FAIL][16] ([i915#5076] / [i915#5614])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb1/igt@[email protected]
- shard-kbl: NOTRUN -> [DMESG-FAIL][17] ([i915#5076] / [i915#5614])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl1/igt@[email protected]
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-skl: NOTRUN -> [SKIP][18] ([fdo#109271]) +218 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl9/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-tglb: [PASS][19] -> [FAIL][20] ([i915#2842])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-tglb6/igt@gem_exec_fair@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb1/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none@vcs1:
- shard-kbl: NOTRUN -> [FAIL][21] ([i915#2842]) +2 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl1/igt@gem_exec_fair@[email protected]
- shard-iclb: NOTRUN -> [FAIL][22] ([i915#2842])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb4/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-glk: [PASS][23] -> [FAIL][24] ([i915#2842]) +3 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-glk4/igt@gem_exec_fair@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-glk9/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-tglb: NOTRUN -> [FAIL][25] ([i915#2842])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb5/igt@gem_exec_fair@[email protected]
* igt@gem_exec_flush@basic-wb-rw-default:
- shard-snb: [PASS][26] -> [SKIP][27] ([fdo#109271]) +3 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-snb4/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-snb6/igt@[email protected]
* igt@gem_exec_params@no-bsd:
- shard-iclb: NOTRUN -> [SKIP][28] ([fdo#109283])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb6/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][29] ([fdo#109283])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb1/igt@[email protected]
* igt@gem_exec_params@secure-non-root:
- shard-tglb: NOTRUN -> [SKIP][30] ([fdo#112283])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb5/igt@[email protected]
* igt@gem_exec_suspend@basic-s3@smem:
- shard-skl: [PASS][31] -> [INCOMPLETE][32] ([i915#4547] / [i915#4939] / [i915#5680])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-skl1/igt@gem_exec_suspend@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl1/igt@gem_exec_suspend@[email protected]
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][33] -> [SKIP][34] ([i915#2190])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-tglb5/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb7/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][35] ([fdo#109271] / [i915#2190])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-apl2/igt@[email protected]
- shard-skl: NOTRUN -> [SKIP][36] ([fdo#109271] / [i915#2190])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl9/igt@[email protected]
* igt@gem_lmem_swapping@heavy-random:
- shard-iclb: NOTRUN -> [SKIP][37] ([i915#4613]) +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb6/igt@[email protected]
* igt@gem_lmem_swapping@heavy-verify-random:
- shard-tglb: NOTRUN -> [SKIP][38] ([i915#4613]) +4 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb1/igt@[email protected]
* igt@gem_lmem_swapping@heavy-verify-random-ccs:
- shard-skl: NOTRUN -> [SKIP][39] ([fdo#109271] / [i915#4613]) +4 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl4/igt@[email protected]
* igt@gem_lmem_swapping@parallel-multi:
- shard-glk: NOTRUN -> [SKIP][40] ([fdo#109271] / [i915#4613]) +1 similar issue
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-glk1/igt@[email protected]
* igt@gem_lmem_swapping@parallel-random-engines:
- shard-apl: NOTRUN -> [SKIP][41] ([fdo#109271] / [i915#4613]) +3 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-apl1/igt@[email protected]
* igt@gem_lmem_swapping@smem-oom:
- shard-kbl: NOTRUN -> [SKIP][42] ([fdo#109271] / [i915#4613]) +3 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl7/igt@[email protected]
* igt@gem_pread@exhaustion:
- shard-iclb: NOTRUN -> [WARN][43] ([i915#2658]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb3/igt@[email protected]
* igt@gem_pwrite@basic-exhaustion:
- shard-tglb: NOTRUN -> [WARN][44] ([i915#2658])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb1/igt@[email protected]
- shard-kbl: NOTRUN -> [WARN][45] ([i915#2658])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl7/igt@[email protected]
* igt@gem_pxp@create-protected-buffer:
- shard-iclb: NOTRUN -> [SKIP][46] ([i915#4270]) +4 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb3/igt@[email protected]
* igt@gem_pxp@protected-raw-src-copy-not-readible:
- shard-tglb: NOTRUN -> [SKIP][47] ([i915#4270]) +5 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb1/igt@[email protected]
* igt@gem_render_copy@x-tiled-to-vebox-yf-tiled:
- shard-kbl: NOTRUN -> [SKIP][48] ([fdo#109271]) +311 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl7/igt@[email protected]
* igt@gem_render_copy@yf-tiled-mc-ccs-to-vebox-yf-tiled:
- shard-iclb: NOTRUN -> [SKIP][49] ([i915#768]) +6 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb2/igt@[email protected]
* igt@gem_softpin@noreloc-s3:
- shard-kbl: [PASS][50] -> [DMESG-WARN][51] ([i915#180])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-kbl4/igt@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl7/igt@[email protected]
* igt@gem_userptr_blits@coherency-sync:
- shard-tglb: NOTRUN -> [SKIP][52] ([fdo#110542])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb6/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][53] ([fdo#109290])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb8/igt@[email protected]
* igt@gem_userptr_blits@dmabuf-sync:
- shard-skl: NOTRUN -> [SKIP][54] ([fdo#109271] / [i915#3323])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl10/igt@[email protected]
* igt@gem_userptr_blits@input-checking:
- shard-skl: NOTRUN -> [DMESG-WARN][55] ([i915#4991])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl9/igt@[email protected]
* igt@gem_userptr_blits@unsync-overlap:
- shard-tglb: NOTRUN -> [SKIP][56] ([i915#3297]) +1 similar issue
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb5/igt@[email protected]
* igt@gem_userptr_blits@unsync-unmap:
- shard-iclb: NOTRUN -> [SKIP][57] ([i915#3297]) +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb5/igt@[email protected]
* igt@gem_userptr_blits@vma-merge:
- shard-snb: NOTRUN -> [FAIL][58] ([i915#2724])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-snb4/igt@[email protected]
- shard-iclb: NOTRUN -> [FAIL][59] ([i915#3318])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb5/igt@[email protected]
- shard-glk: NOTRUN -> [FAIL][60] ([i915#3318])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-glk9/igt@[email protected]
- shard-apl: NOTRUN -> [FAIL][61] ([i915#3318])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-apl8/igt@[email protected]
- shard-skl: NOTRUN -> [FAIL][62] ([i915#3318])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl1/igt@[email protected]
* igt@gen7_exec_parse@oacontrol-tracking:
- shard-iclb: NOTRUN -> [SKIP][63] ([fdo#109289]) +6 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb4/igt@[email protected]
* igt@gen9_exec_parse@allowed-all:
- shard-iclb: NOTRUN -> [SKIP][64] ([i915#2856]) +1 similar issue
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb2/igt@[email protected]
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [PASS][65] -> [DMESG-WARN][66] ([i915#5566] / [i915#716])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-glk4/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-glk9/igt@[email protected]
- shard-skl: [PASS][67] -> [DMESG-WARN][68] ([i915#5566] / [i915#716])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-skl1/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl9/igt@[email protected]
* igt@gen9_exec_parse@bb-secure:
- shard-tglb: NOTRUN -> [SKIP][69] ([i915#2527] / [i915#2856]) +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb8/igt@[email protected]
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-tglb: NOTRUN -> [SKIP][70] ([i915#1904])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb7/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][71] ([i915#658])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb3/igt@[email protected]
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-kbl: NOTRUN -> [SKIP][72] ([fdo#109271] / [i915#1937])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl7/igt@i915_pm_lpsp@[email protected]
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: NOTRUN -> [WARN][73] ([i915#2684])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb6/igt@[email protected]
- shard-tglb: NOTRUN -> [WARN][74] ([i915#2681])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb1/igt@[email protected]
* igt@i915_pm_rpm@gem-execbuf-stress-pc8:
- shard-iclb: NOTRUN -> [SKIP][75] ([fdo#109293] / [fdo#109506])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb6/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][76] ([fdo#109506] / [i915#2411])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb8/igt@[email protected]
* igt@i915_pm_rpm@modeset-lpsp-stress:
- shard-apl: NOTRUN -> [SKIP][77] ([fdo#109271]) +240 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-apl6/igt@[email protected]
* igt@i915_pm_rpm@modeset-non-lpsp:
- shard-iclb: NOTRUN -> [SKIP][78] ([fdo#110892]) +2 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb2/igt@[email protected]
* igt@i915_pm_rpm@modeset-non-lpsp-stress:
- shard-tglb: NOTRUN -> [SKIP][79] ([fdo#111644] / [i915#1397] / [i915#2411]) +2 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb6/igt@[email protected]
* igt@i915_pm_sseu@full-enable:
- shard-skl: [PASS][80] -> [FAIL][81] ([i915#3650])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-skl7/igt@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl9/igt@[email protected]
* igt@kms_addfb_basic@invalid-smem-bo-on-discrete:
- shard-tglb: NOTRUN -> [SKIP][82] ([i915#3826])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb7/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][83] ([i915#3826])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb3/igt@[email protected]
* igt@kms_async_flips@crc:
- shard-skl: NOTRUN -> [FAIL][84] ([i915#4272])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl4/igt@[email protected]
* igt@kms_big_fb@4-tiled-64bpp-rotate-90:
- shard-iclb: NOTRUN -> [SKIP][85] ([i915#5286]) +2 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb4/igt@[email protected]
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
- shard-tglb: NOTRUN -> [SKIP][86] ([i915#5286]) +5 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb7/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html
* igt@kms_big_fb@linear-16bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][87] ([fdo#111614]) +7 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb3/igt@[email protected]
* igt@kms_big_fb@x-tiled-8bpp-rotate-90:
- shard-iclb: NOTRUN -> [SKIP][88] ([fdo#110725] / [fdo#111614]) +4 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb2/igt@[email protected]
* igt@kms_big_fb@yf-tiled-64bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][89] ([fdo#111615]) +6 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb8/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][90] ([fdo#110723]) +1 similar issue
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb6/igt@[email protected]
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-skl: NOTRUN -> [FAIL][91] ([i915#3743]) +1 similar issue
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl4/igt@[email protected]
* igt@kms_big_joiner@2x-modeset:
- shard-iclb: NOTRUN -> [SKIP][92] ([i915#2705])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb1/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][93] ([i915#2705])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb8/igt@[email protected]
* igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][94] ([i915#3689] / [i915#3886]) +4 similar issues
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb5/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs.html
- shard-iclb: NOTRUN -> [SKIP][95] ([fdo#109278] / [i915#3886]) +6 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb7/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][96] ([fdo#109271] / [i915#3886]) +8 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl7/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][97] ([i915#3689]) +9 similar issues
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb8/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_ccs.html
* igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][98] ([fdo#109271] / [i915#3886]) +9 similar issues
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-apl1/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
- shard-glk: NOTRUN -> [SKIP][99] ([fdo#109271] / [i915#3886]) +3 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-glk5/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][100] ([fdo#109271] / [i915#3886]) +13 similar issues
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl1/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_ccs:
- shard-kbl: NOTRUN -> [DMESG-WARN][101] ([i915#62] / [i915#92])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl6/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_ccs.html
* igt@kms_ccs@pipe-d-missing-ccs-buffer-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][102] ([fdo#111615] / [i915#3689]) +6 similar issues
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb1/igt@kms_ccs@pipe-d-missing-ccs-buffer-yf_tiled_ccs.html
* igt@kms_chamelium@hdmi-crc-nonplanar-formats:
- shard-glk: NOTRUN -> [SKIP][103] ([fdo#109271] / [fdo#111827]) +7 similar issues
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-glk2/igt@[email protected]
* igt@kms_color@pipe-a-deep-color:
- shard-iclb: NOTRUN -> [SKIP][104] ([fdo#109278] / [i915#3555])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb6/igt@[email protected]
* igt@kms_color@pipe-d-deep-color:
- shard-tglb: NOTRUN -> [SKIP][105] ([i915#3555]) +3 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb2/igt@[email protected]
* igt@kms_color@pipe-d-degamma:
- shard-iclb: NOTRUN -> [SKIP][106] ([fdo#109278] / [i915#1149]) +1 similar issue
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb3/igt@[email protected]
* igt@kms_color@pipe-d-invalid-ctm-matrix-sizes:
- shard-iclb: NOTRUN -> [SKIP][107] ([fdo#109278]) +51 similar issues
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb5/igt@[email protected]
* igt@kms_color_chamelium@pipe-b-ctm-red-to-blue:
- shard-iclb: NOTRUN -> [SKIP][108] ([fdo#109284] / [fdo#111827]) +15 similar issues
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb5/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][109] ([fdo#109271] / [fdo#111827]) +15 similar issues
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-apl8/igt@[email protected]
- shard-snb: NOTRUN -> [SKIP][110] ([fdo#109271] / [fdo#111827]) +8 similar issues
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-snb4/igt@[email protected]
* igt@kms_color_chamelium@pipe-c-ctm-limited-range:
- shard-kbl: NOTRUN -> [SKIP][111] ([fdo#109271] / [fdo#111827]) +19 similar issues
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl3/igt@[email protected]
* igt@kms_color_chamelium@pipe-c-ctm-negative:
- shard-skl: NOTRUN -> [SKIP][112] ([fdo#109271] / [fdo#111827]) +15 similar issues
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl4/igt@[email protected]
* igt@kms_color_chamelium@pipe-d-ctm-red-to-blue:
- shard-tglb: NOTRUN -> [SKIP][113] ([fdo#109284] / [fdo#111827]) +15 similar issues
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb8/igt@[email protected]
* igt@kms_content_protection@dp-mst-lic-type-1:
- shard-iclb: NOTRUN -> [SKIP][114] ([i915#3116])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb3/igt@[email protected]
* igt@kms_content_protection@mei_interface:
- shard-iclb: NOTRUN -> [SKIP][115] ([fdo#109300] / [fdo#111066]) +1 similar issue
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb1/igt@kms_content_protection@mei_interface.html
* igt@kms_content_protection@uevent:
- shard-tglb: NOTRUN -> [SKIP][116] ([i915#1063]) +2 similar issues
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb6/igt@[email protected]
- shard-apl: NOTRUN -> [FAIL][117] ([i915#2105])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-apl7/igt@[email protected]
- shard-kbl: NOTRUN -> [FAIL][118] ([i915#2105])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl1/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-256x85-sliding:
- shard-snb: NOTRUN -> [SKIP][119] ([fdo#109271]) +237 similar issues
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-snb4/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-32x10-sliding:
- shard-tglb: NOTRUN -> [SKIP][120] ([i915#3359]) +5 similar issues
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb8/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-512x512-random:
- shard-iclb: NOTRUN -> [SKIP][121] ([fdo#109278] / [fdo#109279]) +5 similar issues
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb4/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-32x32-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][122] ([i915#3319]) +3 similar issues
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb1/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-apl: [PASS][123] -> [DMESG-WARN][124] ([i915#180]) +3 similar issues
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-apl8/igt@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-apl6/igt@[email protected]
* igt@kms_cursor_crc@pipe-d-cursor-512x170-offscreen:
- shard-tglb: NOTRUN -> [SKIP][125] ([fdo#109279] / [i915#3359]) +11 similar issues
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb1/igt@[email protected]
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-iclb: NOTRUN -> [SKIP][126] ([fdo#109274] / [fdo#109278]) +7 similar issues
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb8/igt@[email protected]
* igt@kms_cursor_legacy@short-busy-flip-before-cursor-toggle:
- shard-tglb: NOTRUN -> [SKIP][127] ([i915#4103])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb6/igt@[email protected]
* igt@kms_dither@fb-8bpc-vs-panel-8bpc@edp-1-pipe-a:
- shard-tglb: NOTRUN -> [SKIP][128] ([i915#3788])
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb3/igt@kms_dither@[email protected]
* igt@kms_draw_crc@draw-method-xrgb2101010-blt-4tiled:
- shard-tglb: NOTRUN -> [SKIP][129] ([i915#5287]) +3 similar issues
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb2/igt@[email protected]
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-4tiled:
- shard-iclb: NOTRUN -> [SKIP][130] ([i915#5287]) +3 similar issues
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb8/igt@[email protected]
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: NOTRUN -> [INCOMPLETE][131] ([i915#180])
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-apl2/igt@[email protected]
* igt@kms_flip@2x-absolute-wf_vblank:
- shard-tglb: NOTRUN -> [SKIP][132] ([fdo#109274] / [fdo#111825] / [i915#3966])
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb3/igt@kms_flip@2x-absolute-wf_vblank.html
* igt@kms_flip@2x-flip-vs-dpms-off-vs-modeset-interruptible:
- shard-tglb: NOTRUN -> [SKIP][133] ([fdo#109274] / [fdo#111825]) +16 similar issues
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb2/igt@[email protected]
* igt@kms_flip@2x-plain-flip-ts-check-interruptible:
- shard-iclb: NOTRUN -> [SKIP][134] ([fdo#109274]) +9 similar issues
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb7/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-tglb: [PASS][135] -> [FAIL][136] ([i915#79])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-tglb1/igt@kms_flip@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb2/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend@b-dp1:
- shard-apl: NOTRUN -> [DMESG-WARN][137] ([i915#180])
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-apl1/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling:
- shard-tglb: NOTRUN -> [SKIP][138] ([i915#2587])
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling:
- shard-iclb: [PASS][139] -> [SKIP][140] ([i915#3701]) +1 similar issue
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-iclb5/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs-upscaling:
- shard-iclb: NOTRUN -> [SKIP][141] ([i915#2587])
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb7/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs-upscaling.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-tglb: NOTRUN -> [SKIP][142] ([fdo#109280] / [fdo#111825]) +51 similar issues
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-pwrite:
- shard-iclb: NOTRUN -> [SKIP][143] ([fdo#109280]) +44 similar issues
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-render:
- shard-glk: NOTRUN -> [SKIP][144] ([fdo#109271]) +114 similar issues
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-glk5/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-render.html
* igt@kms_hdr@bpc-switch@bpc-switch-edp-1-pipe-a:
- shard-skl: [PASS][145] -> [FAIL][146] ([i915#1188])
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-skl9/igt@kms_hdr@[email protected]
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl6/igt@kms_hdr@[email protected]
* igt@kms_pipe_b_c_ivb@from-pipe-c-to-b-with-3-lanes:
- shard-tglb: NOTRUN -> [SKIP][147] ([fdo#109289]) +7 similar issues
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb7/igt@[email protected]
* igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-b:
- shard-kbl: [PASS][148] -> [DMESG-FAIL][149] ([i915#62] / [i915#92])
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-kbl4/igt@[email protected]
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl6/igt@[email protected]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence:
- shard-apl: NOTRUN -> [SKIP][150] ([fdo#109271] / [i915#533]) +1 similar issue
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-apl3/igt@[email protected]
* igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence:
- shard-glk: NOTRUN -> [SKIP][151] ([fdo#109271] / [i915#533])
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-glk2/igt@[email protected]
- shard-skl: NOTRUN -> [SKIP][152] ([fdo#109271] / [i915#533])
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl1/igt@[email protected]
* igt@kms_plane@plane-position-hole@pipe-a-planes:
- shard-kbl: [PASS][153] -> [DMESG-WARN][154] ([i915#62] / [i915#92]) +4 similar issues
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-kbl4/igt@kms_plane@[email protected]
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl6/igt@kms_plane@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-alpha-basic:
- shard-apl: NOTRUN -> [FAIL][155] ([fdo#108145] / [i915#265]) +1 similar issue
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-apl2/igt@[email protected]
- shard-kbl: NOTRUN -> [FAIL][156] ([fdo#108145] / [i915#265]) +3 similar issues
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl1/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb:
- shard-apl: NOTRUN -> [FAIL][157] ([i915#265])
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-apl8/igt@[email protected]
- shard-glk: NOTRUN -> [FAIL][158] ([i915#265])
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-glk9/igt@[email protected]
- shard-kbl: NOTRUN -> [FAIL][159] ([i915#265])
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl3/igt@[email protected]
- shard-skl: NOTRUN -> [FAIL][160] ([i915#265])
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl1/igt@[email protected]
* igt@kms_plane_lowres@pipe-a-tiling-yf:
- shard-iclb: NOTRUN -> [SKIP][161] ([i915#3536]) +2 similar issues
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb2/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][162] ([fdo#111615] / [fdo#112054])
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb3/igt@[email protected]
* igt@kms_plane_lowres@pipe-d-tiling-x:
- shard-tglb: NOTRUN -> [SKIP][163] ([i915#3536]) +2 similar issues
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb7/igt@[email protected]
* igt@kms_plane_scaling@downscale-with-pixel-format-factor-0-5@pipe-c-edp-1-downscale-with-pixel-format:
- shard-iclb: [PASS][164] -> [SKIP][165] ([i915#5176]) +2 similar issues
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-iclb5/igt@kms_plane_scaling@downscale-with-pixel-format-factor-0-5@pipe-c-edp-1-downscale-with-pixel-format.html
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb2/igt@kms_plane_scaling@downscale-with-pixel-format-factor-0-5@pipe-c-edp-1-downscale-with-pixel-format.html
* igt@kms_plane_scaling@downscale-with-rotation-factor-0-25@pipe-c-edp-1-downscale-with-rotation:
- shard-tglb: NOTRUN -> [SKIP][166] ([i915#5176]) +3 similar issues
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb7/igt@kms_plane_scaling@downscale-with-rotation-factor-0-25@pipe-c-edp-1-downscale-with-rotation.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-a-edp-1-planes-upscale-downscale:
- shard-tglb: NOTRUN -> [SKIP][167] ([i915#5235]) +7 similar issues
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb7/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-a-edp-1-planes-upscale-downscale.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-sf:
- shard-tglb: NOTRUN -> [SKIP][168] ([i915#2920])
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb3/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][169] ([i915#2920])
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb2/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- shard-skl: NOTRUN -> [SKIP][170] ([fdo#109271] / [i915#658]) +1 similar issue
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl1/igt@[email protected]
* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-iclb: [PASS][171] -> [SKIP][172] ([fdo#109642] / [fdo#111068] / [i915#658])
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-iclb2/igt@[email protected]
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb3/igt@[email protected]
* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-tglb: NOTRUN -> [SKIP][173] ([i915#1911])
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb5/igt@kms_psr2_su@page_flip-xrgb8888.html
- shard-kbl: NOTRUN -> [SKIP][174] ([fdo#109271] / [i915#658]) +2 similar issues
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl4/igt@kms_psr2_su@page_flip-xrgb8888.html
- shard-iclb: NOTRUN -> [SKIP][175] ([fdo#109642] / [fdo#111068] / [i915#658])
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb5/igt@kms_psr2_su@page_flip-xrgb8888.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-tglb: NOTRUN -> [FAIL][176] ([i915#132] / [i915#3467]) +4 similar issues
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb8/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: NOTRUN -> [SKIP][177] ([fdo#109441]) +5 similar issues
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb7/igt@kms_psr@psr2_sprite_mmap_gtt.html
* igt@kms_rotation_crc@primary-4-tiled-reflect-x-0:
- shard-iclb: NOTRUN -> [SKIP][178] ([i915#5289]) +1 similar issue
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb5/igt@[email protected]
* igt@kms_rotation_crc@primary-4-tiled-reflect-x-180:
- shard-tglb: NOTRUN -> [SKIP][179] ([i915#5289]) +1 similar issue
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb6/igt@[email protected]
* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-0:
- shard-tglb: NOTRUN -> [SKIP][180] ([fdo#111615] / [i915#5289])
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb2/igt@[email protected]
* igt@kms_setmode@invalid-clone-single-crtc:
- shard-iclb: NOTRUN -> [SKIP][181] ([i915#3555]) +1 similar issue
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb8/igt@[email protected]
* igt@kms_writeback@writeback-check-output:
- shard-kbl: NOTRUN -> [SKIP][182] ([fdo#109271] / [i915#2437])
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl3/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][183] ([i915#2437])
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb1/igt@[email protected]
* igt@kms_writeback@writeback-invalid-parameters:
- shard-skl: NOTRUN -> [SKIP][184] ([fdo#109271] / [i915#2437])
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl6/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][185] ([fdo#109271] / [i915#2437]) +1 similar issue
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-apl1/igt@[email protected]
* igt@nouveau_crc@pipe-b-source-outp-inactive:
- shard-iclb: NOTRUN -> [SKIP][186] ([i915#2530]) +5 similar issues
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb2/igt@[email protected]
* igt@nouveau_crc@pipe-d-ctx-flip-detection:
- shard-tglb: NOTRUN -> [SKIP][187] ([i915#2530]) +7 similar issues
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb7/igt@[email protected]
* igt@nouveau_crc@pipe-d-source-outp-inactive:
- shard-iclb: NOTRUN -> [SKIP][188] ([fdo#109278] / [i915#2530]) +2 similar issues
[188]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb7/igt@[email protected]
* igt@perf@polling-parameterized:
- shard-skl: NOTRUN -> [FAIL][189] ([i915#5639])
[189]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl4/igt@[email protected]
* igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name:
- shard-tglb: NOTRUN -> [SKIP][190] ([fdo#109291]) +7 similar issues
[190]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb3/igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name.html
* igt@prime_nv_api@nv_i915_import_twice_check_flink_name:
- shard-iclb: NOTRUN -> [SKIP][191] ([fdo#109291]) +5 similar issues
[191]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb4/igt@prime_nv_api@nv_i915_import_twice_check_flink_name.html
* igt@sysfs_clients@fair-1:
- shard-iclb: NOTRUN -> [SKIP][192] ([i915#2994]) +3 similar issues
[192]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb3/igt@[email protected]
* igt@sysfs_clients@fair-3:
- shard-kbl: NOTRUN -> [SKIP][193] ([fdo#109271] / [i915#2994]) +2 similar issues
[193]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl7/igt@[email protected]
* igt@sysfs_clients@pidname:
- shard-apl: NOTRUN -> [SKIP][194] ([fdo#109271] / [i915#2994]) +2 similar issues
[194]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-apl6/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][195] ([i915#2994]) +3 similar issues
[195]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb1/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][196] ([fdo#109271] / [i915#2994])
[196]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-glk1/igt@[email protected]
- shard-skl: NOTRUN -> [SKIP][197] ([fdo#109271] / [i915#2994])
[197]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl7/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_balancer@parallel-balancer:
- shard-iclb: [SKIP][198] ([i915#4525]) -> [PASS][199]
[198]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-iclb7/igt@[email protected]
[199]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb2/igt@[email protected]
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-kbl: [FAIL][200] ([i915#2842]) -> [PASS][201] +1 similar issue
[200]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-kbl1/igt@gem_exec_fair@[email protected]
[201]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none@vcs0:
- shard-glk: [FAIL][202] ([i915#2842]) -> [PASS][203]
[202]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-glk1/igt@gem_exec_fair@[email protected]
[203]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-glk2/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [FAIL][204] ([i915#2842]) -> [PASS][205]
[204]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-tglb3/igt@gem_exec_fair@[email protected]
[205]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb2/igt@gem_exec_fair@[email protected]
* igt@gem_exec_flush@basic-uc-set-default:
- shard-snb: [SKIP][206] ([fdo#109271]) -> [PASS][207]
[206]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-snb6/igt@[email protected]
[207]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-snb2/igt@[email protected]
* igt@gem_exec_whisper@basic-fds-priority-all:
- shard-apl: [INCOMPLETE][208] -> [PASS][209]
[208]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-apl1/igt@[email protected]
[209]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-apl4/igt@[email protected]
* igt@gen9_exec_parse@allowed-single:
- shard-apl: [DMESG-WARN][210] ([i915#5566] / [i915#716]) -> [PASS][211]
[210]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-apl6/igt@[email protected]
[211]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-apl3/igt@[email protected]
* igt@i915_selftest@live@gem_contexts:
- shard-tglb: [DMESG-WARN][212] ([i915#2867]) -> [PASS][213] +13 similar issues
[212]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-tglb2/igt@i915_selftest@live@gem_contexts.html
[213]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb8/igt@i915_selftest@live@gem_contexts.html
* igt@i915_selftest@live@gt_timelines:
- shard-tglb: [DMESG-WARN][214] -> [PASS][215] +1 similar issue
[214]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-tglb2/igt@i915_selftest@live@gt_timelines.html
[215]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb8/igt@i915_selftest@live@gt_timelines.html
* igt@i915_selftest@live@hangcheck:
- shard-snb: [INCOMPLETE][216] ([i915#3921]) -> [PASS][217]
[216]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-snb2/igt@i915_selftest@[email protected]
[217]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-snb2/igt@i915_selftest@[email protected]
* igt@kms_async_flips@alternate-sync-async-flip:
- shard-skl: [FAIL][218] ([i915#2521]) -> [PASS][219]
[218]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-skl4/igt@[email protected]
[219]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl4/igt@[email protected]
* igt@kms_big_fb@linear-8bpp-rotate-0:
- shard-glk: [FAIL][220] ([i915#1888] / [i915#5138]) -> [PASS][221]
[220]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-glk7/igt@[email protected]
[221]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-glk4/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-256x85-rapid-movement:
- shard-skl: [SKIP][222] ([fdo#109271]) -> [PASS][223] +21 similar issues
[222]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-skl6/igt@[email protected]
[223]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl1/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-iclb: [FAIL][224] ([i915#79]) -> [PASS][225]
[224]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-iclb2/igt@kms_flip@[email protected]
[225]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb5/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-ts-check-interruptible@a-hdmi-a1:
- shard-glk: [FAIL][226] ([i915#2122]) -> [PASS][227]
[226]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-glk7/igt@kms_flip@[email protected]
[227]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-glk3/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling:
- shard-iclb: [SKIP][228] ([i915#3701]) -> [PASS][229] +1 similar issue
[228]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling.html
[229]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb1/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-kbl: [DMESG-WARN][230] ([i915#180]) -> [PASS][231] +2 similar issues
[230]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-kbl7/igt@[email protected]
[231]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl6/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][232] ([fdo#108145] / [i915#265]) -> [PASS][233] +1 similar issue
[232]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-skl4/igt@[email protected]
[233]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl9/igt@[email protected]
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-b-edp-1-planes-upscale-downscale:
- shard-iclb: [SKIP][234] ([i915#5235]) -> [PASS][235] +2 similar issues
[234]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-iclb2/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-b-edp-1-planes-upscale-downscale.html
[235]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb8/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-b-edp-1-planes-upscale-downscale.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [SKIP][236] ([fdo#109441]) -> [PASS][237] +1 similar issue
[236]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-iclb3/igt@kms_psr@psr2_cursor_mmap_cpu.html
[237]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@kms_psr_stress_test@invalidate-primary-flip-overlay:
- shard-tglb: [SKIP][238] ([i915#5519]) -> [PASS][239]
[238]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-tglb6/igt@[email protected]
[239]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb7/igt@[email protected]
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-apl: [DMESG-WARN][240] ([i915#180]) -> [PASS][241] +2 similar issues
[240]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-apl3/igt@[email protected]
[241]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-apl2/igt@[email protected]
#### Warnings ####
* igt@gem_exec_balancer@parallel:
- shard-iclb: [DMESG-WARN][242] ([i915#5614]) -> [SKIP][243] ([i915#4525]) +1 similar issue
[242]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-iclb2/igt@[email protected]
[243]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb5/igt@[email protected]
* igt@gem_exec_balancer@parallel-keep-in-fence:
- shard-iclb: [SKIP][244] ([i915#4525]) -> [DMESG-WARN][245] ([i915#5614])
[244]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-iclb8/igt@[email protected]
[245]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb2/igt@[email protected]
* igt@i915_pm_backlight@fade_with_suspend:
- shard-kbl: [SKIP][246] ([fdo#109271]) -> [SKIP][247] ([fdo#109271] / [i915#92]) +1 similar issue
[246]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-kbl3/igt@i915_pm_backlight@fade_with_suspend.html
[247]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl6/igt@i915_pm_backlight@fade_with_suspend.html
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-skl: [SKIP][248] ([fdo#109271]) -> [FAIL][249] ([i915#3743])
[248]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-skl6/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
[249]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl1/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
* igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_rc_ccs:
- shard-skl: [SKIP][250] ([fdo#109271] / [i915#1888]) -> [SKIP][251] ([fdo#109271])
[250]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-skl9/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_rc_ccs.html
[251]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl9/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_rc_ccs.html
* igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs:
- shard-skl: [SKIP][252] ([fdo#109271]) -> [SKIP][253] ([fdo#109271] / [i915#3886]) +3 similar issues
[252]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-skl6/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs.html
[253]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl4/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_cursor_crc@pipe-a-cursor-512x512-rapid-movement:
- shard-iclb: [SKIP][254] ([fdo#109278] / [fdo#109279] / [i915#1888]) -> [SKIP][255] ([fdo#109278] / [fdo#109279])
[254]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-iclb4/igt@[email protected]
[255]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb3/igt@[email protected]
* igt@kms_cursor_legacy@pipe-d-single-bo:
- shard-kbl: [SKIP][256] ([fdo#109271] / [i915#533]) -> [SKIP][257] ([fdo#109271] / [i915#533] / [i915#92])
[256]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-kbl1/igt@[email protected]
[257]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl6/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-move-continuous-sf:
- shard-iclb: [SKIP][258] ([i915#2920]) -> [SKIP][259] ([i915#658])
[258]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-iclb2/igt@[email protected]
[259]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb8/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-iclb: [SKIP][260] ([fdo#111068] / [i915#658]) -> [SKIP][261] ([i915#2920])
[260]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-iclb1/igt@[email protected]
[261]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb2/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109290]: https://bugs.freedesktop.org/show_bug.cgi?id=109290
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109293]: https://bugs.freedesktop.org/show_bug.cgi?id=109293
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#110725]: https://bugs.freedesktop.org/show_bug.cgi?id=110725
[fdo#110892]: https://bugs.freedesktop.org/show_bug.cgi?id=110892
[fdo#111066]: https://bugs.freedesktop.org/show_bug.cgi?id=111066
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111314]: https://bugs.freedesktop.org/show_bug.cgi?id=111314
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112022]: https://bugs.freedesktop.org/show_bug.cgi?id=112022
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1149]: https://gitlab.freedesktop.org/drm/intel/issues/1149
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1904]: https://gitlab.freedesktop.org/drm/intel/issues/1904
[i915#1911]: https://gitlab.freedesktop.org/drm/intel/issues/1911
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2105]: https://gitlab.freedesktop.org/drm/intel/issues/2105
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433
[i915#2435]: https://gitlab.freedesktop.org/drm/intel/issues/2435
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#2724]: https://gitlab.freedesktop.org/drm/intel/issues/2724
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3319]: https://gitlab.freedesktop.org/drm/intel/issues/3319
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3376]: https://gitlab.freedesktop.org/drm/intel/issues/3376
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3464]: https://gitlab.freedesktop.org/drm/intel/issues/3464
[i915#3467]: https://gitlab.freedesktop.org/drm/intel/issues/3467
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3639]: https://gitlab.freedesktop.org/drm/intel/issues/3639
[i915#3650]: https://gitlab.freedesktop.org/drm/intel/issues/3650
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3701]: https://gitlab.freedesktop.org/drm/intel/issues/3701
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3788]: https://gitlab.freedesktop.org/drm/intel/issues/3788
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
[i915#3828]: https://gitlab.freedesktop.org/drm/intel/issues/3828
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966
[i915#3987]: https://gitlab.freedesktop.org/drm/intel/issues/3987
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4272]: https://gitlab.freedesktop.org/drm/intel/issues/4272
[i915#4278]: https://gitlab.freedesktop.org/drm/intel/issues/4278
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4369]: https://gitlab.freedesktop.org/drm/intel/issues/4369
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4842]: https://gitlab.freedesktop.org/drm/intel/issues/4842
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5076]: https://gitlab.freedesktop.org/drm/intel/issues/5076
[i915#5098]: https://gitlab.freedesktop.org/drm/intel/issues/5098
[i915#5138]: https://gitlab.freedesktop.org/drm/intel/issues/5138
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5287]: https://gitlab.freedesktop.org/drm/intel/issues/5287
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5614]: https://gitlab.freedesktop.org/drm/intel/issues/5614
[i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639
[i915#5680]: https://gitlab.freedesktop.org/drm/intel/issues/5680
[i915#5691]: https://gitlab.freedesktop.org/drm/intel/issues/5691
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#5748]: https://gitlab.freedesktop.org/drm/intel/issues/5748
[i915#5849]: https://gitlab.freedesktop.org/drm/intel/issues/5849
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#768]: https://gitlab.freedesktop.org/drm/intel/issues/768
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
Build changes
-------------
* IGT: IGT_6464 -> IGTPW_7000
* Linux: CI_DRM_11583 -> Patchwork_102665v4
CI-20190529: 20190529
CI_DRM_11583: 828a5e99fd22d846ff49df61bcc5e9e5c21d562a @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_7000: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7000/index.html
IGT_6464: eddc67c5c85b8ee6eb4d13752ca43da5073dc985 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_102665v4: 828a5e99fd22d846ff49df61bcc5e9e5c21d562a @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/index.html
Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Media freq factor and per-gt enhancements/fixes (rev4)
Quoted 6 lines · Patchwork
Possible regressions
* igt@gem_eio@in-flight-suspend:
* shard-skl: PASS -> INCOMPLETE
This failure in unrelated.
Quoted 6 lines
* {igt@i915_pm_disag_freq@media-freq@gt0} (NEW):
* shard-iclb: NOTRUN -> SKIP
* shard-tglb: NOTRUN -> SKIP
These failures are expected, the test will skip on platforms which do not support this feature.
Quoted 4 lines
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-xtiled:
* shard-kbl: PASS -> FAIL
This failure in unrelated.
Quoted 10 lines
New tests
New tests have been introduced between
CI_DRM_11583_fullandPatchwork_102665v4_full:New IGT tests (1)
* igt@i915_pm_disag_freq@media-freq@gt0:
* Statuses : 7 skip(s)
* Exec time: [0.0] s
These skips are the same as above and expected.
Thanks.
--
Ashutosh
Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Media freq factor and per-gt enhancements/fixes (rev4)
Re-reported and few comments below.
-----Original Message-----
From: Dixit, Ashutosh <[email protected]>
Sent: Friday, April 29, 2022 5:45 PM
To: [email protected]; Vudum, Lakshminarayana <[email protected]>
Subject: Re: ✗ Fi.CI.IGT: failure for drm/i915: Media freq factor and per-gt enhancements/fixes (rev4)
Quoted 6 lines · Patchwork
Possible regressions
* igt@gem_eio@in-flight-suspend:
* shard-skl: PASS -> INCOMPLETE
This failure in unrelated.
Quoted 6 lines
* {igt@i915_pm_disag_freq@media-freq@gt0} (NEW):
* shard-iclb: NOTRUN -> SKIP
* shard-tglb: NOTRUN -> SKIP
These failures are expected, the test will skip on platforms which do not support this feature.
Lakshmi: These tests are not in yet in CI bug log.
Quoted 4 lines
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-xtiled:
* shard-kbl: PASS -> FAIL
This failure in unrelated.
Lakshmi: Filed https://gitlab.freedesktop.org/drm/intel/-/issues/5870
igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-xtiled - fail - Failed assertion: rc == 0
Quoted 10 lines
New tests
New tests have been introduced between
CI_DRM_11583_fullandPatchwork_102665v4_full:New IGT tests (1)
* igt@i915_pm_disag_freq@media-freq@gt0:
* Statuses : 7 skip(s)
* Exec time: [0.0] s
These skips are the same as above and expected.
Thanks.
--
Ashutosh
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Media freq factor and per-gt enhancements/fixes (rev4)
In reply to Ashutosh Dixit== Series Details ==
== Series Details ==
Series: drm/i915: Media freq factor and per-gt enhancements/fixes (rev4)
URL : https://patchwork.freedesktop.org/series/102665/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11583_full -> Patchwork_102665v4_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (10 -> 13)
------------------------------
Additional (3): shard-rkl shard-dg1 shard-tglu
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_102665v4_full:
### IGT changes ###
#### Possible regressions ####
* {igt@i915_pm_disag_freq@media-freq@gt0} (NEW):
- shard-iclb: NOTRUN -> [SKIP][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb2/igt@i915_pm_disag_freq@[email protected]
- shard-tglb: NOTRUN -> [SKIP][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb3/igt@i915_pm_disag_freq@[email protected]
New tests
---------
New tests have been introduced between CI_DRM_11583_full and Patchwork_102665v4_full:
### New IGT tests (1) ###
* igt@i915_pm_disag_freq@media-freq@gt0:
- Statuses : 7 skip(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_102665v4_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_busy@close-race:
- shard-snb: [PASS][3] -> [TIMEOUT][4] ([i915#5748])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-snb4/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-snb5/igt@[email protected]
* igt@gem_ccs@ctrl-surf-copy:
- shard-tglb: NOTRUN -> [SKIP][5] ([i915#3555] / [i915#5325])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb3/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][6] ([i915#5327])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb2/igt@[email protected]
* igt@gem_ctx_persistence@legacy-engines-mixed-process:
- shard-snb: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#1099]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-snb2/igt@[email protected]
* igt@gem_eio@in-flight-contexts-immediate:
- shard-tglb: [PASS][8] -> [TIMEOUT][9] ([i915#3063])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-tglb6/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb8/igt@[email protected]
* igt@gem_eio@in-flight-suspend:
- shard-skl: [PASS][10] -> [INCOMPLETE][11] ([i915#5871])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-skl4/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl10/igt@[email protected]
* igt@gem_exec_balancer@parallel-keep-in-fence:
- shard-kbl: NOTRUN -> [DMESG-WARN][12] ([i915#5076] / [i915#5614])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl7/igt@[email protected]
* igt@gem_exec_balancer@parallel-ordering:
- shard-iclb: NOTRUN -> [DMESG-FAIL][13] ([i915#5614])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb1/igt@[email protected]
- shard-tglb: NOTRUN -> [DMESG-FAIL][14] ([i915#5076] / [i915#5614])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb1/igt@[email protected]
- shard-kbl: NOTRUN -> [DMESG-FAIL][15] ([i915#5076] / [i915#5614])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl1/igt@[email protected]
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-skl: NOTRUN -> [SKIP][16] ([fdo#109271]) +218 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl9/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-tglb: [PASS][17] -> [FAIL][18] ([i915#2842])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-tglb6/igt@gem_exec_fair@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb1/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none@vcs1:
- shard-kbl: NOTRUN -> [FAIL][19] ([i915#2842]) +2 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl1/igt@gem_exec_fair@[email protected]
- shard-iclb: NOTRUN -> [FAIL][20] ([i915#2842])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb4/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-glk: [PASS][21] -> [FAIL][22] ([i915#2842]) +3 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-glk4/igt@gem_exec_fair@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-glk9/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-tglb: NOTRUN -> [FAIL][23] ([i915#2842])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb5/igt@gem_exec_fair@[email protected]
* igt@gem_exec_flush@basic-wb-rw-default:
- shard-snb: [PASS][24] -> [SKIP][25] ([fdo#109271]) +3 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-snb4/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-snb6/igt@[email protected]
* igt@gem_exec_params@no-bsd:
- shard-iclb: NOTRUN -> [SKIP][26] ([fdo#109283])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb6/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][27] ([fdo#109283])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb1/igt@[email protected]
* igt@gem_exec_params@secure-non-root:
- shard-tglb: NOTRUN -> [SKIP][28] ([fdo#112283])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb5/igt@[email protected]
* igt@gem_exec_suspend@basic-s3@smem:
- shard-skl: [PASS][29] -> [INCOMPLETE][30] ([i915#4547] / [i915#4939] / [i915#5680])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-skl1/igt@gem_exec_suspend@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl1/igt@gem_exec_suspend@[email protected]
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][31] -> [SKIP][32] ([i915#2190])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-tglb5/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb7/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][33] ([fdo#109271] / [i915#2190])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-apl2/igt@[email protected]
- shard-skl: NOTRUN -> [SKIP][34] ([fdo#109271] / [i915#2190])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl9/igt@[email protected]
* igt@gem_lmem_swapping@heavy-random:
- shard-iclb: NOTRUN -> [SKIP][35] ([i915#4613]) +2 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb6/igt@[email protected]
* igt@gem_lmem_swapping@heavy-verify-random:
- shard-tglb: NOTRUN -> [SKIP][36] ([i915#4613]) +4 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb1/igt@[email protected]
* igt@gem_lmem_swapping@heavy-verify-random-ccs:
- shard-skl: NOTRUN -> [SKIP][37] ([fdo#109271] / [i915#4613]) +4 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl4/igt@[email protected]
* igt@gem_lmem_swapping@parallel-multi:
- shard-glk: NOTRUN -> [SKIP][38] ([fdo#109271] / [i915#4613]) +1 similar issue
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-glk1/igt@[email protected]
* igt@gem_lmem_swapping@parallel-random-engines:
- shard-apl: NOTRUN -> [SKIP][39] ([fdo#109271] / [i915#4613]) +3 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-apl1/igt@[email protected]
* igt@gem_lmem_swapping@smem-oom:
- shard-kbl: NOTRUN -> [SKIP][40] ([fdo#109271] / [i915#4613]) +3 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl7/igt@[email protected]
* igt@gem_pread@exhaustion:
- shard-iclb: NOTRUN -> [WARN][41] ([i915#2658]) +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb3/igt@[email protected]
* igt@gem_pwrite@basic-exhaustion:
- shard-tglb: NOTRUN -> [WARN][42] ([i915#2658])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb1/igt@[email protected]
- shard-kbl: NOTRUN -> [WARN][43] ([i915#2658])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl7/igt@[email protected]
* igt@gem_pxp@create-protected-buffer:
- shard-iclb: NOTRUN -> [SKIP][44] ([i915#4270]) +4 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb3/igt@[email protected]
* igt@gem_pxp@protected-raw-src-copy-not-readible:
- shard-tglb: NOTRUN -> [SKIP][45] ([i915#4270]) +5 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb1/igt@[email protected]
* igt@gem_render_copy@x-tiled-to-vebox-yf-tiled:
- shard-kbl: NOTRUN -> [SKIP][46] ([fdo#109271]) +311 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl7/igt@[email protected]
* igt@gem_render_copy@yf-tiled-mc-ccs-to-vebox-yf-tiled:
- shard-iclb: NOTRUN -> [SKIP][47] ([i915#768]) +6 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb2/igt@[email protected]
* igt@gem_softpin@noreloc-s3:
- shard-kbl: [PASS][48] -> [DMESG-WARN][49] ([i915#180])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-kbl4/igt@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl7/igt@[email protected]
* igt@gem_userptr_blits@coherency-sync:
- shard-tglb: NOTRUN -> [SKIP][50] ([fdo#110542])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb6/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][51] ([fdo#109290])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb8/igt@[email protected]
* igt@gem_userptr_blits@dmabuf-sync:
- shard-skl: NOTRUN -> [SKIP][52] ([fdo#109271] / [i915#3323])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl10/igt@[email protected]
* igt@gem_userptr_blits@input-checking:
- shard-skl: NOTRUN -> [DMESG-WARN][53] ([i915#4991])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl9/igt@[email protected]
* igt@gem_userptr_blits@unsync-overlap:
- shard-tglb: NOTRUN -> [SKIP][54] ([i915#3297]) +1 similar issue
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb5/igt@[email protected]
* igt@gem_userptr_blits@unsync-unmap:
- shard-iclb: NOTRUN -> [SKIP][55] ([i915#3297]) +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb5/igt@[email protected]
* igt@gem_userptr_blits@vma-merge:
- shard-snb: NOTRUN -> [FAIL][56] ([i915#2724])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-snb4/igt@[email protected]
- shard-iclb: NOTRUN -> [FAIL][57] ([i915#3318])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb5/igt@[email protected]
- shard-glk: NOTRUN -> [FAIL][58] ([i915#3318])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-glk9/igt@[email protected]
- shard-apl: NOTRUN -> [FAIL][59] ([i915#3318])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-apl8/igt@[email protected]
- shard-skl: NOTRUN -> [FAIL][60] ([i915#3318])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl1/igt@[email protected]
* igt@gen7_exec_parse@oacontrol-tracking:
- shard-iclb: NOTRUN -> [SKIP][61] ([fdo#109289]) +6 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb4/igt@[email protected]
* igt@gen9_exec_parse@allowed-all:
- shard-iclb: NOTRUN -> [SKIP][62] ([i915#2856]) +1 similar issue
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb2/igt@[email protected]
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [PASS][63] -> [DMESG-WARN][64] ([i915#5566] / [i915#716])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-glk4/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-glk9/igt@[email protected]
- shard-skl: [PASS][65] -> [DMESG-WARN][66] ([i915#5566] / [i915#716])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-skl1/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl9/igt@[email protected]
* igt@gen9_exec_parse@bb-secure:
- shard-tglb: NOTRUN -> [SKIP][67] ([i915#2527] / [i915#2856]) +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb8/igt@[email protected]
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-tglb: NOTRUN -> [SKIP][68] ([i915#1904])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb7/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][69] ([i915#658])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb3/igt@[email protected]
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-kbl: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#1937])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl7/igt@i915_pm_lpsp@[email protected]
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: NOTRUN -> [WARN][71] ([i915#2684])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb6/igt@[email protected]
- shard-tglb: NOTRUN -> [WARN][72] ([i915#2681])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb1/igt@[email protected]
* igt@i915_pm_rpm@gem-execbuf-stress-pc8:
- shard-iclb: NOTRUN -> [SKIP][73] ([fdo#109293] / [fdo#109506])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb6/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][74] ([fdo#109506] / [i915#2411])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb8/igt@[email protected]
* igt@i915_pm_rpm@modeset-lpsp-stress:
- shard-apl: NOTRUN -> [SKIP][75] ([fdo#109271]) +240 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-apl6/igt@[email protected]
* igt@i915_pm_rpm@modeset-non-lpsp:
- shard-iclb: NOTRUN -> [SKIP][76] ([fdo#110892]) +2 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb2/igt@[email protected]
* igt@i915_pm_rpm@modeset-non-lpsp-stress:
- shard-tglb: NOTRUN -> [SKIP][77] ([fdo#111644] / [i915#1397] / [i915#2411]) +2 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb6/igt@[email protected]
* igt@i915_pm_sseu@full-enable:
- shard-skl: [PASS][78] -> [FAIL][79] ([i915#3650])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-skl7/igt@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl9/igt@[email protected]
* igt@kms_addfb_basic@invalid-smem-bo-on-discrete:
- shard-tglb: NOTRUN -> [SKIP][80] ([i915#3826])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb7/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][81] ([i915#3826])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb3/igt@[email protected]
* igt@kms_async_flips@crc:
- shard-skl: NOTRUN -> [FAIL][82] ([i915#4272])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl4/igt@[email protected]
* igt@kms_big_fb@4-tiled-64bpp-rotate-90:
- shard-iclb: NOTRUN -> [SKIP][83] ([i915#5286]) +2 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb4/igt@[email protected]
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
- shard-tglb: NOTRUN -> [SKIP][84] ([i915#5286]) +5 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb7/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html
* igt@kms_big_fb@linear-16bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][85] ([fdo#111614]) +7 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb3/igt@[email protected]
* igt@kms_big_fb@x-tiled-8bpp-rotate-90:
- shard-iclb: NOTRUN -> [SKIP][86] ([fdo#110725] / [fdo#111614]) +4 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb2/igt@[email protected]
* igt@kms_big_fb@yf-tiled-64bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][87] ([fdo#111615]) +6 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb8/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][88] ([fdo#110723]) +1 similar issue
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb6/igt@[email protected]
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-skl: NOTRUN -> [FAIL][89] ([i915#3743]) +1 similar issue
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl4/igt@[email protected]
* igt@kms_big_joiner@2x-modeset:
- shard-iclb: NOTRUN -> [SKIP][90] ([i915#2705])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb1/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][91] ([i915#2705])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb8/igt@[email protected]
* igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][92] ([i915#3689] / [i915#3886]) +4 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb5/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs.html
- shard-iclb: NOTRUN -> [SKIP][93] ([fdo#109278] / [i915#3886]) +6 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb7/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][94] ([fdo#109271] / [i915#3886]) +8 similar issues
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl7/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][95] ([i915#3689]) +9 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb8/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_ccs.html
* igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][96] ([fdo#109271] / [i915#3886]) +9 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-apl1/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
- shard-glk: NOTRUN -> [SKIP][97] ([fdo#109271] / [i915#3886]) +3 similar issues
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-glk5/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][98] ([fdo#109271] / [i915#3886]) +13 similar issues
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl1/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_ccs:
- shard-kbl: NOTRUN -> [DMESG-WARN][99] ([i915#62] / [i915#92])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl6/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_ccs.html
* igt@kms_ccs@pipe-d-missing-ccs-buffer-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][100] ([fdo#111615] / [i915#3689]) +6 similar issues
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb1/igt@kms_ccs@pipe-d-missing-ccs-buffer-yf_tiled_ccs.html
* igt@kms_chamelium@hdmi-crc-nonplanar-formats:
- shard-glk: NOTRUN -> [SKIP][101] ([fdo#109271] / [fdo#111827]) +7 similar issues
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-glk2/igt@[email protected]
* igt@kms_color@pipe-a-deep-color:
- shard-iclb: NOTRUN -> [SKIP][102] ([fdo#109278] / [i915#3555])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb6/igt@[email protected]
* igt@kms_color@pipe-d-deep-color:
- shard-tglb: NOTRUN -> [SKIP][103] ([i915#3555]) +3 similar issues
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb2/igt@[email protected]
* igt@kms_color@pipe-d-degamma:
- shard-iclb: NOTRUN -> [SKIP][104] ([fdo#109278] / [i915#1149]) +1 similar issue
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb3/igt@[email protected]
* igt@kms_color@pipe-d-invalid-ctm-matrix-sizes:
- shard-iclb: NOTRUN -> [SKIP][105] ([fdo#109278]) +51 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb5/igt@[email protected]
* igt@kms_color_chamelium@pipe-b-ctm-red-to-blue:
- shard-iclb: NOTRUN -> [SKIP][106] ([fdo#109284] / [fdo#111827]) +15 similar issues
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb5/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][107] ([fdo#109271] / [fdo#111827]) +15 similar issues
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-apl8/igt@[email protected]
- shard-snb: NOTRUN -> [SKIP][108] ([fdo#109271] / [fdo#111827]) +8 similar issues
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-snb4/igt@[email protected]
* igt@kms_color_chamelium@pipe-c-ctm-limited-range:
- shard-kbl: NOTRUN -> [SKIP][109] ([fdo#109271] / [fdo#111827]) +19 similar issues
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl3/igt@[email protected]
* igt@kms_color_chamelium@pipe-c-ctm-negative:
- shard-skl: NOTRUN -> [SKIP][110] ([fdo#109271] / [fdo#111827]) +15 similar issues
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl4/igt@[email protected]
* igt@kms_color_chamelium@pipe-d-ctm-red-to-blue:
- shard-tglb: NOTRUN -> [SKIP][111] ([fdo#109284] / [fdo#111827]) +15 similar issues
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb8/igt@[email protected]
* igt@kms_content_protection@dp-mst-lic-type-1:
- shard-iclb: NOTRUN -> [SKIP][112] ([i915#3116])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb3/igt@[email protected]
* igt@kms_content_protection@mei_interface:
- shard-iclb: NOTRUN -> [SKIP][113] ([fdo#109300] / [fdo#111066]) +1 similar issue
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb1/igt@kms_content_protection@mei_interface.html
* igt@kms_content_protection@uevent:
- shard-tglb: NOTRUN -> [SKIP][114] ([i915#1063]) +2 similar issues
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb6/igt@[email protected]
- shard-apl: NOTRUN -> [FAIL][115] ([i915#2105])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-apl7/igt@[email protected]
- shard-kbl: NOTRUN -> [FAIL][116] ([i915#2105])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl1/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-256x85-sliding:
- shard-snb: NOTRUN -> [SKIP][117] ([fdo#109271]) +237 similar issues
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-snb4/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-32x10-sliding:
- shard-tglb: NOTRUN -> [SKIP][118] ([i915#3359]) +5 similar issues
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb8/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-512x512-random:
- shard-iclb: NOTRUN -> [SKIP][119] ([fdo#109278] / [fdo#109279]) +5 similar issues
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb4/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-32x32-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][120] ([i915#3319]) +3 similar issues
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb1/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-apl: [PASS][121] -> [DMESG-WARN][122] ([i915#180]) +3 similar issues
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-apl8/igt@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-apl6/igt@[email protected]
* igt@kms_cursor_crc@pipe-d-cursor-512x170-offscreen:
- shard-tglb: NOTRUN -> [SKIP][123] ([fdo#109279] / [i915#3359]) +11 similar issues
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb1/igt@[email protected]
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-iclb: NOTRUN -> [SKIP][124] ([fdo#109274] / [fdo#109278]) +7 similar issues
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb8/igt@[email protected]
* igt@kms_cursor_legacy@short-busy-flip-before-cursor-toggle:
- shard-tglb: NOTRUN -> [SKIP][125] ([i915#4103])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb6/igt@[email protected]
* igt@kms_dither@fb-8bpc-vs-panel-8bpc@edp-1-pipe-a:
- shard-tglb: NOTRUN -> [SKIP][126] ([i915#3788])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb3/igt@kms_dither@[email protected]
* igt@kms_draw_crc@draw-method-xrgb2101010-blt-4tiled:
- shard-tglb: NOTRUN -> [SKIP][127] ([i915#5287]) +3 similar issues
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb2/igt@[email protected]
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-4tiled:
- shard-iclb: NOTRUN -> [SKIP][128] ([i915#5287]) +3 similar issues
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb8/igt@[email protected]
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-xtiled:
- shard-kbl: [PASS][129] -> [FAIL][130] ([i915#5870])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-kbl7/igt@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl6/igt@[email protected]
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: NOTRUN -> [INCOMPLETE][131] ([i915#180])
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-apl2/igt@[email protected]
* igt@kms_flip@2x-absolute-wf_vblank:
- shard-tglb: NOTRUN -> [SKIP][132] ([fdo#109274] / [fdo#111825] / [i915#3966])
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb3/igt@kms_flip@2x-absolute-wf_vblank.html
* igt@kms_flip@2x-flip-vs-dpms-off-vs-modeset-interruptible:
- shard-tglb: NOTRUN -> [SKIP][133] ([fdo#109274] / [fdo#111825]) +16 similar issues
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb2/igt@[email protected]
* igt@kms_flip@2x-plain-flip-ts-check-interruptible:
- shard-iclb: NOTRUN -> [SKIP][134] ([fdo#109274]) +9 similar issues
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb7/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-tglb: [PASS][135] -> [FAIL][136] ([i915#79])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-tglb1/igt@kms_flip@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb2/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend@b-dp1:
- shard-apl: NOTRUN -> [DMESG-WARN][137] ([i915#180])
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-apl1/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling:
- shard-tglb: NOTRUN -> [SKIP][138] ([i915#2587])
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling:
- shard-iclb: [PASS][139] -> [SKIP][140] ([i915#3701]) +1 similar issue
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-iclb5/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs-upscaling:
- shard-iclb: NOTRUN -> [SKIP][141] ([i915#2587])
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb7/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs-upscaling.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-tglb: NOTRUN -> [SKIP][142] ([fdo#109280] / [fdo#111825]) +51 similar issues
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-pwrite:
- shard-iclb: NOTRUN -> [SKIP][143] ([fdo#109280]) +44 similar issues
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-render:
- shard-glk: NOTRUN -> [SKIP][144] ([fdo#109271]) +114 similar issues
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-glk5/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-render.html
* igt@kms_hdr@bpc-switch@bpc-switch-edp-1-pipe-a:
- shard-skl: [PASS][145] -> [FAIL][146] ([i915#1188])
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-skl9/igt@kms_hdr@[email protected]
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl6/igt@kms_hdr@[email protected]
* igt@kms_pipe_b_c_ivb@from-pipe-c-to-b-with-3-lanes:
- shard-tglb: NOTRUN -> [SKIP][147] ([fdo#109289]) +7 similar issues
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb7/igt@[email protected]
* igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-b:
- shard-kbl: [PASS][148] -> [DMESG-FAIL][149] ([i915#62] / [i915#92])
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-kbl4/igt@[email protected]
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl6/igt@[email protected]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence:
- shard-apl: NOTRUN -> [SKIP][150] ([fdo#109271] / [i915#533]) +1 similar issue
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-apl3/igt@[email protected]
* igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence:
- shard-glk: NOTRUN -> [SKIP][151] ([fdo#109271] / [i915#533])
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-glk2/igt@[email protected]
- shard-skl: NOTRUN -> [SKIP][152] ([fdo#109271] / [i915#533])
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl1/igt@[email protected]
* igt@kms_plane@plane-position-hole@pipe-a-planes:
- shard-kbl: [PASS][153] -> [DMESG-WARN][154] ([i915#62] / [i915#92]) +4 similar issues
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-kbl4/igt@kms_plane@[email protected]
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl6/igt@kms_plane@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-alpha-basic:
- shard-apl: NOTRUN -> [FAIL][155] ([fdo#108145] / [i915#265]) +1 similar issue
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-apl2/igt@[email protected]
- shard-kbl: NOTRUN -> [FAIL][156] ([fdo#108145] / [i915#265]) +3 similar issues
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl1/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb:
- shard-apl: NOTRUN -> [FAIL][157] ([i915#265])
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-apl8/igt@[email protected]
- shard-glk: NOTRUN -> [FAIL][158] ([i915#265])
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-glk9/igt@[email protected]
- shard-kbl: NOTRUN -> [FAIL][159] ([i915#265])
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl3/igt@[email protected]
- shard-skl: NOTRUN -> [FAIL][160] ([i915#265])
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl1/igt@[email protected]
* igt@kms_plane_lowres@pipe-a-tiling-yf:
- shard-iclb: NOTRUN -> [SKIP][161] ([i915#3536]) +2 similar issues
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb2/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][162] ([fdo#111615] / [fdo#112054])
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb3/igt@[email protected]
* igt@kms_plane_lowres@pipe-d-tiling-x:
- shard-tglb: NOTRUN -> [SKIP][163] ([i915#3536]) +2 similar issues
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb7/igt@[email protected]
* igt@kms_plane_scaling@downscale-with-pixel-format-factor-0-5@pipe-c-edp-1-downscale-with-pixel-format:
- shard-iclb: [PASS][164] -> [SKIP][165] ([i915#5176]) +2 similar issues
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-iclb5/igt@kms_plane_scaling@downscale-with-pixel-format-factor-0-5@pipe-c-edp-1-downscale-with-pixel-format.html
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb2/igt@kms_plane_scaling@downscale-with-pixel-format-factor-0-5@pipe-c-edp-1-downscale-with-pixel-format.html
* igt@kms_plane_scaling@downscale-with-rotation-factor-0-25@pipe-c-edp-1-downscale-with-rotation:
- shard-tglb: NOTRUN -> [SKIP][166] ([i915#5176]) +3 similar issues
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb7/igt@kms_plane_scaling@downscale-with-rotation-factor-0-25@pipe-c-edp-1-downscale-with-rotation.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-a-edp-1-planes-upscale-downscale:
- shard-tglb: NOTRUN -> [SKIP][167] ([i915#5235]) +7 similar issues
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb7/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-a-edp-1-planes-upscale-downscale.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-sf:
- shard-tglb: NOTRUN -> [SKIP][168] ([i915#2920])
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb3/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][169] ([i915#2920])
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb2/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- shard-skl: NOTRUN -> [SKIP][170] ([fdo#109271] / [i915#658]) +1 similar issue
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl1/igt@[email protected]
* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-iclb: [PASS][171] -> [SKIP][172] ([fdo#109642] / [fdo#111068] / [i915#658])
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-iclb2/igt@[email protected]
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb3/igt@[email protected]
* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-tglb: NOTRUN -> [SKIP][173] ([i915#1911])
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb5/igt@kms_psr2_su@page_flip-xrgb8888.html
- shard-kbl: NOTRUN -> [SKIP][174] ([fdo#109271] / [i915#658]) +2 similar issues
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl4/igt@kms_psr2_su@page_flip-xrgb8888.html
- shard-iclb: NOTRUN -> [SKIP][175] ([fdo#109642] / [fdo#111068] / [i915#658])
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb5/igt@kms_psr2_su@page_flip-xrgb8888.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-tglb: NOTRUN -> [FAIL][176] ([i915#132] / [i915#3467]) +4 similar issues
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb8/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: NOTRUN -> [SKIP][177] ([fdo#109441]) +5 similar issues
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb7/igt@kms_psr@psr2_sprite_mmap_gtt.html
* igt@kms_rotation_crc@primary-4-tiled-reflect-x-0:
- shard-iclb: NOTRUN -> [SKIP][178] ([i915#5289]) +1 similar issue
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb5/igt@[email protected]
* igt@kms_rotation_crc@primary-4-tiled-reflect-x-180:
- shard-tglb: NOTRUN -> [SKIP][179] ([i915#5289]) +1 similar issue
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb6/igt@[email protected]
* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-0:
- shard-tglb: NOTRUN -> [SKIP][180] ([fdo#111615] / [i915#5289])
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb2/igt@[email protected]
* igt@kms_setmode@invalid-clone-single-crtc:
- shard-iclb: NOTRUN -> [SKIP][181] ([i915#3555]) +1 similar issue
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb8/igt@[email protected]
* igt@kms_writeback@writeback-check-output:
- shard-kbl: NOTRUN -> [SKIP][182] ([fdo#109271] / [i915#2437])
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl3/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][183] ([i915#2437])
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb1/igt@[email protected]
* igt@kms_writeback@writeback-invalid-parameters:
- shard-skl: NOTRUN -> [SKIP][184] ([fdo#109271] / [i915#2437])
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl6/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][185] ([fdo#109271] / [i915#2437]) +1 similar issue
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-apl1/igt@[email protected]
* igt@nouveau_crc@pipe-b-source-outp-inactive:
- shard-iclb: NOTRUN -> [SKIP][186] ([i915#2530]) +5 similar issues
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb2/igt@[email protected]
* igt@nouveau_crc@pipe-d-ctx-flip-detection:
- shard-tglb: NOTRUN -> [SKIP][187] ([i915#2530]) +7 similar issues
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb7/igt@[email protected]
* igt@nouveau_crc@pipe-d-source-outp-inactive:
- shard-iclb: NOTRUN -> [SKIP][188] ([fdo#109278] / [i915#2530]) +2 similar issues
[188]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb7/igt@[email protected]
* igt@perf@polling-parameterized:
- shard-skl: NOTRUN -> [FAIL][189] ([i915#5639])
[189]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl4/igt@[email protected]
* igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name:
- shard-tglb: NOTRUN -> [SKIP][190] ([fdo#109291]) +7 similar issues
[190]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb3/igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name.html
* igt@prime_nv_api@nv_i915_import_twice_check_flink_name:
- shard-iclb: NOTRUN -> [SKIP][191] ([fdo#109291]) +5 similar issues
[191]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb4/igt@prime_nv_api@nv_i915_import_twice_check_flink_name.html
* igt@sysfs_clients@fair-1:
- shard-iclb: NOTRUN -> [SKIP][192] ([i915#2994]) +3 similar issues
[192]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb3/igt@[email protected]
* igt@sysfs_clients@fair-3:
- shard-kbl: NOTRUN -> [SKIP][193] ([fdo#109271] / [i915#2994]) +2 similar issues
[193]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl7/igt@[email protected]
* igt@sysfs_clients@pidname:
- shard-apl: NOTRUN -> [SKIP][194] ([fdo#109271] / [i915#2994]) +2 similar issues
[194]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-apl6/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][195] ([i915#2994]) +3 similar issues
[195]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb1/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][196] ([fdo#109271] / [i915#2994])
[196]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-glk1/igt@[email protected]
- shard-skl: NOTRUN -> [SKIP][197] ([fdo#109271] / [i915#2994])
[197]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl7/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_balancer@parallel-balancer:
- shard-iclb: [SKIP][198] ([i915#4525]) -> [PASS][199]
[198]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-iclb7/igt@[email protected]
[199]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb2/igt@[email protected]
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-kbl: [FAIL][200] ([i915#2842]) -> [PASS][201] +1 similar issue
[200]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-kbl1/igt@gem_exec_fair@[email protected]
[201]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none@vcs0:
- shard-glk: [FAIL][202] ([i915#2842]) -> [PASS][203]
[202]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-glk1/igt@gem_exec_fair@[email protected]
[203]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-glk2/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [FAIL][204] ([i915#2842]) -> [PASS][205]
[204]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-tglb3/igt@gem_exec_fair@[email protected]
[205]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb2/igt@gem_exec_fair@[email protected]
* igt@gem_exec_flush@basic-uc-set-default:
- shard-snb: [SKIP][206] ([fdo#109271]) -> [PASS][207]
[206]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-snb6/igt@[email protected]
[207]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-snb2/igt@[email protected]
* igt@gem_exec_whisper@basic-fds-priority-all:
- shard-apl: [INCOMPLETE][208] -> [PASS][209]
[208]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-apl1/igt@[email protected]
[209]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-apl4/igt@[email protected]
* igt@gen9_exec_parse@allowed-single:
- shard-apl: [DMESG-WARN][210] ([i915#5566] / [i915#716]) -> [PASS][211]
[210]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-apl6/igt@[email protected]
[211]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-apl3/igt@[email protected]
* igt@i915_selftest@live@gem_contexts:
- shard-tglb: [DMESG-WARN][212] ([i915#2867]) -> [PASS][213] +13 similar issues
[212]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-tglb2/igt@i915_selftest@live@gem_contexts.html
[213]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb8/igt@i915_selftest@live@gem_contexts.html
* igt@i915_selftest@live@gt_timelines:
- shard-tglb: [DMESG-WARN][214] -> [PASS][215] +1 similar issue
[214]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-tglb2/igt@i915_selftest@live@gt_timelines.html
[215]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb8/igt@i915_selftest@live@gt_timelines.html
* igt@i915_selftest@live@hangcheck:
- shard-snb: [INCOMPLETE][216] ([i915#3921]) -> [PASS][217]
[216]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-snb2/igt@i915_selftest@[email protected]
[217]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-snb2/igt@i915_selftest@[email protected]
* igt@kms_async_flips@alternate-sync-async-flip:
- shard-skl: [FAIL][218] ([i915#2521]) -> [PASS][219]
[218]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-skl4/igt@[email protected]
[219]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl4/igt@[email protected]
* igt@kms_big_fb@linear-8bpp-rotate-0:
- shard-glk: [FAIL][220] ([i915#1888] / [i915#5138]) -> [PASS][221]
[220]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-glk7/igt@[email protected]
[221]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-glk4/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-256x85-rapid-movement:
- shard-skl: [SKIP][222] ([fdo#109271]) -> [PASS][223] +21 similar issues
[222]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-skl6/igt@[email protected]
[223]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl1/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-iclb: [FAIL][224] ([i915#79]) -> [PASS][225]
[224]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-iclb2/igt@kms_flip@[email protected]
[225]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb5/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-ts-check-interruptible@a-hdmi-a1:
- shard-glk: [FAIL][226] ([i915#2122]) -> [PASS][227]
[226]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-glk7/igt@kms_flip@[email protected]
[227]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-glk3/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling:
- shard-iclb: [SKIP][228] ([i915#3701]) -> [PASS][229] +1 similar issue
[228]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling.html
[229]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb1/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-kbl: [DMESG-WARN][230] ([i915#180]) -> [PASS][231] +2 similar issues
[230]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-kbl7/igt@[email protected]
[231]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl6/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][232] ([fdo#108145] / [i915#265]) -> [PASS][233] +1 similar issue
[232]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-skl4/igt@[email protected]
[233]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl9/igt@[email protected]
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-b-edp-1-planes-upscale-downscale:
- shard-iclb: [SKIP][234] ([i915#5235]) -> [PASS][235] +2 similar issues
[234]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-iclb2/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-b-edp-1-planes-upscale-downscale.html
[235]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb8/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-b-edp-1-planes-upscale-downscale.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [SKIP][236] ([fdo#109441]) -> [PASS][237] +1 similar issue
[236]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-iclb3/igt@kms_psr@psr2_cursor_mmap_cpu.html
[237]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@kms_psr_stress_test@invalidate-primary-flip-overlay:
- shard-tglb: [SKIP][238] ([i915#5519]) -> [PASS][239]
[238]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-tglb6/igt@[email protected]
[239]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-tglb7/igt@[email protected]
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-apl: [DMESG-WARN][240] ([i915#180]) -> [PASS][241] +2 similar issues
[240]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-apl3/igt@[email protected]
[241]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-apl2/igt@[email protected]
#### Warnings ####
* igt@gem_exec_balancer@parallel:
- shard-iclb: [DMESG-WARN][242] ([i915#5614]) -> [SKIP][243] ([i915#4525]) +1 similar issue
[242]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-iclb2/igt@[email protected]
[243]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb5/igt@[email protected]
* igt@gem_exec_balancer@parallel-keep-in-fence:
- shard-iclb: [SKIP][244] ([i915#4525]) -> [DMESG-WARN][245] ([i915#5614])
[244]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-iclb8/igt@[email protected]
[245]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb2/igt@[email protected]
* igt@i915_pm_backlight@fade_with_suspend:
- shard-kbl: [SKIP][246] ([fdo#109271]) -> [SKIP][247] ([fdo#109271] / [i915#92]) +1 similar issue
[246]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-kbl3/igt@i915_pm_backlight@fade_with_suspend.html
[247]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl6/igt@i915_pm_backlight@fade_with_suspend.html
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-skl: [SKIP][248] ([fdo#109271]) -> [FAIL][249] ([i915#3743])
[248]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-skl6/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
[249]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl1/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
* igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_rc_ccs:
- shard-skl: [SKIP][250] ([fdo#109271] / [i915#1888]) -> [SKIP][251] ([fdo#109271])
[250]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-skl9/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_rc_ccs.html
[251]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl9/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_rc_ccs.html
* igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs:
- shard-skl: [SKIP][252] ([fdo#109271]) -> [SKIP][253] ([fdo#109271] / [i915#3886]) +3 similar issues
[252]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-skl6/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs.html
[253]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-skl4/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_cursor_crc@pipe-a-cursor-512x512-rapid-movement:
- shard-iclb: [SKIP][254] ([fdo#109278] / [fdo#109279] / [i915#1888]) -> [SKIP][255] ([fdo#109278] / [fdo#109279])
[254]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-iclb4/igt@[email protected]
[255]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb3/igt@[email protected]
* igt@kms_cursor_legacy@pipe-d-single-bo:
- shard-kbl: [SKIP][256] ([fdo#109271] / [i915#533]) -> [SKIP][257] ([fdo#109271] / [i915#533] / [i915#92])
[256]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-kbl1/igt@[email protected]
[257]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-kbl6/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-move-continuous-sf:
- shard-iclb: [SKIP][258] ([i915#2920]) -> [SKIP][259] ([i915#658])
[258]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-iclb2/igt@[email protected]
[259]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb8/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-iclb: [SKIP][260] ([fdo#111068] / [i915#658]) -> [SKIP][261] ([i915#2920])
[260]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11583/shard-iclb1/igt@[email protected]
[261]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/shard-iclb2/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109290]: https://bugs.freedesktop.org/show_bug.cgi?id=109290
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109293]: https://bugs.freedesktop.org/show_bug.cgi?id=109293
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#110725]: https://bugs.freedesktop.org/show_bug.cgi?id=110725
[fdo#110892]: https://bugs.freedesktop.org/show_bug.cgi?id=110892
[fdo#111066]: https://bugs.freedesktop.org/show_bug.cgi?id=111066
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111314]: https://bugs.freedesktop.org/show_bug.cgi?id=111314
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112022]: https://bugs.freedesktop.org/show_bug.cgi?id=112022
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1149]: https://gitlab.freedesktop.org/drm/intel/issues/1149
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1904]: https://gitlab.freedesktop.org/drm/intel/issues/1904
[i915#1911]: https://gitlab.freedesktop.org/drm/intel/issues/1911
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2105]: https://gitlab.freedesktop.org/drm/intel/issues/2105
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433
[i915#2435]: https://gitlab.freedesktop.org/drm/intel/issues/2435
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#2724]: https://gitlab.freedesktop.org/drm/intel/issues/2724
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3319]: https://gitlab.freedesktop.org/drm/intel/issues/3319
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3376]: https://gitlab.freedesktop.org/drm/intel/issues/3376
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3464]: https://gitlab.freedesktop.org/drm/intel/issues/3464
[i915#3467]: https://gitlab.freedesktop.org/drm/intel/issues/3467
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3639]: https://gitlab.freedesktop.org/drm/intel/issues/3639
[i915#3650]: https://gitlab.freedesktop.org/drm/intel/issues/3650
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3701]: https://gitlab.freedesktop.org/drm/intel/issues/3701
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3788]: https://gitlab.freedesktop.org/drm/intel/issues/3788
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
[i915#3828]: https://gitlab.freedesktop.org/drm/intel/issues/3828
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966
[i915#3987]: https://gitlab.freedesktop.org/drm/intel/issues/3987
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4272]: https://gitlab.freedesktop.org/drm/intel/issues/4272
[i915#4278]: https://gitlab.freedesktop.org/drm/intel/issues/4278
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4369]: https://gitlab.freedesktop.org/drm/intel/issues/4369
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4842]: https://gitlab.freedesktop.org/drm/intel/issues/4842
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5076]: https://gitlab.freedesktop.org/drm/intel/issues/5076
[i915#5098]: https://gitlab.freedesktop.org/drm/intel/issues/5098
[i915#5138]: https://gitlab.freedesktop.org/drm/intel/issues/5138
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5287]: https://gitlab.freedesktop.org/drm/intel/issues/5287
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5614]: https://gitlab.freedesktop.org/drm/intel/issues/5614
[i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639
[i915#5680]: https://gitlab.freedesktop.org/drm/intel/issues/5680
[i915#5691]: https://gitlab.freedesktop.org/drm/intel/issues/5691
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#5748]: https://gitlab.freedesktop.org/drm/intel/issues/5748
[i915#5849]: https://gitlab.freedesktop.org/drm/intel/issues/5849
[i915#5870]: https://gitlab.freedesktop.org/drm/intel/issues/5870
[i915#5871]: https://gitlab.freedesktop.org/drm/intel/issues/5871
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#768]: https://gitlab.freedesktop.org/drm/intel/issues/768
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
Build changes
-------------
* IGT: IGT_6464 -> IGTPW_7000
* Linux: CI_DRM_11583 -> Patchwork_102665v4
CI-20190529: 20190529
CI_DRM_11583: 828a5e99fd22d846ff49df61bcc5e9e5c21d562a @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_7000: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7000/index.html
IGT_6464: eddc67c5c85b8ee6eb4d13752ca43da5073dc985 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_102665v4: 828a5e99fd22d846ff49df61bcc5e9e5c21d562a @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v4/index.html