Skip to contentSkip to conversation

linux-dummy: add empty dependent packages

PATCH In review Li Wang 2 participants 4 messages Mar 12, 2021 – Mar 17, 2021 1 message not in the archive

lore
Share & tools
lore

Li Wang

author
#0 lore raw

PATCH 1/1 linux-dummy: add empty dependent packages

some kernel includes kernel-image-image and kernel-devicetree packages. these patckages are defined in kernel.bbclass
but, when use linux-dummy, these packages are not defined. so, define them as empty packages for avoiding compile error:

ERROR: Nothing RPROVIDES 'kernel-devicetree'

---
 meta/classes/linux-dummy.bbclass         | 26 ++++++++++++++++++++++++++
 meta/recipes-kernel/linux/linux-dummy.bb |  2 +-
 2 files changed, 27 insertions(+), 1 deletion(-)
 create mode 100644 meta/classes/linux-dummy.bbclass
meta/classes/linux-dummy.bbclass new file +26 -0
new file mode 100644
index 0000000..cd87915
@@ -0,0 +1,26 @@
+
+python __anonymous () {
+    if d.getVar('PREFERRED_PROVIDER_virtual/kernel') == 'linux-dummy':
+        # copy part codes from kernel.bbclass
+        kname = d.getVar('KERNEL_PACKAGE_NAME') or "kernel"
+
+        # set an empty package of kernel-devicetree
+        d.appendVar('PACKAGES', ' %s-devicetree' % kname)
+        d.setVar('ALLOW_EMPTY_%s-devicetree' % kname, '1')
+
+        # Merge KERNEL_IMAGETYPE and KERNEL_ALT_IMAGETYPE into KERNEL_IMAGETYPES
+        type = d.getVar('KERNEL_IMAGETYPE') or ""
+        alttype = d.getVar('KERNEL_ALT_IMAGETYPE') or ""
+        types = d.getVar('KERNEL_IMAGETYPES') or ""
+        if type not in types.split():
+            types = (type + ' ' + types).strip()
+        if alttype not in types.split():
+            types = (alttype + ' ' + types).strip()
+
+        # set empty packages of kernel-image-*
+        for type in types.split():
+            typelower = type.lower()
+            d.appendVar('PACKAGES', ' %s-image-%s' % (kname, typelower))
+            d.setVar('ALLOW_EMPTY_%s-image-%s' % (kname, typelower), '1')
+}
+
meta/recipes-kernel/linux/linux-dummy.bb +1 -1
index 95dc85f..c56f899 100644
@@ -9,7 +9,7 @@ LIC_FILES_CHKSUM = "file://COPYING.GPL;md5=751419260aa954499f7abaabaa882bbe"
 
 PROVIDES += "virtual/kernel"
 
-inherit deploy
+inherit deploy linux-dummy
 
 PACKAGES_DYNAMIC += "^kernel-module-.*"
 PACKAGES_DYNAMIC += "^kernel-image-.*"
Signature · 1 line
2.7.4
#1 lore raw
Quoted 36 lines · Li Wang

some kernel includes kernel-image-image and kernel-devicetree packages. these patckages are defined in kernel.bbclass
but, when use linux-dummy, these packages are not defined. so, define them as empty packages for avoiding compile error:

ERROR: Nothing RPROVIDES 'kernel-devicetree'

---
 meta/classes/linux-dummy.bbclass | 26 ++++++++++++++++++++++++++
 meta/recipes-kernel/linux/linux-dummy.bb | 2 +-

 2 files changed, 27 insertions(+), 1 deletion(-)

 create mode 100644 meta/classes/linux-dummy.bbclass

meta/classes/linux-dummy.bbclass new file +16 -0
new file mode 100644
index 0000000..cd87915
@@ -0,0 +1,26 @@
+
+python __anonymous () {
+    if d.getVar('PREFERRED_PROVIDER_virtual/kernel') == 'linux-dummy':
+        # copy part codes from kernel.bbclass
+        kname = d.getVar('KERNEL_PACKAGE_NAME') or "kernel"
+
+        # set an empty package of kernel-devicetree
+        d.appendVar('PACKAGES', ' %s-devicetree' % kname)
+        d.setVar('ALLOW_EMPTY_%s-devicetree' % kname, '1')
+
+        # Merge KERNEL_IMAGETYPE and KERNEL_ALT_IMAGETYPE into KERNEL_IMAGETYPES
+        type = d.getVar('KERNEL_IMAGETYPE') or ""
+        alttype = d.getVar('KERNEL_ALT_IMAGETYPE') or ""
+        types = d.getVar('KERNEL_IMAGETYPES') or ""
+        if type not in types.split():
+            types = (type + ' ' + types).strip()

meta/classes/linux-dummy.bbclass line 26

Quoted 10 lines
meta/classes/linux-dummy.bbclass new file +10 -0
+        if alttype not in types.split():
+            types = (alttype + ' ' + types).strip()
+
+        # set empty packages of kernel-image-*
+        for type in types.split():
+            typelower = type.lower()
+            d.appendVar('PACKAGES', ' %s-image-%s' % (kname, typelower))
+            d.setVar('ALLOW_EMPTY_%s-image-%s' % (kname, typelower), '1')
+}
+

Rather than generating broken empty packages, why not just set RPROVIDES_${PN} with the appropriate things?

Cheers,

Richard

author
#2 lore raw
Quoted 41 lines · Richard Purdie
Quoted 40 lines · Li Wang

some kernel includes kernel-image-image and kernel-devicetree packages. these patckages are defined in kernel.bbclass
but, when use linux-dummy, these packages are not defined. so, define them as empty packages for avoiding compile error:

ERROR: Nothing RPROVIDES 'kernel-devicetree'

---
  meta/classes/linux-dummy.bbclass         | 26 ++++++++++++++++++++++++++
  meta/recipes-kernel/linux/linux-dummy.bb |  2 +-
  2 files changed, 27 insertions(+), 1 deletion(-)

 create mode 100644 meta/classes/linux-dummy.bbclass

meta/classes/linux-dummy.bbclass new file +20 -0
new file mode 100644
index 0000000..cd87915
@@ -0,0 +1,26 @@
+
+python __anonymous () {
+    if d.getVar('PREFERRED_PROVIDER_virtual/kernel') == 'linux-dummy':
+        # copy part codes from kernel.bbclass
+        kname = d.getVar('KERNEL_PACKAGE_NAME') or "kernel"
+
+        # set an empty package of kernel-devicetree
+        d.appendVar('PACKAGES', ' %s-devicetree' % kname)
+        d.setVar('ALLOW_EMPTY_%s-devicetree' % kname, '1')
+
+        # Merge KERNEL_IMAGETYPE and KERNEL_ALT_IMAGETYPE into KERNEL_IMAGETYPES
+        type = d.getVar('KERNEL_IMAGETYPE') or ""
+        alttype = d.getVar('KERNEL_ALT_IMAGETYPE') or ""
+        types = d.getVar('KERNEL_IMAGETYPES') or ""
+        if type not in types.split():
+            types = (type + ' ' + types).strip()
+        if alttype not in types.split():
+            types = (alttype + ' ' + types).strip()
+
+        # set empty packages of kernel-image-*
Quoted 8 lines

meta/classes/linux-dummy.bbclass line 26

Quoted 6 lines
meta/classes/linux-dummy.bbclass new file +6 -0
+        for type in types.split():
+            typelower = type.lower()
+            d.appendVar('PACKAGES', ' %s-image-%s' % (kname, typelower))
+            d.setVar('ALLOW_EMPTY_%s-image-%s' % (kname, typelower), '1')
+}
+

Rather than generating broken empty packages, why not just set RPROVIDES_${PN} with the appropriate things?

linux-dummy is just an empty package, what does it PROVIDE the appropriate things?

linux-dummy has the similar codes:

=====

oe-core/meta/recipes-kernel/linux/linux-dummy.bb

PACKAGES += "kernel-modules kernel-vmlinux" FILES_kernel-modules = "" ALLOW_EMPTY_kernel-modules = "1" DESCRIPTION_kernel-modules = "Kernel modules meta package" FILES_kernel-vmlinux = "" ALLOW_EMPTY_kernel-vmlinux = "1" DESCRIPTION_kernel-vmlinux = "Kernel vmlinux meta package"

=====

I can offer a more complete empty package as above sample.(FILES_* DESCRIPTION_*)

please give me some suggest about it.

Thanks,
LiWang.

Quoted 5 lines

Cheers,

Richard

A message that is not in the archive (sent off-list or not yet received): [email protected]

author
#4 lore raw

ping!

Thanks,
LiWang.

Quoted 89 lines · Li Wang
Quoted 45 lines · Richard Purdie
Quoted 44 lines · Li Wang

some kernel includes kernel-image-image and kernel-devicetree packages. these patckages are defined in kernel.bbclass
but, when use linux-dummy, these packages are not defined. so, define them as empty packages for avoiding compile error:

ERROR: Nothing RPROVIDES 'kernel-devicetree'

---
  meta/classes/linux-dummy.bbclass         | 26
++++++++++++++++++++++++++
  meta/recipes-kernel/linux/linux-dummy.bb |  2 +-

  2 files changed, 27 insertions(+), 1 deletion(-)

  create mode 100644 meta/classes/linux-dummy.bbclass

meta/classes/linux-dummy.bbclass new file +11 -0
new file mode 100644
index 0000000..cd87915
@@ -0,0 +1,26 @@
+
+python __anonymous () {
+    if d.getVar('PREFERRED_PROVIDER_virtual/kernel') == 'linux-dummy':
+        # copy part codes from kernel.bbclass
+        kname = d.getVar('KERNEL_PACKAGE_NAME') or "kernel"
+
+        # set an empty package of kernel-devicetree
+        d.appendVar('PACKAGES', ' %s-devicetree' % kname)
+        d.setVar('ALLOW_EMPTY_%s-devicetree' % kname, '1')
+
+        # Merge KERNEL_IMAGETYPE and KERNEL_ALT_IMAGETYPE into 

KERNEL_IMAGETYPES
+        type = d.getVar('KERNEL_IMAGETYPE') or "" +        alttype = d.getVar('KERNEL_ALT_IMAGETYPE') or "" +        types = d.getVar('KERNEL_IMAGETYPES') or "" +        if type not in types.split():
+            types = (type + ' ' + types).strip() +        if alttype not in types.split():
+            types = (alttype + ' ' + types).strip() +
+        # set empty packages of kernel-image-* +        for type in types.split():
+            typelower = type.lower()

Quoted 8 lines

meta/classes/linux-dummy.bbclass line 26

Quoted 6 lines

+            d.appendVar('PACKAGES', ' %s-image-%s' % (kname, typelower))
+            d.setVar('ALLOW_EMPTY_%s-image-%s' % (kname, typelower), '1')

meta/classes/linux-dummy.bbclass new file +2 -0
+}
+

Rather than generating broken empty packages, why not just set RPROVIDES_${PN} with the appropriate things?

linux-dummy is just an empty package, what does it PROVIDE the appropriate things?

linux-dummy has the similar codes:

=====

oe-core/meta/recipes-kernel/linux/linux-dummy.bb

PACKAGES += "kernel-modules kernel-vmlinux" FILES_kernel-modules = "" ALLOW_EMPTY_kernel-modules = "1" DESCRIPTION_kernel-modules = "Kernel modules meta package" FILES_kernel-vmlinux = "" ALLOW_EMPTY_kernel-vmlinux = "1" DESCRIPTION_kernel-vmlinux = "Kernel vmlinux meta package"

=====

I can offer a more complete empty package as above sample.(FILES_* DESCRIPTION_*)

please give me some suggest about it.

Thanks,
LiWang.

Quoted 5 lines

Cheers,

Richard