Skip to contentSkip to conversation

test: fix broken "make test"

PATCH Applied Rami Rosen 4 participants 5 messages Feb 11, 2019 – Feb 12, 2019

lore
Share & tools
lore

Rami Rosen

author
#0 lore raw

PATCH 1/1 test: fix broken "make test"

This patch fixes a broken build; when running
make test
we get the following error:
...
Traceback (most recent call last):
File "/work/src/dpdk-19.02/test/test/autotest.py", line 49, in <module>
num_fails = runner.run_all_tests()
File "/work/src/dpdk-19.02/test/test/autotest_runner.py", line 345, in
run_all_tests
self.parallel_tests)
File "/work/src/dpdk-19.02/test/test/autotest_runner.py", line 264, in
__filter_test
test_cmd = test["Command"]
KeyError: 'Command'
...
The reason is that the pdump autotest entry uses "Comamnd" instead of "Command"; this patch fixes it.

Bugzilla ID: 205

Fixes 086eb64db39e ("test/pdump: add unit test for pdump library")
---
 test/test/autotest_data.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
test/test/autotest_data.py +1 -1
index 948a625b5..5f87bb94d 100644
@@ -508,7 +508,7 @@
     },
     {
         "Name":    "Pdump autotest",
-        "Comamnd": "pdump_autotest",
+        "Command": "pdump_autotest",
         "Func":    default_autotest,
         "Report":  None,
     },
Signature · 1 line
2.19.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 18 lines · Rami Rosen

This patch fixes a broken build; when running
make test
we get the following error:
...
Traceback (most recent call last):
File "/work/src/dpdk-19.02/test/test/autotest.py", line 49, in <module>
num_fails = runner.run_all_tests()
File "/work/src/dpdk-19.02/test/test/autotest_runner.py", line 345, in
run_all_tests
self.parallel_tests)
File "/work/src/dpdk-19.02/test/test/autotest_runner.py", line 264, in
__filter_test
test_cmd = test["Command"]
KeyError: 'Command'
...
The reason is that the pdump autotest entry uses "Comamnd" instead of "Command"; this patch fixes it.

Quoted 3 lines

Bugzilla ID: 205

Fixes 086eb64db39e ("test/pdump: add unit test for pdump library")

Good catch! But it seems 19.02 released autotest broken, so this needs to be backported to 19.02:

Thomas,
What do you think adding autotest into DPDK community lab testing? I will bring the the suggestion in next meeting.

#2 lore raw
Quoted 4 lines · Ferruh Yigit

Good catch! But it seems 19.02 released autotest broken, so this needs to be
backported to 19.02:

Quoted 8 lines

Thomas,
What do you think adding autotest into DPDK community lab testing? I will bring
the the suggestion in next meeting.

+1.

Signature · 1 line
David Marchand
#3 lore raw
In reply to Ferruh Yigit

12/02/2019 10:36, Ferruh Yigit:

Quoted 23 lines · Rami Rosen
Quoted 18 lines

This patch fixes a broken build; when running
make test
we get the following error:
...
Traceback (most recent call last):
File "/work/src/dpdk-19.02/test/test/autotest.py", line 49, in <module>
num_fails = runner.run_all_tests()
File "/work/src/dpdk-19.02/test/test/autotest_runner.py", line 345, in
run_all_tests
self.parallel_tests)
File "/work/src/dpdk-19.02/test/test/autotest_runner.py", line 264, in
__filter_test
test_cmd = test["Command"]
KeyError: 'Command'
...
The reason is that the pdump autotest entry uses "Comamnd" instead of "Command"; this patch fixes it.

Quoted 3 lines

Bugzilla ID: 205

Fixes 086eb64db39e ("test/pdump: add unit test for pdump library")
Quoted 6 lines

Good catch! But it seems 19.02 released autotest broken, so this needs to be backported to 19.02:

Applied, thanks

Quoted 3 lines

Thomas,
What do you think adding autotest into DPDK community lab testing? I will bring the the suggestion in next meeting.

Yes, sure.
It has already been discussed but no task was created:
https://bugs.dpdk.org/buglist.cgi?product=lab
Let's follow-up in next meeting.

#4 lore raw
Quoted 34 lines · Thomas Monjalon

12/02/2019 10:36, Ferruh Yigit:

Quoted 23 lines · Rami Rosen
Quoted 18 lines

This patch fixes a broken build; when running
make test
we get the following error:
...
Traceback (most recent call last):
File "/work/src/dpdk-19.02/test/test/autotest.py", line 49, in <module>
num_fails = runner.run_all_tests()
File "/work/src/dpdk-19.02/test/test/autotest_runner.py", line 345, in
run_all_tests
self.parallel_tests)
File "/work/src/dpdk-19.02/test/test/autotest_runner.py", line 264, in
__filter_test
test_cmd = test["Command"]
KeyError: 'Command'
...
The reason is that the pdump autotest entry uses "Comamnd" instead of "Command"; this patch fixes it.

Quoted 3 lines

Bugzilla ID: 205

Fixes 086eb64db39e ("test/pdump: add unit test for pdump library")
Quoted 6 lines

Good catch! But it seems 19.02 released autotest broken, so this needs to be backported to 19.02:

Applied, thanks

Quoted 8 lines
Quoted 3 lines

Thomas,
What do you think adding autotest into DPDK community lab testing? I will bring the the suggestion in next meeting.

Yes, sure.
It has already been discussed but no task was created:
https://bugs.dpdk.org/buglist.cgi?product=lab
Let's follow-up in next meeting.

It has been discussed again, and following task created for lab:
https://bugs.dpdk.org/show_bug.cgi?id=212