Skip to contentSkip to conversation

ocfs2: send correct UUID to cleancache initialization

PATCH In review Dan Magenheimer 2 participants 2 messages Oct 17, 2011 – Nov 17, 2011 OCFS2

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ocfs2: send correct UUID to cleancache initialization

ocfs2: Fix cleancache initialization call to correctly pass uuid

As reported by Steven Whitehouse in https://lkml.org/lkml/2011/5/27/221
the ocfs2 volume UUID is incorrectly passed to cleancache. As a result, shared-ephemeral tmem pools will not actually be created; instead they will be private (unshared) which misses out on a major benefit of tmem.

fs/ocfs2/super.c +1 -1
@@ -2374,7 +2374,7 @@ static int ocfs2_initialize_super(struct super_block *sb,
 		mlog_errno(status);
 		goto bail;
 	}
-	cleancache_init_shared_fs((char *)&uuid_net_key, sb);
+	cleancache_init_shared_fs((char *)&di->id2.i_super.s_uuid, sb);
 
 bail:
 	return status;
maintainer
#1 lore raw
Quoted 10 lines · Dan Magenheimer

ocfs2: Fix cleancache initialization call to correctly pass uuid

As reported by Steven Whitehouse in https://lkml.org/lkml/2011/5/27/221
the ocfs2 volume UUID is incorrectly passed to cleancache. As a result, shared-ephemeral tmem pools will not actually be created; instead they will be private (unshared) which misses out on a major benefit of tmem.

This patch is now in the 'fixes' branch of ocfs2.git.

Joel

Quoted 13 lines
fs/ocfs2/super.c +1 -1
@@ -2374,7 +2374,7 @@ static int ocfs2_initialize_super(struct super_block *sb,
 		mlog_errno(status);
 		goto bail;
 	}
-	cleancache_init_shared_fs((char *)&uuid_net_key, sb);
+	cleancache_init_shared_fs((char *)&di->id2.i_super.s_uuid, sb);
 
 bail:
 	return status;
Signature · 5 lines
"Well-timed silence hath more eloquence than speech."  
         - Martin Fraquhar Tupper

			http://www.jlbec.org/
			jlbec at evilplan.org