Skip to contentSkip to conversation

locking/qspinlock: Fix inaccessible URL of MCS lock paper

PATCH Superseded Waiman Long 2 participants 3 messages Jan 7, 2020 Locking primitives

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Waiman Long

author reviewer
#0 lore raw

PATCH v2 1/1 locking/qspinlock: Fix inaccessible URL of MCS lock paper

It turns out that the URL of the MCS lock paper listed in the source code is no longer accessible. I did got question about where the paper was. This patch updates the URL to BZ 206115 which contains a copy of the paper from

https://www.cs.rochester.edu/u/scott/papers/1991_TOCS_synch.pdf

---
 kernel/locking/qspinlock.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
kernel/locking/qspinlock.c +2 -3
index 2473f10c6956..ce75b2270b58 100644
@@ -31,10 +31,9 @@
 /*
  * The basic principle of a queue-based spinlock can best be understood
  * by studying a classic queue-based spinlock implementation called the
- * MCS lock. The paper below provides a good description for this kind
- * of lock.
+ * MCS lock. A copy of the original MCS lock papaer is available at
  *
- * http://www.cise.ufl.edu/tr/DOC/REP-1992-71.pdf
+ * https://bugzilla.kernel.org/show_bug.cgi?id=206115
  *
  * This queued spinlock implementation is based on the MCS lock, however to make
  * it fit the 4 bytes we assume spinlock_t to be, and preserve its existing
Signature · 1 line
2.18.1
maintainer
#1 lore raw
Quoted 17 lines · Waiman Long

It turns out that the URL of the MCS lock paper listed in the source code is no longer accessible. I did got question about where the paper was. This patch updates the URL to BZ 206115 which contains a copy of the paper from

https://www.cs.rochester.edu/u/scott/papers/1991_TOCS_synch.pdf

---
 kernel/locking/qspinlock.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
kernel/locking/qspinlock.c +0 -0
index 2473f10c6956..ce75b2270b58 100644

kernel/locking/qspinlock.c line 34

Quoted 6 lines
kernel/locking/qspinlock.c +1 -2
@@ -31,10 +31,9 @@
 /*
  * The basic principle of a queue-based spinlock can best be understood
  * by studying a classic queue-based spinlock implementation called the
- * MCS lock. The paper below provides a good description for this kind
- * of lock.
+ * MCS lock. A copy of the original MCS lock papaer is available at

s/papaer/paper/

I think I reviewed the previous patch as you sent this version, but please could you reword as suggested here [1]?

Cheers,

Will

[1] https://lore.kernel.org/lkml/20200107172343.GA32009@willie-the-truck/T/#m0f9eaf53e509b87d0f6378e35514c9b120d8edc2

author reviewer
#2 lore raw
Quoted 26 lines · Will Deacon
Quoted 17 lines · Waiman Long

It turns out that the URL of the MCS lock paper listed in the source code is no longer accessible. I did got question about where the paper was. This patch updates the URL to BZ 206115 which contains a copy of the paper from

https://www.cs.rochester.edu/u/scott/papers/1991_TOCS_synch.pdf

---
 kernel/locking/qspinlock.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
kernel/locking/qspinlock.c +0 -0
index 2473f10c6956..ce75b2270b58 100644

kernel/locking/qspinlock.c line 34

Quoted 6 lines
kernel/locking/qspinlock.c +1 -2
@@ -31,10 +31,9 @@
 /*
  * The basic principle of a queue-based spinlock can best be understood
  * by studying a classic queue-based spinlock implementation called the
- * MCS lock. The paper below provides a good description for this kind
- * of lock.
+ * MCS lock. A copy of the original MCS lock papaer is available at

s/papaer/paper/

Quoted 9 lines

I think I reviewed the previous patch as you sent this version, but please could you reword as suggested here [1]?

Cheers,

Will

[1] https://lore.kernel.org/lkml/20200107172343.GA32009@willie-the-truck/T/#m0f9eaf53e509b87d0f6378e35514c9b120d8edc2

Sure. I will send out v3 shortly.

Cheers,
Longman