x86/CPU/AMD: Prefix messages with x86/amd
PATCH v3 1/1 x86/CPU/AMD: Prefix messages with x86/amd
To clarify which messages come from arch/x86/kernel/cpu/amd.c add a prefix to all messages instead of just the previous reset reason.
---
v3:
* add tag, put in it's own series
--- arch/x86/kernel/cpu/amd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
arch/x86/kernel/cpu/amd.c +3 -1
@@ -1,4 +1,6 @@// SPDX-License-Identifier: GPL-2.0-only +#define pr_fmt (fmt) "x86/amd: " fmt +#include <linux/export.h> #include <linux/bitops.h> #include <linux/elf.h>
@@ -1396,7 +1398,7 @@ static __init int print_s5_reset_status_mmio(void)continue ;if (s5_reset_reason_txt[i]) { -pr_info ("x86/amd: Previous system reset reason [0x%08x]: %s\n" , +pr_info ("Previous system reset reason [0x%08x]: %s\n" , value, s5_reset_reason_txt[i]); } }
Signature · 1 line
2.43.0
Borislav Petkov
maintainerQuoted 2 lines · Mario Limonciello (AMD)
To clarify which messages come from
arch/x86/kernel/cpu/amd.cadd a prefix to all messages instead of just the previous reset reason.
The usual question: why do we need this?
Signature · 4 lines
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquetteQuoted 6 lines · Borislav Petkov
Quoted 2 lines · Mario Limonciello (AMD)
To clarify which messages come from
arch/x86/kernel/cpu/amd.cadd a prefix to all messages instead of just the previous reset reason.The usual question: why do we need this?
Well originally the reason was that another message was being added in a series. But the review of the series was deciding not to do it that way. But this way any other future messages pick up the prefix already.
It's a trivial patch, but if you want to wait until another message comes around again we can hold off.
Borislav Petkov
maintainerQuoted 6 lines · Mario Limonciello (AMD) (kernel.org)
Well originally the reason was that another message was being added in a series. But the review of the series was deciding not to do it that way. But this way any other future messages pick up the prefix already.
It's a trivial patch, but if you want to wait until another message comes around again we can hold off.
I'm actually wondering whether there's any specific reason to denote that the messages come from this particular compilation unit...?
Signature · 4 lines
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquetteQuoted 11 lines · Borislav Petkov
Quoted 6 lines · Mario Limonciello (AMD) (kernel.org)
Well originally the reason was that another message was being added in a series. But the review of the series was deciding not to do it that way. But this way any other future messages pick up the prefix already.
It's a trivial patch, but if you want to wait until another message comes around again we can hold off.
I'm actually wondering whether there's any specific reason to denote that the messages come from this particular compilation unit...?
My own personal use when looking at very noisy logs is to use "grep -v" and filter out prefixes. Don't know if other people do that.