Skip to contentSkip to conversation

configs: j784s4_evm : Increase Dynamic memory allocation size

PATCH In review Udit Kumar 4 participants 8 messages Jul 15, 2024 – Jul 20, 2024

lore
Share & tools
lore

Udit Kumar

author
#0 lore raw

PATCH 1/1 configs: j784s4_evm : Increase Dynamic memory allocation size

Increase malloc size to 32 MB to align with other J7 family devices.

---
 configs/j784s4_evm_a72_defconfig | 1 +
 configs/j784s4_evm_r5_defconfig  | 1 +
 2 files changed, 2 insertions(+)
configs/j784s4_evm_a72_defconfig +1 -0
index 3cfa006f86..520a53b12f 100644
@@ -1,5 +1,6 @@
 CONFIG_ARM=y
 CONFIG_ARCH_K3=y
+CONFIG_SYS_MALLOC_LEN=0x2000000
 CONFIG_SYS_MALLOC_F_LEN=0x8000
 CONFIG_SPL_GPIO=y
 CONFIG_SPL_LIBCOMMON_SUPPORT=y
configs/j784s4_evm_r5_defconfig +1 -0
index 7ace661526..543b0a50d7 100644
@@ -1,5 +1,6 @@
 CONFIG_ARM=y
 CONFIG_ARCH_K3=y
+CONFIG_SYS_MALLOC_LEN=0x2000000
 CONFIG_SYS_MALLOC_F_LEN=0x10000
 CONFIG_SPL_GPIO=y
 CONFIG_SPL_LIBCOMMON_SUPPORT=y
Signature · 1 line
2.34.1
#1 lore raw

Hello,

Quoted 2 lines · Udit Kumar

Increase malloc size to 32 MB to align with other J7 family devices.

Is this needed for any specific reason? I am asking to understand if other boards using the same SOC should be updated to prevent $random_issue.

Francesco

#2 lore raw

Hi Francesco

Quoted 8 lines · Francesco Dolcini

Hello,

Quoted 2 lines · Udit Kumar

Increase malloc size to 32 MB to align with other J7 family devices.

Is this needed for any specific reason? I am asking to understand if other boards using the same SOC should be updated to prevent $random_issue.

In our downstream version, we are seeing an issue , while using DFU to MMC

Please see

https://gist.github.com/uditkumarti/b8209f61eff3154f6eb288ba63715263#file-gistfile1-txt-L82

Since DFU is not supported yet in mainline u-boot, so I avoided to mention that failure.

Also this change is generic, so i thought of pushing it now instead of waiting for DFU series.

Quoted 2 lines

Francesco

#3 lore raw

Hello,

Quoted 4 lines · Udit
Quoted 3 lines · Francesco Dolcini
Quoted 2 lines · Udit Kumar

Increase malloc size to 32 MB to align with other J7 family devices.

Quoted 8 lines
Quoted 3 lines

Is this needed for any specific reason? I am asking to understand if other boards using the same SOC should be updated to prevent $random_issue.

Since DFU is not supported yet in mainline u-boot, so I avoided to mention that failure.

Also this change is generic, so i thought of pushing it now instead of waiting for DFU series.

Thanks for the update, on our board DFU works fine on our j784s4 based board (UUU or UMS are not working, but this is off topic for this conversation ;-)

Francesco

#4 lore raw
Quoted 13 lines · Francesco Dolcini

Hello,

Quoted 10 lines · Udit
Quoted 6 lines · Francesco Dolcini
Quoted 2 lines · Udit Kumar

Increase malloc size to 32 MB to align with other J7 family devices.

Is this needed for any specific reason? I am asking to understand if other boards using the same SOC should be updated to prevent $random_issue.

Since DFU is not supported yet in mainline u-boot, so I avoided to mention that failure.

Quoted 6 lines
Quoted 2 lines

Also this change is generic, so i thought of pushing it now instead of waiting for DFU series.

Thanks for the update, on our board DFU works fine on our j784s4 based board (UUU or UMS are not working, but this is off topic for this conversation ;-)

I still think your comment is valid - commit message does need to explain something like "make space for future standard features such as DFU etc.."

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
#5 lore raw
In reply to Kumar, Udit
Quoted 20 lines · Udit

Hi Francesco

Quoted 8 lines · Francesco Dolcini

Hello,

Quoted 2 lines · Udit Kumar

Increase malloc size to 32 MB to align with other J7 family devices.

Is this needed for any specific reason? I am asking to understand if other boards using the same SOC should be updated to prevent $random_issue.

In our downstream version, we are seeing an issue , while using DFU to MMC

Please see

https://gist.github.com/uditkumarti/b8209f61eff3154f6eb288ba63715263#file-gistfile1-txt-L82

Quoted 5 lines

Since DFU is not supported yet in mainline u-boot, so I avoided to mention that failure.

Also this change is generic, so i thought of pushing it now instead of waiting for DFU series.

if we are going to repeat this over and over - does it make sense to have this in include? so that *other* board manufacturers do not need to re-discover this?

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
#6 lore raw
Quoted 20 lines · Nishanth Menon
Quoted 19 lines · Udit
Quoted 6 lines · Francesco Dolcini
Quoted 2 lines · Udit Kumar

Increase malloc size to 32 MB to align with other J7 family devices.

Is this needed for any specific reason? I am asking to understand if other boards using the same SOC should be updated to prevent $random_issue.

In our downstream version, we are seeing an issue , while using DFU to MMC

Please see

https://gist.github.com/uditkumarti/b8209f61eff3154f6eb288ba63715263#file-gistfile1-txt-L82

Since DFU is not supported yet in mainline u-boot, so I avoided to mention that failure.

Quoted 6 lines
Quoted 2 lines

Also this change is generic, so i thought of pushing it now instead of waiting for DFU series.

if we are going to repeat this over and over - does it make sense to have this in include? so that *other* board manufacturers do not need to re-discover this?

The reason we (our board) might be fine, is that we have

default 0x2000000 if ARCH_ROCKCHIP || ARCH_OMAP2PLUS || ARCH_MESON || ARCH_K3

from the downstream TI branch (the specific board we have with J784S4 is not in mainline yet).

Francesco

#7 lore raw
In reply to Udit Kumar
Quoted 4 lines · Udit Kumar

Increase malloc size to 32 MB to align with other J7 family devices.

Applied to u-boot/master, thanks!

Signature · 1 line
Tom