Skip to contentSkip to conversation

iio: adc: ad4080: add support for AD4082, AD4085 and AD4088

PATCH Superseded Antoniu Miclaus 5 participants 17 messages Feb 6 – Feb 16

Subsystems (4)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Antoniu Miclaus

author maintainer
#0 lore raw

cover iio: adc: ad4080: add support for AD4082, AD4085 and AD4088

Add support for AD4082, AD4085 and AD4088 SAR ADCs to the existing ad4080 driver:

- AD4082: 20-bit SAR ADC with LVDS CNV clock count max of 8
- AD4085: 16-bit SAR ADC with LVDS CNV clock count max of 8
- AD4088: 14-bit SAR ADC with LVDS CNV clock count max of 8

These devices share the same register map as AD4080 but differ in resolution and LVDS CNV clock count maximum values.

Antoniu Miclaus (6):
dt-bindings: iio: adc: adi,ad4080: add support for AD4082
iio: adc: ad4080: add support for AD4082
dt-bindings: iio: adc: adi,ad4080: add support for AD4085
iio: adc: ad4080: add support for AD4085
dt-bindings: iio: adc: adi,ad4080: add support for AD4088
iio: adc: ad4080: add support for AD4088

 .../bindings/iio/adc/adi,ad4080.yaml          |  3 ++
 drivers/iio/adc/ad4080.c                      | 45 +++++++++++++++++++
 2 files changed, 48 insertions(+)
Signature · 1 line
2.43.0
author maintainer
#1 lore raw

PATCH 1/6 dt-bindings: iio: adc: adi,ad4080: add support for AD4082

Add device tree binding support for the AD4082 20-bit SAR ADC. Add adi,ad4082 to the compatible enum.

A fallback compatible string to adi,ad4080 is not appropriate as the AD4082 has a different LVDS CNV clock count maximum (8 vs 7), requiring different driver configuration.

---
 Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml +1 -0
index ccd6a0ac1539..eeabf99f9a12 100644
@@ -27,6 +27,7 @@ properties:
     enum:
       - adi,ad4080
       - adi,ad4081
+      - adi,ad4082
       - adi,ad4083
       - adi,ad4084
       - adi,ad4086
Signature · 1 line
2.43.0
author maintainer
#2 lore raw

PATCH 2/6 iio: adc: ad4080: add support for AD4082

In reply to Antoniu Miclaus

Add support for AD4082 20-bit SAR ADC. The AD4082 has the same resolution as AD4080 (20-bit) but differs in LVDS CNV clock count maximum (8 vs 7).

Changes:
- Add AD4082_CHIP_ID definition (0x0052)
- Create ad4082_channel with 20-bit resolution and 32-bit storage
- Add ad4082_chip_info with lvds_cnv_clk_cnt_max = 8
- Register AD4082 in device ID and OF match tables

---
 drivers/iio/adc/ad4080.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
drivers/iio/adc/ad4080.c +15 -0
index 7cf3b6ed7940..7cbbe284dea7 100644
@@ -127,6 +127,7 @@
 #define AD4080_SPI_READ						BIT(7)
 #define AD4080_CHIP_ID						0x0050
 #define AD4081_CHIP_ID						0x0051
+#define AD4082_CHIP_ID						0x0052
 #define AD4083_CHIP_ID						0x0053
 #define AD4084_CHIP_ID						0x0054
 #define AD4086_CHIP_ID						0x0056
@@ -442,6 +443,8 @@ static const struct iio_chan_spec ad4080_channel = AD4080_CHANNEL_DEFINE(20, 32)
 
 static const struct iio_chan_spec ad4081_channel = AD4080_CHANNEL_DEFINE(20, 32);
 
+static const struct iio_chan_spec ad4082_channel = AD4080_CHANNEL_DEFINE(20, 32);
+
 static const struct iio_chan_spec ad4083_channel = AD4080_CHANNEL_DEFINE(16, 16);
 
 static const struct iio_chan_spec ad4084_channel = AD4080_CHANNEL_DEFINE(16, 16);
@@ -470,6 +473,16 @@ static const struct ad4080_chip_info ad4081_chip_info = {
 	.lvds_cnv_clk_cnt_max = 2,
 };
 
+static const struct ad4080_chip_info ad4082_chip_info = {
+	.name = "ad4082",
+	.product_id = AD4082_CHIP_ID,
+	.scale_table = ad4080_scale_table,
+	.num_scales = ARRAY_SIZE(ad4080_scale_table),
+	.num_channels = 1,
+	.channels = &ad4082_channel,
+	.lvds_cnv_clk_cnt_max = 8,
+};
+
 static const struct ad4080_chip_info ad4083_chip_info = {
 	.name = "ad4083",
 	.product_id = AD4083_CHIP_ID,
@@ -666,6 +679,7 @@ static int ad4080_probe(struct spi_device *spi)
 static const struct spi_device_id ad4080_id[] = {
 	{ "ad4080", (kernel_ulong_t)&ad4080_chip_info },
 	{ "ad4081", (kernel_ulong_t)&ad4081_chip_info },
+	{ "ad4082", (kernel_ulong_t)&ad4082_chip_info },
 	{ "ad4083", (kernel_ulong_t)&ad4083_chip_info },
 	{ "ad4084", (kernel_ulong_t)&ad4084_chip_info },
 	{ "ad4086", (kernel_ulong_t)&ad4086_chip_info },
@@ -677,6 +691,7 @@ MODULE_DEVICE_TABLE(spi, ad4080_id);
 static const struct of_device_id ad4080_of_match[] = {
 	{ .compatible = "adi,ad4080", &ad4080_chip_info },
 	{ .compatible = "adi,ad4081", &ad4081_chip_info },
+	{ .compatible = "adi,ad4082", &ad4082_chip_info },
 	{ .compatible = "adi,ad4083", &ad4083_chip_info },
 	{ .compatible = "adi,ad4084", &ad4084_chip_info },
 	{ .compatible = "adi,ad4086", &ad4086_chip_info },
Signature · 1 line
2.43.0
Reviewed-by on v1 2/6
#3 lore raw

Re: [PATCH 2/6] iio: adc: ad4080: add support for AD4082

Quoted 9 lines · Antoniu Miclaus

Add support for AD4082 20-bit SAR ADC. The AD4082 has the same resolution as AD4080 (20-bit) but differs in LVDS CNV clock count maximum (8 vs 7).

Changes:
- Add AD4082_CHIP_ID definition (0x0052)
- Create ad4082_channel with 20-bit resolution and 32-bit storage
- Add ad4082_chip_info with lvds_cnv_clk_cnt_max = 8
- Register AD4082 in device ID and OF match tables

TBH, I think this section is too much for the commit message...

Quoted 2 lines

---

...and just as good to be placed here.

Otherwise, LGTM,

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#4 lore raw

Re: [PATCH 2/6] iio: adc: ad4080: add support for AD4082

Quoted 13 lines · Andy Shevchenko
Quoted 9 lines · Antoniu Miclaus

Add support for AD4082 20-bit SAR ADC. The AD4082 has the same resolution as AD4080 (20-bit) but differs in LVDS CNV clock count maximum (8 vs 7).

Changes:
- Add AD4082_CHIP_ID definition (0x0052)
- Create ad4082_channel with 20-bit resolution and 32-bit storage
- Add ad4082_chip_info with lvds_cnv_clk_cnt_max = 8
- Register AD4082 in device ID and OF match tables

TBH, I think this section is too much for the commit message...

Quoted 7 lines
Quoted 2 lines

---

...and just as good to be placed here.

Otherwise, LGTM,

Same comments for the patches 4 & 6. With that being addressed, feel free to add my Rb there as well.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
Reviewed-by on v1 2/6
#5 lore raw

Re: [PATCH 2/6] iio: adc: ad4080: add support for AD4082

In reply to Antoniu Miclaus
Quoted 4 lines · Antoniu Miclaus

Add support for AD4082 20-bit SAR ADC. The AD4082 has the same resolution as AD4080 (20-bit) but differs in LVDS CNV clock count maximum (8 vs 7).

Quoted 8 lines

Changes:
- Add AD4082_CHIP_ID definition (0x0052)
- Create ad4082_channel with 20-bit resolution and 32-bit storage
- Add ad4082_chip_info with lvds_cnv_clk_cnt_max = 8
- Register AD4082 in device ID and OF match tables

---

And same,

Quoted 58 lines

 drivers/iio/adc/ad4080.c | 15 +++++++++++++++

 1 file changed, 15 insertions(+)
drivers/iio/adc/ad4080.c +1 -0
index 7cf3b6ed7940..7cbbe284dea7 100644
@@ -127,6 +127,7 @@
  #define AD4080_SPI_READ						BIT(7)
  #define AD4080_CHIP_ID						0x0050
  #define AD4081_CHIP_ID						0x0051
+#define AD4082_CHIP_ID						0x0052
  #define AD4083_CHIP_ID						0x0053
  #define AD4084_CHIP_ID						0x0054
  #define AD4086_CHIP_ID						0x0056
@@ -442,6 +443,8 @@ static const struct iio_chan_spec ad4080_channel =
 AD4080_CHANNEL_DEFINE(20, 32)


 static const struct iio_chan_spec ad4081_channel = AD4080_CHANNEL_DEFINE(20, 32);

drivers/iio/adc/ad4080.c +2 -0
+static const struct iio_chan_spec ad4082_channel = AD4080_CHANNEL_DEFINE(20, 32);
+

 static const struct iio_chan_spec ad4083_channel = AD4080_CHANNEL_DEFINE(16, 16);
 static const struct iio_chan_spec ad4084_channel = AD4080_CHANNEL_DEFINE(16, 16);

drivers/iio/adc/ad4080.c +0 -0
@@ -470,6 +473,16 @@ static const struct ad4080_chip_info ad4081_chip_info = {
  	.lvds_cnv_clk_cnt_max = 2,
  };

drivers/iio/adc/ad4080.c +10 -0
+static const struct ad4080_chip_info ad4082_chip_info = {
+	.name = "ad4082",
+	.product_id = AD4082_CHIP_ID,
+	.scale_table = ad4080_scale_table,
+	.num_scales = ARRAY_SIZE(ad4080_scale_table),
+	.num_channels = 1,
+	.channels = &ad4082_channel,
+	.lvds_cnv_clk_cnt_max = 8,
+};
+

 static const struct ad4080_chip_info ad4083_chip_info = { .name = "ad4083",
  .product_id = AD4083_CHIP_ID,

drivers/iio/adc/ad4080.c +2 -0
@@ -666,6 +679,7 @@ static int ad4080_probe(struct spi_device *spi)
  static const struct spi_device_id ad4080_id[] = {
  	{ "ad4080", (kernel_ulong_t)&ad4080_chip_info },
  	{ "ad4081", (kernel_ulong_t)&ad4081_chip_info },
+	{ "ad4082", (kernel_ulong_t)&ad4082_chip_info },
  	{ "ad4083", (kernel_ulong_t)&ad4083_chip_info },
  	{ "ad4084", (kernel_ulong_t)&ad4084_chip_info },
  	{ "ad4086", (kernel_ulong_t)&ad4086_chip_info },
@@ -677,6 +691,7 @@ MODULE_DEVICE_TABLE(spi, ad4080_id);
  static const struct of_device_id ad4080_of_match[] = {
  	{ .compatible = "adi,ad4080", &ad4080_chip_info },
  	{ .compatible = "adi,ad4081", &ad4081_chip_info },
+	{ .compatible = "adi,ad4082", &ad4082_chip_info },
  	{ .compatible = "adi,ad4083", &ad4083_chip_info },
  	{ .compatible = "adi,ad4084", &ad4084_chip_info },
  	{ .compatible = "adi,ad4086", &ad4086_chip_info },
author maintainer
#6 lore raw

PATCH 3/6 dt-bindings: iio: adc: adi,ad4080: add support for AD4085

In reply to Antoniu Miclaus

Add device tree binding support for the AD4085 16-bit SAR ADC. Add adi,ad4085 to the compatible enum.

A fallback compatible string to adi,ad4080 is not appropriate as the AD4085 has a different LVDS CNV clock count maximum (8 vs 7), requiring different driver configuration.

---
 Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml +1 -0
index eeabf99f9a12..106267aee195 100644
@@ -30,6 +30,7 @@ properties:
       - adi,ad4082
       - adi,ad4083
       - adi,ad4084
+      - adi,ad4085
       - adi,ad4086
       - adi,ad4087
 
Signature · 1 line
2.43.0
#7 lore raw

Re: [PATCH 3/6] dt-bindings: iio: adc: adi,ad4080: add support for AD4085

Quoted 10 lines · Antoniu Miclaus

Add device tree binding support for the AD4085 16-bit SAR ADC. Add adi,ad4085 to the compatible enum.

A fallback compatible string to adi,ad4080 is not appropriate as the AD4085 has a different LVDS CNV clock count maximum (8 vs 7), requiring different driver configuration.

---
 Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml | 1 +

Squash the patches. You just added one line, but commit msg is 5 lines. Exactly copied from previous commit.

Best regards,
Krzysztof

maintainer
#8 lore raw

Re: [PATCH 3/6] dt-bindings: iio: adc: adi,ad4080: add support for AD4085

Quoted 8 lines · On Sat, 7 Feb 2026 11:52:57 +0100 Krzysztof Kozlowski <[email protected]> wrote:
Quoted 7 lines · Antoniu Miclaus

Add device tree binding support for the AD4085 16-bit SAR ADC. Add adi,ad4085 to the compatible enum.

A fallback compatible string to adi,ad4080 is not appropriate as the AD4085 has a different LVDS CNV clock count maximum (8 vs 7), requiring different driver configuration.

Quoted 6 lines
Quoted 3 lines
---
 Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml | 1 +  

Squash the patches. You just added one line, but commit msg is 5 lines. Exactly copied from previous commit.

Squashing the driver changes as well into a single patch with all 3 new devices added seems sensible alongside squashing the DT.

The changes are all very similar across the 3 patches.

Jonathan

Quoted 5 lines

Best regards,
Krzysztof

author maintainer
#9 lore raw

RE: [PATCH 3/6] dt-bindings: iio: adc: adi,ad4080: add support for AD4085

In reply to Krzysztof Kozlowski
Quoted 24 lines

-----Original Message-----
From: Krzysztof Kozlowski <[email protected]>
Sent: Saturday, February 7, 2026 12:53 PM
To: Miclaus, Antoniu <[email protected]>
Cc: Lars-Peter Clausen <[email protected]>; Hennerich, Michael <[email protected]>; Jonathan Cameron <[email protected]>; David Lechner <[email protected]>; Sa, Nuno <[email protected]>; Andy Shevchenko <[email protected]>; Rob Herring <[email protected]>; Krzysztof Kozlowski <[email protected]>; Conor Dooley <[email protected]>; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH 3/6] dt-bindings: iio: adc: adi,ad4080: add support for AD4085

[External]

Quoted 7 lines · Antoniu Miclaus

Add device tree binding support for the AD4085 16-bit SAR ADC. Add adi,ad4085 to the compatible enum.

A fallback compatible string to adi,ad4080 is not appropriate as the AD4085 has a different LVDS CNV clock count maximum (8 vs 7), requiring different driver configuration.

Quoted 6 lines
Quoted 3 lines
---
 Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml | 1 +

Squash the patches. You just added one line, but commit msg is 5 lines. Exactly copied from previous commit.

Sorry for missing your comments for v2.
I wanted to keep the structure of the patch series similar to what was already accepted and integrated into the main branch:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=83185903b4eca86e0c7145d62e55de768eeb9e7b
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6c3e7265734bbde7347d44fa8e5720bcc5ad5cea
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d34ad6467200380c8f8337ceefee9f3d8cee5492
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f11de95215311816595a1f2ee81cf8239d9b660a
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4028cbcf3415f6e0810326d87c6e0b494814ae12
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=45e81d6ac0e1af349e5da050dc0be48a72fad9dd

Do you mind if I keep the same structure for consistency? (each part in in its own patch, not half of them squashed) I will rephrase the commits based on your feedback and Conor's such that we don't have identical commit bodies.

Thanks,

Quoted 2 lines

Best regards,
Krzysztof

#10 lore raw

Re: [PATCH 3/6] dt-bindings: iio: adc: adi,ad4080: add support for AD4085

Quoted 28 lines · Antoniu
Quoted 28 lines

-----Original Message-----
From: Krzysztof Kozlowski <[email protected]>
Sent: Saturday, February 7, 2026 12:53 PM
To: Miclaus, Antoniu <[email protected]>
Cc: Lars-Peter Clausen <[email protected]>; Hennerich, Michael <[email protected]>; Jonathan Cameron <[email protected]>; David Lechner <[email protected]>; Sa, Nuno <[email protected]>; Andy Shevchenko <[email protected]>; Rob Herring <[email protected]>; Krzysztof Kozlowski <[email protected]>; Conor Dooley <[email protected]>; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH 3/6] dt-bindings: iio: adc: adi,ad4080: add support for AD4085

[External]

Quoted 10 lines · Antoniu Miclaus

Add device tree binding support for the AD4085 16-bit SAR ADC. Add adi,ad4085 to the compatible enum.

A fallback compatible string to adi,ad4080 is not appropriate as the AD4085 has a different LVDS CNV clock count maximum (8 vs 7), requiring different driver configuration.

---
 Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml | 1 +
Quoted 5 lines
Quoted 2 lines

Squash the patches. You just added one line, but commit msg is 5 lines. Exactly copied from previous commit.

Sorry for missing your comments for v2.
I wanted to keep the structure of the patch series similar to what was already accepted and integrated into the main branch:

And I want flying inflatable yellow duck. We do not use arguments that we want, but we use arguments WHY we want something or why community should want something.

Quoted 8 lines

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=83185903b4eca86e0c7145d62e55de768eeb9e7b
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6c3e7265734bbde7347d44fa8e5720bcc5ad5cea
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d34ad6467200380c8f8337ceefee9f3d8cee5492
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f11de95215311816595a1f2ee81cf8239d9b660a
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4028cbcf3415f6e0810326d87c6e0b494814ae12
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=45e81d6ac0e1af349e5da050dc0be48a72fad9dd

No, because it does not make the code easier to handle.

Best regards,
Krzysztof

author maintainer
#11 lore raw

PATCH 4/6 iio: adc: ad4080: add support for AD4085

In reply to Antoniu Miclaus

Add support for AD4085 16-bit SAR ADC. The AD4085 has the same resolution as AD4084 (16-bit) but differs in LVDS CNV clock count maximum (8 vs 2).

Changes:
- Add AD4085_CHIP_ID definition (0x0055)
- Create ad4085_channel with 16-bit resolution and 16-bit storage
- Add ad4085_chip_info with lvds_cnv_clk_cnt_max = 8
- Register AD4085 in device ID and OF match tables

---
 drivers/iio/adc/ad4080.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
drivers/iio/adc/ad4080.c +15 -0
index 7cbbe284dea7..728df626f09e 100644
@@ -130,6 +130,7 @@
 #define AD4082_CHIP_ID						0x0052
 #define AD4083_CHIP_ID						0x0053
 #define AD4084_CHIP_ID						0x0054
+#define AD4085_CHIP_ID						0x0055
 #define AD4086_CHIP_ID						0x0056
 #define AD4087_CHIP_ID						0x0057
 
@@ -449,6 +450,8 @@ static const struct iio_chan_spec ad4083_channel = AD4080_CHANNEL_DEFINE(16, 16)
 
 static const struct iio_chan_spec ad4084_channel = AD4080_CHANNEL_DEFINE(16, 16);
 
+static const struct iio_chan_spec ad4085_channel = AD4080_CHANNEL_DEFINE(16, 16);
+
 static const struct iio_chan_spec ad4086_channel = AD4080_CHANNEL_DEFINE(14, 16);
 
 static const struct iio_chan_spec ad4087_channel = AD4080_CHANNEL_DEFINE(14, 16);
@@ -503,6 +506,16 @@ static const struct ad4080_chip_info ad4084_chip_info = {
 	.lvds_cnv_clk_cnt_max = 2,
 };
 
+static const struct ad4080_chip_info ad4085_chip_info = {
+	.name = "ad4085",
+	.product_id = AD4085_CHIP_ID,
+	.scale_table = ad4080_scale_table,
+	.num_scales = ARRAY_SIZE(ad4080_scale_table),
+	.num_channels = 1,
+	.channels = &ad4085_channel,
+	.lvds_cnv_clk_cnt_max = 8,
+};
+
 static const struct ad4080_chip_info ad4086_chip_info = {
 	.name = "ad4086",
 	.product_id = AD4086_CHIP_ID,
@@ -682,6 +695,7 @@ static const struct spi_device_id ad4080_id[] = {
 	{ "ad4082", (kernel_ulong_t)&ad4082_chip_info },
 	{ "ad4083", (kernel_ulong_t)&ad4083_chip_info },
 	{ "ad4084", (kernel_ulong_t)&ad4084_chip_info },
+	{ "ad4085", (kernel_ulong_t)&ad4085_chip_info },
 	{ "ad4086", (kernel_ulong_t)&ad4086_chip_info },
 	{ "ad4087", (kernel_ulong_t)&ad4087_chip_info },
 	{ }
@@ -694,6 +708,7 @@ static const struct of_device_id ad4080_of_match[] = {
 	{ .compatible = "adi,ad4082", &ad4082_chip_info },
 	{ .compatible = "adi,ad4083", &ad4083_chip_info },
 	{ .compatible = "adi,ad4084", &ad4084_chip_info },
+	{ .compatible = "adi,ad4085", &ad4085_chip_info },
 	{ .compatible = "adi,ad4086", &ad4086_chip_info },
 	{ .compatible = "adi,ad4087", &ad4087_chip_info },
 	{ }
Signature · 1 line
2.43.0
Reviewed-by on v1 4/6
#12 lore raw

Re: [PATCH 4/6] iio: adc: ad4080: add support for AD4085

Quoted 4 lines · Antoniu Miclaus

Add support for AD4085 16-bit SAR ADC. The AD4085 has the same resolution as AD4084 (16-bit) but differs in LVDS CNV clock count maximum (8 vs 2).

Quoted 8 lines

Changes:
- Add AD4085_CHIP_ID definition (0x0055)
- Create ad4085_channel with 16-bit resolution and 16-bit storage
- Add ad4085_chip_info with lvds_cnv_clk_cnt_max = 8
- Register AD4085 in device ID and OF match tables

---

I do agree with Andy that the commit is too verbose. With that handled:

Quoted 58 lines

 drivers/iio/adc/ad4080.c | 15 +++++++++++++++

 1 file changed, 15 insertions(+)
drivers/iio/adc/ad4080.c +1 -0
index 7cbbe284dea7..728df626f09e 100644
@@ -130,6 +130,7 @@
  #define AD4082_CHIP_ID						0x0052
  #define AD4083_CHIP_ID						0x0053
  #define AD4084_CHIP_ID						0x0054
+#define AD4085_CHIP_ID						0x0055
  #define AD4086_CHIP_ID						0x0056
  #define AD4087_CHIP_ID						0x0057

drivers/iio/adc/ad4080.c +0 -0
@@ -449,6 +450,8 @@ static const struct iio_chan_spec ad4083_channel =
 AD4080_CHANNEL_DEFINE(16, 16)


 static const struct iio_chan_spec ad4084_channel = AD4080_CHANNEL_DEFINE(16, 16);

drivers/iio/adc/ad4080.c +2 -0
+static const struct iio_chan_spec ad4085_channel = AD4080_CHANNEL_DEFINE(16, 16);
+

 static const struct iio_chan_spec ad4086_channel = AD4080_CHANNEL_DEFINE(14, 16);
 static const struct iio_chan_spec ad4087_channel = AD4080_CHANNEL_DEFINE(14, 16);

drivers/iio/adc/ad4080.c +0 -0
@@ -503,6 +506,16 @@ static const struct ad4080_chip_info ad4084_chip_info = {
  	.lvds_cnv_clk_cnt_max = 2,
  };

drivers/iio/adc/ad4080.c +10 -0
+static const struct ad4080_chip_info ad4085_chip_info = {
+	.name = "ad4085",
+	.product_id = AD4085_CHIP_ID,
+	.scale_table = ad4080_scale_table,
+	.num_scales = ARRAY_SIZE(ad4080_scale_table),
+	.num_channels = 1,
+	.channels = &ad4085_channel,
+	.lvds_cnv_clk_cnt_max = 8,
+};
+

 static const struct ad4080_chip_info ad4086_chip_info = { .name = "ad4086",
  .product_id = AD4086_CHIP_ID,

drivers/iio/adc/ad4080.c +2 -0
@@ -682,6 +695,7 @@ static const struct spi_device_id ad4080_id[] = {
  	{ "ad4082", (kernel_ulong_t)&ad4082_chip_info },
  	{ "ad4083", (kernel_ulong_t)&ad4083_chip_info },
  	{ "ad4084", (kernel_ulong_t)&ad4084_chip_info },
+	{ "ad4085", (kernel_ulong_t)&ad4085_chip_info },
  	{ "ad4086", (kernel_ulong_t)&ad4086_chip_info },
  	{ "ad4087", (kernel_ulong_t)&ad4087_chip_info },
  	{ }
@@ -694,6 +708,7 @@ static const struct of_device_id ad4080_of_match[] = {
  	{ .compatible = "adi,ad4082", &ad4082_chip_info },
  	{ .compatible = "adi,ad4083", &ad4083_chip_info },
  	{ .compatible = "adi,ad4084", &ad4084_chip_info },
+	{ .compatible = "adi,ad4085", &ad4085_chip_info },
  	{ .compatible = "adi,ad4086", &ad4086_chip_info },
  	{ .compatible = "adi,ad4087", &ad4087_chip_info },
  	{ }
author maintainer
#13 lore raw

PATCH 5/6 dt-bindings: iio: adc: adi,ad4080: add support for AD4088

In reply to Antoniu Miclaus

Add device tree binding support for the AD4088 14-bit SAR ADC. Add adi,ad4088 to the compatible enum.

A fallback compatible string to adi,ad4080 is not appropriate as the AD4088 has a different LVDS CNV clock count maximum (8 vs 7), requiring different driver configuration.

---
 Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml +1 -0
index 106267aee195..79df2696ef24 100644
@@ -33,6 +33,7 @@ properties:
       - adi,ad4085
       - adi,ad4086
       - adi,ad4087
+      - adi,ad4088
 
   reg:
     maxItems: 1
Signature · 1 line
2.43.0
#14 lore raw

Re: [PATCH 5/6] dt-bindings: iio: adc: adi,ad4080: add support for AD4088

Quoted 6 lines · Antoniu Miclaus

Add device tree binding support for the AD4088 14-bit SAR ADC. Add adi,ad4088 to the compatible enum.

A fallback compatible string to adi,ad4080 is not appropriate as the AD4088 has a different LVDS CNV clock count maximum (8 vs 7), requiring different driver configuration.

And here one more exact copy-paste. So third commit, same text, same one liner.

Best regards,
Krzysztof

author maintainer
#15 lore raw

PATCH 6/6 iio: adc: ad4080: add support for AD4088

In reply to Antoniu Miclaus

Add support for AD4088 14-bit SAR ADC. The AD4088 has the same resolution as AD4087 (14-bit) but differs in LVDS CNV clock count maximum (8 vs 1).

Changes:
- Add AD4088_CHIP_ID definition (0x0058)
- Create ad4088_channel with 14-bit resolution and 16-bit storage
- Add ad4088_chip_info with lvds_cnv_clk_cnt_max = 8
- Register AD4088 in device ID and OF match tables

---
 drivers/iio/adc/ad4080.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
drivers/iio/adc/ad4080.c +15 -0
index 728df626f09e..fc261d3d7687 100644
@@ -133,6 +133,7 @@
 #define AD4085_CHIP_ID						0x0055
 #define AD4086_CHIP_ID						0x0056
 #define AD4087_CHIP_ID						0x0057
+#define AD4088_CHIP_ID						0x0058
 
 #define AD4080_LVDS_CNV_CLK_CNT_MAX				7
 
@@ -456,6 +457,8 @@ static const struct iio_chan_spec ad4086_channel = AD4080_CHANNEL_DEFINE(14, 16)
 
 static const struct iio_chan_spec ad4087_channel = AD4080_CHANNEL_DEFINE(14, 16);
 
+static const struct iio_chan_spec ad4088_channel = AD4080_CHANNEL_DEFINE(14, 16);
+
 static const struct ad4080_chip_info ad4080_chip_info = {
 	.name = "ad4080",
 	.product_id = AD4080_CHIP_ID,
@@ -536,6 +539,16 @@ static const struct ad4080_chip_info ad4087_chip_info = {
 	.lvds_cnv_clk_cnt_max = 1,
 };
 
+static const struct ad4080_chip_info ad4088_chip_info = {
+	.name = "ad4088",
+	.product_id = AD4088_CHIP_ID,
+	.scale_table = ad4080_scale_table,
+	.num_scales = ARRAY_SIZE(ad4080_scale_table),
+	.num_channels = 1,
+	.channels = &ad4088_channel,
+	.lvds_cnv_clk_cnt_max = 8,
+};
+
 static int ad4080_setup(struct iio_dev *indio_dev)
 {
 	struct ad4080_state *st = iio_priv(indio_dev);
@@ -698,6 +711,7 @@ static const struct spi_device_id ad4080_id[] = {
 	{ "ad4085", (kernel_ulong_t)&ad4085_chip_info },
 	{ "ad4086", (kernel_ulong_t)&ad4086_chip_info },
 	{ "ad4087", (kernel_ulong_t)&ad4087_chip_info },
+	{ "ad4088", (kernel_ulong_t)&ad4088_chip_info },
 	{ }
 };
 MODULE_DEVICE_TABLE(spi, ad4080_id);
@@ -711,6 +725,7 @@ static const struct of_device_id ad4080_of_match[] = {
 	{ .compatible = "adi,ad4085", &ad4085_chip_info },
 	{ .compatible = "adi,ad4086", &ad4086_chip_info },
 	{ .compatible = "adi,ad4087", &ad4087_chip_info },
+	{ .compatible = "adi,ad4088", &ad4088_chip_info },
 	{ }
 };
 MODULE_DEVICE_TABLE(of, ad4080_of_match);
Signature · 1 line
2.43.0
Reviewed-by on v1 6/6
#16 lore raw

Re: [PATCH 6/6] iio: adc: ad4080: add support for AD4088

Quoted 4 lines · Antoniu Miclaus

Add support for AD4088 14-bit SAR ADC. The AD4088 has the same resolution as AD4087 (14-bit) but differs in LVDS CNV clock count maximum (8 vs 1).

Quoted 8 lines

Changes:
- Add AD4088_CHIP_ID definition (0x0058)
- Create ad4088_channel with 14-bit resolution and 16-bit storage
- Add ad4088_chip_info with lvds_cnv_clk_cnt_max = 8
- Register AD4088 in device ID and OF match tables

---

Same,

Quoted 58 lines

 drivers/iio/adc/ad4080.c | 15 +++++++++++++++

 1 file changed, 15 insertions(+)
drivers/iio/adc/ad4080.c +1 -0
index 728df626f09e..fc261d3d7687 100644
@@ -133,6 +133,7 @@
  #define AD4085_CHIP_ID						0x0055
  #define AD4086_CHIP_ID						0x0056
  #define AD4087_CHIP_ID						0x0057
+#define AD4088_CHIP_ID						0x0058


 #define AD4080_LVDS_CNV_CLK_CNT_MAX 7

drivers/iio/adc/ad4080.c +0 -0
@@ -456,6 +457,8 @@ static const struct iio_chan_spec ad4086_channel =
 AD4080_CHANNEL_DEFINE(14, 16)


 static const struct iio_chan_spec ad4087_channel = AD4080_CHANNEL_DEFINE(14, 16);

drivers/iio/adc/ad4080.c +2 -0
+static const struct iio_chan_spec ad4088_channel = AD4080_CHANNEL_DEFINE(14, 16);
+

 static const struct ad4080_chip_info ad4080_chip_info = { .name = "ad4080",
  .product_id = AD4080_CHIP_ID,

drivers/iio/adc/ad4080.c +0 -0
@@ -536,6 +539,16 @@ static const struct ad4080_chip_info ad4087_chip_info = {
  	.lvds_cnv_clk_cnt_max = 1,
  };

drivers/iio/adc/ad4080.c +10 -0
+static const struct ad4080_chip_info ad4088_chip_info = {
+	.name = "ad4088",
+	.product_id = AD4088_CHIP_ID,
+	.scale_table = ad4080_scale_table,
+	.num_scales = ARRAY_SIZE(ad4080_scale_table),
+	.num_channels = 1,
+	.channels = &ad4088_channel,
+	.lvds_cnv_clk_cnt_max = 8,
+};
+

 static int ad4080_setup(struct iio_dev *indio_dev) {
  struct ad4080_state *st = iio_priv(indio_dev);

drivers/iio/adc/ad4080.c +2 -0
@@ -698,6 +711,7 @@ static const struct spi_device_id ad4080_id[] = {
  	{ "ad4085", (kernel_ulong_t)&ad4085_chip_info },
  	{ "ad4086", (kernel_ulong_t)&ad4086_chip_info },
  	{ "ad4087", (kernel_ulong_t)&ad4087_chip_info },
+	{ "ad4088", (kernel_ulong_t)&ad4088_chip_info },
  	{ }
  };
  MODULE_DEVICE_TABLE(spi, ad4080_id);
@@ -711,6 +725,7 @@ static const struct of_device_id ad4080_of_match[] = {
  	{ .compatible = "adi,ad4085", &ad4085_chip_info },
  	{ .compatible = "adi,ad4086", &ad4086_chip_info },
  	{ .compatible = "adi,ad4087", &ad4087_chip_info },
+	{ .compatible = "adi,ad4088", &ad4088_chip_info },
  	{ }
  };
  MODULE_DEVICE_TABLE(of, ad4080_of_match);