Skip to contentSkip to conversation

efi: change usage syntax

PATCH New Maxim Uvarov 2 participants 2 messages Aug 28, 2020 – Sep 15, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 efi: change usage syntax

syntax was changed from "," to ":". Account this also in the documentation.

Fixes 2b3fbcb59f efi_loader: use ':' as separator for setenv -i
---
 cmd/nvedit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
cmd/nvedit.c +1 -1
index d188c6aa6b..d03accead9 100644
@@ -1472,7 +1472,7 @@ static char env_help_text[] =
 	"env select [target] - select environment target\n"
 #endif
 #if defined(CONFIG_CMD_NVEDIT_EFI)
-	"env set -e [-nv][-bs][-rt][-at][-a][-i addr,size][-v] name [arg ...]\n"
+	"env set -e [-nv][-bs][-rt][-at][-a][-i addr:size][-v] name [arg ...]\n"
 	"    - set UEFI variable; unset if '-i' or 'arg' not specified\n"
 #endif
 	"env set [-f] name [arg ...]\n";
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 efi: change usage syntax

Quoted 2 lines · Maxim Uvarov

syntax was changed from "," to ":". Account this also in the documentation.

Thank you for the patch.

For future contributions, please, use scripts/get_maintainer.pl to determine who should be on copy.

Quoted 1 line
Fixes 2b3fbcb59f efi_loader: use ':' as separator for setenv -i

Nits: We would normally write this as

Fixes 2b3fbcb59f41 ("efi_loader: use ':' as separator for setenv -i")
Quoted 2 lines

I will also correct the following line when merging:

cmd/nvedit.c +1 -1
index 63b0c5f802..7fce723800 100644
@@ -1541,7 +1541,7 @@ U_BOOT_CMD_COMPLETE(
        "set environment variables",
 #if defined(CONFIG_CMD_NVEDIT_EFI)
        "-e [-guid guid][-nv][-bs][-rt][-at][-a][-v]\n"
-       "        [-i addr,size name], or [name [value ...]]\n"
+       "        [-i addr:size name], or [name [value ...]]\n"
        "    - set UEFI variable 'name' to 'value' ...'\n"
        "      \"-guid\": GUID xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx\n"
        "      \"-nv\": set non-volatile attribute\n"
Quoted 18 lines
---
 cmd/nvedit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
cmd/nvedit.c +1 -1
index d188c6aa6b..d03accead9 100644
@@ -1472,7 +1472,7 @@ static char env_help_text[] =
 	"env select [target] - select environment target\n"
 #endif
 #if defined(CONFIG_CMD_NVEDIT_EFI)
-	"env set -e [-nv][-bs][-rt][-at][-a][-i addr,size][-v] name [arg ...]\n"
+	"env set -e [-nv][-bs][-rt][-at][-a][-i addr:size][-v] name [arg ...]\n"
 	"    - set UEFI variable; unset if '-i' or 'arg' not specified\n"
 #endif
 	"env set [-f] name [arg ...]\n";