Skip to contentSkip to conversation

image: usage of value ~0UL for intrd_high

PATCH New Heinrich Schuchardt 4 participants 14 messages Jan 9, 2021 – Jan 15, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 image: usage of value ~0UL for intrd_high

The comment for initrd_high in the coding and in README were contradicting and neither fully described what the coding does.

Clarify the usage of the special value ~0UL for the environment variable initrd_high.

---
 README         | 3 ++-
 common/image.c | 6 ++++--
 2 files changed, 6 insertions(+), 3 deletions(-)
README +2 -1
index 7b73a1c973..fe58f1ab98 100644
@@ -3310,7 +3310,8 @@ List of environment variables (most likely not complete):
 
 		  setenv initrd_high 00c00000
 
-		  If you set initrd_high to 0xFFFFFFFF, this is an
+		  If you set initrd_high to 0xFFFFFFFF on a 32-bit systems
+		  or 0xFFFFFFFFFFFFFFFF on a 64-bit systems, this is an
 		  indication to U-Boot that all addresses are legal
 		  for the Linux kernel, including addresses in flash
 		  memory. In this case U-Boot will NOT COPY the
common/image.c +4 -2
index 451fc689a8..007e4e987a 100644
@@ -1362,8 +1362,10 @@ int boot_ramdisk_high(struct lmb *lmb, ulong rd_data, ulong rd_len,
 
 	s = env_get("initrd_high");
 	if (s) {
-		/* a value of "no" or a similar string will act like 0,
-		 * turning the "load high" feature off. This is intentional.
+		/*
+		 * A value of 0xffffffffffffffff on 64-bit or 0xffffffff
+		 * on 32-bit systems will disable the copying of the initial
+		 * RAM disk to high memory.
 		 */
 		initrd_high = simple_strtoul(s, NULL, 16);
 		if (initrd_high == ~0)

--
2.29.2

#1 lore raw

PATCH 1/1 image: usage of value ~0UL for intrd_high

Quoted 6 lines · Heinrich Schuchardt

The comment for initrd_high in the coding and in README were contradicting and neither fully described what the coding does.

Clarify the usage of the special value ~0UL for the environment variable initrd_high.

All those F:s are hard to read in the comments and documentation and typo prone. I would prefer to rephrase like "all 1:s value in 32- or 64-bit format" or alike.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw

PATCH 1/1 image: usage of value ~0UL for intrd_high

Quoted 11 lines · Andy Shevchenko
Quoted 6 lines · Heinrich Schuchardt

The comment for initrd_high in the coding and in README were contradicting and neither fully described what the coding does.

Clarify the usage of the special value ~0UL for the environment variable initrd_high.

All those F:s are hard to read in the comments and documentation and typo prone. I would prefer to rephrase like "all 1:s value in 32- or 64-bit format" or alike.

If we're going to improve this we should also note it's discouraged unless you know for certain there will be no overlap and it's strongly discouraged in default environments.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210109/bbdd029b/attachment.sig>
#3 lore raw

PATCH 1/1 image: usage of value ~0UL for intrd_high

Quoted 9 lines · Tom Rini
Quoted 8 lines · Andy Shevchenko
Quoted 6 lines · Heinrich Schuchardt

The comment for initrd_high in the coding and in README were contradicting and neither fully described what the coding does.

Clarify the usage of the special value ~0UL for the environment variable initrd_high.

Quoted 7 lines
Quoted 3 lines

All those F:s are hard to read in the comments and documentation and typo prone. I would prefer to rephrase like "all 1:s value in 32- or 64-bit format" or alike.

If we're going to improve this we should also note it's discouraged unless you know for certain there will be no overlap and it's strongly discouraged in default environments.

What exactly is discouraged?

* setting initrd_high to a value != ~0? Here I would agree.
* setting intird_high to ~0? Why should we copy initrd to a different place? Is it for some outdated Linux release?

Best regards

Heinrich

#4 lore raw

PATCH 1/1 image: usage of value ~0UL for intrd_high

Quoted 18 lines · Heinrich Schuchardt
Quoted 9 lines · Tom Rini
Quoted 8 lines · Andy Shevchenko
Quoted 6 lines · Heinrich Schuchardt

The comment for initrd_high in the coding and in README were contradicting and neither fully described what the coding does.

Clarify the usage of the special value ~0UL for the environment variable initrd_high.

Quoted 7 lines
Quoted 3 lines

All those F:s are hard to read in the comments and documentation and typo prone. I would prefer to rephrase like "all 1:s value in 32- or 64-bit format" or alike.

If we're going to improve this we should also note it's discouraged unless you know for certain there will be no overlap and it's strongly discouraged in default environments.

Quoted 5 lines

What exactly is discouraged?

* setting initrd_high to a value != ~0? Here I would agree.
* setting intird_high to ~0? Why should we copy initrd to a different place? Is it for some outdated Linux release?

We should always default to allowing the initrd to be relocated because we can see (in many cases) overlap that will lead to failure to boot but this forces us to ignore that. Having good default load values means we don't have a problem here.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210109/4e501f74/attachment.sig>
#5 lore raw

PATCH 1/1 image: usage of value ~0UL for intrd_high

Am 9. Januar 2021 20:40:04 MEZ schrieb Tom Rini <[email protected]>:

Quoted 31 lines · Heinrich Schuchardt
Quoted 3 lines · Tom Rini
Quoted 2 lines · Andy Shevchenko
Quoted 1 line

On Sat, Jan 9, 2021 at 8:06 PM Heinrich Schuchardt

Quoted 2 lines · <[email protected]> wrote:
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

The comment for initrd_high in the coding and in README were

contradicting

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

and neither fully described what the coding does.

Clarify the usage of the special value ~0UL for the environment

variable

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 1 line

initrd_high.

All those F:s are hard to read in the comments and documentation

and

Quoted 1 line
Quoted 1 line
Quoted 1 line

typo prone. I would prefer to rephrase like "all 1:s value in 32-

or

Quoted 4 lines
Quoted 4 lines
Quoted 1 line

64-bit format" or alike.

If we're going to improve this we should also note it's discouraged unless you know for certain there will be no overlap and it's

strongly

Quoted 7 lines
Quoted 1 line

discouraged in default environments.

What exactly is discouraged?

* setting initrd_high to a value != ~0? Here I would agree.
* setting intird_high to ~0? Why should we copy initrd to a different place? Is it for some outdated Linux release?

Quoted 6 lines

We should always default to allowing the initrd to be relocated because we can see (in many cases) overlap that will lead to failure to boot but
this forces us to ignore that. Having good default load values means we
don't have a problem here.

We have an initrd that is already in memory. What could it overlap with that is not already overwritten?

Can you provide the text you want to see here?

#6 lore raw

PATCH 1/1 image: usage of value ~0UL for intrd_high

Quoted 39 lines · Heinrich Schuchardt

Am 9. Januar 2021 20:40:04 MEZ schrieb Tom Rini <[email protected]>:

Quoted 31 lines · Heinrich Schuchardt
Quoted 3 lines · Tom Rini
Quoted 2 lines · Andy Shevchenko
Quoted 1 line

On Sat, Jan 9, 2021 at 8:06 PM Heinrich Schuchardt

Quoted 2 lines · <[email protected]> wrote:
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

The comment for initrd_high in the coding and in README were

contradicting

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

and neither fully described what the coding does.

Clarify the usage of the special value ~0UL for the environment

variable

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 1 line

initrd_high.

All those F:s are hard to read in the comments and documentation

and

Quoted 1 line
Quoted 1 line
Quoted 1 line

typo prone. I would prefer to rephrase like "all 1:s value in 32-

or

Quoted 4 lines
Quoted 4 lines
Quoted 1 line

64-bit format" or alike.

If we're going to improve this we should also note it's discouraged unless you know for certain there will be no overlap and it's

strongly

Quoted 7 lines
Quoted 1 line

discouraged in default environments.

What exactly is discouraged?

* setting initrd_high to a value != ~0? Here I would agree.
* setting intird_high to ~0? Why should we copy initrd to a different place? Is it for some outdated Linux release?

Quoted 6 lines

We should always default to allowing the initrd to be relocated because we can see (in many cases) overlap that will lead to failure to boot but
this forces us to ignore that. Having good default load values means we
don't have a problem here.

Quoted 2 lines

We have an initrd that is already in memory. What could it overlap with that is not already overwritten?

Having the kernel and initrd too close in memory has the kernel BSS overwrite the initrd. This has happened time and time again before I went around making some platforms have reasonable (ie kernel early, ramdisk in lowmem but beyond where a kernel+bss can be, etc) defaults and pushing others to do the same.

Quoted 1 line

Can you provide the text you want to see here?

Off-hand, it should look more like the big comment block in include/configs/ti_armv7_common.h and reference the Linux booting on arm/arm64 documents while noting that other architectures have the same fundamental issues and their exact limits may or may not be as well documented.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210109/2a7c6b31/attachment.sig>
#7 lore raw

PATCH 1/1 image: usage of value ~0UL for intrd_high

Am 9. Januar 2021 22:23:01 MEZ schrieb Tom Rini <[email protected]>:

Quoted 14 lines · Heinrich Schuchardt
Quoted 12 lines

Am 9. Januar 2021 20:40:04 MEZ schrieb Tom Rini <[email protected]>:

Quoted 11 lines · Heinrich Schuchardt
Quoted 3 lines · Tom Rini
Quoted 2 lines · Andy Shevchenko
Quoted 1 line

On Sat, Jan 9, 2021 at 8:06 PM Heinrich Schuchardt

Quoted 2 lines · <[email protected]> wrote:
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

The comment for initrd_high in the coding and in README were

contradicting

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

and neither fully described what the coding does.

Clarify the usage of the special value ~0UL for the

environment

Quoted 10 lines
Quoted 4 lines
Quoted 4 lines

variable

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 1 line

initrd_high.

All those F:s are hard to read in the comments and

documentation

Quoted 2 lines
Quoted 2 lines

and

Quoted 1 line
Quoted 1 line
Quoted 1 line

typo prone. I would prefer to rephrase like "all 1:s value in

32-

Quoted 2 lines
Quoted 2 lines

or

Quoted 1 line
Quoted 1 line
Quoted 1 line

64-bit format" or alike.

Who would understand that?

All 1s that is 111111111?

We need something a non-developer will grasp. Copying the exact value from the readme is the easiest thing to do and the least typo prone.

Best regards

Heinrich

Quoted 38 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

If we're going to improve this we should also note it's

discouraged

Quoted 11 lines
Quoted 11 lines
Quoted 1 line
Quoted 1 line

unless you know for certain there will be no overlap and it's

strongly

Quoted 7 lines
Quoted 1 line

discouraged in default environments.

What exactly is discouraged?

* setting initrd_high to a value != ~0? Here I would agree.
* setting intird_high to ~0? Why should we copy initrd to a different place? Is it for some outdated Linux release?

We should always default to allowing the initrd to be relocated

because

Quoted 3 lines
Quoted 3 lines

we can see (in many cases) overlap that will lead to failure to boot but
this forces us to ignore that. Having good default load values

means

Quoted 5 lines
Quoted 2 lines

we
don't have a problem here.

We have an initrd that is already in memory. What could it overlap with that is not already overwritten?

Having the kernel and initrd too close in memory has the kernel BSS overwrite the initrd. This has happened time and time again before I went around making some platforms have reasonable (ie kernel early, ramdisk in lowmem but beyond where a kernel+bss can be, etc) defaults and pushing others to do the same.

Quoted 1 line

Can you provide the text you want to see here?

Off-hand, it should look more like the big comment block in include/configs/ti_armv7_common.h and reference the Linux booting on arm/arm64 documents while noting that other architectures have the same fundamental issues and their exact limits may or may not be as well documented.

#8 lore raw

PATCH 1/1 image: usage of value ~0UL for intrd_high

Quoted 25 lines · Heinrich Schuchardt

Am 9. Januar 2021 22:23:01 MEZ schrieb Tom Rini <[email protected]>:

Quoted 23 lines · Heinrich Schuchardt
Quoted 12 lines

Am 9. Januar 2021 20:40:04 MEZ schrieb Tom Rini <[email protected]>:

Quoted 11 lines · Heinrich Schuchardt
Quoted 3 lines · Tom Rini
Quoted 2 lines · Andy Shevchenko
Quoted 1 line

On Sat, Jan 9, 2021 at 8:06 PM Heinrich Schuchardt

Quoted 2 lines · <[email protected]> wrote:
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

The comment for initrd_high in the coding and in README were

contradicting

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

and neither fully described what the coding does.

Clarify the usage of the special value ~0UL for the

environment

Quoted 4 lines
Quoted 4 lines

variable

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 1 line

initrd_high.

All those F:s are hard to read in the comments and

documentation

Quoted 2 lines
Quoted 2 lines

and

Quoted 1 line
Quoted 1 line
Quoted 1 line

typo prone. I would prefer to rephrase like "all 1:s value in

32-

Quoted 1 line
Quoted 1 line

or

Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

64-bit format" or alike.

Who would understand that?

All 1s that is 111111111?

We need something a non-developer will grasp. Copying the exact value from the readme is the easiest thing to do and the least typo prone.

What about -1?

adam

Quoted 44 lines

Best regards

Heinrich

Quoted 38 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

If we're going to improve this we should also note it's

discouraged

Quoted 11 lines
Quoted 11 lines
Quoted 1 line
Quoted 1 line

unless you know for certain there will be no overlap and it's

strongly

Quoted 7 lines
Quoted 1 line

discouraged in default environments.

What exactly is discouraged?

* setting initrd_high to a value != ~0? Here I would agree.
* setting intird_high to ~0? Why should we copy initrd to a different place? Is it for some outdated Linux release?

We should always default to allowing the initrd to be relocated

because

Quoted 3 lines
Quoted 3 lines

we can see (in many cases) overlap that will lead to failure to boot but
this forces us to ignore that. Having good default load values

means

Quoted 5 lines
Quoted 2 lines

we
don't have a problem here.

We have an initrd that is already in memory. What could it overlap with that is not already overwritten?

Having the kernel and initrd too close in memory has the kernel BSS overwrite the initrd. This has happened time and time again before I went around making some platforms have reasonable (ie kernel early, ramdisk in lowmem but beyond where a kernel+bss can be, etc) defaults and pushing others to do the same.

Quoted 1 line

Can you provide the text you want to see here?

Off-hand, it should look more like the big comment block in include/configs/ti_armv7_common.h and reference the Linux booting on arm/arm64 documents while noting that other architectures have the same fundamental issues and their exact limits may or may not be as well documented.

#9 lore raw

PATCH 1/1 image: usage of value ~0UL for intrd_high

In reply to Heinrich Schuchardt
Quoted 22 lines · Heinrich Schuchardt

Am 9. Januar 2021 22:23:01 MEZ schrieb Tom Rini <[email protected]>:

Quoted 21 lines · Heinrich Schuchardt
Quoted 12 lines

Am 9. Januar 2021 20:40:04 MEZ schrieb Tom Rini <[email protected]>:

Quoted 11 lines · Heinrich Schuchardt
Quoted 3 lines · Tom Rini
Quoted 2 lines · Andy Shevchenko
Quoted 1 line

On Sat, Jan 9, 2021 at 8:06 PM Heinrich Schuchardt

Quoted 2 lines · <[email protected]> wrote:
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

The comment for initrd_high in the coding and in README were

contradicting

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

and neither fully described what the coding does.

Clarify the usage of the special value ~0UL for the

environment

Quoted 4 lines
Quoted 4 lines

variable

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 1 line

initrd_high.

All those F:s are hard to read in the comments and

documentation

Quoted 2 lines
Quoted 2 lines

and

Quoted 1 line
Quoted 1 line
Quoted 1 line

typo prone. I would prefer to rephrase like "all 1:s value in

Quoted 8 lines
Quoted 3 lines

32-

Quoted 2 lines
Quoted 2 lines

or

Quoted 1 line
Quoted 1 line
Quoted 1 line

64-bit format" or alike.

Who would understand that?

All 1s that is 111111111?

Oh, com'n. Most of the users understand that. But we could go further and be more verbose: "All bit set to 1".

Quoted 45 lines

We need something a non-developer will grasp. Copying the exact value from the readme is the easiest thing to do and the least typo prone.

Best regards

Heinrich

Quoted 38 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

If we're going to improve this we should also note it's

discouraged

Quoted 11 lines
Quoted 11 lines
Quoted 1 line
Quoted 1 line

unless you know for certain there will be no overlap and it's

strongly

Quoted 7 lines
Quoted 1 line

discouraged in default environments.

What exactly is discouraged?

* setting initrd_high to a value != ~0? Here I would agree.
* setting intird_high to ~0? Why should we copy initrd to a different place? Is it for some outdated Linux release?

We should always default to allowing the initrd to be relocated

because

Quoted 3 lines
Quoted 3 lines

we can see (in many cases) overlap that will lead to failure to boot but
this forces us to ignore that. Having good default load values

means

Quoted 5 lines
Quoted 2 lines

we
don't have a problem here.

We have an initrd that is already in memory. What could it overlap with that is not already overwritten?

Having the kernel and initrd too close in memory has the kernel BSS overwrite the initrd. This has happened time and time again before I went around making some platforms have reasonable (ie kernel early, ramdisk in lowmem but beyond where a kernel+bss can be, etc) defaults and pushing others to do the same.

Quoted 1 line

Can you provide the text you want to see here?

Off-hand, it should look more like the big comment block in include/configs/ti_armv7_common.h and reference the Linux booting on arm/arm64 documents while noting that other architectures have the same fundamental issues and their exact limits may or may not be as well documented.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#10 lore raw

PATCH 1/1 image: usage of value ~0UL for intrd_high

In reply to Tom Rini
Quoted 49 lines · Tom Rini
Quoted 39 lines · Heinrich Schuchardt

Am 9. Januar 2021 20:40:04 MEZ schrieb Tom Rini <[email protected]>:

Quoted 31 lines · Heinrich Schuchardt
Quoted 3 lines · Tom Rini
Quoted 2 lines · Andy Shevchenko
Quoted 1 line

On Sat, Jan 9, 2021 at 8:06 PM Heinrich Schuchardt

Quoted 2 lines · <[email protected]> wrote:
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

The comment for initrd_high in the coding and in README were

contradicting

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

and neither fully described what the coding does.

Clarify the usage of the special value ~0UL for the environment

variable

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 1 line

initrd_high.

All those F:s are hard to read in the comments and documentation

and

Quoted 1 line
Quoted 1 line
Quoted 1 line

typo prone. I would prefer to rephrase like "all 1:s value in 32-

or

Quoted 4 lines
Quoted 4 lines
Quoted 1 line

64-bit format" or alike.

If we're going to improve this we should also note it's discouraged unless you know for certain there will be no overlap and it's

strongly

Quoted 7 lines
Quoted 1 line

discouraged in default environments.

What exactly is discouraged?

* setting initrd_high to a value != ~0? Here I would agree.
* setting intird_high to ~0? Why should we copy initrd to a different place? Is it for some outdated Linux release?

Quoted 6 lines

We should always default to allowing the initrd to be relocated because we can see (in many cases) overlap that will lead to failure to boot but
this forces us to ignore that. Having good default load values means we
don't have a problem here.

Quoted 2 lines

We have an initrd that is already in memory. What could it overlap with that is not already overwritten?

Having the kernel and initrd too close in memory has the kernel BSS overwrite the initrd. This has happened time and time again before I went around making some platforms have reasonable (ie kernel early, ramdisk in lowmem but beyond where a kernel+bss can be, etc) defaults and pushing others to do the same.

Quoted 8 lines
Quoted 1 line

Can you provide the text you want to see here?

Off-hand, it should look more like the big comment block in include/configs/ti_armv7_common.h and reference the Linux booting on arm/arm64 documents while noting that other architectures have the same fundamental issues and their exact limits may or may not be as well documented.

There is nothing in the include/configs/ti_armv7_common.h comments requiring to relocate initrd.

Best regards

Heinrich

#11 lore raw

PATCH 1/1 image: usage of value ~0UL for intrd_high

Quoted 59 lines · Heinrich Schuchardt
Quoted 49 lines · Tom Rini
Quoted 39 lines · Heinrich Schuchardt

Am 9. Januar 2021 20:40:04 MEZ schrieb Tom Rini <[email protected]>:

Quoted 31 lines · Heinrich Schuchardt
Quoted 3 lines · Tom Rini
Quoted 2 lines · Andy Shevchenko
Quoted 1 line

On Sat, Jan 9, 2021 at 8:06 PM Heinrich Schuchardt

Quoted 2 lines · <[email protected]> wrote:
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

The comment for initrd_high in the coding and in README were

contradicting

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

and neither fully described what the coding does.

Clarify the usage of the special value ~0UL for the environment

variable

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 1 line

initrd_high.

All those F:s are hard to read in the comments and documentation

and

Quoted 1 line
Quoted 1 line
Quoted 1 line

typo prone. I would prefer to rephrase like "all 1:s value in 32-

or

Quoted 4 lines
Quoted 4 lines
Quoted 1 line

64-bit format" or alike.

If we're going to improve this we should also note it's discouraged unless you know for certain there will be no overlap and it's

strongly

Quoted 7 lines
Quoted 1 line

discouraged in default environments.

What exactly is discouraged?

* setting initrd_high to a value != ~0? Here I would agree.
* setting intird_high to ~0? Why should we copy initrd to a different place? Is it for some outdated Linux release?

Quoted 6 lines

We should always default to allowing the initrd to be relocated because we can see (in many cases) overlap that will lead to failure to boot but
this forces us to ignore that. Having good default load values means we
don't have a problem here.

Quoted 2 lines

We have an initrd that is already in memory. What could it overlap with that is not already overwritten?

Having the kernel and initrd too close in memory has the kernel BSS overwrite the initrd. This has happened time and time again before I went around making some platforms have reasonable (ie kernel early, ramdisk in lowmem but beyond where a kernel+bss can be, etc) defaults and pushing others to do the same.

Quoted 8 lines
Quoted 1 line

Can you provide the text you want to see here?

Off-hand, it should look more like the big comment block in include/configs/ti_armv7_common.h and reference the Linux booting on arm/arm64 documents while noting that other architectures have the same fundamental issues and their exact limits may or may not be as well documented.

Quoted 2 lines

There is nothing in the include/configs/ti_armv7_common.h comments requiring to relocate initrd.

/*
* We setup defaults based on constraints from the Linux kernel, which should
* also be safe elsewhere. We have the default load at 32MB into DDR (for
* the kernel), FDT above 128MB (the maximum location for the end of the
* kernel), and the ramdisk 512KB above that (allowing for hopefully never
* seen large trees). We say all of this must be within the first 256MB
* as that will normally be within the kernel lowmem and thus visible via
* bootm_size and we only run on platforms with 256MB or more of memory. *
* As a temporary storage for DTBO blobs (which should be applied into DTB
* blob), we use the location 15.5 MB above the ramdisk. If someone wants to
* use ramdisk bigger than 15.5 MB, then DTBO can be loaded and applied to DTB
* blob before loading the ramdisk, as DTBO location is only used as a temporary
* storage, and can be re-used after 'fdt apply' command is done. */

Now, it's I gather not clear that we're NOT setting initrd_high here (nor fdt_high) because we're setting reasonable defaults for everyone to use, so long as they have enough memory.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210110/01e8536b/attachment.sig>
#12 lore raw

PATCH 1/1 image: usage of value ~0UL for intrd_high

Quoted 63 lines · Tom Rini
Quoted 59 lines · Heinrich Schuchardt
Quoted 49 lines · Tom Rini
Quoted 39 lines · Heinrich Schuchardt

Am 9. Januar 2021 20:40:04 MEZ schrieb Tom Rini <[email protected]>:

Quoted 31 lines · Heinrich Schuchardt
Quoted 3 lines · Tom Rini
Quoted 2 lines · Andy Shevchenko
Quoted 1 line

On Sat, Jan 9, 2021 at 8:06 PM Heinrich Schuchardt

Quoted 2 lines · <[email protected]> wrote:
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

The comment for initrd_high in the coding and in README were

contradicting

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

and neither fully described what the coding does.

Clarify the usage of the special value ~0UL for the environment

variable

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 1 line

initrd_high.

All those F:s are hard to read in the comments and documentation

and

Quoted 1 line
Quoted 1 line
Quoted 1 line

typo prone. I would prefer to rephrase like "all 1:s value in 32-

or

Quoted 4 lines
Quoted 4 lines
Quoted 1 line

64-bit format" or alike.

If we're going to improve this we should also note it's discouraged unless you know for certain there will be no overlap and it's

strongly

Quoted 7 lines
Quoted 1 line

discouraged in default environments.

What exactly is discouraged?

* setting initrd_high to a value != ~0? Here I would agree.
* setting intird_high to ~0? Why should we copy initrd to a different place? Is it for some outdated Linux release?

Quoted 6 lines

We should always default to allowing the initrd to be relocated because we can see (in many cases) overlap that will lead to failure to boot but
this forces us to ignore that. Having good default load values means we
don't have a problem here.

Quoted 2 lines

We have an initrd that is already in memory. What could it overlap with that is not already overwritten?

Having the kernel and initrd too close in memory has the kernel BSS overwrite the initrd. This has happened time and time again before I went around making some platforms have reasonable (ie kernel early, ramdisk in lowmem but beyond where a kernel+bss can be, etc) defaults and pushing others to do the same.

Quoted 8 lines
Quoted 1 line

Can you provide the text you want to see here?

Off-hand, it should look more like the big comment block in include/configs/ti_armv7_common.h and reference the Linux booting on arm/arm64 documents while noting that other architectures have the same fundamental issues and their exact limits may or may not be as well documented.

Quoted 2 lines

There is nothing in the include/configs/ti_armv7_common.h comments requiring to relocate initrd.

Quoted 15 lines

/*
* We setup defaults based on constraints from the Linux kernel, which should
* also be safe elsewhere. We have the default load at 32MB into DDR (for
* the kernel), FDT above 128MB (the maximum location for the end of the
* kernel), and the ramdisk 512KB above that (allowing for hopefully never
* seen large trees). We say all of this must be within the first 256MB
* as that will normally be within the kernel lowmem and thus visible via
* bootm_size and we only run on platforms with 256MB or more of memory. *
* As a temporary storage for DTBO blobs (which should be applied into DTB
* blob), we use the location 15.5 MB above the ramdisk. If someone wants to
* use ramdisk bigger than 15.5 MB, then DTBO can be loaded and applied to DTB
* blob before loading the ramdisk, as DTBO location is only used as a temporary
* storage, and can be re-used after 'fdt apply' command is done. */

I cannot see how this relates to initrd relocation.

Best regards

Heinrich

Quoted 5 lines

Now, it's I gather not clear that we're NOT setting initrd_high here (nor fdt_high) because we're setting reasonable defaults for everyone to use, so long as they have enough memory.

#13 lore raw

PATCH 1/1 image: usage of value ~0UL for intrd_high

Quoted 80 lines · Heinrich Schuchardt
Quoted 63 lines · Tom Rini
Quoted 59 lines · Heinrich Schuchardt
Quoted 49 lines · Tom Rini
Quoted 39 lines · Heinrich Schuchardt

Am 9. Januar 2021 20:40:04 MEZ schrieb Tom Rini <[email protected]>:

Quoted 31 lines · Heinrich Schuchardt
Quoted 3 lines · Tom Rini
Quoted 2 lines · Andy Shevchenko
Quoted 1 line

On Sat, Jan 9, 2021 at 8:06 PM Heinrich Schuchardt

Quoted 2 lines · <[email protected]> wrote:
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

The comment for initrd_high in the coding and in README were

contradicting

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

and neither fully described what the coding does.

Clarify the usage of the special value ~0UL for the environment

variable

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 1 line

initrd_high.

All those F:s are hard to read in the comments and documentation

and

Quoted 1 line
Quoted 1 line
Quoted 1 line

typo prone. I would prefer to rephrase like "all 1:s value in 32-

or

Quoted 4 lines
Quoted 4 lines
Quoted 1 line

64-bit format" or alike.

If we're going to improve this we should also note it's discouraged unless you know for certain there will be no overlap and it's

strongly

Quoted 7 lines
Quoted 1 line

discouraged in default environments.

What exactly is discouraged?

* setting initrd_high to a value != ~0? Here I would agree.
* setting intird_high to ~0? Why should we copy initrd to a different place? Is it for some outdated Linux release?

Quoted 6 lines

We should always default to allowing the initrd to be relocated because we can see (in many cases) overlap that will lead to failure to boot but
this forces us to ignore that. Having good default load values means we
don't have a problem here.

Quoted 2 lines

We have an initrd that is already in memory. What could it overlap with that is not already overwritten?

Having the kernel and initrd too close in memory has the kernel BSS overwrite the initrd. This has happened time and time again before I went around making some platforms have reasonable (ie kernel early, ramdisk in lowmem but beyond where a kernel+bss can be, etc) defaults and pushing others to do the same.

Quoted 8 lines
Quoted 1 line

Can you provide the text you want to see here?

Off-hand, it should look more like the big comment block in include/configs/ti_armv7_common.h and reference the Linux booting on arm/arm64 documents while noting that other architectures have the same fundamental issues and their exact limits may or may not be as well documented.

Quoted 2 lines

There is nothing in the include/configs/ti_armv7_common.h comments requiring to relocate initrd.

Quoted 15 lines

/*
* We setup defaults based on constraints from the Linux kernel, which should
* also be safe elsewhere. We have the default load at 32MB into DDR (for
* the kernel), FDT above 128MB (the maximum location for the end of the
* kernel), and the ramdisk 512KB above that (allowing for hopefully never
* seen large trees). We say all of this must be within the first 256MB
* as that will normally be within the kernel lowmem and thus visible via
* bootm_size and we only run on platforms with 256MB or more of memory. *
* As a temporary storage for DTBO blobs (which should be applied into DTB
* blob), we use the location 15.5 MB above the ramdisk. If someone wants to
* use ramdisk bigger than 15.5 MB, then DTBO can be loaded and applied to DTB
* blob before loading the ramdisk, as DTBO location is only used as a temporary
* storage, and can be re-used after 'fdt apply' command is done. */

Quoted 1 line

I cannot see how this relates to initrd relocation.

You cannot safely disable initrd relocation without ensuring it won't be locked in an unsafe location first. It's also _generally_ going to be noise in the boot sequence and not an advisable default. It should be documented as part of how to tune a system for optimal boot times. But given how often defaults are copy/pasted to the next platform without fully understanding why those values were picked is why what we use as default in one platform needs to be very carefully done.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210115/4e632d1b/attachment.sig>