drm/doc: Fix title underline length
Subsystems (3)
PATCH 1/3 drm/doc: Fix title underline length
The underline length for the new Analog TV properties section doesn't match the title length, resulting in a warning.
--- Documentation/gpu/drm-kms.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/gpu/drm-kms.rst +1 -1
@@ -521,7 +521,7 @@ HDMI Specific Connector Properties :doc: HDMI connector properties Analog TV Specific Connector Properties ----------------------------------- +--------------------------------------- .. kernel-doc:: drivers/gpu/drm/drm_connector.c :doc: Analog TV Connector Properties
Signature · 1 line
2.38.1
PATCH 2/3 drm/modes: Use strscpy() to copy command-line mode name
The mode name in struct drm_cmdline_mode can hold 32 characters at most, which can easily get overrun. Switch to strscpy() to prevent such a thing.
Addresses-Coverity-ID: 1527354 ("Security best practices violations")
--- drivers/gpu/drm/drm_modes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/drm_modes.c +1 -1
@@ -2316,7 +2316,7 @@ static int drm_mode_parse_cmdline_named_mode(const char *name,if (ret != name_end)continue ; -strcpy (cmdline_mode->name, mode->name); +strscpy (cmdline_mode->name, mode->name,sizeof (cmdline_mode->name)); cmdline_mode->pixel_clock = mode->pixel_clock_khz; cmdline_mode->xres = mode->xres; cmdline_mode->yres = mode->yres;
Signature · 1 line
2.38.1
Re: [PATCH 2/3] drm/modes: Use strscpy() to copy command-line mode name
Quoted 9 lines · Maxime Ripard
The mode name in struct
drm_cmdline_modecan hold 32 characters at most, which can easily get overrun. Switch tostrscpy()to prevent such a thing.Reported-by coverity-bot <[email protected]>Addresses-Coverity-ID: 1527354 ("Security best practices violations")
Fixes a7ab155397dd ("drm/modes: Switch to named mode descriptors")Signed-off-by Maxime Ripard <[email protected]>---
Signature · 5 lines
Best regards, Javier Martinez Canillas Core Platforms Red Hat
Re: [PATCH 2/3] drm/modes: Use strscpy() to copy command-line mode name
In reply to Maxime RipardQuoted 8 lines · Maxime Ripard
The mode name in struct
drm_cmdline_modecan hold 32 characters at most, which can easily get overrun. Switch tostrscpy()to prevent such a thing.Reported-by coverity-bot <[email protected]>Addresses-Coverity-ID: 1527354 ("Security best practices violations")
Fixes a7ab155397dd ("drm/modes: Switch to named mode descriptors")Signed-off-by Maxime Ripard <[email protected]>
Signature · 1 line
Kees Cook
PATCH 3/3 drm/tests: helpers: Add missing export
In reply to Maxime Riparddrm_kunit_device_init() is a public function meant to be used by other tests, but isn't exported. This leads to modpost errors when the other tests are compiled as module.
--- drivers/gpu/drm/tests/drm_kunit_helpers.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/tests/drm_kunit_helpers.c +1 -0
@@ -66,6 +66,7 @@ struct drm_device *drm_kunit_device_init(struct kunit *test, u32 features, charreturn drm; } +EXPORT_SYMBOL (drm_kunit_device_init);MODULE_AUTHOR ("Maxime Ripard <[email protected]>" );MODULE_LICENSE ("GPL" );
Signature · 1 line
2.38.1
Re: [PATCH 3/3] drm/tests: helpers: Add missing export
Quoted 6 lines · Maxime Ripard
drm_kunit_device_init()is a public function meant to be used by other tests, but isn't exported. This leads to modpost errors when the other tests are compiled as module.Reported-by kernel test robot <[email protected]>Signed-off-by Maxime Ripard <[email protected]>
Best Regards,
- Maíra Canal
Quoted 16 lines
--- drivers/gpu/drm/tests/drm_kunit_helpers.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/tests/drm_kunit_helpers.c +1
-0@@ -66,6 +66,7 @@ struct drm_device *drm_kunit_device_init(struct kunit *test, u32 features, charreturn drm; } +EXPORT_SYMBOL (drm_kunit_device_init);MODULE_AUTHOR ("Maxime Ripard <[email protected]>" );MODULE_LICENSE ("GPL" );
Quoted 7 lines · Maxime Ripard
The underline length for the new Analog TV properties section doesn't match the title length, resulting in a warning.
Fixes 7d63cd8526f1 ("drm/connector: Add TV standard property")Reported-by kernel test robot <[email protected]>Signed-off-by Maxime Ripard <[email protected]>---
Ah, I wasn't aware that this would lead to a kernel-doc warning.
Signature · 5 lines
Best regards, Javier Martinez Canillas Core Platforms Red Hat
Maxime Ripard
AppliedQuoted 4 lines · Maxime Ripard
The underline length for the new Analog TV properties section doesn't match the title length, resulting in a warning.
Applied to drm/drm-misc (drm-misc-next).
Thanks!
Maxime