Skip to contentSkip to conversation

proc: remove unused macro

PATCH In review Alex Shi 2 participants 2 messages Jan 21, 2020

Subsystems (2)
lore
Share & tools
lore

Alex Shi

author
#0 lore raw

PATCH 1/1 proc: remove unused macro

KPMBITS is never used from it was introduced. better to remove it.

Cc Alexey Dobriyan <[email protected]>
Cc Andrew Morton <[email protected]>
Cc David Hildenbrand <[email protected]>
Cc "Michael S. Tsirkin" <[email protected]>
Cc Pankaj gupta <[email protected]>
Cc Konstantin Khlebnikov <[email protected]>
---
 fs/proc/page.c | 1 -
 1 file changed, 1 deletion(-)
fs/proc/page.c +0 -1
index 7c952ee732e6..c4b1005a82bc 100644
@@ -19,7 +19,6 @@
 
 #define KPMSIZE sizeof(u64)
 #define KPMMASK (KPMSIZE - 1)
-#define KPMBITS (KPMSIZE * BITS_PER_BYTE)
 
 /* /proc/kpagecount - an array exposing page counts
  *
Signature · 1 line
1.8.3.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 1 line · Alex Shi

KPMBITS is never used from it was introduced. better to remove it.

I suggest

"fs/proc/page.c: remove unused macro KPMBITS

KPMBITS was never used since it was introduced in commit 3c3fc71c8cfa ("mm: introduce idle page tracking"). Let's remove it.
"

Quoted 27 lines
Cc Alexey Dobriyan <[email protected]>
Cc Andrew Morton <[email protected]>
Cc David Hildenbrand <[email protected]>
Cc "Michael S. Tsirkin" <[email protected]>
Cc Pankaj gupta <[email protected]>
Cc Konstantin Khlebnikov <[email protected]>
---
 fs/proc/page.c | 1 -
 1 file changed, 1 deletion(-)
fs/proc/page.c +0 -1
index 7c952ee732e6..c4b1005a82bc 100644
@@ -19,7 +19,6 @@
 
 #define KPMSIZE sizeof(u64)
 #define KPMMASK (KPMSIZE - 1)
-#define KPMBITS (KPMSIZE * BITS_PER_BYTE)
 
 /* /proc/kpagecount - an array exposing page counts
  *
Signature · 3 lines
Thanks,

David / dhildenb