Skip to contentSkip to conversation

xen: remove stray preempt_disable() from PV AP startup code

PATCH In review Juergen Gross 2 participants 2 messages Aug 25, 2021 – Sep 8, 2021

Subsystems (2)
lore
Share & tools
lore

Juergen Gross

author maintainer
#0 lore raw

PATCH 1/1 xen: remove stray preempt_disable() from PV AP startup code

In cpu_bringup() there is a call of preempt_disable() without a paired preempt_enable(). This is not needed as interrupts are off initially. Additionally this will result in early boot messages like:

BUG: scheduling while atomic: swapper/1/0/0x00000002
---
 arch/x86/xen/smp_pv.c | 1 -
 1 file changed, 1 deletion(-)
arch/x86/xen/smp_pv.c +0 -1
index c2ac319f11a4..96afadf9878e 100644
@@ -64,7 +64,6 @@ static void cpu_bringup(void)
 	cr4_init();
 	cpu_init();
 	touch_softlockup_watchdog();
-	preempt_disable();
 
 	/* PVH runs in ring 0 and allows us to do native syscalls. Yay! */
 	if (!xen_feature(XENFEAT_supervisor_mode_kernel)) {
Signature · 1 line
2.26.2