hw/arm/virt-acpi-build: use PCIE_MMCFG_BUS to retrieve end_bus_number
PATCH 1/1 hw/arm/virt-acpi-build: use PCIE_MMCFG_BUS to retrieve end_bus_number
This is more proper to use PCIE_MMCFG_BUS to retrieve end_bus_number.
Signed-off-by Wei Yang <[email protected]>
--- hw/arm/virt-acpi-build.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
hw/arm/virt-acpi-build.c +2 -2
@@ -560,8 +560,8 @@ build_mcfg(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms)/* Only a single allocation so no need to play with segments */ mcfg->allocation[0 ].pci_segment =cpu_to_le16 (0 ); mcfg->allocation[0 ].start_bus_number =0 ; - mcfg->allocation[0 ].end_bus_number = (memmap[ecam_id].size - /PCIE_MMCFG_SIZE_MIN ) -1 ; + mcfg->allocation[0 ].end_bus_number = +PCIE_MMCFG_BUS (memmap[ecam_id].size -1 );build_header (linker, table_data, (void *)(table_data->data + mcfg_start),"MCFG" , table_data->len - mcfg_start,1 ,NULL ,NULL );
Signature · 1 line
2.19.1
Hi
Quoted 3 lines · Wei Yang
This is more proper to use
PCIE_MMCFG_BUSto retrieveend_bus_number.Signed-off-by Wei Yang <[email protected]>
Reviewed-by Eric Auger <[email protected]>
Thanks
Eric
Quoted 20 lines
--- hw/arm/virt-acpi-build.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)hw/arm/virt-acpi-build.c +2
-2@@ -560,8 +560,8 @@ build_mcfg(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms)/* Only a single allocation so no need to play with segments */ mcfg->allocation[0 ].pci_segment =cpu_to_le16 (0 ); mcfg->allocation[0 ].start_bus_number =0 ; - mcfg->allocation[0 ].end_bus_number = (memmap[ecam_id].size - /PCIE_MMCFG_SIZE_MIN ) -1 ; + mcfg->allocation[0 ].end_bus_number = +PCIE_MMCFG_BUS (memmap[ecam_id].size -1 );build_header (linker, table_data, (void *)(table_data->data + mcfg_start),"MCFG" , table_data->len - mcfg_start,1 ,NULL ,NULL );
Quoted 3 lines · On Tue, 12 Mar 2019 15:49:53 +0800 Wei Yang <[email protected]>…
This is more proper to use
PCIE_MMCFG_BUSto retrieveend_bus_number.Signed-off-by Wei Yang <[email protected]>
Reviewed-by Igor Mammedov <[email protected]>
Quoted 19 lines
--- hw/arm/virt-acpi-build.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)hw/arm/virt-acpi-build.c +2
-2@@ -560,8 +560,8 @@ build_mcfg(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms)/* Only a single allocation so no need to play with segments */ mcfg->allocation[0 ].pci_segment =cpu_to_le16 (0 ); mcfg->allocation[0 ].start_bus_number =0 ; - mcfg->allocation[0 ].end_bus_number = (memmap[ecam_id].size - /PCIE_MMCFG_SIZE_MIN ) -1 ; + mcfg->allocation[0 ].end_bus_number = +PCIE_MMCFG_BUS (memmap[ecam_id].size -1 );build_header (linker, table_data, (void *)(table_data->data + mcfg_start),"MCFG" , table_data->len - mcfg_start,1 ,NULL ,NULL );
Peter Maydell
AppliedQuoted 24 lines · Wei Yang
This is more proper to use
PCIE_MMCFG_BUSto retrieveend_bus_number.Signed-off-by Wei Yang <[email protected]>--- hw/arm/virt-acpi-build.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)hw/arm/virt-acpi-build.c +2
-3@@ -560,8 +560,8 @@ build_mcfg(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms)/* Only a single allocation so no need to play with segments */ mcfg->allocation[0 ].pci_segment =cpu_to_le16 (0 ); mcfg->allocation[0 ].start_bus_number =0 ; - mcfg->allocation[0 ].end_bus_number = (memmap[ecam_id].size - /PCIE_MMCFG_SIZE_MIN ) -1 ; + mcfg->allocation[0 ].end_bus_number = +PCIE_MMCFG_BUS (memmap[ecam_id].size -1 );build_header (linker, table_data, (void *)(table_data->data + mcfg_start),"MCFG" , table_data->len - mcfg_start,1 ,NULL ,NULL ); --
Quoted 1 line
2.19.1
Applied to target-arm.next, thanks.
-- PMM