r8169: align setting PME with vendor driver
Heiner Kallweit
maintainerPATCH 1/1 r8169: align setting PME with vendor driver
Align setting PME with the vendor driver. PMEnable is writable on RTL8169 only, on later chip versions it's read-only. PME_SIGNAL is used on chip versions from RTL8168evl with the exception of the RTL8168f family.
Signed-off-by Heiner Kallweit <[email protected]>
--- drivers/net/ethernet/realtek/r8169_main.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/net/ethernet/realtek/r8169_main.c +6 -2
@@ -1414,18 +1414,22 @@ static void __rtl8169_set_wol(struct rtl8169_private *tp, u32 wolopts) }switch (tp->mac_version) { - case RTL_GIGA_MAC_VER_02 ... RTL_GIGA_MAC_VER_17: + case RTL_GIGA_MAC_VER_02 ... RTL_GIGA_MAC_VER_06: options =RTL_R8 (tp, Config1) & ~PMEnable;if (wolopts) options |= PMEnable;RTL_W8 (tp, Config1, options);break ; -default : +case RTL_GIGA_MAC_VER_34 : +case RTL_GIGA_MAC_VER_37 : + case RTL_GIGA_MAC_VER_39 ... RTL_GIGA_MAC_VER_51: options =RTL_R8 (tp, Config2) & ~PME_SIGNAL ;if (wolopts) options |=PME_SIGNAL ;RTL_W8 (tp, Config2, options);break ; +default : +break ; }rtl_lock_config_regs (tp);
Signature · 1 line
2.22.0
From: Heiner Kallweit <[email protected]>
Date: Fri, 26 Jul 2019 20:56:20 +0200
Quoted 6 lines
Align setting PME with the vendor driver. PMEnable is writable on RTL8169 only, on later chip versions it's read-only.
PME_SIGNALis used on chip versions from RTL8168evl with the exception of the RTL8168f family.Signed-off-by Heiner Kallweit <[email protected]>
Applied.