Skip to contentSkip to conversation

drm/i915/gem: Fix inconsistent IS_ERR and PTR_ERR

PATCH Markus Elfring 1 participant 1 message May 4, 2020 Kernel janitors

lore
Share & tools
lore
#0 lore raw

…

Quoted 3 lines

The proper pointer to be passed as argument is ce.

This bug was detected with the help of Coccinelle.

My software development attention was caught also by your commit message.

…

Review static int __reloc_gpu_alloc(struct i915_execbuffer *eb, · line 1331

Quoted 10 lines

+++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c

(quoted diff) +1 -1
@@ -1325,7 +1325,7 @@ static int __reloc_gpu_alloc(struct i915_execbuffer *eb,
 
 		ce = intel_context_create(engine);
 		if (IS_ERR(ce)) {
-			err = PTR_ERR(rq);
+			err = PTR_ERR(ce);
 			goto err_unpin;
 		}
 

Are you looking for any more questionable identifier (or expression) combinations also at other places by the means of advanced source code analysis?

Regards,
Markus