Skip to contentSkip to conversation

ARM: milbeaut: Add missing of_node_put() call in m10v_smp_init()

PATCH Markus Elfring 1 participant 1 message Jul 25, 2020 Kernel janitors

lore
Share & tools
lore
#0 lore raw
Quoted 2 lines

The variable np in function m10v_smp_init takes the return value of of_find_compatible_node, which gets a node but does not put it.

Such information is useful.

Quoted 1 line

If this node is not put it may cause a memory leak.

Is the reference management generally improvable for this function implementation?

Will the tag “Fixes” become helpful for the commit message?

Regards,
Markus