Skip to contentSkip to conversation

New board: pine64+

PATCH New Avi Shukron 2 participants 2 messages Dec 29, 2019 – May 26, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 New board: pine64+

The pine64+ is a variant of the original pine64 with 1/2 GB RAM and GbE phy.

The pine64+ has a distinct dts file in both mainline kernel and uboot, thus it cannot be supported with the existing pine64_defconfig.

The board is added with mainline ATF, Uboot and kernel support, all at the latest (or almost) version.

The new defconfig for the board was tested and booted successfully with serial console access + console output to HDMI. Network interface eth0 is working properly and configured with DHCP at boot time.

---
 board/pine64/pine64-plus/boot.cmd     |  6 +++
 board/pine64/pine64-plus/genimage.cfg | 39 +++++++++++++++++++
 board/pine64/pine64-plus/readme.txt   | 55 +++++++++++++++++++++++++++
 configs/pine64_plus_defconfig         | 35 +++++++++++++++++
 4 files changed, 135 insertions(+)
 create mode 100644 board/pine64/pine64-plus/boot.cmd
 create mode 100644 board/pine64/pine64-plus/genimage.cfg
 create mode 100644 board/pine64/pine64-plus/readme.txt
 create mode 100644 configs/pine64_plus_defconfig
board/pine64/pine64-plus/boot.cmd new file +6 -0
new file mode 100644
index 0000000000..511111e2ee
@@ -0,0 +1,6 @@
+setenv bootargs console=tty0 console=ttyS0,115200 earlyprintk root=/dev/mmcblk0p2 rootwait
+
+fatload mmc 0 $kernel_addr_r Image
+fatload mmc 0 $fdt_addr_r sun50i-a64-pine64-plus.dtb
+
+booti $kernel_addr_r - $fdt_addr_r
board/pine64/pine64-plus/genimage.cfg new file +39 -0
new file mode 100644
index 0000000000..60dac9d882
@@ -0,0 +1,39 @@
+image boot.vfat {
+	vfat {
+		files = {
+			"Image",
+			"sun50i-a64-pine64-plus.dtb",
+			"boot.scr"
+		}
+	}
+	size = 64M
+}
+
+image sdcard.img {
+	hdimage {
+	}
+
+	partition spl {
+		in-partition-table = "no"
+		image = "sunxi-spl.bin"
+		offset = 8192
+	}
+
+	partition u-boot {
+		in-partition-table = "no"
+		image = "u-boot.itb"
+		offset = 40K
+		size = 1M # 1MB - 40K
+	}
+
+	partition boot {
+		partition-type = 0xC
+		bootable = "true"
+		image = "boot.vfat"
+	}
+
+	partition rootfs {
+		partition-type = 0x83
+		image = "rootfs.ext4"
+	}
+}
board/pine64/pine64-plus/readme.txt new file +55 -0

55 lines not on this page · raw message

configs/pine64_plus_defconfig new file +35 -0
new file mode 100644
index 0000000000..d1b267b64e
@@ -0,0 +1,35 @@
+BR2_aarch64=y
+BR2_ARM_FPU_VFPV4=y
+BR2_CCACHE=y
+BR2_TOOLCHAIN_EXTERNAL=y
+BR2_TARGET_GENERIC_ISSUE="Welcome to PINE64+"
+BR2_SYSTEM_DHCP="eth0"
+BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
+BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/pine64/pine64-plus/genimage.cfg"
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
+BR2_LINUX_KERNEL_DTS_SUPPORT=y
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="allwinner/sun50i-a64-pine64-plus"
+BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
+BR2_TARGET_ROOTFS_EXT2=y
+BR2_TARGET_ROOTFS_EXT2_4=y
+BR2_TARGET_ROOTFS_EXT2_SIZE="100M"
+BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION=y
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION_VALUE="v2.2"
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="sun50i_a64"
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_DEBUG=y
+BR2_TARGET_UBOOT=y
+BR2_TARGET_UBOOT_BOARD_DEFCONFIG="pine64_plus"
+BR2_TARGET_UBOOT_NEEDS_DTC=y
+BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
+BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y
+BR2_TARGET_UBOOT_FORMAT_CUSTOM=y
+BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="u-boot.itb"
+BR2_TARGET_UBOOT_SPL=y
+BR2_TARGET_UBOOT_SPL_NAME="spl/sunxi-spl.bin"
+BR2_TARGET_UBOOT_BOOT_SCRIPT=y
+BR2_TARGET_UBOOT_BOOT_SCRIPT_SOURCE="board/pine64/pine64-plus/boot.cmd"
+BR2_PACKAGE_HOST_DOSFSTOOLS=y
+BR2_PACKAGE_HOST_GENIMAGE=y
+BR2_PACKAGE_HOST_MTOOLS=y
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 New board: pine64+

Hi Avi,

One and a half years after you submitted this patch, you're probably not too
motivated to follow up on it... Still, I have some feedback. I've marked the patch as Changes Requested in patchwork.

Quoted 59 lines · Avi Shukron

The pine64+ is a variant of the original pine64 with 1/2 GB RAM and GbE phy.

The pine64+ has a distinct dts file in both mainline kernel and uboot, thus it cannot be supported with the existing pine64_defconfig.

The board is added with mainline ATF, Uboot and kernel support, all at the latest (or almost) version.

The new defconfig for the board was tested and booted successfully with serial console access + console output to HDMI. Network interface eth0 is working properly and configured with DHCP at boot time.

---
 board/pine64/pine64-plus/boot.cmd     |  6 +++
 board/pine64/pine64-plus/genimage.cfg | 39 +++++++++++++++++++
 board/pine64/pine64-plus/readme.txt   | 55 +++++++++++++++++++++++++++
 configs/pine64_plus_defconfig         | 35 +++++++++++++++++
 4 files changed, 135 insertions(+)
 create mode 100644 board/pine64/pine64-plus/boot.cmd
 create mode 100644 board/pine64/pine64-plus/genimage.cfg
 create mode 100644 board/pine64/pine64-plus/readme.txt
 create mode 100644 configs/pine64_plus_defconfig
board/pine64/pine64-plus/boot.cmd new file +6 -0
new file mode 100644
index 0000000000..511111e2ee
@@ -0,0 +1,6 @@
+setenv bootargs console=tty0 console=ttyS0,115200 earlyprintk root=/dev/mmcblk0p2 rootwait
+
+fatload mmc 0 $kernel_addr_r Image
+fatload mmc 0 $fdt_addr_r sun50i-a64-pine64-plus.dtb
+
+booti $kernel_addr_r - $fdt_addr_r
board/pine64/pine64-plus/genimage.cfg new file +16 -0
new file mode 100644
index 0000000000..60dac9d882
@@ -0,0 +1,39 @@
+image boot.vfat {
+	vfat {
+		files = {
+			"Image",
+			"sun50i-a64-pine64-plus.dtb",
+			"boot.scr"
+		}
+	}
+	size = 64M
+}
+
+image sdcard.img {
+	hdimage {
+	}
+
+	partition spl {

board/pine64/pine64-plus/genimage.cfg line 26

Quoted 10 lines
board/pine64/pine64-plus/genimage.cfg new file +10 -0
+		in-partition-table = "no"
+		image = "sunxi-spl.bin"
+		offset = 8192
+	}
+
+	partition u-boot {
+		in-partition-table = "no"
+		image = "u-boot.itb"
+		offset = 40K
+		size = 1M # 1MB - 40K

I guess you copied the comment from somewhere - 1M is not 1MB - 40K :-) Hm,
apparently that comment is wrong in quite a lot of genimage.cfg files... Anyway, let's not propagate the madness!

board/pine64/pine64-plus/genimage.cfg line 32

Quoted 6 lines
board/pine64/pine64-plus/genimage.cfg new file +6 -0
+	}
+
+	partition boot {
+		partition-type = 0xC
+		bootable = "true"
+		image = "boot.vfat"

Modern upstream U-Boot generally supports using /boot in the ext4. Any reason
not to use that? (It's OK to do it like this even if it's just because "that's what the wiki page says".) Similarly, modern devices generally use a GPT partition table.

Quoted 7 lines
board/pine64/pine64-plus/genimage.cfg new file +7 -0
+	}
+
+	partition rootfs {
+		partition-type = 0x83
+		image = "rootfs.ext4"
+	}
+}

[snip]

configs/pine64_plus_defconfig line 1

Quoted 7 lines
configs/pine64_plus_defconfig new file +1 -0
new file mode 100644
index 0000000000..d1b267b64e
@@ -0,0 +1,35 @@
+BR2_aarch64=y

Please explicitly set BR2_cortex_a53=y

Also, it's nice if you beautify the defconfig and split it in sections. See
e.g. pine64_defconfig.

configs/pine64_plus_defconfig line 3

Quoted 2 lines
configs/pine64_plus_defconfig new file +2 -0
+BR2_ARM_FPU_VFPV4=y
+BR2_CCACHE=y

We don't use ccache in our defconfigs. Defconfigs are supposed to be minimal.

configs/pine64_plus_defconfig line 4

Quoted 1 line
configs/pine64_plus_defconfig new file +1 -0
+BR2_TOOLCHAIN_EXTERNAL=y

We use an internal toolchain (with uClibc) unless there's a *very* good reason
not to.

configs/pine64_plus_defconfig line 9

Quoted 5 lines
configs/pine64_plus_defconfig new file +5 -0
+BR2_TARGET_GENERIC_ISSUE="Welcome to PINE64+"
+BR2_SYSTEM_DHCP="eth0"
+BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
+BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/pine64/pine64-plus/genimage.cfg"
+BR2_LINUX_KERNEL=y

Always use BR2_LINUX_KERNEL_CUSTOM_VERSION=y and use an explicit *tested*
kernel version. Otherwise, when the default kernel version is bumped in Buildroot, the board may suddenly break.

configs/pine64_plus_defconfig line 16

Quoted 7 lines
configs/pine64_plus_defconfig new file +7 -0
+BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
+BR2_LINUX_KERNEL_DTS_SUPPORT=y
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="allwinner/sun50i-a64-pine64-plus"
+BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
+BR2_TARGET_ROOTFS_EXT2=y
+BR2_TARGET_ROOTFS_EXT2_4=y
+BR2_TARGET_ROOTFS_EXT2_SIZE="100M"

Is there a reason to make a larger rootfs? We normally only do that for configs
which have large extra requirements.

configs/pine64_plus_defconfig line 21

Quoted 5 lines
configs/pine64_plus_defconfig new file +5 -0
+BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION=y
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION_VALUE="v2.2"
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="sun50i_a64"
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_DEBUG=y

Is there a reason to turn on debugging?

Regards,
Arnout

Quoted 15 lines
configs/pine64_plus_defconfig new file +14 -0
+BR2_TARGET_UBOOT=y
+BR2_TARGET_UBOOT_BOARD_DEFCONFIG="pine64_plus"
+BR2_TARGET_UBOOT_NEEDS_DTC=y
+BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
+BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y
+BR2_TARGET_UBOOT_FORMAT_CUSTOM=y
+BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="u-boot.itb"
+BR2_TARGET_UBOOT_SPL=y
+BR2_TARGET_UBOOT_SPL_NAME="spl/sunxi-spl.bin"
+BR2_TARGET_UBOOT_BOOT_SCRIPT=y
+BR2_TARGET_UBOOT_BOOT_SCRIPT_SOURCE="board/pine64/pine64-plus/boot.cmd"
+BR2_PACKAGE_HOST_DOSFSTOOLS=y
+BR2_PACKAGE_HOST_GENIMAGE=y
+BR2_PACKAGE_HOST_MTOOLS=y