net/hns3: fix checking enough Tx BDs
PATCH 1/1 net/hns3: fix checking enough Tx BDs
From: "Wei Hu (Xavier)" <[email protected]>
In .tx_pkt_burst ops implementation function of hns3 PMD driver, there is one check whether there are enough BDs in the TX queue. If not, driver will stop sending the packets.
Currently in the 'for' process loop, the next_to_use member of TX queue is not updated in time after processing BDs of one packet, which results in the invalid action of checking whether there are enough BDs and failure in sending packets.
This patch fixes it by moving the assignment statment of the next_to_use member of TX queue to the place after porcessing TX BDs in the 'for' loop.
--- drivers/net/hns3/hns3_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/hns3/hns3_rxtx.c +1 -1
@@ -1649,6 +1649,7 @@ hns3_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) }while (m_seg !=NULL ); nb_hold += i; + txq->next_to_use = tx_next_use; } end_of_tx:
@@ -1656,7 +1657,6 @@ hns3_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)if (likely (nb_tx)) {hns3_queue_xmit (txq, nb_hold); txq->next_to_clean = tx_next_clean; - txq->next_to_use = tx_next_use; txq->tx_bd_ready = tx_bd_ready - nb_hold; }
Signature · 1 line
2.23.0
Quoted 4 lines · Wei Hu (Xavier)
From: "Wei Hu (Xavier)" <[email protected]>
In .tx_pkt_burst ops implementation function of hns3 PMD driver, there is one check whether there are enough BDs in the TX queue.
Out of curiosity, is BD refers to "buffer descriptor"? What is the difference between Tx descriptor and TX BD?
Quoted 42 lines
If not, driver will stop sending the packets.
Currently in the 'for' process loop, the
next_to_usemember of TX queue is not updated in time after processing BDs of one packet, which results in the invalid action of checking whether there are enough BDs and failure in sending packets.This patch fixes it by moving the assignment statment of the
next_to_usemember of TX queue to the place after porcessing TX BDs in the 'for' loop.Fixes bba636698316 ("net/hns3: support Rx/Tx and related operations")Signed-off-by Hongbo Zheng <[email protected]>Signed-off-by Huisong Li <[email protected]>Signed-off-by Wei Hu (Xavier) <[email protected]>--- drivers/net/hns3/hns3_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/hns3/hns3_rxtx.c +1
-1@@ -1649,6 +1649,7 @@ hns3_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) }while (m_seg !=NULL ); nb_hold += i; + txq->next_to_use = tx_next_use; } end_of_tx:@@ -1656,7 +1657,6 @@ hns3_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)if (likely (nb_tx)) {hns3_queue_xmit (txq, nb_hold); txq->next_to_clean = tx_next_clean; - txq->next_to_use = tx_next_use; txq->tx_bd_ready = tx_bd_ready - nb_hold; }
Ferruh Yigit
AppliedQuoted 15 lines · Wei Hu (Xavier)
From: "Wei Hu (Xavier)" <[email protected]>
In .tx_pkt_burst ops implementation function of hns3 PMD driver, there is one check whether there are enough BDs in the TX queue. If not, driver will stop sending the packets.
Currently in the 'for' process loop, the
next_to_usemember of TX queue is not updated in time after processing BDs of one packet, which results in the invalid action of checking whether there are enough BDs and failure in sending packets.This patch fixes it by moving the assignment statment of the
next_to_usemember of TX queue to the place after porcessing TX BDs in the 'for' loop.
Quoted 6 lines
Fixes bba636698316 ("net/hns3: support Rx/Tx and related operations")Signed-off-by Hongbo Zheng <[email protected]>Signed-off-by Huisong Li <[email protected]>Signed-off-by Wei Hu (Xavier) <[email protected]>
Applied to dpdk-next-net/master, thanks.